Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9504 --- I went ahead and pushed this to the mainline this morning. Sorry I was

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9503 --- Ship it! Please go ahead with this and we can fine tune later. Could

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

> On March 2, 2017, 10:56 p.m., Brad Beckmann wrote: > > CONTRIBUTING.md, line 55 > > > > > > What happens when a maintainer has not been assigned to a region of > > code? Is there a way even to guarantee that all existing

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

> On Feb. 28, 2017, 9:48 p.m., Brad Beckmann wrote: > > CONTRIBUTING.md, line 205 > > > > > > Where is the "Generate Password" option? I don't see it after signing > > in. Is this password unique to just pushing patches

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9500 --- Several of us have discussed this document at AMD and we have a few more

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9495 --- CONTRIBUTING.md (line 205)

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9494 --- CONTRIBUTING.md (line 7)

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

> On Feb. 23, 2017, 11:20 a.m., Andreas Hansson wrote: > > CONTRIBUTING.md, line 69 > > > > > > Is there a step where tests/regressions are added and/or updated, or is > > that perhaps too much detail for this doc? We

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9457 --- Thanks for getting this in shape. Some minor things worth considering.

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9456 --- Ship it! Ship It! - Pierre-Yves Péneau On Feb. 21, 2017, 6:34 p.m.,

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9441 --- Ship it! Ship It! - Tony Gutierrez On Feb. 21, 2017, 9:34 a.m.,

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9440 --- Ship it! Ship It! - Andreas Sandberg On Feb. 21, 2017, 5:34 p.m.,

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/ --- (Updated Feb. 21, 2017, 5:34 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9437 --- Thanks for writing formalising this! There are some really minor nits

[gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/ --- Review request for Default. Repository: gem5 Description --- changesets: