Re: [m5-dev] Alpha data faults taking fields from the MachInst

2010-08-24 Thread Gabe Black
I guess it was too good to be true. When I actually -used- StaticInstPtr by itself, gcc didn't like passing an incomplete type by value. Gabe Black wrote: In the process of implementing this, I wound up creating an include loop between static_inst.hh and sim/faults.hh. All I really needed was

Re: [m5-dev] Review Request: ARM: Expand the mode checking utility functions.

2010-08-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/217/#review326 --- Ship it! - Nathan On 2010-08-23 09:39:10, Ali Saidi wrote:

Re: [m5-dev] Review Request: ARM: Implement all ARM SIMD instructions.

2010-08-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/218/#review327 --- I'm not really qualified to review this diff, and I'd assume ship it

Re: [m5-dev] Review Request: ARM: Implement CPACR register and return Undefined Instruction when FP access is disabled.

2010-08-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/219/#review328 --- Again, I can't review this very well. I say ship it unless someone

Re: [m5-dev] Review Request: ARM: Fix VFP enabled checks for mem instructions

2010-08-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/223/#review330 --- I say ship it if nobody objects - Nathan On 2010-08-23 09:38:01, Ali

Re: [m5-dev] Review Request: ARM: Set the high bits in the part number so it's considered new by some code.

2010-08-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/224/#review331 --- src/arch/arm/isa.cc http://reviews.m5sim.org/r/224/#comment439 You

[m5-dev] O3ThreadContext::copyArchRegs() vs TheISA::copyRegs()

2010-08-24 Thread Ioannis Ilkos
Hello, This is related to the bug reported in http://www.mail-archive.com/m5-us...@m5sim.org/msg03669.html. According to Gabriel's response a possible fix would be using the copyRegs() function defined in the ISA for the same task, and it actually seems to work. Is there any reason that O3

Re: [m5-dev] changeset in m5: ruby: Resurrected Ruby's deterministic tests

2010-08-24 Thread Beckmann, Brad
Thanks for heads up Gabe. Yep I missed that. It turns out there a few things currently broken with the ruby config scripts. I'll be pushing some changes momentarily. Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Gabe Black

[m5-dev] changeset in m5: MOESI_hammer: fixed bug for dma reads in single...

2010-08-24 Thread Brad Beckmann
changeset 9bd6e86476d2 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9bd6e86476d2 description: MOESI_hammer: fixed bug for dma reads in single cpu systems diffstat: src/mem/protocol/MOESI_hammer-cache.sm | 43 ++--- 1 files changed, 29

[m5-dev] changeset in m5: testers: move testers to a new directory

2010-08-24 Thread Brad Beckmann
changeset acf43d6bbc18 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=acf43d6bbc18 description: testers: move testers to a new directory This patch moves the testers to a new subdirectory under src/cpu and includes the necessary fixes to work with

[m5-dev] changeset in m5: config: fixed ruby dma device connections

2010-08-24 Thread Brad Beckmann
changeset d8112aa18a1b in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d8112aa18a1b description: config: fixed ruby dma device connections diffstat: configs/common/FSConfig.py | 5 +++-- configs/example/ruby_fs.py | 2 +-

[m5-dev] changeset in m5: config: changed ruby config file names to be co...

2010-08-24 Thread Brad Beckmann
changeset a322932de08f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a322932de08f description: config: changed ruby config file names to be consistent diffstat: configs/example/memtest-ruby.py | 161

Re: [m5-dev] Review Request: ARM: fixed a bug in the arm register flattening logic (FP_Base_DepTag was set too low)

2010-08-24 Thread Ali Saidi
Everyone ok with this? Thanks, Ali On Aug 24, 2010, at 5:24 PM, Ali Saidi wrote: The previous change caused o3 boot on Alpha/Linux to fail since the max deptag wasn't Ctrl_DepTag + NumMiscRegs but rather needed to also know about the internal processor registers. I think it's good to keep

Re: [m5-dev] Review Request: ARM: fixed a bug in the arm register flattening logic (FP_Base_DepTag was set too low)

2010-08-24 Thread Steve Reinhardt
Looks fine to me. Steve On Tue, Aug 24, 2010 at 8:12 PM, Ali Saidi sa...@umich.edu wrote: Everyone ok with this? Thanks, Ali On Aug 24, 2010, at 5:24 PM, Ali Saidi wrote: The previous change caused o3 boot on Alpha/Linux to fail since the max deptag wasn't Ctrl_DepTag + NumMiscRegs but

Re: [m5-dev] Review Request: ARM: fixed a bug in the arm register flattening logic (FP_Base_DepTag was set too low)

2010-08-24 Thread Gabe Black
Me to. Gabe Steve Reinhardt wrote: Looks fine to me. Steve On Tue, Aug 24, 2010 at 8:12 PM, Ali Saidi sa...@umich.edu wrote: Everyone ok with this? Thanks, Ali On Aug 24, 2010, at 5:24 PM, Ali Saidi wrote: The previous change caused o3 boot on Alpha/Linux to fail since the