Re: [m5-dev] Review Request: Old Path Diff for gabe

2011-03-03 Thread Gabe Black
I finally took the time to look at this diff. It looks like a viable approach to implementing the path searching part, but I'm not there yet. This change is to tidy up the existing code and to make the default path more standard. Subsequent changes will search for each file instead of just finding

[m5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2011-03-03 Thread Cron Daemon
* build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MESI_CMP_directory passed. * build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MESI_CMP_directory passed. *

Re: [m5-dev] ISAs working with inorder CPU

2011-03-03 Thread Timothy M Jones
Ok, cool. Thanks for the information. Cheers Tim Korey Sewell wrote: Yup, Ali's right. InOrder isnt supporting FS mode right now. It's pretty high on the to-do list (actually, it's next), but the recent time I've spent with Inorder has been with optimizing the simulation speed for inorder

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/ --- (Updated 2011-03-03 02:45:15.055168) Review request for Default, Ali Saidi, Gabe

[m5-dev] Review Request: SCons: Turn some scons variables into command line options.

2011-03-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/530/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: SCons: Add an option to dump the build vars, and only do that if asked.

2011-03-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/531/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Review Request: SCons: Add an option to dump the build vars, and only do that if asked.

2011-03-03 Thread Gabe Black
This is mostly an idea I'm entertaining. It makes it a lot easier to see the command line option part of the help which scrolls off the screen otherwise which is nice, although whether that's a good thing depends on whether you think the command line stuff or the variable stuff is more important.

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-03 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review927 --- Ship it! - Steve On 2011-03-03 02:45:15, Gabe Black wrote:

[m5-dev] Review Request: Ruby: Add stall and wait to MESI CMP directory

2011-03-03 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/330/ --- Review request for Default. Summary --- This patch adds the stall and wait on

Re: [m5-dev] Review Request: SCons: Add an option to dump the build vars, and only do that if asked.

2011-03-03 Thread Gabe Black
Thinking about this more, this opens up space in the build help for more higher level, well, build help. We could list all the possible configurations to use, ie. list the files in build_opts. We could list the possible m5 binaries to build and what each is for. We could talk about how regressions

Re: [m5-dev] Review Request: Ruby: Add stall and wait to MESI CMP directory

2011-03-03 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/330/#review928 --- Do you have to always call wakeUpAllDependents? Initially it atleast was

Re: [m5-dev] Review Request: Ruby: Add stall and wait to MESI CMP directory

2011-03-03 Thread Nilay Vaish
On 2011-03-03 16:52:42, Brad Beckmann wrote: Do you have to always call wakeUpAllDependents? Initially it atleast was my hope that the per cache block wakeUpDependents would be sufficient. However, I could see that in certain situations where requets are stalled because a tbe entry

[m5-dev] Review Request: Mips: MIPS_FS doesn't build currently, so delete it to avoid confusion.

2011-03-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/532/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Review Request: Mips: MIPS_FS doesn't build currently, so delete it to avoid confusion.

2011-03-03 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/532/#review930 --- Ship it! - Korey On 2011-03-03 17:18:01, Gabe Black wrote:

[m5-dev] A small bug on thread pid and start time.

2011-03-03 Thread Yi Xiang
I found a bug while trying to generate trace file for thread execution. At first, --trace-thread returned wrong value for thread tid and start time. For example, tids for all the threads are 3211264. Actually, this bug can be fixed by changing from Addr offset to ini32_t offset in line106 and

Re: [m5-dev] A small bug on thread pid and start time.

2011-03-03 Thread Korey Sewell
Many more details are needed for us to incorporate this bug fix. What is the command line you ran that caused the error? What is the output that shows the error? What files do you change to fix the error? On Thu, Mar 3, 2011 at 9:05 PM, Yi Xiang y...@colostate.edu wrote: I found a bug while

Re: [m5-dev] A small bug on thread pid and start time.

2011-03-03 Thread Gabriel Michael Black
They did mention the line that needed to be changed, so that's covered. But I think we'll still need that other information (how to reproduce it, basically) so we can verify the fix ourselves. In any case, thanks for letting us know! Gabe Quoting Korey Sewell ksew...@umich.edu: Many

Re: [m5-dev] m5-dev Digest, Vol 47, Issue 10

2011-03-03 Thread Yi Xiang
OK. Here is some detail. At first, I followed this instruction https://docs.google.com/View?id=dfkk59gg_1079rhf4bd5 AND ran splash2 benchmark on m5.opt (Alpha architecture) with --trace-flags=thread option enabled to get trace of threads:

Re: [m5-dev] Review Request: cpu: split o3-specific parts out of BaseDynInst

2011-03-03 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/529/#review932 --- Please don't ship this until I have a chance to try it, I just want to

Re: [m5-dev] Review Request: cpu: split o3-specific parts out of BaseDynInst

2011-03-03 Thread Korey Sewell
On 2011-03-03 20:41:09, Ali Saidi wrote: Please don't ship this until I have a chance to try it, I just want to make sure it doesn't break ARM_FS/O3. Sure, I'd welcome a go of things from some other folks to test if I haven't introduced something quirky. After there is some commentary,

Re: [m5-dev] A small bug on thread pid and start time.

2011-03-03 Thread Korey Sewell
They did mention the line that needed to be changed, so that's covered. Oops, Sorry for missing that. As Gabe says , it's definitely great that you (Yi Xiang) found a bug but we need a little bit more help to reproduce it and apply the appropriate changes. -- - Korey

Re: [m5-dev] Review Request: cpu: split o3-specific parts out of BaseDynInst

2011-03-03 Thread Gabe Black
I think there's been a lot of aversion to virtual functions in the past because they add some performance overhead. You've got the indirection through what's basically a function pointer, and you can't really inline the function because you don't know what it's going to be ahead of time. The

[m5-dev] changeset in m5: Mips: MIPS_FS doesn't build currently, so delet...

2011-03-03 Thread Gabe Black
changeset 5e5efbb37e6f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=5e5efbb37e6f description: Mips: MIPS_FS doesn't build currently, so delete it to avoid confusion. MIPS_FS doesn't build and presumably doesn't work right now. Users might see the

Re: [m5-dev] Review Request: SCons: Turn some scons variables into command line options.

2011-03-03 Thread Gabe Black
Ah, right, good catch. Gabe On 03/03/11 20:38, Ali Saidi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/530/#review931 --- Ship

[m5-dev] changeset in m5: SCons: Turn some scons variables into command l...

2011-03-03 Thread Gabe Black
changeset e4257cde2d79 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=e4257cde2d79 description: SCons: Turn some scons variables into command line options. diffstat: SConstruct | 99 +++ tests/SConscript |

[m5-dev] changeset in m5: SCons: Clean up some inconsistent capitalizatio...

2011-03-03 Thread Gabe Black
changeset 457c24115bde in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=457c24115bde description: SCons: Clean up some inconsistent capitalization in scons options. diffstat: SConstruct | 2 +- src/mem/protocol/SConsopts | 2 +- 2 files changed, 2

[m5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2011-03-03 Thread Cron Daemon
See /z/m5/regression/regress-2011-03-04-03:00:01 for details. ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev