Re: [m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-04 Thread nathan binkert
> So do we want to define a standard set of assert like > macros/functions/whatever? If we're going to go for a fixed format we > should stick that in a header somewhere. I went with asserts because > they pretty conveniently check the result and blow up if there's a > problem, but printing PASS/FA

Re: [m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-04 Thread Gabe Black
So do we want to define a standard set of assert like macros/functions/whatever? If we're going to go for a fixed format we should stick that in a header somewhere. I went with asserts because they pretty conveniently check the result and blow up if there's a problem, but printing PASS/FAIL would b

Re: [m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-04 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/365/#review618 --- It's pretty good. I think Nate's suggestion is great and maybe a little co

Re: [m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-03 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/365/#review597 --- Ship it! I have some suggestions, but overall, it looks good. It would b

Re: [m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/365/ --- (Updated 2011-01-03 12:56:11.143277) Review request for Default, Ali Saidi, Gabe Bl

[m5-dev] Review Request: RefCount: Add a unit test for reference counting pointers.

2011-01-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/365/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke