Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

On Sat, 19 Mar 2011, Nilay Vaish wrote: On Fri, 18 Mar 2011, Lisa Hsu wrote: What's going on with this patch? I don't believe it's been committed but it seems like it should. I've also got some patches waiting behind this because they used to touch CacheMsg and I don't want to mess Nilay up

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

On Fri, 18 Mar 2011, Lisa Hsu wrote: What's going on with this patch? I don't believe it's been committed but it seems like it should. I've also got some patches waiting behind this because they used to touch CacheMsg and I don't want to mess Nilay up, so I've been waiting to serialize behind

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

What's going on with this patch? I don't believe it's been committed but it seems like it should. I've also got some patches waiting behind this because they used to touch CacheMsg and I don't want to mess Nilay up, so I've been waiting to serialize behind this. Lisa On Wed, Feb 9, 2011 at 1:28

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/#review841 --- Overall, this patch looks good to me as well. I just have a couple minor

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-25 09:15:23.221045) Review request for Default. Summary (updated

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

To be honest, I think that libruby removal should really be a separate diff. Nate > With this update, all the protocols have been changed. Also, libruby.hh and > libruby.cc have been removed. Only problem is that there are still a couple > of files DeterministicDriver.cc, RaceyPseudoThread.hh,

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-24 20:26:28.555420) Review request for Default. Summary (updated

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

> On 2011-01-20 15:49:13, Brad Beckmann wrote: > > I've only had a chance to briefly review this, but I do have a couple > > comments: - The hammer cache changes didn't seem to upload cleanly. Can you try to post them again? - I just want to confirm that the libruby interface is still useful t

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

> On 2011-01-20 15:49:13, Brad Beckmann wrote: > > I've only had a chance to briefly review this, but I do have a couple > > comments: - The hammer cache changes didn't seem to upload cleanly. Can you try to post them again? - I just want to confirm that the libruby interface is still useful t

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-21 05:19:07.165598) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

> On 2011-01-20 15:49:13, Brad Beckmann wrote: > > I've only had a chance to briefly review this, but I do have a couple > > comments: - The hammer cache changes didn't seem to upload cleanly. Can you try to post them again? - I just want to confirm that the libruby interface is still useful t

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-21 05:03:54.622452) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/#review791 --- I've only had a chance to briefly review this, but I do have a couple comm

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/#review790 --- src/mem/ruby/system/Sequencer.cc

[m5-dev] Review Request: Remove CacheMsg class from SLICC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- Review request for Default. Summary --- The goal of the patch is to do away wi