Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-18 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/#review982 --- Ship it! Looks good. Thanks for fixing it up. - Gabe On 2011-03-17

Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-17 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/ --- (Updated 2011-03-17 20:17:57.438673) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-15 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/#review960 --- I think this is a great change. There are only a couple small things to

Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-15 Thread Korey Sewell
On 2011-03-15 11:08:23, Gabe Black wrote: src/arch/mips/isa.hh, line 58 http://reviews.m5sim.org/r/578/diff/2/?file=10941#file10941line58 Do you really want these to be static? Then they can't be changed between different CPUs which have separate ISA state. I can see how you

[m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-14 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-14 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/578/ --- (Updated 2011-03-14 17:34:17.189549) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: isa: get rid of expandForMT function

2011-03-14 Thread Korey Sewell
Reviewboard is complaining about posting consecutive changesets to the board for some reason. When I view the diff it gives an error message about not being able to apply the patch. So for now, I just posted both patches merged and will split on commit. Anyone else run into this problem? On