Re: [VOTE] DataSketches-memory RC2

2019-08-02 Thread Justin Mclean
Hi, > I will do a thorough license search. Ask your mentor for help they will be able to help you with this. > I will try to locate the WIP Disclaimer ... do you have a link? Yes https://incubator.apache.org/policy/incubation.html#disclaimers. There also an email to this list today with the

Re: [VOTE] DataSketches-memory RC2

2019-08-02 Thread Justin Mclean
HI, > [*INFO*] Exclude: **/test/resources/**/*.txt That missed one of the files in question, I found it by running rat manually. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
I ran "mvn apache-rat:check" // didn't find anything: [*INFO*] *--- *apache-rat-plugin:0.12:check *(default-cli)* @ datasketches-memory* ---* [*INFO*] Enabled default license matchers. [*INFO*] Will parse SCM ignores for exclusions... [*INFO*] Parsing exclusions from

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
Found the WIP Disclaimer. On Thu, Aug 1, 2019 at 9:58 PM leerho wrote: > Justin, > Thank you so much for your response! > ( I feel like I'm in a vacuum at times ... so your help is much > appreciated!! ) > > I will do a thorough license search. > I will try to locate the WIP Disclaimer ... do

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
Justin, Thank you so much for your response! ( I feel like I'm in a vacuum at times ... so your help is much appreciated!! ) I will do a thorough license search. I will try to locate the WIP Disclaimer ... do you have a link? Right now I am struggling with pom issue related to the

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread Justin Mclean
Hi, > I have fixed the LICENSE file as you requested. I hope you noticed that a couple of the files included multiple, differently licensed, pieces of 3rd party code. Each license needs to be listed and checked if it is compatible with the Apache License. If Apache LIcense you need to check

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
Justin, Thank you for finding these. I have fixed the LICENSE file as you requested. I have deleted the stylesheet.css as it is no longer needed. The Gettysburg Address is public domain and indicated so in the License file. All the other files have corrected notices and are also listed in the

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread Justin Mclean
Hi, Can you please fix up your LICENSE file, the source release contains a number of 3rd party content (not al of which is under an ALv2 license) but none it it is mentioned in LICENSE. You are also not binding by the terms of some of those licenses (i.e. they require you to include the

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
Ted, I upgraded Maven to 3.6.1 -- now I see the warning above. I think I understand, after some research..., the new Maven doesn't like the ... style of specifying what Maven to use, it want us to use the Maven enforcer plugin instead. Jeez, the error message could have just said that. On Thu,

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread leerho
Thank you Furkan KAMACI, Greg Stein, and Ted Dunning. You all responded within a one hour window! Ted, [*WARNING*] The > project org.apache.datasketches:datasketches-memory:jar:1.0.0-incubating > uses > prerequisites which is only intended for maven-plugin projects but not > for non

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread Ted Dunning
+1 (binding) As a side comment, I know that you said it in your second email, but the restriction to *exactly* java 1.8 isn't clear from the README. Also, it is easy to *think* you have changed which version of java you are using, but not actually have done so. For an example of how this illusion

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread Greg Stein
+1 (binding) On Mon, Jul 29, 2019 at 12:09 AM leerho wrote: > Hello Apache general@incubator community. > > 1. This is a call for vote to release Apache DataSketches-memory version: > 1.0.0-incubating-RC2 > > NOTE 1: This is one component of the DataSketches library which needs to be >

Re: [VOTE] DataSketches-memory RC2

2019-08-01 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - Disclaimer exists - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run Kind Regards, Furkan KAMACI On Mon, Jul 29, 2019 at 7:01 PM leerho wrote: > Additional information accidentally

Re: [VOTE] DataSketches-memory RC2

2019-07-29 Thread leerho
Additional information accidentally omitted from the vote letter: 8. Build Guide: The DataSketches-memory component is pure Java and is structured as a Maven project. You must compile using JDK 8. There is one run-time dependency and, of course, a number of test and Maven plugin dependencies,

[VOTE] DataSketches-memory RC2

2019-07-28 Thread leerho
Hello Apache general@incubator community. 1. This is a call for vote to release Apache DataSketches-memory version: 1.0.0-incubating-RC2 NOTE 1: This is one component of the DataSketches library which needs to be released first as other repositories have a dependency on this one. Once this is