Thanks Justin for your information.
We can remove Font-Awesome dependencies and use new fonts in future.
I have fixed these issues, will create a new RC.
Best,
Jingsong
On Tue, May 23, 2023 at 1:01 PM wrote:
>
> Hi,
>
> > Font-Awesome has different licenses for code and fonts. So I just
> >
Hi,
> Font-Awesome has different licenses for code and fonts. So I just
> introduce two license files: LICENSE.font-awesome-code and
> LICENSE.font-awesome-fonts. Copy the contents of their respective
> licenses.
>
> And in LICENSE file:
>
> MIT License
> ---
>
Very thanks to Justin.
This RC is canceled.
Some questions I hope you can help me solve:
> LICENSE is missing license for [1] (see [2]) and other files and the maven
> wrapper.
Font-Awesome has different licenses for code and fonts. So I just
introduce two license files:
Hi,
There are many different versions of the maven wrapper, both before and after
it was donated to the ASF. However the ASF version does need to be mentioned in
LICENSE [1] and NOTICE [2].
Kind Regards,
Justin
1. https://infra.apache.org/licensing-howto.html#alv2-dep
2.
Hi,
Sorry but it's -1 (binding) from me as LICENSE and NOTICE need a little more
work and quite a few sure files are missing ASF headers.
I checked:
- incubating in name
- signature and hash are fine (Although you might want to consider changing
your apache id, it's signed with
Hi Jingsong,
The Maven Wrapper is a source dependency, so you need to add it to the
source license file.
Maybe each ASF project choose a different version of Maven Wrapper, and not
all versions of Maven Wrapper has the NOTICE file.
Jingsong Li 于2023年5月19日周五 10:17写道:
> Thanks all for your
+1(non-binding)
Checked:
- Download links are valid.
- Checksums and signatures.
- LICENSE/NOTICE files exist
- All source files have ASF headers
- Compile from source on macOS Monterey
On 2023/05/15 09:51:43 Jingsong Li wrote:
> Hello Incubator PMC,
>
> The Apache Paimon community has voted
Thanks all for your voting.
Thanks Calvin and Yu Li,
About mvn* files, yes, Paimon sources contain Maven Wrapper
Distribution. [1] We should add copyright in NOTICE. Paimon uses
distribution without any additional modifications, so there is no need
to add it to the license?
I will prepare a PR
Hi Calvin,
Thanks for the careful checking.
About the AWS-SDK and PalDB mentioning in NOTICE file, since the referenced
codes (as mentioned in the LICENSE file) are irrelevant to the other
contents of AWS-SDK [1] and PalDB's [2] NOTICE files, only the "Copyright"
lines are bubbled up according
+ 1 (binding)
[√] Download links are valid.
[√] Checksums and signatures.
[√] LICENSE/NOTICE files exist
[√] No unexpected binary files
[√] All source files have ASF headers
[√]Can compile from source
Best wishes!
Yu Xiao
Apache Member
Apache ShenYu V.P
Calvin Kirs 于2023年5月18日周四 16:40写道:
>
Hi,
-1(binding)
The mvn* files in the source package come from maven-wrapper, which is
not reflected in the License and NOTICE.
The AWS-SDK and PalDB mentioned in the NOTICE do not seem to be the
original NOTICE files, can you make sure?
I checked:
- Checksum and signature are fine.
-
+1 (non-binding)
I checked:
[x] Download links are valid
[x] Checksums and signatures
[x] LICENSE/NOTICE files exist
[x] All source files have ASF headers
[x] Can compile from source
Best,
Huajie Wang
Kent Yao 于2023年5月18日周四 14:57写道:
> Hi Justin & Yu. Thanks for the explaination.
>
>
+1
I checked:
[ok] Download links are valid
[ok] Checksums and PGP signatures are valid
[ok] Source code artifacts have correct names matching the current release
[ok] No compiled archives bundled in source archive
Kent Yao 于2023年5月18日周四 14:57写道:
> Hi Justin & Yu. Thanks for the explaination.
Hi Justin & Yu. Thanks for the explaination.
+1(non-binding)
Kent Yao
On 2023/05/18 06:49:14 Yu Li wrote:
> Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
> before Dec. 2018 it used BSD 3-clause license, and the scala version
> depended in Paimon is 2.12.7, which was
Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
before Dec. 2018 it used BSD 3-clause license, and the scala version
depended in Paimon is 2.12.7, which was released in Sep. 2018.
I also noticed this during review and commented on the PR [1], JFYI.
Please let us know if any
HI,
> The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due
> to https://www.scala-lang.org/news/license-change.html
>
> I am not sure if this is a blocker or not.
I think that can be fixed in a later release, both licenses are compatible with
the Apache license so it
The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due to
https://www.scala-lang.org/news/license-change.html
I am not sure if this is a blocker or not.
Kent Yao
On 2023/05/18 06:21:09 Becket Qin wrote:
> +1 (binding)
>
> - verified signature and checksum
> - verified
+1 (non-binding)
I checked:
[x] Download links are valid
[x] Checksums and PGP signatures are valid
[x] DISCLAIMER is included
[x] Source code artifacts have correct names matching the current release
[x] LICENSE and NOTICE files are correct for each repo
[x] All files have license headers if
+1 (non-binding)
Download links are valid.
Checksums and signatures.
LICENSE/NOTICE files exist
All source files have ASF headers
Becket Qin 于2023年5月18日周四 14:22写道:
> +1 (binding)
>
> - verified signature and checksum
> - verified license in the source code
> - locally built the source and ran
+1 (binding)
- verified signature and checksum
- verified license in the source code
- locally built the source and ran all the tests. (Some of the tests are
occasionally failing due to testcontainer timeout, but does not seem a
blocker of release).
Thanks,
Jiangjie (Becket) Qin
On Wed, May
+1 (binding)
- Checked release file name and location: *OK*
- Checked sum and signatures: *OK*
- Checked DISCLAIMER file exists: *OK*
- Checked LICENSE and NOTICE files: *OK*
* License of 3rd-party code contained correctly mentioned in LICENSE:
*OK*
* Included dependencies are
21 matches
Mail list logo