Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-23 Thread Vadim A. Misbakh-Soloviov
Thanks. But I think we can simplify that for now, since lua53 isn't available (neither in the official tree or the lua overlay) and =lua-5.2 is hardmasked. Anyway, I think, we need my default patch for luajit support here (which, actually, I'd suggest to apply on all packages in the tree,

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-23 Thread Ben de Groot
On 23 February 2015 at 14:17, Vadim A. Misbakh-Soloviov m...@mva.name wrote: I'd also say: neovim: CDEPEND=dev-lang/luajit ... dev-lua/LuaBitOp 1) I'm not sure luajit:1 fits the dep 2) LuaJIT:2 has it's own bit modules and is unneded LuaBitOp Thanks! I don't know that much about

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-22 Thread William Hubbs
On Sat, Feb 21, 2015 at 09:18:08AM +0100, Michał Górny wrote: neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5 inherit cmake-utils flag-o-matic DESCRIPTION=Vim's rebirth for the 21st century

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-22 Thread Ben de Groot
On 23 February 2015 at 01:39, William Hubbs willi...@gentoo.org wrote: On Sat, Feb 21, 2015 at 09:18:08AM +0100, Michał Górny wrote: neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5 inherit

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-22 Thread Vadim A. Misbakh-Soloviov
I'd also say: neovim: CDEPEND=dev-lang/luajit ... dev-lua/LuaBitOp 1) I'm not sure luajit:1 fits the dep 2) LuaJIT:2 has it's own bit modules and is unneded LuaBitOp Unibilium: 1.1.2 made a day ago. Bump, please ;) lua-MessagePack: RDEPEND==dev-lang/lua-5.1 And what about LuaJIT?

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Michał Górny
Hi, Don't you think it sucks to review a few ebuilds in one e-mail? :) neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5 inherit cmake-utils flag-o-matic DESCRIPTION=Vim's rebirth for the 21st century

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Paweł Hajdan, Jr.
On 2/20/15 12:10 PM, Ben de Groot wrote: At the suggestion of radhermit, I'm putting my neovim deps ebuilds up here for review, before I commit them to the official tree. Do you see any possible improvements? Overall the ebuilds look nice and clean. Some ideas: - consider asking libtermkey

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Ben de Groot
On 21 February 2015 at 16:18, Michał Górny mgo...@gentoo.org wrote: Hi, Don't you think it sucks to review a few ebuilds in one e-mail? :) No. :) neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread hasufell
Michał Górny: dev-lua/LuaBitOp dev-lua/lpeg dev-lua/lua-MessagePack DEPEND=${CDEPEND} virtual/libiconv virtual/libintl RDEPEND=${CDEPEND} perl? ( dev-lang/perl ) python? ( dev-python/neovim-python-client ) src_configure() { append-cflags

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Michał Górny
Dnia 2015-02-21, o godz. 14:43:05 Michael Orlitzky m...@gentoo.org napisał(a): On 02/21/2015 03:18 AM, Michał Górny wrote: DEPEND=${RDEPEND} sys-devel/libtool Using system-wide libtool is horrendously broken. This is something for upstream to fix (like they should start using a

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Michael Orlitzky
On 02/21/2015 04:05 PM, Michał Górny wrote: https://bugs.gentoo.org/show_bug.cgi?id=401237 because Nagios needs libltdl to build. Is that still a problem? Yes, it is. Because dev-libs/libltdl. Thanks, it looks like I investigated the bug on the same day that package was committed. I

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Tim Harder
On 2015-02-21 13:19, Ben de Groot wrote: neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5 inherit cmake-utils flag-o-matic DESCRIPTION=Vim's rebirth for the 21st century

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Michael Orlitzky
On 02/21/2015 03:18 AM, Michał Górny wrote: DEPEND=${RDEPEND} sys-devel/libtool Using system-wide libtool is horrendously broken. This is something for upstream to fix (like they should start using a sane build system) but if you really want to commit it like this, already open a bug

Re: [gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-21 Thread Michał Górny
Dnia 2015-02-22, o godz. 02:19:18 Ben de Groot yng...@gentoo.org napisał(a): neovim: # Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=5 inherit cmake-utils flag-o-matic DESCRIPTION=Vim's rebirth for

[gentoo-dev] [RFC] please review ebuilds for neovim and deps

2015-02-20 Thread Ben de Groot
At the suggestion of radhermit, I'm putting my neovim deps ebuilds up here for review, before I commit them to the official tree. Do you see any possible improvements? Right now the neovim ebuild does not install any global default nvimrc like we do with vim. We should probably consider doing