Ulrich Mueller writes:
>> On Mon, 26 Jun 2023, Sam James wrote:
>
>> +
>> +# Avoid creating ${WORKDIR}_build (which is above WORKDIR).
>> +# TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
>> +# See bug #889420.
>> +if [[ ${S} ==
> On Mon, 26 Jun 2023, Jaco Kroon wrote:
>> if [[ ${BUILD_DIR} != "${WORKDIR}"/* ]]; then
> BUILD_DIR="${WORKDIR}/../build"
Oh right, I hadn't thought about the case that the ebuild would override
it. (AFAICS cmake.eclass itself doesn't do .. in BUILD_DIR.)
> I know it's pathological ...
Hi,
On 2023/06/26 12:36, Ulrich Mueller wrote:
On Mon, 26 Jun 2023, Sam James wrote:
+
+ # Avoid creating ${WORKDIR}_build (which is above WORKDIR).
+ # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
+ # See bug #889420.
+ if [[
> On Mon, 26 Jun 2023, Sam James wrote:
> +
> + # Avoid creating ${WORKDIR}_build (which is above WORKDIR).
> + # TODO: For EAPI > 8, we should ban S=WORKDIR for CMake.
> + # See bug #889420.
> + if [[ ${S} == ${WORKDIR} && ${BUILD_DIR} ==
When S=${WORKDIR}, cmake.eclass would create its build directory (if
CMAKE_USE_DIR
is unset) above WORKDIR(!) as ${WORKDIR}_build. Creating directories above
WORKDIR is not legal.
Portage has its own bug (bug #889418) in that it doesn't clean up unknown
directories
above WORKDIR in
