Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Sampo Savolainen
Hi Justin, On Tue, May 20, 2014 at 6:50 AM, Justin Deoliveira < jdeol...@boundlessgeo.com> wrote: > > 1. What would be the consequence of not using the naming convention and > just exposing the stored queries directly as they are named? Is it solely > to make it explicit that the type is a stored

Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Justin Deoliveira
Hey Sampo, Sorry I haven't been following the work too closely, but my first initial thoughts. 1. What would be the consequence of not using the naming convention and just exposing the stored queries directly as they are named? Is it solely to make it explicit that the type is a stored query, and

Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Sampo Savolainen
Ok. I hadn't noticed you were this far along. I was proposing merging our changesets to avoid us from diverging from this point onwards. As you're almost done so we should be pretty safe from that. Andrea, Justin, or anyone: do you guys have any comments regarding the questions I brought up earlie

Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Sampo Savolainen
Hi, Should I just create a pull request on your branch and then I could continue work on a branch based off your branch? This would mean bundling our changes into a single changeset. I haven't heard any opposition to this idea, though. Thoughts? Sampo On Mon, May 19, 2014 at 11:23 AM, Niels C

Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Niels Charlier
There is currently a pull request for my changes being reviewed. I'm not sure when your changes will be reviewed and by whom. But I assume they need to be reviewed separately, and preferably not at the same time. But it is already good that your changes have now a base from my branch. Regards

Re: [Geoserver-devel] Status update + merge

2014-05-19 Thread Niels Charlier
Thanks for the merging Sampo, looks good. Cheers Niels On 15/05/14 11:09, Sampo Savolainen wrote: Hi, I've successfully merged my and Niels's work. It was surprisingly easy with only one minor conflict. I noticed that you have discussed having a shared branch for me, Niels and Reni. This wou

Re: [Geoserver-devel] Status update + merge

2014-05-15 Thread Sampo Savolainen
On Thu, May 15, 2014 at 12:42 PM, Andrea Aime wrote: > > GeoServer core currently depends on the wfs module in order to support WMS > feature portrayal services, > that is, requests where the indication of the data to be painted is > provided in the request by giving > a link to a capabilities docu

Re: [Geoserver-devel] Status update + merge

2014-05-15 Thread Andrea Aime
On Thu, May 15, 2014 at 11:09 AM, Sampo Savolainen < sampo.savolai...@spatineo.com> wrote: > Hi, > > I've successfully merged my and Niels's work. It was surprisingly easy > with only one minor conflict. I noticed that you have discussed having a > shared branch for me, Niels and Reni. This would

[Geoserver-devel] Status update + merge

2014-05-15 Thread Sampo Savolainen
Hi, I've successfully merged my and Niels's work. It was surprisingly easy with only one minor conflict. I noticed that you have discussed having a shared branch for me, Niels and Reni. This would be wise indeed as the danger of us either working on the same thing or against each other is pretty b