On Tue, Jun 25, 2013 at 11:39 PM, Brett Walker
brett.wal...@geometryit.comwrote:
Hi,
What is the policy/procedure/expectation for pull requests that have been
submitted for more than a couple of weeks?
There are a number of pull requests that have been sitting 'dormant' for a
while. Do
On Tue, Jun 25, 2013 at 11:39 PM, Brett Walker
brett.wal...@geometryit.comwrote:
Ignoring worthwhile patches could appear to give the cold shoulder to the
wider community.
Ah, if you were referring to this pull request:
https://github.com/geotools/geotools/pull/208
the reason why it's not
https://github.com/geotools/geotools/pull/217
Peter thinks this one is fine, I look at it and see a nuclear bomb ready to
explode.
In order to upgrade this one we also have to upgrade the dependencies in
GeoServer and GWC and make sure the upgrade path is smooth (the database
format changed a
Andrea,
It was my misunderstanding on my part. It was trying to have a discussion which
would educate subsequent commits. This being the first of several. I should
have had the discussion on this mailing list rather on the pull request.
The pull request (PR#208) is finished. Could you provide
I had concerns also.
While not nuclear bomb-like, backwards compatibility came to mind.
Brett
From: Andrea Aime [mailto:andrea.a...@geo-solutions.it]
Sent: Wednesday, 26 June 2013 4:16 PM
To: Geotools-Devel list
Subject: [Geotools-devel] About PR 217, H2 upgrad
On Wed, Jun 26, 2013 at 8:15 AM, Brett Walker
brett.wal...@geometryit.comwrote:
Andrea,
** **
It was my misunderstanding on my part. It was trying to have a discussion
which would educate subsequent commits. This being the first of several. I
should have had the discussion on this
On Wed, Jun 26, 2013 at 5:24 AM, Ben Caradoc-Davies
ben.caradoc-dav...@csiro.au wrote:
+1.
I changed the title to attract attention. You need three +1 votes. See
also:
http://docs.geotools.org/latest/developer/roles/commit.html
Here goes the second +1
Cheers
Andrea
--
==
Our support,
Hi
@Chris. I am the long term maintainer of the DB2 module. See the latestet
release notes
http://geotoolsnews.blogspot.co.at/2013/06/geotools-93-released.html
There is almost no feed back from the community, enhancements are done
based on my experience or from requirements sent to me by David
And here comes the third +1
Cheers
Christian
2013/6/26 Andrea Aime andrea.a...@geo-solutions.it
On Wed, Jun 26, 2013 at 5:24 AM, Ben Caradoc-Davies
ben.caradoc-dav...@csiro.au wrote:
+1.
I changed the title to attract attention. You need three +1 votes. See
also:
A little confused here... are we talking h2 or hsql? The pr doesn't seem to
touch h2 at all unless i am missing something.
Regardless i agree that any upgrade requiring a migration like this we need
to be careful of. I would say keep pegged to a version we know is safe but
also try to allow for
On Wed, Jun 26, 2013 at 12:48 PM, Justin Deoliveira jdeol...@opengeo.orgwrote:
A little confused here... are we talking h2 or hsql? The pr doesn't seem
to touch h2 at all unless i am missing something.
Doh, you're right, it's HSQL!
Regardless i agree that any upgrade requiring a migration
You are rightly confused.
The original Pull Request is about the epsg-hsql module.
Andrea mentioned the jdbc-h2 module. I think this is the start of the
confusion. I didn't spot the difference either until you mentioned it.
What I said about maintaining backwards compatibility still stands.
Ah right, apologies Christian, I'd completely forgotten, I guess because
you've actually been doing great work with it for so long, and you've
expanded your contributions in to many other areas.
Oh yeah, and merging the file and database image modules would be really
great. One preliminary step
Once again from off-list:
geotools-9.3\modules\library\main\src\main\java\org\geotools\util\EnumerationConverterFactory.java
geotools-9.3\modules\unsupported\process-raster\src\main\java\org\geotools\process\raster\BaseCoverageAlgebraProcess.java
Hi Chris
I am completely with you, but I think we should discuss this in a new
thread.
Cheers
Christian
2013/6/26 Chris Holmes chol...@opengeo.org
Ah right, apologies Christian, I'd completely forgotten, I guess because
you've actually been doing great work with it for so long, and you've
Kevin
16 matches
Mail list logo
