[Geotools-devel] getting set for java 11 compatible milestone release

2018-12-27 Thread Jody Garnett
I would like to start the release process for GeoTools 21-M0 and GeoServer 2.15-M0. Checking the CITE tests we may have a bit of work todo to determine the geotools revision: version = 2.15-SNAPSHOT > git revision = eb0c4d22f6b3bf6b9f4eccae3451d25b5546 > git branch = origin/master > build dat

Re: [Geotools-devel] Thinking about static analysis

2018-12-27 Thread Andrea Aime
On Thu, Dec 27, 2018 at 6:46 PM Andrea Aime wrote: > I believe it was done once already in the past... think I did it actually, > it was running on a old computer below my desk > Ah yep, back in 2011: https://sourceforge.net/p/geotools/mailman/message/27433564/ Compare the enthusiasm in the thr

Re: [Geotools-devel] Thinking about static analysis

2018-12-27 Thread Andrea Aime
Hi Frank, I'm familiar with it and almost sure that while it can work in a job setting where one has hardening sprints and targets to get quality at certain levels, it won't work in an open source project like GeoTools or GeoServer, where each changeset is stand-alone, often driven by a particular

Re: [Geotools-devel] Thinking about static analysis

2018-12-27 Thread Frank Gasdorf via GeoTools-Devel
We are using https://www.sonarqube.org/ to check code quality not only for one project. Maybe it's worth to define rules that can be used by other OSGeo Projects as well. Great stuff IMHO, because you get trends, and coverage reports with maven builds, just integrate the plugin and configure Jenki

Re: [Geotools-devel] QA branch is going live (was "thinking about static analysis")

2018-12-27 Thread Andrea Aime
Hi all, think I'm getting to a point where I'm satisfied with the results: - added a few more rules in PMD - added errorprone in the mix and got a full build going (requires JDK 11) - the travis build is still erratic, works fine locally but goes OOM on Travis (done at least twice)

Re: [Geotools-devel] QA branch is going live (was "thinking about static analysis")

2018-12-27 Thread Andrea Aime
On Thu, Dec 27, 2018 at 9:01 AM Andrea Aime wrote: > Next steps: > >- I want to see if I can use the Travis build matrix ability in order >to have three builds, a jdk 8 without formatting checks, a jdk 11 without >formatting checks, and a QA JDK 8 build that does formatting checks and

[Geotools-devel] QA branch is going live (was "thinking about static analysis")

2018-12-27 Thread Andrea Aime
Hi all, following the discussion about static analysis, and considering there have been no negative statements about it, here is a branch to host the collaborative work on adding automatic QA checks in the codebase: https://github.com/geotools/geotools/tree/qa There is also a pull request to check