Re: [Geotools-devel] app-schema / complex features module

2012-11-13 Thread Adam.Brown
Hi Andrea, Sorry, I think my previous email might have been a bit misleading: XSDMapping is just an @interface whose only dependency is on java.lang.annotation.*. I put it in gt-main to keep it next to FeatureWrapper, with which I intend it to be used. Both of these files can be moved elsewhere

Re: [Geotools-devel] app-schema / complex features module

2012-11-12 Thread Adam.Brown
Hi Niels, et al., The work that I did in ComplexFeature Parsing and building support is located at https://github.com/Adam-Brown/geotools/tree/gml_client_lib. It includes a generic feature builder, a complex feature builder and an attribute builder which I put in gt-main. I also added XSDMappin

Re: [Geotools-devel] Voting for ComplexFeature Parsing and Building Support

2012-09-03 Thread Adam.Brown
Hi Andrea, Thanks for your feedback and sorry about the formatting issues - I was running the formatter over the whole document as I thought they were meant to comply with the guidelines but Ben has explained to me that any existing code's style should take precedence. I've fixed the formattin

[Geotools-devel] ComplexFeature Parsing and Building Support

2012-08-29 Thread Adam.Brown
Hi Andrea, others, I've just added another test to XmlComplexFeatureParserTest which uses gsml's borehole as an example. This particular one has a nested ComplexFeature (borehole collar), is this the kind of thing you were referring to in your second question? Cheers, Adam -Original Mess

[Geotools-devel] Parsing and Building / Creating a complex feature type out of a XML schema

2012-08-29 Thread Adam.Brown
Hi Andrea, others, I've gathered up all your recent questions to answer them all together, the last one also pertains to your question about creating complex feature types from an XSD: Q: Is the WFS data store going to return back simple features and simple feature types for simple feature GML

[Geotools-devel] Voting for ComplexFeature Parsing and Building Support

2012-08-28 Thread Adam.Brown
Hi all, I'd like to request a vote on getting my ComplexFeature parsing work integrated in trunk. The change proposal is here: http://docs.codehaus.org/display/GEOTOOLS/ComplexFeature+Parsing+and+Building+Support And my work is on https://github.com/Adam-Brown/geotools (master branch) Many th

[Geotools-devel] 2. Complex feature builder, where are you?

2012-08-28 Thread Adam.Brown
Re: 2. Complex feature builder, where are you? Hi Andrea, I've just pushed through some finishing touches (commenting, formatting etc) to my Geotools fork: https://github.com/Adam-Brown/geotools/commits/master The main tests that will reveal the new changes are in: XmlComplexFeatureParserTest C

Re: [Geotools-devel] [ExternalEmail] Migrate ComplexFeature Parsing work off wfs-ng

2012-07-27 Thread Adam.Brown
Hi Ben and others, Thanks for your response. I already forked wfs-ng (from Gabriel's) but the problem I'm having is that there are errors in it which prevent it compiling. I don't really know how much (if any) of wfs-ng I need because I don't actually know how it differs from trunk - I just pu

[Geotools-devel] Migrate ComplexFeature Parsing work off wfs-ng

2012-07-26 Thread Adam.Brown
Hi all, I am doing some work to add ComplexFeature parsing and building support to GeoTools. At the moment it's on my own fork of wfs-ng. The decision around me doing this work on this branch was arr

Re: [Geotools-devel] API Change Proposal: ComplexFeature Parsing & Building Support

2012-06-12 Thread Adam.Brown
Hi Andrea, Thank you for your response. I will try to add more explanatory notes to the proposal when time permits. I considered making several smaller proposals but decided against it as I didn't think the task lent itself to being broken up; the individual components wouldn't have any utility

Re: [Geotools-devel] API Change Proposal: ComplexFeature Parsing & Building

2012-06-11 Thread Adam.Brown
Hi Justin, What I meant by ComplexFeatureBuilder.append(Name, Property) and SimpleFeatureBuilder.add(Object) being semantically different is that the append(...) method associates a Property with a specific Name (this is necessary for schemata that have multi-valued types) whereas add(...) just

Re: [Geotools-devel] API Change Proposal: ComplexFeature Parsing & Building Support

2012-06-06 Thread Adam.Brown
Hi Justin et al., Thanks for your feedback. I could change append(...) to add(...) but I wouldn't be able to raise it to the superclass (FeatureBuilder<...>) because the signatures are different: append(Name, Property) and add(Object). So we would just have two different add(...) methods in ea

Re: [Geotools-devel] ComplexFeature Parsing & Building Support

2012-06-06 Thread Adam.Brown
Hi Andrea, Thanks for your response. Answers to your questions follow: * I don't have commit access to the SVN repository but I've forked Gabriel's wfs-ng branch (https://github.com/groldan/geotools/tree/wfs_ng) to https://github.com/Adam-Brown/geotools/tree/wfs_ng and I've been working there.

[Geotools-devel] ComplexFeature Parsing & Building Support

2012-06-04 Thread Adam.Brown
Hi all, I want to add support for complex feature parsing to GeoTools. It will involve some new API additions hence I'm following the change proposal guide. http://jira.codehaus.org/browse/GEOT-4147 http://docs.codehaus.org/pages/viewpage.action?pageId=229736622 This will involve the introduct