Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-22 Thread Kevin Smith
I did a quick scan and it looks good to me. On 22 April 2014 08:42, Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it> wrote: > If it helps, it has been used for a month and it has worked fine. > > Cheers, > Nicola. > > > 2014-04-22 17:23 GMT+02:00 Nicola Lagomarsini < > nicola.lagomars..

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-22 Thread Kevin Smith
Looks good to me. On 22 April 2014 08:42, Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it> wrote: > If it helps, it has been used for a month and it has worked fine. > > Cheers, > Nicola. > > > 2014-04-22 17:23 GMT+02:00 Nicola Lagomarsini < > nicola.lagomars...@geo-solutions.it>: > > H

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-22 Thread Nicola Lagomarsini
If it helps, it has been used for a month and it has worked fine. Cheers, Nicola. 2014-04-22 17:23 GMT+02:00 Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it>: > Hi all, > > I'm asking if I can backport my modifications related to the WMSTileFuser > on the 1.5.x branch of GeoWebCache. >

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-22 Thread Nicola Lagomarsini
Hi all, I'm asking if I can backport my modifications related to the WMSTileFuser on the 1.5.x branch of GeoWebCache. NOTE: The pull request will upgrade the ImageIO-Ext version. I will be pleased to answer to your questions. Cheers, Nicola. 2014-04-08 19:19 GMT+02:00 Nicola Lagomarsini < nic

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-08 Thread Nicola Lagomarsini
Hi all, I have prepared the first pull request related to the backport of my modifications for the WMSTileFuser(GeoWebCache) on GeoTools 11.x. The pull request is https://github.com/geotools/geotools/pull/410. NOTE: This pull requests will upgrade the ImageIO-Ext version from 1.1.8 to 1.1.9 whic

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-04-04 Thread Nicola Lagomarsini
Hi all, I would ask if I can backport my modifications related to the WMSTileFuser class (GeoWebCache) on the following versions of GeoTools, GeoServer and GeoWebCache: - Geotools: 11.x and 10.x - GeoServer: 2.5.x and 2.4.x - GeoWebCache: 1.5.x I will wait a month from the date of eac

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Nicola Lagomarsini
Hi all, I have changed the hints configurations by differentiating the interpolation type for each configuration: - speed = nearest interpolation (link https://drive.google.com/file/d/0B_H-B1p4qGi6aXN1TGpwNUc0MWs/edit?usp=sharing ) - default = bilinear interpolation (link https://d

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Nicola Lagomarsini
Hi all, I have changed the quality factor to 0.25 and the image size is above 40kb. Here you can find the links for the new compressed images. speed configuration link: https://drive.google.com/file/d/0B_H-B1p4qGi6OHhRZU9GcXZTZG8/edit?usp=sharing default configuration link: https://drive.google.c

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Nicola Lagomarsini
Hi all, I have set the quality factor to 0.1 inside the pull requests. Cheers, Nicola. 2014-03-07 11:11 GMT+01:00 Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it>: > Hi Andrea, > > the quality parameter can be configured inside the application context for > the PNGEncoder inside the g

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Nicola Lagomarsini
Hi Andrea, the quality parameter can be configured inside the application context for the PNGEncoder inside the gwc-wms and gs-gwc modules. By setting for example the quality parameter to 0.1 the image size is considerably reduced. About the hints considerations I have used different hints for ea

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Andrea Aime
On Fri, Mar 7, 2014 at 10:28 AM, Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it> wrote: > Hi all, > > I'm going to show some images for comparing the old wmsTileFuser class and > its modified version, both in *fullWMS* mode enabled. > > I made the *fullWMS* parameter configurable from th

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-07 Thread Nicola Lagomarsini
Hi all, I'm going to show some images for comparing the old wmsTileFuser class and its modified version, both in *fullWMS* mode enabled. I made the *fullWMS* parameter configurable from the geowebcache.xml file by adding the TRUE(or FALSE) field. I added the possibility for the user to change th

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-05 Thread Andrea Aime
On Wed, Mar 5, 2014 at 4:41 PM, Simone Giannecchini < simone.giannecch...@geo-solutions.it> wrote: > Ciao Nicola, > I would leave this parameter as it was originally, which is False. > > This behaviour should be, IMHO, enabled explicitly if needed. > The annoying bit is that now it's enabled in S

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-05 Thread Simone Giannecchini
Ciao Nicola, I would leave this parameter as it was originally, which is False. This behaviour should be, IMHO, enabled explicitly if needed. Regards, Simone Giannecchini == Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information. == Ing. Simone Giannecchini @simog

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-05 Thread Nicola Lagomarsini
Hi all, I would ask you a question about the GeoWebCache configuration. In my pull request I have set the GeoWebCache *fullWMS* parameter from FALSE to TRUE inside the applicationContext for enabling the operations with the WMSTileFuser class. Could this parameter always be set to true or it mus

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-05 Thread Nicola Lagomarsini
Hi all, I have sent you the following pull requests to review. They should be merged in the following order: Geotools --> https://github.com/geotools/geotools/pull/384 GeoWebCache --> https://github.com/GeoWebCache/geowebcache/pull/229 GeoServer --> https://github.com/geoserver/geoserver/pull/524

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-03 Thread Nicola Lagomarsini
Hi Jody, I will apply my changes only when the 11.0 will go out. Cheers, Nicola. 2014-03-01 13:32 GMT+01:00 Jody Garnett : > Question: are you wishing to apply this to 11.x before 11.0 goes out? That > is a bit risk, if that is your intention you will need to move promptly to > perform the cha

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-03-01 Thread Jody Garnett
Question: are you wishing to apply this to 11.x before 11.0 goes out? That is a bit risk, if that is your intention you will need to move promptly to perform the change prior to RC2 going out. Jody Jody Garnett On Sat, Mar 1, 2014 at 2:06 AM, Nicola Lagomarsini < nicola.lagomars...@geo-solution

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-28 Thread Nicola Lagomarsini
Hi all, I would recall the proposal for modifying the WMSTileFuser class in order to reach better performances on image reading and writing. The modifications on the WMSTileFuser class can be divided in 3 groups: - improving the reading of every tile and the final image writing by adding f

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-10 Thread Jody Garnett
Not from me, technically what you are doing is very clear cut. It would be good to hear back from GWC list as that appears to be the most effected (i.e. new functionality). Jody Garnett On Tue, Feb 11, 2014 at 2:12 AM, Nicola Lagomarsini < nicola.lagomars...@geo-solutions.it> wrote: > Ok I wil

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-10 Thread Nicola Lagomarsini
Ok I will send an email to the ML. Is there another feedback? Cheers, Nicola. 2014-02-10 12:37 GMT+01:00 Jody Garnett : > I am always troubled by such questions, let me think. > > As the original contributor you can pick up the code and contribute it to > another project. > > Since it is Nicol

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-10 Thread Jody Garnett
I am always troubled by such questions, let me think. As the original contributor you can pick up the code and contribute it to another project. Since it is Nicola is doing the work, your +1 on the GeoServer list as a PSC will work out fine. That way the GeoServer list has a record that the reque

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-10 Thread Andrea Aime
On Sun, Feb 9, 2014 at 1:29 PM, Jody Garnett wrote: > So I understand what is being proposed. I suppose my questions twofold a) > what is your time frame for this work and b) why 10.x ( since we are > nearing the 11.0)? > > As for moving code between projects, everything looks okay. For the > Ge

Re: [Geotools-devel] [Geowebcache-devel] Modification on WMSTileFuser class

2014-02-09 Thread Jody Garnett
So I understand what is being proposed. I suppose my questions twofold a) what is your time frame for this work and b) why 10.x ( since we are nearing the 11.0)? As for moving code between projects, everything looks okay. For the GeoServer code subject to a license change we will need a email requ