Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > I guess we can just revert to the old way for the time being. > Getting the output in bin is a matter of using: > mvn eclipse:eclipse -DoutputDirectory=bin > not significantly longer than enabling a profile. > Is this ok for everybody? I am also happy with that. Please documen

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > Third option, take the latest eclipse stable release, patch it so > that it generate separate output folders, roll our own eclipse-gt > plugin variant until the official eclipse plugin gets its acts > togheter. > I'll try to give a shot at this option during the weekend. > How

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > I can see two paths: > - move back the eclipse output trick in a profile I think this is the cleanest approach for now. How about -Peclipse-bin? I would be equally happy with leaving bin as the default and having a profile to turn it off (-Peclipse-shared). > - have the tes

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Justin Deoliveira wrote: > Andrea Aime wrote: >> I can see two paths: >> - move back the eclipse output trick in a profile >> - have the tests that need to register factories avoid using META-INF >>and roll a custom factory iterator instead. As far as I can see >>only three modules make use

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Christian Müller
Works for me Justin Deoliveira writes: > Andrea Aime wrote: >> Justin Deoliveira ha scritto: >>> 3) revert back to the old way :) >>> >>> Seems like 1) move the new eclipse config to a profile seems the >>> nicest way. It gives developers the choice of how to set up their >>> eclipse environ

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Justin Deoliveira ha scritto: > Andrea Aime wrote: >> Andrea Aime ha scritto: >>> Ben Caradoc-Davies ha scritto: Andrea Aime wrote: > Did you spot what exactly is not working, which spi resource is not > being properly read? org.geotools.data.DataAccessFactory org.geotools.fi

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Justin Deoliveira
Andrea Aime wrote: > Andrea Aime ha scritto: >> Ben Caradoc-Davies ha scritto: >>> Andrea Aime wrote: Did you spot what exactly is not working, which spi resource is not being properly read? >>> org.geotools.data.DataAccessFactory >>> org.geotools.filter.FunctionExpression >>> >>> which b

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Justin Deoliveira
Andrea Aime wrote: > Justin Deoliveira ha scritto: >> 3) revert back to the old way :) >> >> Seems like 1) move the new eclipse config to a profile seems the >> nicest way. It gives developers the choice of how to set up their >> eclipse environment. > > I guess we can just revert to the old way

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Justin Deoliveira ha scritto: > 3) revert back to the old way :) > > Seems like 1) move the new eclipse config to a profile seems the nicest > way. It gives developers the choice of how to set up their eclipse > environment. I guess we can just revert to the old way for the time being. Getting

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Justin Deoliveira
Andrea Aime wrote: > Ben Caradoc-Davies ha scritto: >> Andrea Aime wrote: >>> Did you spot what exactly is not working, which spi resource is not >>> being properly read? >> org.geotools.data.DataAccessFactory >> org.geotools.filter.FunctionExpression >> >> which both have main versions and test ve

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Andrea Aime ha scritto: > Ben Caradoc-Davies ha scritto: >> Andrea Aime wrote: >>> Did you spot what exactly is not working, which spi resource is not >>> being properly read? >> org.geotools.data.DataAccessFactory >> org.geotools.filter.FunctionExpression >> >> which both have main versions and te

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: > Andrea Aime wrote: >> Btw, I was trying to look into this one and noticed that >> app-schema is not included in the build when specifying -Dall, >> meaning the main Hudson won't pick it up. >> It this by choice? > > Yes, it has never been proposed for inclusion. On

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: > Andrea Aime wrote: >> Did you spot what exactly is not working, which spi resource is not >> being properly read? > > org.geotools.data.DataAccessFactory > org.geotools.filter.FunctionExpression > > which both have main versions and test versions. The test ones ca

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > Btw, I was trying to look into this one and noticed that > app-schema is not included in the build when specifying -Dall, > meaning the main Hudson won't pick it up. > It this by choice? Yes, it has never been proposed for inclusion. On my rather long list of things to do. I

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > Did you spot what exactly is not working, which spi resource is not > being properly read? org.geotools.data.DataAccessFactory org.geotools.filter.FunctionExpression which both have main versions and test versions. The test ones cannot go in main because they reference test

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: > Andrea, > > I can confirm that changing the maven-eclipse-plugin > buildOutputDirectory to bin (GEOT-2576) breaks app-schema unit tests > because it prevents both main and test SPI resources from being > available at unit test run time in Eclipse (they run fine

Re: [Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Andrea Aime
Ben Caradoc-Davies ha scritto: > Andrea, > > I can confirm that changing the maven-eclipse-plugin > buildOutputDirectory to bin (GEOT-2576) breaks app-schema unit tests > because it prevents both main and test SPI resources from being > available at unit test run time in Eclipse (they run fine

[Geotools-devel] Eclipse bin output breaks test SPI resources

2009-07-02 Thread Ben Caradoc-Davies
Andrea, I can confirm that changing the maven-eclipse-plugin buildOutputDirectory to bin (GEOT-2576) breaks app-schema unit tests because it prevents both main and test SPI resources from being available at unit test run time in Eclipse (they run fine in maven). With the default maven settings