Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread David Winslow
Okay, I dug around here a bit and I don't see any surprising behavior here. It looks like adding that Color->String conversion fixed the problem I was seeing as well, so even the first patch probably doesn't fix anything any more. Sorry for the noise. -- David Winslow OpenGeo - http://openge

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread David Winslow
Oops, I commented on the GeoServer ticket before seeing this. For convenience I'll copy/paste: I'm not evaluating expressions anywhere; the CSS file gets converted to an instance of org.geotools.styling.Style and passed to GeoTools' SLDTransformer.transform(). When no color is specifie

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Jody Garnett
Thanks David; next time can you supply a test case so we can show that the patch "does" something? (or indeed does anything?) As Andrea indicated we should focus a bit more on getting patches in and reviewed so we can recommend new committers; in part by following the same procedure ourselves :

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Jody Garnett
We should stay on the list and that stack trace should go into the bug report :-) So now we are making some progress it is ParameterGroup that is having trouble? Those classes are not really supposed to be that mutable (and thus not need cloning). Oh wait maybe it was ParameterGroupDescri

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread David Winslow
I have a tiny little patch that I'd love to see make it into this release: http://jira.codehaus.org/browse/GEOT-3036 As far as I know this only shows itself in the GeoServer css community module, and there's an easy workaround, but it would be nice to get it working in GeoTools proper. -- Davi

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Jody Garnett
Comments inline. On 12/05/2010, at 10:02 PM, Joachim Van der Auwera wrote: > Dear Jody, > > Nobody on our team has commit rights. Well that can be fixed; I see andrea has already indicated how :-) We do try to be an open welcoming project if there is anything we can do to assist let us know.

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Andrea Aime
Joachim Van der Auwera ha scritto: > Dear Jody, > > Nobody on our team has commit rights. > > The patch does not literally include a patch, but it includes details > about the fix and how to reproduce the problem (fix just involves adding > "implements Cloneable" on "org.geotools.referencing.wk

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Joachim Van der Auwera
Dear Jody, Nobody on our team has commit rights. The patch does not literally include a patch, but it includes details about the fix and how to reproduce the problem (fix just involves adding "implements Cloneable" on "org.geotools.referencing.wkt.Formattable"). Kind regards, Joachim On 05/12

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-12 Thread Michael Bedward
> On 11 May 2010 17:19, Jody Garnett wrote: >> >> Michael can your interpolate function be brought in from the cold? I think >> it has gotten some review now ... >> With Andrea's help, the problems with the last patch have been fixed and a new one is attached to the issue... http://jira.codehaus.

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-11 Thread Jody Garnett
Sure; do you have someone with commit access to apply the patch? Is there a patch :-) Is there a test case... I am not going to call "out of the pool" until Friday according to the CSIRO crew doing the geoserver release; so you have some time to get fixes in. Jody On 12/05/2010, at 4:17 PM, Jo

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-11 Thread Joachim Van der Auwera
Dear Jody, Would it still be possible to consider GEOT-3062 for inclusion in this release? That would help Geomajas to use the latest version. Thanks, Joachim On 05/11/2010 09:19 AM, Jody Garnett wrote: > We are going to get a GeoTools 2.6.4 out this week :-) > > By happy chance both uDig and G

Re: [Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-11 Thread Michael Bedward
On 11 May 2010 17:19, Jody Garnett wrote: > > Michael can your interpolate function be brought in from the cold? I think it > has gotten some review now ... > Andrea said he managed to break it. I'm waiting for him to tell me how he did it :-) Michael ---

[Geotools-devel] GeoTools 2.6.4 releaese warning

2010-05-11 Thread Jody Garnett
We are going to get a GeoTools 2.6.4 out this week :-) By happy chance both uDig and GeoServer are getting released at the same time; so this release of GeoTools will be subject to lots of testing. Michael can your interpolate function be brought in from the cold? I think it has gotten some rev