Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-24 Thread Jody Garnett
Did the proposal also want to remove (deprecate in this case) the collection listeners? Or was it just the discussion block in the jira? The CollectionEvent support is replaced by FeatureEvent (i.e. feature source level) as per another already approved proposal. Indeed it was completing that

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-24 Thread Jody Garnett
Sorry I did not look closely at the proposal, I only deprecated what it described, and left the sort and subCollection methods in place (as it also described). I will double check the remaining methods and update the proposal page if you like. I am more focused on the patch right now.

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-24 Thread Andrea Aime
On Sun, Jun 24, 2012 at 11:32 AM, Jody Garnett jody.garn...@gmail.comwrote: I think getDescriptor() is simply missing. Still don't get it. The need is either clear or it should be left out. I don't get what you don't get :( getSchema(): FeatureType (holds the type of the element of the

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-24 Thread Jody Garnett
Okay I get where the confusion comes from … This is not the descriptor of the feature collection (which you are correct would be handled by whatever is containing it). This is instead only talking about getting a better handle on the contents of our feature collection. My impression this is

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-23 Thread Andrea Aime
On Thu, Jun 21, 2012 at 9:36 AM, Jody Garnett jody.garn...@gmail.comwrote: Ugh, implemented as you suggest it will affect performance of WPS chaining a lot. This is due to the removal of the subCollection methods, which are the only way to have a streaming process (one that returns a

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-21 Thread Andrea Aime
On Thu, Jun 21, 2012 at 3:09 AM, Jody Garnett jody.garn...@gmail.comwrote: A very old proposal removing the methods that assume an in memory model: - http://docs.codehaus.org/display/GEOTOOLS/FeatureCollection+revolution I have a small non-destructive patch providing the remaining

Re: [Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-21 Thread Jody Garnett
Ugh, implemented as you suggest it will affect performance of WPS chaining a lot. This is due to the removal of the subCollection methods, which are the only way to have a streaming process (one that returns a computing collection) compute less data if a downstream process needs

[Geotools-devel] Proposal (old) ready for review and deprecation patch for 8.x patch

2012-06-20 Thread Jody Garnett
A very old proposal removing the methods that assume an in memory model: - http://docs.codehaus.org/display/GEOTOOLS/FeatureCollection+revolution I have a small non-destructive patch providing the remaining deprecations outlined in the proposal: - https://jira.codehaus.org/browse/GEOT-4181 Can