Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2816
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948677d23a58ce112b57f91bea953a93baab4c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: BSC: Add series of message sequence charts about MGCP handling
..
BSC: Add series of message sequence charts about MGCP handling
Change-Id: Id5948677d23a
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2856
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3dd32102c7362f3b280d2c058c2decebccb357a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
G
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2855
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ca4950e49a09c63b608b13ac7561ebbd351889a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Ge
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2802
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I710c7871f959671deb3d18ab9062588f3056fd7c
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: introduce proper test case for GSM FR detection
..
introduce proper test case for GSM FR detection
our code is actually wrong, so let's skip the test unt
Harald Welte has submitted this change and it was merged.
Change subject: Fix wrongful GSM FR codec SID frame detection in DTX.
..
Fix wrongful GSM FR codec SID frame detection in DTX.
Based on ETSI TS 101 318 section 5.1.2 the
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 483: msg = 'suite.conf reserved only %d x %r.' %
(len(kind_reserved), kind)
> exactly, this is correct. I could check for used_count == len(
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2852
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c67600ba69351859e46b8b2f368ee8106db0993
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 7: Code-Review-1
(1 comment)
You can merge once you push a new version removing the line I pointed in the
comment.
https://gerrit.osmocom.org/#/c/2854/7/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 179: self.status = SuiteRun.UNKNOWN
This is already s
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2787
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia699d3494b93b7f88c36338e4960b35c42a29b9c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: osmo_{fr,hr}_check_sid(): Use const input argument
..
osmo_{fr,hr}_check_sid(): Use const input argument
Change-Id: If779cce63f06a18d4f3b0cb3d6dd7a99aa52
Harald Welte has submitted this change and it was merged.
Change subject: Update L3 protocol discriminator definitions
..
Update L3 protocol discriminator definitions
Change-Id: Ia699d3494b93b7f88c36338e4960b35c42a29b9c
---
M i
Harald Welte has submitted this change and it was merged.
Change subject: don't re-implement osmo_talloc_replace_string()
..
don't re-implement osmo_talloc_replace_string()
osmo_talloc_replace_string() was introducd into libosm
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2014
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: osmo-sgsn: fix arrow tips in flow diagrams
..
osmo-sgsn: fix arrow tips in flow diagrams
The arrow style used to desribe the flowcharts in gsup.adoc does
Harald Welte has submitted this change and it was merged.
Change subject: osmo-nitb: Update VTY command reference
..
osmo-nitb: Update VTY command reference
Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca
---
M OsmoNITB/vt
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2655
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07f1e4246eb178838b7df21946a08a1f60f2084
Gerrit-PatchSet: 2
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: libgtp: improve error logging and propagation
..
libgtp: improve error logging and propagation
* propagate error code from gtp_new() to caller instead of
Harald Welte has submitted this change and it was merged.
Change subject: measurement: fix measurement computation
..
measurement: fix measurement computation
Timing advance is currently not taken into account when computing
th
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2800
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35b2865998bca3c2c0cb4b77e4e73d12e08bd7e
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2783
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Harald Welte has submitted this change and it was merged.
Change subject: Get TRX attributes
..
Get TRX attributes
Request per-TRX attributes in addition to BTS attributes.
Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46
Harald Welte has submitted this change and it was merged.
Change subject: Request and parse BTS feature list via OML
..
Request and parse BTS feature list via OML
Request features supported by BTS when getting attributes over O
Harald Welte has submitted this change and it was merged.
Change subject: Re-add version to phy_instance
..
Re-add version to phy_instance
This is resubmission of 9eeb0b1a136fc8c24a86cb4d832c264674c10db0 with
errorneous use of
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2844
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02ae6fffdc808c1ea14185dbb4a720d27a62d4bb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 5:
> > get_p_max_out_mdBm() should be used in this context, with no
> fall-back
>
> See updated revision, not sure if I'm doing it right - is there
> some limit on returned value?
the limit implied by physical reality. It's very rare that you would see a
value in excess of ~ 46
Patch Set 1: Code-Review-2
* OsmoBTS implements only a single BTS within a given OML link so a value !=
0x00 is invalid. If this happens, the transmitter of the message must be fixed.
* TS 52.021 clearly defines the meaning of 0xff in the bts number:
"If the BTS number is NULL, it shall be unde
Harald Welte has submitted this change and it was merged.
Change subject: Include codec.h file from codec C files
..
Include codec.h file from codec C files
failure to do so would prevent the compiler from catching
inconsistenc
Patch Set 1:
ok, than it means that BSC code is doing smth wrong as I got 1 (bts number in
openbsc config) value which triggers this error. I'll look into that, thank you
for clarification.
--
To view, visit https://gerrit.osmocom.org/2846
To unsubscribe, visit https://gerrit.osmocom.org/sett
Max has abandoned this change.
Change subject: Remove incorrect BTS number check
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2846
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: aba
Patch Set 7: Code-Review+2
Nice work, output looks much cleaner now.
--
To view, visit https://gerrit.osmocom.org/2853
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0846d457cab26f54c25e6906a8bb304724e2d8
Gerrit-PatchSet: 7
Gerrit-Pro
Review at https://gerrit.osmocom.org/2861
osmo-bts-litecell15: Fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for osmo-bts-litecell15 does not include
the frame number into the measurement indications it forwards
to higher layers. The frame number is required to properly
d
dexter has abandoned this change.
Change subject: measurement: Fix measurement reporting period tables
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2795
To unsubscribe, visit https://gerrit.osmocom.org/settings
G
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2813
to look at the new patch set (#3).
osmo-bts-trx: fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for osmo-trx does not include
the frame number into the measur
Review at https://gerrit.osmocom.org/2863
sysmobts: normalize frame number in measurement indication
The higher layers relay on a normalized version of frame number
in order to detect the end of a measurement period.
The frame number on which the measurement reports are sent may
depend on the
Review at https://gerrit.osmocom.org/2862
Revert "measurement: exclude idle channels from uplink measurement"
The offsets used in the lookup tables may be phy dependand. So we
will have to do the alignment in the layer 1 interface of the
phy dependand code before we report the frame number up t
Review at https://gerrit.osmocom.org/2864
cosmetic: remove unused variable
Tha variable ms_timing_offset in lchan_meas_check_compute is not
used anymore.
Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c
---
M src/common/measurement.c
1 file changed, 0 insertions(+), 1 deletion(-)
git p
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1464
to look at the new patch set (#7).
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1526
to look at the new patch set (#3).
Add function to generate random identifier
The function is a wrapper on top of getrandom() (if available via glibc) or
corresponding sys
Patch Set 3:
Note: the current version does not implement direct reading from /dev/urandom
as a fallback when getrandom() is missing. Instead insecure rand() used and
error is reported to caller. The reasons are twofold: 1) it's much simpler 2)
that matches the way RAND_bytes() is used through
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1526
to look at the new patch set (#4).
Add function to generate random identifier
The function is a wrapper on top of getrandom() (if available via glibc) or
corresponding sys
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2864
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/2813/3/src/osmo-bts-trx/l1_if.h
File src/osmo-bts-trx/l1_if.h:
Line 71: void l1if_fill_meas_res(struct osmo_phsap_prim *l1sap, uint8_t
chan_nr, struct gsm_lchan *lchan,
Why do you need chan_nr and *lchan in parameters at the same time? Wh
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2863
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90bd01479e41f04a6b0aefe3845d071e3148d0c6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2861/2/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:
Line 898: LOGPC(DL1C, ll, ", Meas: RSSI %-3.2f dBm, Qual %-3.
l1sap->u.info.u.meas_ind.fn = fn;2f dB, "
Looks like typo. If not than ple
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1526
to look at the new patch set (#5).
Add function to generate random identifier
The function is a wrapper on top of getrandom() (if available via glibc) or
corresponding sys
Neels Hofmeyr has submitted this change and it was merged.
Change subject: error log: clarify for using more resources than reserved
..
error log: clarify for using more resources than reserved
Figure out how many resources wer
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/2854/7/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 179: self.status = SuiteRun.UNKNOWN
> This is already set two lines below, no need for this line.
heh, thanks. I think it came from rebase confusion: I had
Neels Hofmeyr has submitted this change and it was merged.
Change subject: refactor: fix error handling; fix log.Origin; only one trial
..
refactor: fix error handling; fix log.Origin; only one trial
A bit of refactoring to fix
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2854
to look at the new patch set (#8).
junit result: also write for aborted runs
Even if aborted due to signal, write a JUnit report XML, and make sure to
indicate the run
Patch Set 1:
I'll update OS#2317 with related questions - please follow-up discussion there.
--
To view, visit https://gerrit.osmocom.org/2846
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d5078ed1239d553c7200ceb5b08b638df33a15
Gerri
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2861
to look at the new patch set (#3).
osmo-bts-litecell15: Fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for osmo-bts-litecell15 does not include
the frame numb
Review at https://gerrit.osmocom.org/2865
octphy: fix segfault
The priv pointer of the callback function app_info_compl_cb() is
set to null by the pointer. It should be set to pinst instead.
Besides of that there is a memory violation while accessing
the local variable ver_hdr using osmo_strlcp
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2865
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I558d78ef29e9a4d8f45f4142611f11289d3ed806
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2865
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I558d78ef29e9a4d8f45f4142611f11289d3ed806
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: octphy: fix segfault
..
octphy: fix segfault
The priv pointer of the callback function app_info_compl_cb() is
set to null by the pointer. It should be se
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2864
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2862
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8acab50cc1bb1cb133831c6a145f4d790e99176c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2863
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90bd01479e41f04a6b0aefe3845d071e3148d0c6
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove unused variable
..
cosmetic: remove unused variable
Tha variable ms_timing_offset in lchan_meas_check_compute is not
used anymore.
Chan
Harald Welte has submitted this change and it was merged.
Change subject: Revert "measurement: exclude idle channels from uplink
measurement"
..
Revert "measurement: exclude idle channels from uplink measurement"
The offsets u
Harald Welte has submitted this change and it was merged.
Change subject: sysmobts: normalize frame number in measurement indication
..
sysmobts: normalize frame number in measurement indication
The higher layers relay on a nor
Review at https://gerrit.osmocom.org/2866
OML: move BTS number check into separate function
* move code which checks for BTS number (obtained via OML) validity into
separate function
* adjust log messages to match the check
* add spec reference and comments
Change-Id: Id5714fbed910696d30e18d
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2786
to look at the new patch set (#6).
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
Change-
Patch Set 5:
I'll move stuff related to nominal power into separate patch and will implement
using new IE there.
--
To view, visit https://gerrit.osmocom.org/2786
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f72305bbf1ab74745bffac1b
Review at https://gerrit.osmocom.org/2867
osmo-bts-octphy: normalize frame number in MEAS IND
The higher layers will no longer care for the alignment of the frame number
in order to detect when a measurement period ends. This patch normalizes the
frame number directly in the measurement indicat
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2786
to look at the new patch set (#7).
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
Change-
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2786
to look at the new patch set (#8).
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
Change-
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2786
to look at the new patch set (#9).
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
Change-
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2799
to look at the new patch set (#7).
Set and report BTS features
Set (possibly incomplete) list of BTS model-specific features and report
them in response to attribute request via OML.
C
Review at https://gerrit.osmocom.org/2868
Fix BTS number in attribute requests
Use 0 to indicate given BTS and 0xFF to indicate all BTS' as it's
explained in 3GPP TS 52.021 ยง9.3.
Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Fixes: OS#2317
---
M openbsc/src/libbsc/bsc_init.c
1 file chan
Review at https://gerrit.osmocom.org/2869
build: Require and check for gcc C++11 support
It is now 2017. We can and should be able to use C++11 features now.
Change-Id: I96477e4125390b17b43a3705bb1daf98fa01c9bb
Signed-off-by: Tom Tsou
---
A config/ax_cxx_compile_stdcxx.m4
A config/ax_cxx_comp
Review at https://gerrit.osmocom.org/2870
IPv6 support
Change-Id: If8ce8b4b8cd2ba97f7ba122de4703983111046e4
---
M ggsn/ggsn.c
M ggsn/ippool.c
M ggsn/ippool.h
M ggsn/tun.c
M ggsn/tun.h
M gtp/gtp.c
M gtp/gtp.h
M gtp/pdp.c
M gtp/pdp.h
M gtp/queue.c
M gtp/queue.h
M sgsnemu/ippool.c
M sgsnemu/ippool
Review at https://gerrit.osmocom.org/2871
uhd: Use map container for for device parameter access
OsmoTRX is written in C++ so we might as well use built-in
container types when applicable. Map access allows removal
of significant amounts of special device handling code.
Aggregate device rates
Review at https://gerrit.osmocom.org/2872
uhd: Add non-UmTRX channel swap support
Previously an UmTRX-only feature.
Change-Id: I4a0e0c1d69e89993158e948535ad33f54e568d2d
Signed-off-by: Tom Tsou
---
M Transceiver52M/UHDDevice.cpp
1 file changed, 44 insertions(+), 21 deletions(-)
git pull ss
76 matches
Mail list logo
