Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2920
to look at the new patch set (#3).
sigProcLib: Remove heap based signal vector allocations
The osmo-trx internals rely heavily on dynamic alloction of
I/Q signal vectors.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2926
to look at the new patch set (#2).
uhd: Fix Tx-RX timing offset setting
Integer timestamp offset was set to zero due to bad cast-operator
precedence.
Change-Id: Ib1f524cc86416699b3c143
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2925
to look at the new patch set (#2).
uhd: Fix USRP2/N200/N210 device detection
Commit 1fb0ce67 "uhd: Use map container for for device parameter access"
inadvertently removed the string id
Review at https://gerrit.osmocom.org/2927
transceiver: Fix POWEROFF crash on USRP2/N200/X300 devices
Upon issuing POWEROFF command to a running transceiver, UHD
interfacing thread state may become undefined if the device
is stopped with I/O threads still active. Bad behavior is
device dependent
Review at https://gerrit.osmocom.org/2925
uhd: Fix USRP2/N200/N210 device detection
Commit 1fb0ce67 "uhd: Use map container for for device parameter access"
inadvertently removed the string identifier for the USRP2 and derived
devices (N200/N210).
Add the missing USRP2 string identifier. Also
Review at https://gerrit.osmocom.org/2926
uhd: Fix Tx-RX timing offset setting
Integer timestamp offset was set to zero due to bad cast-operator
precedence.
Change-Id: Ib1f524cc86416699b3c143e5faddb33d61380767
---
M Transceiver52M/UHDDevice.cpp
1 file changed, 1 insertion(+), 2 deletions(-)
Harald Welte has submitted this change and it was merged.
Change subject: bsc_init: Forget which SIs are valid for the trx
..
bsc_init: Forget which SIs are valid for the trx
Previously the SI generation lead to setting the BCC
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2819
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e288252a2e7709c4dae16b96a0b1512278847f
Gerrit-PatchSet: 7
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2824
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3aeb90804edab1b0325c3eb7347526ae995dbf51
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: RSL: receive and send multiple SI2q messages
..
RSL: receive and send multiple SI2q messages
* change BCCH Info handler to explicitly support multiple SI
Max has submitted this change and it was merged.
Change subject: Update SI data structures and generation
..
Update SI data structures and generation
To support segmented SI2quater as per 3GPP TS 44.018 we'll have to
support mu
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d5fcbdd77fe41d78cfe54731dd2ebfc4171f62c
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerr
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2840
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9172735bc7a05d9d7425a0e66dd90ff2569ee05
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix some typos
..
cosmetic: fix some typos
Change-Id: Ib9172735bc7a05d9d7425a0e66dd90ff2569ee05
---
M include/osmo-bts/scheduler.h
M include/os
Harald Welte has submitted this change and it was merged.
Change subject: scheduler_trx.c: strip unused variable
..
scheduler_trx.c: strip unused variable
Change-Id: I870dad2a00f68cca1c31a719221fc30a07b30c20
---
M src/osmo-bts-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2842
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I870dad2a00f68cca1c31a719221fc30a07b30c20
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: core/conv/conv.c: drop useless assignment
..
core/conv/conv.c: drop useless assignment
Change-Id: I8c3aa5ec100abacf93da1493aa134e42bf612206
---
M src/con
Harald Welte has submitted this change and it was merged.
Change subject: sim/core.c: drop useless double assignment
..
sim/core.c: drop useless double assignment
Change-Id: I3bfcabd80b57aeb7f110b306350802e6e82c847a
---
M src/s
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2876
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36012d4443d97470050cdf9638a9d4cf67ea3b40
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: core/conv/viterbi.c: fix possible NULL-pointer reference
..
core/conv/viterbi.c: fix possible NULL-pointer reference
Change-Id: I36012d4443d97470050cdf96
Harald Welte has submitted this change and it was merged.
Change subject: gsm/gsm48.c: drop useless assignment
..
gsm/gsm48.c: drop useless assignment
Change-Id: I96c1ba70e332199a4ca95e827a7562f953975af4
---
M src/gsm/gsm48.c
1
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2880
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia30b6481ee570c6cf3e3b38e7a78028c66c036b7
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: gb/gprs_bssgp.c: avoid valueless goto usage
..
gb/gprs_bssgp.c: avoid valueless goto usage
Change-Id: I0c2aaf1ab462c923d62232f1a63fae1e4eb18b4d
---
M src
Harald Welte has submitted this change and it was merged.
Change subject: vty/command.c: drop useless assignment
..
vty/command.c: drop useless assignment
Change-Id: Ia30b6481ee570c6cf3e3b38e7a78028c66c036b7
---
M src/vty/comma
Harald Welte has submitted this change and it was merged.
Change subject: ctrl_test.c: fix build with GCC 7.1.1
..
ctrl_test.c: fix build with GCC 7.1.1
According to GCC's online docs:
When an inline function is not static, th
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2832
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic516ec9f0b821557d9461ae9f1c0afdd786f3b05
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 6:
are there any "SYSTEM INFORMATION" messages that we can set on non-BCCH TRXs
anyway? The only SI sent on non-BCCH are those over the SACCH, and those are
set by RSL SACCH FILLING, right?
--
To view, visit https://gerrit.osmocom.org/2819
To unsubscribe, visit https://gerrit.osmoco
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2819
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e288252a2e7709c4dae16b96a0b1512278847f
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 11:
Nevermind - if it's not meant to be run directly than there's no point in
making it executable.
--
To view, visit https://gerrit.osmocom.org/2465
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f81023
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2832
to look at the new patch set (#5).
Update SI data structures and generation
To support segmented SI2quater as per 3GPP TS 44.018 we'll have to
support multiple SI messages
Max has submitted this change and it was merged.
Change subject: Cleanup SI scheduling
..
Cleanup SI scheduling
* use GSM_BTS_HAS_SI() from OpenBSC instead of local copy
* arrange GSM_BTS_HAS_SI() checks to improve readability
Review at https://gerrit.osmocom.org/2924
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an IP-Address, there is also point code, ssn and more. To
simplify and unify the handling of such objects, this patch
introduces
Review at https://gerrit.osmocom.org/2923
cosmetic: fix typo
Change-Id: I931ccf6f765d4fe916ea94bde704314561e4537c
---
M src/osmo_ss7_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/23/2923/1
diff --git a/src/osmo_ss7_vty
Review at https://gerrit.osmocom.org/2922
vty: additional nodes for sccp-address configuration
The planned sccp-addressbook implementation in libosmo-sccp
requires to additional VTY nodes.
Change-Id: I42aa29c097f284b85801c5329b015b189640
---
M TODO-RELEASE
M include/osmocom/vty/command.h
2
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2819
to look at the new patch set (#6).
bsc_init: Forget which SIs are valid for the trx
Previously the SI generation lead to setting the BCCH SIs for all TRX in
a multi-trx se
Max has submitted this change and it was merged.
Change subject: Set and report BTS features
..
Set and report BTS features
Set (possibly incomplete) list of BTS model-specific features and report
them in response to attribute
Max has submitted this change and it was merged.
Change subject: Extend Get Attribute responder
..
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2799
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8a6681c3562ec261441e84dde6e085b516d92f
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2819
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e288252a2e7709c4dae16b96a0b1512278847f
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2786
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f72305bbf1ab74745bffac1bee9f539f5a6de32
Gerrit-PatchSet: 9
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2824
to look at the new patch set (#2).
RSL: receive and send multiple SI2q messages
* change BCCH Info handler to explicitly support multiple SI2quater
messages sent from BS
Max has submitted this change and it was merged.
Change subject: Move SI-related defines
..
Move SI-related defines
* move SI2quater related defines to shared header
* add define from OsmoBTS which checks for presence of a give
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2819
to look at the new patch set (#4).
bsc_init: Forget which SIs are valid for the trx
Previously the SI generation lead to setting the BCCH SIs for all TRX in
a multi-trx setup. This is b
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/2824/1/src/common/rsl.c
File src/common/rsl.c:
Line 318: memset(GSM_BTS_SI2Q(bts, bts->si2q_index),
0x2b, sizeof(sysinfo_buf_t));
we can use GSM_MACBLOCK_PADDING from libosmogsm gsm_04_08.h for that
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2822
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If74bc536fe7d2bfbc976c07d882151873ecda4f2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2832
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic516ec9f0b821557d9461ae9f1c0afdd786f3b05
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2821
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11432c93c772d1ead6d45a7bb0f1d13d492c82f1
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/2819/3/openbsc/src/libbsc/bsc_init.c
File openbsc/src/libbsc/bsc_init.c:
Line 118: rc = rsl_bcch_info(bts, trx, i, GSM_BTS_SI(bts, i),
si_len);
we resolve 'bts' from trx->bts above, there's no point in passing both into the
Patch Set 11:
Would be also nice to make script executable by default.
--
To view, visit https://gerrit.osmocom.org/2465
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484
Gerrit-PatchSet: 11
Gerrit-
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/2884/3/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl:
Line 24: smpp
indentation is not correct.
Line 26: system-id test-nitb
this should be test-msc
--
To view, visit https://
Patch Set 4:
> osmo-gsm-tester scripts don't use osmo-ci
So why you've comment in another patch that "each is still callable on its own"
in the context of osmo-gsm-tester and jenkins_* helpers in osmo-bts? Those are
using osmo-ci.
--
To view, visit https://gerrit.osmocom.org/2893
To unsubscr
Hello Neels Hofmeyr,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2893
to look at the new patch set (#5).
Add script for fetching BTS-specific L1 headers
Several of the supported BTS models require hw-specific L1 headers for
compilation which are stored in s
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2901
to look at the new patch set (#2).
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move macro from libosmoc
Patch Set 1:
(1 comment)
I am not all convinced that we will end up using a process over all tests runs
in it, but it may happen. I think we agree though that for now we want to run
processes in per-test scope, which is good. If later we want to add per-suite
scope processes then we may need
Patch Set 1:
> Does this also have implications on the debian files, i.e. missing changes?
No, I check that .deb builds fine before submitting this patch.
--
To view, visit https://gerrit.osmocom.org/2916
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Ge
Patch Set 7:
> shellcheck?
Tool for static analysis of shell scripts. This comment is directive
instructing it where to look for sourced file.
--
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change
Patch Set 7:
> this file seems to belong in the other patch
jenkins_lc15.sh uses it so it belongs to this commit - you've asked to first
merge jenkins_lc15.sh and than other changes so I changed the order of commits.
Please make up your mind which commit should go first.
--
To view, visit ht
Patch Set 3:
Oops, I probably copied it from the wrong tab in my web browser, good catch!
--
To view, visit https://gerrit.osmocom.org/2747
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c70b3b8436e2647fc35d579a302dfbf32a83f0
Gerrit-P
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/2914/1//COMMIT_MSG
Commit Message:
Line 10: this test starts using it so it fixes it too.
> "this test"? commit log: good to stick to imperative form:
Heh I meant "this patch" but I was thinking about the tests added in previous
patch. I
Patch Set 11:
(2 comments)
Thanks for your review! I actually expected more comments as you stated "some
comments" in an earlier PS. :)
I will apply all comments, but for two of them I need further
information/clarification. Please see my comments, just want to be sure to get
your points rig
Patch Set 3:
(25 comments)
Thanks for the review!
https://gerrit.osmocom.org/#/c/2884/3/src/osmo_gsm_tester/esme.py
File src/osmo_gsm_tester/esme.py:
Line 37: self.system_id = 'esme-id'
> each new Esme class gets an identical system_id, which gets put in a config
Yes, but the ID can be
Patch Set 3:
(1 comment)
> (1 comment)
>
> When I read this, I still have a question. So we install to
> separate dirs, then stow creates symlinks to combine the installed
> files in one dir again? But then we need to pass only one
> LD_LIBRARY_PATH and one PKG_CONFIG_PATH with the symlink
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2916/1/Makefile.am
File Makefile.am:
Line 8: contrib/dump_docs.py contrib/screenrc-l1fwd
contrib/osmo-bts-sysmo.service \
> we're removing sysmobts.service from EXTRA_DIST but keeping the file in the
This is the point of this pat
63 matches
Mail list logo
