Build failure of network:osmocom:nightly/libsmpp34 in xUbuntu_17.04/i586

2018-02-28 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/xUbuntu_17.04/i586 Package network:osmocom:nightly/libsmpp34 failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build

[PATCH] libosmocore[master]: timer: Introduce osmo_clock_gettime to override clock_gettime

2018-02-28 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6961 to look at the new patch set (#2). timer: Introduce osmo_clock_gettime to override clock_gettime Change-Id: I5bebc6e01fc9d238065bc2517058f0ba85620349 --- M

[PATCH] libosmocore[master]: timer: Document osmo_gettimeofday API

2018-02-28 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7015 timer: Document osmo_gettimeofday API Change-Id: I1f9e13645033c61ffaed97e457deb5e78a6bec58 --- M src/timer_gettimeofday.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/7015/1

osmo-sgsn[master]: implement support for 3-digit MNC with leading zeros

2018-02-28 Thread Harald Welte
Patch Set 2: Code-Review-1 just to make sure we have tested this somehow, particularly the gbproxy changes (see my last comment) -- To view, visit https://gerrit.osmocom.org/6672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libosmocore[master]: gsm0408_test: test new gsm48_{decode, generate}_lai2() functions

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0408_test: test new gsm48_{decode,generate}_lai2() functions .. gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id:

[MERGED] libosmocore[master]: gsm0408_test: check for new mnc_3_digits flag

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0408_test: check for new mnc_3_digits flag .. gsm0408_test: check for new mnc_3_digits flag Note that on the input side, the 3-digits flag may be

[MERGED] libosmocore[master]: gsm0408_test: add test cases for MNC with leading zeros

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0408_test: add test cases for MNC with leading zeros .. gsm0408_test: add test cases for MNC with leading zeros Change-Id:

[MERGED] libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: implement support for 3-digit MNC with leading zeros .. implement support for 3-digit MNC with leading zeros Enable representing three-digit MNC with

[MERGED] libosmocore[master]: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp(...

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC .. gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for

[MERGED] osmo-msc[master]: cosmetic: gsm_network_init(): imply default 001-01 PLMN

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: gsm_network_init(): imply default 001-01 PLMN .. cosmetic: gsm_network_init(): imply default 001-01 PLMN All callers pass mcc=1, mnc=1, so

[ABANDON] osmocom-bb[fixeria/trx]: remove gsm48_encode_classmark1() which is now in libosmocore

2018-02-28 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: remove gsm48_encode_classmark1() which is now in libosmocore .. Abandoned libosmocore has this reverted now -- To view, visit https://gerrit.osmocom.org/6679 To

osmo-ttcn3-hacks[master]: bts: Update towards most recent "laforge/trx" branch

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7013 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d0122202e5d23308421e76b75e608d206aab56e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: bts: Update towards most recent "laforge/trx" branch

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Update towards most recent "laforge/trx" branch .. bts: Update towards most recent "laforge/trx" branch The existing BTS testing code was based on

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Increase TOA256 value ranges

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7014 fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this context. However, our test cases want to test the BTS behavior is correct if ever a larger timing offset is reported from TRX to the BTS, to

[PATCH] osmo-ttcn3-hacks[master]: bts: Update towards most recent "laforge/trx" branch

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7013 bts: Update towards most recent "laforge/trx" branch The existing BTS testing code was based on a ~1 week old version of trxcon+fake_trx from osmocom-bb.git fixeria/trx branch, which has meanwhile evolved: * port number change for TRX protocol *

[MERGED] osmo-bts[master]: pcu_sock: LOG + drop PCU DATA.req for inactive lchan

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: LOG + drop PCU DATA.req for inactive lchan .. pcu_sock: LOG + drop PCU DATA.req for inactive lchan Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Always send control responses to where commands ar...

2018-02-28 Thread Harald Welte
fake_trx: Always send control responses to where commands are from fake_trx is using locally bound and not connected UDP sockets for control commands. When we receive a control command, we should not simply send the response to the default destination, but send it back to the exact ip+prt from

[MERGED] osmo-bts[master]: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot .. pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Send positive response to FAKE_TOA commands

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7012 fake_trx: Send positive response to FAKE_TOA commands Now that ctrl_if.py is capable of sending back the response to where the command originated from, we can just as well send a positive response back after executing the related commands. Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: trxcon: Define event names for osmo_fsm's

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7009 trxcon: Define event names for osmo_fsm's Change-Id: Id3279e99966a0ab236923c497ac0abbc9ed2c93c --- M src/host/trxcon/l1ctl_link.c M src/host/trxcon/trx_if.c M src/host/trxcon/trxcon.c 3 files changed, 19 insertions(+), 0 deletions(-) git pull

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Always send control responses to where commands ar...

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7011 fake_trx: Always send control responses to where commands are from fake_trx is using locally bound and not connected UDP sockets for control commands. When we receive a control command, we should not simply send the response to the default

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: Log IP/Port information at start-up

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7010 fake_trx: Log IP/Port information at start-up Change-Id: I4ebeed7271d91ab2e45199e0fb59776c00ad833c --- M src/target/fake_trx/ctrl_if_bb.py M src/target/fake_trx/ctrl_if_bts.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-gsm-tester[master]: ms: Add a first test to use all parts of the system

2018-02-28 Thread Holger Freyther
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6918 to look at the new patch set (#5). ms: Add a first test to use all parts of the system This is an interim solution but is bringing all parts together. We will need to:

[PATCH] osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-02-28 Thread Holger Freyther
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6232 to look at the new patch set (#6). ms: Lua part of location update testing The lua part to start the MS and then signal the first successful Location Update. Change-Id:

[PATCH] osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-02-28 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6917 to look at the new patch set (#5). ms: Create a starter for virtphy and mobile application In the long run we might not want to start the virtphy but

[PATCH] osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

2018-02-28 Thread Holger Freyther
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6916 to look at the new patch set (#5). ms: Create template for the osmocom-bb mobile application Change-Id: I9296f42edfab57762f8dd317d63231298cda5430 --- A

[PATCH] osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-02-28 Thread Holger Freyther
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6913 to look at the new patch set (#4). ms: Create a simple epoll (or kqueue) based event loop Create a C-like single process event loop. It could be powered by

[PATCH] osmo-bts[master]: pcu_sock: LOG + drop PCU DATA.req for inactive lchan

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7008 pcu_sock: LOG + drop PCU DATA.req for inactive lchan Change-Id: I11c622967885d594ef7e1c24b9bafd0fb8fd400c --- M src/common/pcu_sock.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

osmo-bts[master]: pcu_sock: LOG + drop PCU DATA.req for inactive lchan

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7008 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11c622967885d594ef7e1c24b9bafd0fb8fd400c Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7007 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ae496eca96bc0823dfeca16ce36c200ce000895 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7007 pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot Change-Id: I3ae496eca96bc0823dfeca16ce36c200ce000895 --- M src/common/pcu_sock.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

[MERGED] osmo-ttcn3-hacks[master]: bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS ...

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS function) .. bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS function)

[MERGED] osmo-ttcn3-hacks[master]: bts: Add PCU Interface testcases

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add PCU Interface testcases .. bts: Add PCU Interface testcases Change-Id: I671b8e2c61705485f46602f648eb5fdc01db12f7 --- M bts/BTS_Tests.default M

osmo-ttcn3-hacks[master]: bts: Add PCU Interface testcases

2018-02-28 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7005 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I671b8e2c61705485f46602f648eb5fdc01db12f7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: Log an error message and discard PCU primitives for BTS != 0 .. pcu_sock: Log an error message and discard PCU primitives for BTS != 0 In

osmo-ttcn3-hacks[master]: bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS ...

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I619264654bfeafe4b76c8702ede5876a82c32f13 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: bts: Add PCU Interface testcases

2018-02-28 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7005 to look at the new patch set (#3). bts: Add PCU Interface testcases Change-Id: I671b8e2c61705485f46602f648eb5fdc01db12f7 --- M bts/BTS_Tests.default M bts/BTS_Tests.ttcn M

osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I158f935fed12941737c806c0677a8192ea3418a0 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS ...

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7006 bts: Fix bugs in RACH Tests (timer not started, wrong CS/PS function) Change-Id: I619264654bfeafe4b76c8702ede5876a82c32f13 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull

[PATCH] osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Harald Welte
Hello Stefan Sperling, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6997 to look at the new patch set (#3). pcu_sock: Log an error message and discard PCU primitives for BTS != 0 In OsmoBTS, we (so far?) only have a single BTS inside each

osmo-ttcn3-hacks[master]: bts: Add PCU Interface testcases

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7005 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I671b8e2c61705485f46602f648eb5fdc01db12f7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: bts: Add PCU Interface testcases

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/7005 bts: Add PCU Interface testcases Change-Id: I671b8e2c61705485f46602f648eb5fdc01db12f7 --- M bts/BTS_Tests.default M bts/BTS_Tests.ttcn M bts/gen_links.sh A library/PCUIF_CodecPort.ttcn A library/PCUIF_Types.ttcn 5 files changed, 815 insertions(+), 0

libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-28 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6659 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221 Gerrit-PatchSet: 7 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-msc[master]: cosmetic: gsm_network_init(): imply default 001-01 PLMN

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd1cc38f170895305ae176a5574384c74a33939 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: FIX: apply TA value correctly

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/burst_fwd.py: FIX: apply TA value correctly .. fake_trx/burst_fwd.py: FIX: apply TA value correctly If field randomization is disabled, Timing

[MERGED] osmo-bts[master]: pcu_sock: Don't overflow the timeslot array

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: Don't overflow the timeslot array .. pcu_sock: Don't overflow the timeslot array Don't blindly trust that the ts_nr received on the PCU socket

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: FIX: apply TA value correctly

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7004 fake_trx/burst_fwd.py: FIX: apply TA value correctly If field randomization is disabled, Timing Advance value indicated by MS would be ignored. Let's fix this by separating the TA calculation code. Change-Id: If43d5823fc33efc2f1649ea941ab6f619bb6f5e7

libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-28 Thread Neels Hofmeyr
Patch Set 11: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/6509/11/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: Line 74: /* deprecated */ OSMO_DEPRECATED()? https://gerrit.osmocom.org/#/c/6509/11/tests/gsm0808/gsm0808_test.c File

libosmocore[master]: gsm0408_test: test new gsm48_{decode, generate}_lai2() functions

2018-02-28 Thread Neels Hofmeyr
Patch Set 7: Code-Review+2 only trivial function renames from prev patch set -- To view, visit https://gerrit.osmocom.org/6661 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b Gerrit-PatchSet: 7

[PATCH] osmo-msc[master]: cosmetic: gsm_network_init(): imply default 001-01 PLMN

2018-02-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7003 cosmetic: gsm_network_init(): imply default 001-01 PLMN All callers pass mcc=1, mnc=1, so just have it as default. (Prepare for net->country_code etc to be replaced by net->plmn) Change-Id: Ibcd1cc38f170895305ae176a5574384c74a33939 --- M

[PATCH] osmo-msc[master]: implement support for 3-digit MNC with leading zeros

2018-02-28 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6671 to look at the new patch set (#3). implement support for 3-digit MNC with leading zeros Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout the

[PATCH] libosmocore[master]: gsm0408_test: add test cases for MNC with leading zeros

2018-02-28 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6662 to look at the new patch set (#7). gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c --- M

[PATCH] libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-28 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6659 to look at the new patch set (#7). implement support for 3-digit MNC with leading zeros Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are

[PATCH] libosmocore[master]: gsm0408_test: test new gsm48_{decode, generate}_lai2() functions

2018-02-28 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6661 to look at the new patch set (#7). gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b --- M

[MERGED] osmo-bts[master]: pcu_sock: Discard messages that are too short

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: Discard messages that are too short .. pcu_sock: Discard messages that are too short The downstream code of pcu_sock.c doesn't contain any

osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Stefan Sperling
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6997/2/src/common/pcu_sock.c File src/common/pcu_sock.c: Line 625: LOGP(DPCU, LOGL_ERROR, "Received PCU Prim for non-existant BTS %u\n", pcu_prim->bts_nr); spelling: 'non-existent' -- To view, visit

osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Stefan Sperling
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I158f935fed12941737c806c0677a8192ea3418a0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: pcu_sock: Don't overflow the timeslot array

2018-02-28 Thread Stefan Sperling
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6996 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9964c8dc0ca7b049da7dfec0ac0a0d3f1aedd45 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: pcu_sock: Discard messages that are too short

2018-02-28 Thread Stefan Sperling
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6995 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ac84d4db6d21ea61afbd1864c810bbf601d69b Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmocom-bb[fixeria/trx]: fake_trx: handle SETTA (Timing Advance) indicated by MS

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6999 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5833a9f221587bbcac10f0b223ead9c1cbda72b Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmo-bts[master]: pcu_sock: Don't overflow the timeslot array

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6996 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9964c8dc0ca7b049da7dfec0ac0a0d3f1aedd45 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I158f935fed12941737c806c0677a8192ea3418a0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: drop useless set_slot() method

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/burst_fwd.py: drop useless set_slot() method .. fake_trx/burst_fwd.py: drop useless set_slot() method Change-Id:

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: calculate both RSSI and ToA separately

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/burst_fwd.py: calculate both RSSI and ToA separately .. fake_trx/burst_fwd.py: calculate both RSSI and ToA separately In order to be able to

osmo-bts[master]: pcu_sock: Discard messages that are too short

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6995 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35ac84d4db6d21ea61afbd1864c810bbf601d69b Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmocom-bb[fixeria/trx]: fake_trx: handle SETTA (Timing Advance) indicated by MS

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx: handle SETTA (Timing Advance) indicated by MS .. fake_trx: handle SETTA (Timing Advance) indicated by MS Timing Advance value is a timing

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: use integer math for ToA

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/data_msg.py: use integer math for ToA .. fake_trx/data_msg.py: use integer math for ToA In order to avoid both float arithmetic as well as

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: implement ToA parsing support

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/data_msg.py: implement ToA parsing support .. fake_trx/data_msg.py: implement ToA parsing support This change implements ToA (Timing of

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: disable field randomization by default

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/burst_fwd.py: disable field randomization by default .. fake_trx/burst_fwd.py: disable field randomization by default Both RSSI and ToA fields

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/fake_trx.py: add options to enable field randomization

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/fake_trx.py: add options to enable field randomization .. fake_trx/fake_trx.py: add options to enable field randomization By default, both RSSI

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command

2018-02-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command .. fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command FAKE_TOA is an auxilary CTRL command, which may

osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command

2018-02-28 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6846 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia23becec4104d47e7b22350db67b8834d6f1ad1b Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: disable field randomization by default

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7001 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94835a840b6239f2c05197292825cb26977d0216 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/fake_trx.py: add options to enable field randomization

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7002 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieac63cc3aadef397906479a6179ba54a53a5311a Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: calculate both RSSI and ToA separately

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7000 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2031f22f2b549c799c782d0c8c8d0691fb6f18c Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: implement ToA parsing support

2018-02-28 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6991 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib11482c06b977c4cf01b0644f5845a2e49d059fb Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: use integer math for ToA

2018-02-28 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6990 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b88740f4d782ac7591fc096d1969514784a4e1 Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: drop useless set_slot() method

2018-02-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6998 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721c87758f04a1962427341eb1b2d47cfdd3f780 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: disable field randomization by default

2018-02-28 Thread Vadim Yanitskiy
Patch Set 1: Code-Review-1 Introduced a bug here, fix is WIP... -- To view, visit https://gerrit.osmocom.org/7001 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94835a840b6239f2c05197292825cb26977d0216 Gerrit-PatchSet: 1

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: drop useless set_slot() method

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/6998 fake_trx/burst_fwd.py: drop useless set_slot() method Change-Id: I721c87758f04a1962427341eb1b2d47cfdd3f780 --- M src/target/fake_trx/burst_fwd.py 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb

[PATCH] osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-02-28 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6387 to look at the new patch set (#3). Generate the S_L_INP_TEI_UP signal earlier. The S_L_INP_TEI_UP signal was generated when the first message from a BTS arrives on the

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: disable field randomization by default

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7001 fake_trx/burst_fwd.py: disable field randomization by default Both RSSI and ToA fields randomization is only required in some specific test / use cases, so let's disable it by default. Change-Id: I94835a840b6239f2c05197292825cb26977d0216 --- M

[PATCH] osmocom-bb[fixeria/trx]: fake_trx: handle SETTA (Timing Advance) indicated by MS

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/6999 fake_trx: handle SETTA (Timing Advance) indicated by MS Timing Advance value is a timing correction value, indicated by the network to MS, which is used to compensate UL signal delay. In other words, the network instructs a phone to transmit bursts

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/burst_fwd.py: calculate both RSSI and ToA separately

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7000 fake_trx/burst_fwd.py: calculate both RSSI and ToA separately In order to be able to simulate and randomize both RSSI and ToA values for Uplink and Downlink separately, let's calculate them in separate methods of the BurstForwarder. Change-Id:

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/fake_trx.py: add options to enable field randomization

2018-02-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7002 fake_trx/fake_trx.py: add options to enable field randomization By default, both RSSI and ToA fields randomization is disabled. Let's add command line options, which allow one to enable it. Change-Id: Ieac63cc3aadef397906479a6179ba54a53a5311a --- M

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: implement ToA parsing support

2018-02-28 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6991 to look at the new patch set (#2). fake_trx/data_msg.py: implement ToA parsing support This change implements ToA (Timing of Arrival) parsing, which was missing in the

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: use integer math for ToA

2018-02-28 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6990 to look at the new patch set (#2). fake_trx/data_msg.py: use integer math for ToA In order to avoid both float arithmetic as well as loosing any precision, let's use

[PATCH] osmocom-bb[fixeria/trx]: fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command

2018-02-28 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6846 to look at the new patch set (#4). fake_trx/ctrl_if_(bb|bts).py: add FAKE_TOA command FAKE_TOA is an auxilary CTRL command, which may be used to update the ToA (Timing of

osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-02-28 Thread Stefan Sperling
Patch Set 1: > > pleaes test with real BTS setup, update commitlog and then we can > > merge it. > > Yes, as noted in https://osmocom.org/issues/2719#note-7 I plan to > get to doing this soon. I have tested the patch with a sysmobts now and it looks good to me. Please see the pcap files I

[PATCH] osmo-bts[master]: pcu_sock: Discard messages that are too short

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/6995 pcu_sock: Discard messages that are too short The downstream code of pcu_sock.c doesn't contain any length checks, so let's discard any messages that are shorter than the primitive length. Change-Id: I35ac84d4db6d21ea61afbd1864c810bbf601d69b --- M

[PATCH] osmo-bts[master]: pcu_sock: Don't overflow the timeslot array

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/6996 pcu_sock: Don't overflow the timeslot array Don't blindly trust that the ts_nr received on the PCU socket will be small enough to not overflow our timeslot array! Change-Id: Ie9964c8dc0ca7b049da7dfec0ac0a0d3f1aedd45 --- M src/common/pcu_sock.c 1 file

[PATCH] osmo-bts[master]: pcu_sock: Log an error message and discard PCU primitives fo...

2018-02-28 Thread Harald Welte
Review at https://gerrit.osmocom.org/6997 pcu_sock: Log an error message and discard PCU primitives for BTS != 0 In OsmoBTS, we (so far?) only have a single BTS inside each process, let's make sure we log an error message if the PCU should ever want to transmit primitives to a non-zero BTS

[PATCH] libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-28 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#11). support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell

[PATCH] libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-28 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#10). support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell

libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-28 Thread Stefan Sperling
Patch Set 9: (11 comments) https://gerrit.osmocom.org/#/c/6509/9/include/osmocom/gsm/gsm0808_utils.h File include/osmocom/gsm/gsm0808_utils.h: Line 32: #define GSM0808_CELL_ID_LIST2_MAXLEN 128 > from (255-1)/2 the theoretical max is 127, would be nice to explain that in Yes, comment

[PATCH] osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-28 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6594 to look at the new patch set (#6). bsc_vty: Merge more VTY documentation string #defines Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f --- M src/libbsc/bsc_vty.c 1

[PATCH] osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-28 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6594 to look at the new patch set (#5). bsc_vty: Merge more VTY documentation string #defines Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f --- M src/libbsc/bsc_vty.c 1

[PATCH] osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-28 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6594 to look at the new patch set (#4). bsc_vty: Merge more VTY documentation string #defines Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f --- M src/libbsc/bsc_vty.c 1

[PATCH] osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-28 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6594 to look at the new patch set (#3). bsc_vty: Merge more VTY documentation string #defines Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f --- M src/libbsc/bsc_vty.c 1

[MERGED] osmocom-bb[fixeria/trx]: fake_trx/data_msg.py: use a single unified constructor

2018-02-28 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: fake_trx/data_msg.py: use a single unified constructor .. fake_trx/data_msg.py: use a single unified constructor There are no message specific

  1   2   >