Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-15 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11786 to look at the new patch set (#2). Change subject: add contrib/struct_endianess.py .. add

Change in libosmocore[master]: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie

2018-11-15 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11788 Change subject: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie .. gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie These are

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-11-15 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11787 to look at the new patch set (#2). Change subject: add/clean big-endian packed structs (struct_endianess.py) ..

Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11786 ) Change subject: add contrib/struct_endianess.py .. Patch Set 1: see also

Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-15 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11786 Change subject: add contrib/struct_endianess.py .. add contrib/struct_endianess.py In libosmocore (and likely elsewhere) we have scores of

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-11-15 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11787 Change subject: add/clean big-endian packed structs (struct_endianess.py) .. add/clean big-endian packed structs (struct_endianess.py)

Change in osmo-bsc[master]: don't remove socket path in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11782 to look at the new patch set (#4). Change subject: don't remove socket path in rf_create_socket()

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 ) Change subject: unlink socket path correctly in rf_create_socket() .. Patch Set 3: > Patch Set 2: > > > Patch Set 2: > > > > Can anyone

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11782 to look at the new patch set (#3). Change subject: unlink socket path correctly in rf_create_socket()

Change in libosmocore[master]: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11785 ) Change subject: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f .. Patch Set 1: (1 comment)

Change in libosmocore[master]: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11785 Change subject: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f .. gsm48: gsm48_decode_freq_list: Improve

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 ) Change subject: unlink socket path correctly in rf_create_socket() .. Patch Set 2: > Patch Set 2: > > Can anyone tell what is up with

Change in osmo-bts[master]: properly initialize si3 in test_is_ccch_for_agch_setup()

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11784 ) Change subject: properly initialize si3 in test_is_ccch_for_agch_setup() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: properly initialize si3 in test_is_ccch_for_agch_setup()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11784 Change subject: properly initialize si3 in test_is_ccch_for_agch_setup() .. properly initialize si3 in test_is_ccch_for_agch_setup()

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11782 ) Change subject: unlink socket path correctly in rf_create_socket() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 ) Change subject: unlink socket path correctly in rf_create_socket() .. Patch Set 2: (1 comment) > Patch Set 1: Code-Review-1 > > (1

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11782 to look at the new patch set (#2). Change subject: unlink socket path correctly in rf_create_socket()

Change in osmo-bts[master]: add missing check of osmo_wqueue_enqueue() return value

2018-11-15 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11783 Change subject: add missing check of osmo_wqueue_enqueue() return value .. add missing check of osmo_wqueue_enqueue() return value The

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11782 ) Change subject: unlink socket path correctly in rf_create_socket() .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bsc[master]: unlink socket path correctly in rf_create_socket()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11782 Change subject: unlink socket path correctly in rf_create_socket() .. unlink socket path correctly in rf_create_socket() In commit

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. use enums consistently instead of falling back to int

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #308

2018-11-15 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11781 ) Change subject: add missing 'break' in switch statement .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11781 to look at the new patch set (#2). Change subject: add missing 'break' in switch statement .. add

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#4). Change subject: use enums consistently instead of falling back to int

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 3: (1 comment)

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11781 ) Change subject: add missing 'break' in switch statement .. Patch Set 1: > Patch Set 1: > > Did you look at git log for hints? Yes I

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11781 ) Change subject: add missing 'break' in switch statement .. Patch Set 1: Did you look at git log for hints? -- To view, visit

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11781 ) Change subject: add missing 'break' in switch statement .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-15 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11781 Change subject: add missing 'break' in switch statement .. add missing 'break' in switch statement Coverity points out that

Change in libosmocore[master]: gsm29118: add value strings for SGSAP IEI

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11780 ) Change subject: gsm29118: add value strings for SGSAP IEI .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 3: (1 comment)

Change in libosmocore[master]: gsm29118: add value strings for SGSAP IEI

2018-11-15 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11780 Change subject: gsm29118: add value strings for SGSAP IEI .. gsm29118: add value strings for SGSAP IEI The value strings for the SGSAP IEI are

Change in libosmocore[master]: gsm/protocol/gsm_08_58.h: Fix typo

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11779 ) Change subject: gsm/protocol/gsm_08_58.h: Fix typo .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11779 To

Change in libosmocore[master]: gsm/protocol/gsm_08_58.h: Fix typo

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11779 ) Change subject: gsm/protocol/gsm_08_58.h: Fix typo .. gsm/protocol/gsm_08_58.h: Fix typo Fix a typo that prevents building on

Change in libosmocore[master]: gsm/protocol/gsm_08_58.h: Fix typo

2018-11-15 Thread roox
roox has uploaded this change for review. ( https://gerrit.osmocom.org/11779 Change subject: gsm/protocol/gsm_08_58.h: Fix typo .. gsm/protocol/gsm_08_58.h: Fix typo Fix a typo that prevents building on ppc64 (Power8, Big

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#3). Change subject: use enums consistently instead of falling back to int

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: (1 comment)

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-15 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. fix bogus error check in gprs_sndcp_comp_create() The

Change in osmo-ttcn3-hacks[master]: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get

2018-11-15 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11763 ) Change subject: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get .. attempt to fix a race condition in BSC test's

Change in osmo-bsc[master]: show dynamic timeslot details in 'show timeslot' vty command

2018-11-15 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11762 ) Change subject: show dynamic timeslot details in 'show timeslot' vty command .. show dynamic timeslot details in 'show timeslot'

Change in osmo-bsc[master]: bsc: vty: Use enum value in neighbor-list check

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11778 Change subject: bsc: vty: Use enum value in neighbor-list check .. bsc: vty: Use enum value in neighbor-list check Change-Id: