Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12236 Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI .. vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI There is no state

Change in libosmocore[master]: fix api doc for osmo_bcd2str()

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12235 ) Change subject: fix api doc for osmo_bcd2str() .. fix api doc for osmo_bcd2str() Change-Id: I504ea849fc9daeb34a1b3c5343371161deba74

Change in osmo-bsc[master]: set gscon FSM instances' log level to DEBUG

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12211 ) Change subject: set gscon FSM instances' log level to DEBUG .. set gscon FSM instances' log level to DEBUG Currently, we see all su

Change in libosmocore[master]: fix api doc for osmo_bcd2str()

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12235 ) Change subject: fix api doc for osmo_bcd2str() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12235 To unsubsc

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. move ASS-COMPL MGCP handling out of a_iface_bssap.c BSSMAP A

Change in osmo-msc[master]: drop gsm48 RR ciph mode compl from permitted initial messages

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12207 ) Change subject: drop gsm48 RR ciph mode compl from permitted initial messages .. drop gsm48 RR ciph mode compl from permitted initia

Change in libosmocore[master]: fix api doc for osmo_bcd2str()

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12235 Change subject: fix api doc for osmo_bcd2str() .. fix api doc for osmo_bcd2str() Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e --- M

Change in osmo-msc[master]: LU: do not always invoke sub_pres_vlr_fsm_start()

2018-12-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12233 to look at the new patch set (#2). Change subject: LU: do not always invoke sub_pres_vlr_fsm_start() .. LU: do not al

Change in osmo-msc[master]: LU: do not always invoke sub_pres_vlr_fsm_start()

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12233 Change subject: LU: do not always invoke sub_pres_vlr_fsm_start() .. LU: do not always invoke sub_pres_vlr_fsm_start() sub_pres_vlr_fsm_star

Change in osmo-msc[master]: tweak comment to indicate sub_pres_vlr fsm as dead code

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12234 Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code .. tweak comment to indicate sub_pres_vlr fsm as dead code sub_pres_

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review+2 by Neels Hofmeyr -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review+1 by Max -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail filters,

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review+2 by Neels Hofmeyr -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review+2 by Neels Hofmeyr -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Verified+1 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed -Code-Review by osmith -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail filters

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12218 ) Change subject: What about -1 vote counting? .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12218 To unsubscri

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed -Code-Review by osmith -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail filters

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review-1 by osmith -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing mail filter

Change in sandbox[master]: What about -1 vote counting?

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has removed a vote on this change. Change subject: What about -1 vote counting? .. Removed Code-Review+2 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/12218 To unsubscribe, or for help writing m

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 10: Code-Review-1 (25 comments) many comments aren't critical,

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 4: Code-Review+2 (5 comments) I still see some of my p

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11751 T

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12227

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File t

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: Code-Review+1 Can you provide some patches to get rid of the

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12221/1/tests/sgs

Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

2018-12-10 Thread Pau Espin Pedrol
Hello Stefan Sperling, Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12133 to look at the new patch set (#3). Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI ...

Change in osmo-bsc[master]: set gscon FSM instances' log level to DEBUG

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12211 ) Change subject: set gscon FSM instances' log level to DEBUG .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in docker-playground[master]: cosmetic: gerrit: use variables for the files to patch

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12205 ) Change subject: cosmetic: gerrit: use variables for the files to patch .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in libosmo-netif[master]: logging: fix typo in stream.c

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12217 ) Change subject: logging: fix typo in stream.c .. logging: fix typo in stream.c Change-Id: I5dcae1f19e18f04709ce7585943af1d582ebc7ed

Change in libosmocore[master]: stats.h: Fix build on MacOS

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12212 ) Change subject: stats.h: Fix build on MacOS .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12212 To unsubscribe

Change in libosmo-netif[master]: logging: fix typo in stream.c

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12217 ) Change subject: logging: fix typo in stream.c .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12217 To unsubscri

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12232 ) Change subject: detach cancelled subscribers from VLR .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12232 To u

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.

Change in osmo-msc[master]: drop gsm48 RR ciph mode compl from permitted initial messages

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12207 ) Change subject: drop gsm48 RR ciph mode compl from permitted initial messages .. Patch Set 3: Code-Review+2 -- To view, visit https://gerri

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12215 ) Change subject: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels .. bsc: TC_chan_exhaustion: Send correct RA

Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12133 ) Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI .. Patch Set 2: Code-Review+1 (4 comments) https:/

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12215 ) Change subject: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels .. Patch Set 1: Code-Review+2 -- To view, visit h

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12215 ) Change subject: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels .. Patch Set 1: Code-Review+1 (1 comment) http

Change in osmo-msc[master]: drop gsm48 RR ciph mode compl from permitted initial messages

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12207 ) Change subject: drop gsm48 RR ciph mode compl from permitted initial messages .. Patch Set 3: Code-Review+1 -- To view, visit https://ge

Change in libosmo-netif[master]: logging: fix typo in stream.c

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12217 ) Change subject: logging: fix typo in stream.c .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12217 To unsubs

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Patch Set 23: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11827/23/tes

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 17: (1 comment) https://gerrit.osmocom.org/#/c/12020/13/tests

Change in libosmocore[master]: stats.h: Fix build on MacOS

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12212 ) Change subject: stats.h: Fix build on MacOS .. Patch Set 1: Code-Review+1 Oooohh! a non-Linux platform! :) -- To view, visit https://ge

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has removed a vote on this change. Change subject: disable recording of LU timestamps by default .. Removed Code-Review+2 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/12228 To unsubscribe, o

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: Please don't merge this before Harald has had a chance to r

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db_

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12232 ) Change subject: detach cancelled subscribers from VLR .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12232

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12228 to look at the new patch set (#4). Change subject: disable recording of LU timestamps by default ..

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/

Change in osmo-sgsn[master]: Drop unused osmo-sgsn.pc

2018-12-10 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12231 ) Change subject: Drop unused osmo-sgsn.pc .. Drop unused osmo-sgsn.pc We do not install any libraries so we don't need it: most likely it's a

Change in osmo-sgsn[master]: Use explicit length check

2018-12-10 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12229 ) Change subject: Use explicit length check .. Use explicit length check Use OSMO_MIN macro to check for MSISDN length. This makes the code cle

Change in osmo-sgsn[master]: Drop unused osmo-sgsn.pc

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12231 ) Change subject: Drop unused osmo-sgsn.pc .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12231 To unsubscrib

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 2: (1 comment) So I'm fine with moving it into a f

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12226/3/include/osmocom/sgsn/gprs_s

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12224/

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-10 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12232 Change subject: detach cancelled subscribers from VLR .. detach cancelled subscribers from VLR When a subscriber is cancelled, fake an IMS

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

2018-12-10 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/1 ) Change subject: Constify sgsn_acl_lookup() parameter .. Constify sgsn_acl_lookup() parameter This requires I414e67a3de733fab407161b3264d3b890

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 3: (1 comment) I do agree that extra byte is probably unnecessary

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db_

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12224/

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.os

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db_

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12224/

Jenkins build is back to normal : master-osmo-iuh ยป a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #2638

2018-12-10 Thread jenkins
See

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/1 ) Change subject: Constify sgsn_acl_lookup() parameter .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1 T

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/

Change in osmo-sgsn[master]: Drop unused osmo-sgsn.pc

2018-12-10 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12231 Change subject: Drop unused osmo-sgsn.pc .. Drop unused osmo-sgsn.pc We do not install any libraries so we don't need it: most likely it's a forgotten

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12228/2/src/hl

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-10 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12227/2/src/gprs/

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-10 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 3: (1 comment) The rest is fixed in next revision. https://gerrit.osmocom.org/#/c/12226/2/tests

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12224/2/include/osmo

Change in osmo-sgsn[master]: Add sgsn_acl_count()

2018-12-10 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12223 ) Change subject: Add sgsn_acl_count() .. Abandoned -- To view, visit https://gerrit.osmocom.org/12223 To unsubscribe, or for help writing mail filters, visit ht

Change in osmo-sgsn[master]: ACL: move allocation check forward in sgsn_acl_add()

2018-12-10 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12225 ) Change subject: ACL: move allocation check forward in sgsn_acl_add() .. Abandoned -- To view, visit https://gerrit.osmocom.org/12225 To unsubscribe, or for help

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2018-12-10 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12224 to look at the new patch set (#3). Change subject: Use libosmocore constant for IMSI length in ACL entry ...

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-10 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12226 to look at the new patch set (#3). Change subject: Add tests for IMSI ACLs .. Add tests for IMSI ACLs Change-Id: Ia7

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-10 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12227 to look at the new patch set (#3). Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .

Change in osmo-sgsn[master]: Constify sgsn_acl_lookup() parameter

2018-12-10 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1 to look at the new patch set (#2). Change subject: Constify sgsn_acl_lookup() parameter .. Constify

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-10 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12221 to look at the new patch set (#2). Change subject: Use explicit parameter for sgsn_auth_init() .. U

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12228 to look at the new patch set (#3). Change subject: disable recording of LU timestamps by default .. disable recording

Change in libosmocore[master]: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12154 ) Change subject: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases .. gsm48_mi_to_string: use osmo_bcd2str(), fix some cor

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12228/2/src/db_

Change in osmo-sgsn[master]: Remove misleading comment

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12220 ) Change subject: Remove misleading comment .. Remove misleading comment The code which has been used for 4 years is hardly temporary.

Change in docker-playground[master]: gerrit: fix libopenid path

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12204 ) Change subject: gerrit: fix libopenid path .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12204 To unsubscribe,

Change in libosmocore[master]: gsm48_mi_to_string(): guard against zero length output buffer

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12156 ) Change subject: gsm48_mi_to_string(): guard against zero length output buffer .. gsm48_mi_to_string(): guard against zero length outp

Change in libosmocore[master]: gsm48_mi_to_string(): guard against zero length output buffer

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12156 ) Change subject: gsm48_mi_to_string(): guard against zero length output buffer .. Patch Set 7: Code-Review+2 -- To view, visit https://gerri

Change in libosmocore[master]: gsm48_mi_to_string(): do not read from zero length input buffer

2018-12-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12157 ) Change subject: gsm48_mi_to_string(): do not read from zero length input buffer .. gsm48_mi_to_string(): do not read from zero length

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12228/2/src/hlr

Change in libosmocore[master]: gsm48_mi_to_string(): do not read from zero length input buffer

2018-12-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12157 ) Change subject: gsm48_mi_to_string(): do not read from zero length input buffer .. Patch Set 8: Code-Review+2 -- To view, visit https://ger

  1   2   3   >