Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper
..
Patch Set 1: Code-Review-1
(1 comment)
good except
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helper
..
Patch Set 7: Code-Review-1
(5 comments)
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12476 )
Change subject: Add initial version of asyncio trap2cgi script
..
Add initial version of asyncio trap2cgi script
It uses the same config
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 5:
see
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 5:
it's good, but will soon be replaced by LOG_RAN_CONN() (if the patch is
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12491 )
Change subject: LCLS: add allocator function
..
Patch Set 1:
ok, but why?
--
To view, visit https://gerrit.osmocom.org/12491
To
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12487 )
Change subject: deb: fix wrong changelog date
..
Patch Set 1: Code-Review-1
(1 comment)
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12476 )
Change subject: Add initial version of asyncio trap2cgi script
..
Patch Set 4: Code-Review+2
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12485 )
Change subject: LCLS: constify helper parameters
..
Patch Set 1: Code-Review-1
(1 comment)
looks good except that one const there
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12483 )
Change subject: LCLS: add status parameter to Assignment Completed message
..
Patch Set 2: Code-Review-1
(3 comments)
looks good except
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12375 )
Change subject: LCLS: don't encode incorrect values
..
Patch Set 3: Code-Review-1
(1 comment)
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12367 )
Change subject: LCLS: use proper types for value_string wrappers
..
LCLS: use proper types for value_string wrappers
Change-Id:
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12367 )
Change subject: LCLS: use proper types for value_string wrappers
..
Patch Set 3: Code-Review+2
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12379 )
Change subject: LCLS: use Status for HO-COMPLETE message
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/12379/1//COMMIT_MSG
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface
..
Patch Set 29:
(10 comments)
https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c
File
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12516
Change subject: add README file
..
add README file
this describes the project, how to compile, and how to flash the
USB DFU bootloader
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12515
Change subject: use reserved bootloader get application start
..
use reserved bootloader get application start
the reserved bootloader size
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12511
Change subject: remove unused example code
..
remove unused example code
Change-Id: I205cd02f0c9a55d22bb78e84a88a29afe31224b0
---
D
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12514
Change subject: enable flashing by providing real downloaded data length
..
enable flashing by providing real downloaded data length
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12512
Change subject: add license file
..
add license file
this include the LGPL v2.1 for the DFU stack, ASF for the ASFv4
library, and Apache 2.0
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12513
Change subject: set USB string to osmocom osmo-ASF4-DFU
..
set USB string to osmocom osmo-ASF4-DFU
Change-Id:
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12502
Change subject: add code to initialize flash
..
add code to initialize flash
Change-Id: I2a208abb39a9da8796e2a4bcb803ce32686cb95f
---
M
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12510
Change subject: remove unused ARMCC Makefile
..
remove unused ARMCC Makefile
Change-Id: I232502798d71c97d0e7b4adf6bb6af3fa0940bd1
---
D
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12503
Change subject: add system LED initialisation
..
add system LED initialisation
Change-Id: I79f1b769fc9dd7e1a972bacf0928ff46988f0e36
---
M
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12507
Change subject: restructure and complete the USB-side DFU state machine
..
restructure and complete the USB-side DFU state machine
the USB
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12504
Change subject: switch to LGPLv2 license
..
switch to LGPLv2 license
this should remove any possible conflict with the ASF license
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12506
Change subject: make USB descriptor available for the two state machines
..
make USB descriptor available for the two state machines
this is
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12508
Change subject: implement flashing-side of the DFU state machine
..
implement flashing-side of the DFU state machine
the USB-side state
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12495
Change subject: ignore output files
..
ignore output files
Change-Id: Ia6c90711a67a9b1cafc7a6cc3b07aa769e8684d0
---
A .gitignore
1 file
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12497
Change subject: ignore gdb history file
..
ignore gdb history file
Change-Id: Ie3acf07ad7404fa3981baf65dab2a3ef416f9938
---
M .gitignore
1
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12498
Change subject: fix USB enabling
..
fix USB enabling
Change-Id: I22cdd77648ac21490909423bf529fb31f30d6af0
---
M usb/class/dfu/device/dfudf.c
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12505
Change subject: declare variables so the main loop can read the data to be
flashed provided by the USB stack
..
declare variables so the main
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12499
Change subject: add documentation and fix timeout value
..
add documentation and fix timeout value
Change-Id:
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12500
Change subject: add initial DFU class request handling
..
add initial DFU class request handling
downloading is not supported yet, but the
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12482 )
Change subject: paging: fix nullpointer deref
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12482
To
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12488 )
Change subject: Cosmetic: GSUP: note "on wire" for imei_result
..
Cosmetic: GSUP: note "on wire" for imei_result
Note that
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12490 )
Change subject: Cosmetic: hlr.c: remove confusing indent below if
..
Cosmetic: hlr.c: remove confusing indent below if
Remove a
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12488 )
Change subject: Cosmetic: GSUP: note "on wire" for imei_result
..
Patch Set 1: Code-Review+2
what would it be for wireless links? :P
--
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12490 )
Change subject: Cosmetic: hlr.c: remove confusing indent below if
..
Patch Set 1: Code-Review+2
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12478 )
Change subject: VLR: send CHECK-IMEI to EIR/HLR
..
Patch Set 6: Code-Review-1
(6 comments)
very nice so far.
Also add an msc_vlr_test
Kévin Redon has posted comments on this change. (
https://gerrit.osmocom.org/12494 )
Change subject: use USB CDC Echo example project
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/12494
To
Kévin Redon has submitted this change and it was merged. (
https://gerrit.osmocom.org/12494 )
Change subject: use USB CDC Echo example project
..
use USB CDC Echo example project
this is the USB CDC Echo example project source
Kévin Redon has posted comments on this change. (
https://gerrit.osmocom.org/12494 )
Change subject: use USB CDC Echo example project
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12494
To
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12480 )
Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg
..
VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg
Make the vsub
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12479 )
Change subject: vlr_core.h: remove duplicate declarations
..
vlr_core.h: remove duplicate declarations
Remove vlr_subscr_name() and
Kévin Redon has uploaded a new patch set (#2). (
https://gerrit.osmocom.org/12494 )
Change subject: use USB CDC Echo example project
..
use USB CDC Echo example project
this is the USB CDC Echo example project source code,
for
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: make check-imei-rqd configurable
..
msc_vty.c: make check-imei-rqd configurable
Related: OS#3189
Change-Id:
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/12489 )
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Cosmetic: msc_vty: remove redundant "0 =", "1 ="
Remove "0 =", "1 ="
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12489 )
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12489
Hello Stefan Sperling, Vadim Yanitskiy, Max, Neels Hofmeyr, Harald Welte,
Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12489
to look at the new patch set (#2).
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/12494
Change subject: use USB CDC Echo example project
..
use USB CDC Echo example project
this is the USB CDC Echo example project source code,
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12480 )
Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg
..
Patch Set 1: Code-Review+2
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12479 )
Change subject: vlr_core.h: remove duplicate declarations
..
Patch Set 1: Code-Review+2
what, we have a vlr_core.h? :P
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: make check-imei-rqd configurable
..
Patch Set 4: Code-Review+2
--
To view, visit
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12489 )
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Patch Set 1: Code-Review+2
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12401
to look at the new patch set (#3).
Change subject: fix lchan modifications: switch off re-using lchan during
assignment
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12401 )
Change subject: fix call-during-call: switch off re-using lchan during
assignment
..
Patch Set 2:
> I'm not really buying the argument
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12470 )
Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
..
Patch Set 2:
(1 comment)
Max has posted comments on this change. ( https://gerrit.osmocom.org/12490 )
Change subject: Cosmetic: hlr.c: remove confusing indent below if
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12490
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12404 )
Change subject: err log: fully log MS supported A5 algos on mismatch
..
Patch Set 10: Code-Review+2
I trivially moved a whitespace out of
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12404
to look at the new patch set (#10).
Change subject: err log: fully log MS supported A5 algos on mismatch
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12493
Change subject: LCLS: add GCR comparison helper
..
LCLS: add GCR comparison helper
Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12492
to look at the new patch set (#7).
Change subject: LCLS: add string dump helper
..
LCLS: add string dump helper
Max has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helper
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12492
To
Max has posted comments on this change. ( https://gerrit.osmocom.org/12488 )
Change subject: Cosmetic: GSUP: note "on wire" for imei_result
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12488
To
Max has posted comments on this change. ( https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: make check-imei-rqd configurable
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12302
To
Max has posted comments on this change. ( https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12484
To unsubscribe, or for help
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
msgb: fix debug print
Since osmo_hexdump() use static buffers we can't re-use pointers to it
after
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12484
To unsubscribe, or for
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 5:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12365
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12492
Change subject: LCLS: add string dump helper
..
LCLS: add string dump helper
Change-Id: Ic3609224c8f3282d667e75f68bc20327e36eb9e6
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12491
Change subject: LCLS: add allocator function
..
LCLS: add allocator function
Change-Id: If67cf93ae3dd449e96156485fe1baaf013df3f77
---
M
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12490
Change subject: Cosmetic: hlr.c: remove confusing indent below if
..
Cosmetic: hlr.c: remove confusing indent below if
Remove a misleading block in
Max has posted comments on this change. ( https://gerrit.osmocom.org/12489 )
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12489
To
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: make check-imei-rqd configurable
..
Patch Set 1:
(1 comment)
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12489
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Cosmetic: msc_vty: remove redundant "0 =", "1 ="
Remove "0 =", "1 =" in-front
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12487 )
Change subject: deb: fix wrong changelog date
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12487
To unsubscribe, or
77 matches
Mail list logo
