Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has uploaded a new patch set (#7) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Patch Set 7: Verified+1 Code-Review+2 -- To view, visit https://gerrit.os

Change in pysim[master]: Treat MCC and MNC as strings, not integers

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18225 ) Change subject: Treat MCC and MNC as strings, not integers .. Treat MCC and MNC as strings, not integers A MNC of 02 and 002 are *not* equal. Th

Change in libosmocore[master]: gsm0808_utils: Fix gsm0808_cause_class() function

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18230 ) Change subject: gsm0808_utils: Fix gsm0808_cause_class() function .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit

Change in libosmocore[master]: gsm0808: Make a function to extract Cause IE publicly available.

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18229 ) Change subject: gsm0808: Make a function to extract Cause IE publicly available. .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm0808: Make a function to extract Cause IE publicly available.

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18229 ) Change subject: gsm0808: Make a function to extract Cause IE publicly available. .. gsm0808: Make a function to extract Cause IE publicly av

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 ) Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. .. Patch Set 1: Code-Review+1 -- To

Change in libosmocore[master]: gsm0808_utils: Fix gsm0808_cause_class() function

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18230 ) Change subject: gsm0808_utils: Fix gsm0808_cause_class() function .. gsm0808_utils: Fix gsm0808_cause_class() function Cause class is in bi

Change in osmo-bsc[master]: osmo_bsc_bssap: check for conn early

2020-05-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18233 ) Change subject: osmo_bsc_bssap: check for conn early .. osmo_bsc_bssap: check for conn early Check the conn pointer in bsc_handle_dt

Change in osmo-bts[master]: measurement: expect at least 1 SUB frame for AMR

2020-05-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 ) Change subject: measurement: expect at least 1 SUB frame for AMR .. Patch Set 6: (3 comments) (forcing gerrit to send stuck review c

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 ) Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. .. Patch Set 1: (3 comments) https://

Change in osmo-bsc[master]: osmo_bsc_bssap: check for conn early

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18233 ) Change subject: osmo_bsc_bssap: check for conn early .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc

Change in osmo-bts[master]: measurement: expect at least 1 SUB frame for AMR

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 ) Change subject: measurement: expect at least 1 SUB frame for AMR .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 ) Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. .. Patch Set 1: (3 comments) https:/

Change in osmo-hlr[master]: doc: do not use loglevel info for log category ss

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/17600 ) Change subject: doc: do not use loglevel info for log category ss .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in osmo-hlr[master]: doc: do not use loglevel info for log category ss

2020-05-13 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/17600 ) Change subject: doc: do not use loglevel info for log category ss .. doc: do not use loglevel info for log category ss The log category ss uses

Change in osmo-pcu[master]: gprs_debug: Use only LOGL_NOTICE as default loglevel

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17609 ) Change subject: gprs_debug: Use only LOGL_NOTICE as default loglevel .. Patch Set 4: Looks good to me, the only reservation would be t

Change in osmo-pcu[master]: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used...

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18223 ) Change subject: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used to exist beforehand .. Patch Set 1: Code-Review+

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Patch Set 1: Requiring a ta argument can be a good way to make sure caller

Change in osmo-pcu[master]: bts: Drop specific functions to increase counters

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18226 ) Change subject: bts: Drop specific functions to increase counters .. Patch Set 2: Code-Review+1 This patch makes it nicer to read inde

Change in osmo-pcu[master]: bts: Drop specific functions to add values to counters

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18227 ) Change subject: bts: Drop specific functions to add values to counters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit

Change in osmo-pcu[master]: bts: Drop specific functions to add values to stats

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18228 ) Change subject: bts: Drop specific functions to add values to stats .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.os

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 4: Code-Review-1 (3 comments) This change is ready f

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Patch Set 1: > Patch Set 1: > > Requiring a ta argument can be a good way

Change in osmo-ttcn3-hacks[master]: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks()

2020-05-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18234 ) Change subject: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks() .. pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks()

Change in osmo-ttcn3-hacks[master]: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks()

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18234 ) Change subject: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks() .. Patch Set 1: Code-Review+2 -- To view, visit https:

Change in osmo-ttcn3-hacks[master]: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks()

2020-05-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18234 ) Change subject: pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks() .. pcu: Properly pass tlli in f_tx_rlcmac_ul_n_blocks() Change-Id:

Change in osmo-ttcn3-hacks[master]: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block

2020-05-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235 ) Change subject: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block .. pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_bloc

Change in osmo-ttcn3-hacks[master]: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235 ) Change subject: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block

2020-05-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235 ) Change subject: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block .. pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block Downlink

Change in osmo-bsc[master]: deprecate 'msc' / 'ip.access rtp-base '

2020-05-13 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18236 ) Change subject: deprecate 'msc' / 'ip.access rtp-base ' .. deprecate 'msc' / 'ip.access rtp-base ' The bsc_msc_data->rtp_base has bee

Change in osmo-bsc[master]: deprecate 'msc' / 'ip.access rtp-base '

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18236 ) Change subject: deprecate 'msc' / 'ip.access rtp-base ' .. Patch Set 1: Code-Review-1 You miss updating doc/manuals/vty/bsc_vty_refer

Change in osmo-pcu[master]: bts: Drop specific functions to increase counters

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18226 ) Change subject: bts: Drop specific functions to increase counters .. Patch Set 2: No functional change indeed. I'm trying to avoid fu

Change in docker-playground[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18237 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config osmo-

Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18238 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config osmo-b

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. pcu: use correct RA type to properly test 2phase a

Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18238 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. Patch Set 2: Code-Review+2 -- To view, visit https://ge

Change in docker-playground[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18237 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. Patch Set 1: Code-Review+2 -- To view, visit https://g

Change in libosmocore[master]: gsm0808: Make a function to extract Cause IE publicly available.

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18229 ) Change subject: gsm0808: Make a function to extract Cause IE publicly available. .. Patch Set 1: (1 comment) https://gerrit.osmoc

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 1: (1 comment) https://gerrit.osmocom.

Change in docker-playground[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18237 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. Patch Set 1: Verified+1 -- To view, visit https://ger

Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18238 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config osmo-bsc does n

Change in docker-playground[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18237 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. Patch Set 1: Code-Review+2 -- To view, visit https://

Change in docker-playground[master]: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18237 ) Change subject: bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config .. bsc/osmo-bsc.cfg: remove legacy 'rtp-base' config osmo-bsc does

Change in osmo-pcu[master]: bts: Drop specific functions to add values to stats

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18228 ) Change subject: bts: Drop specific functions to add values to stats .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

Change in osmo-pcu[master]: bts: Drop specific functions to add values to counters

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18227 ) Change subject: bts: Drop specific functions to add values to counters .. Patch Set 1: Code-Review+2 -- To view, visit https://gerr

Change in osmo-pcu[master]: bts: Drop specific functions to increase counters

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18226 ) Change subject: bts: Drop specific functions to increase counters .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.os

Change in osmo-pcu[master]: gprs_debug: Use only LOGL_NOTICE as default loglevel

2020-05-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17609 ) Change subject: gprs_debug: Use only LOGL_NOTICE as default loglevel .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit

Change in osmo-pcu[master]: gprs_debug: Use only LOGL_NOTICE as default loglevel

2020-05-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17609 ) Change subject: gprs_debug: Use only LOGL_NOTICE as default loglevel .. gprs_debug: Use only LOGL_NOTICE as default loglevel The default logle

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 1: (3 comments) https://gerrit.osmocom

Change in libosmo-abis[master]: Fix subchan_demux_test compiler warning on some gcc versions

2020-05-13 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18240 ) Change subject: Fix subchan_demux_test compiler warning on some gcc versions .. Fix subchan_demux_test compiler warning on some

Change in libosmo-abis[master]: Fix subchan_demux_test compiler warning on some gcc versions

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18240 ) Change subject: Fix subchan_demux_test compiler warning on some gcc versions .. Patch Set 1: Code-Review+2 -- To view, visit http

Change in libosmo-abis[master]: Fix subchan_demux_test compiler warning on some gcc versions

2020-05-13 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18240 ) Change subject: Fix subchan_demux_test compiler warning on some gcc versions .. Fix subchan_demux_test compiler warning on some gcc versions

Change in osmo-bsc[master]: manual: fix config example typo 'msc-addr'

2020-05-13 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18241 ) Change subject: manual: fix config example typo 'msc-addr' .. manual: fix config example typo 'msc-addr' Change-Id: Ifb84d7ceddc772e3

Change in osmo-bsc[master]: deprecate 'msc' / 'ip.access rtp-base '

2020-05-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18236 ) Change subject: deprecate 'msc' / 'ip.access rtp-base ' .. Patch Set 1: > You miss updating doc/manuals/vty/bsc_vty_reference.xml I t

Change in osmo-bsc[master]: manual: fix config example typo 'msc-addr'

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18241 ) Change subject: manual: fix config example typo 'msc-addr' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in osmo-bsc[master]: deprecate 'msc' / 'ip.access rtp-base '

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18236 ) Change subject: deprecate 'msc' / 'ip.access rtp-base ' .. Patch Set 1: It's autogenerated using osmo-python scripts, but still you n

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-13 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 to look at the new patch set (#2). Change subject: pcu: use correct RA type to properly test 2phase access ..

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 2: (1 comment) https://gerrit.osmocom.

Change in libosmocore[master]: gsm0808: Make a function to extract Cause IE publicly available.

2020-05-13 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18229 ) Change subject: gsm0808: Make a function to extract Cause IE publicly available. .. Patch Set 1: (1 comment) https://gerrit.osmocom

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-13 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. gsm0808_utils: Add gsm0808_

Change in libosmocore[master]: libosmogsm: import hopping sequence generation code

2020-05-13 Thread fixeria
Hello tnt, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18244 to review the following change. Change subject: libosmogsm: import hopping sequence generation code .. libosmogsm:

Change in libosmocore[master]: libosmogsm: cosmetic: use '%u' instead of PRIu32 for uint32_t

2020-05-13 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18243 ) Change subject: libosmogsm: cosmetic: use '%u' instead of PRIu32 for uint32_t .. libosmogsm: cosmetic: use '%u' instead of PRIu32

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-13 Thread fixeria
Hello laforge, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18245 to review the following change. Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. libo

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-13 Thread fixeria
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18245 to look at the new patch set (#2). Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() ...

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-13 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18243 to look at the new patch set (#2). Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 ..

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-13 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18243 to look at the new patch set (#3). Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 ..

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. Patch Set 1: Code-Review-2

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-13 Thread ipse
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18242 to look at the new patch set (#2). Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-13 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. Patch Set 2: > Patch Set 1:

Change in libosmocore[master]: libosmogsm: import hopping sequence generation code

2020-05-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18244 ) Change subject: libosmogsm: import hopping sequence generation code .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.o

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmo

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18243 ) Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 .. Patch Set 3: Code-Review+1 -- To view, visit https://ger

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/