Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
msgb: add test helpers
It's often handy to compare certain msgb layer to a given array and
print
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12017
To unsubscribe,
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12017
To
Stefan Sperling has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12017
To
Hello Stefan Sperling, Vadim Yanitskiy, Pau Espin Pedrol, Neels Hofmeyr, Harald
Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12017
to look at the new patch set (#12).
Change subject: msgb: add test helpers
Stefan Sperling has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 11: Code-Review+1
(1 comment)
I like this idea.
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 11:
> one slight problem with LOGP could be that in regression tests, we often only
> check
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 5:
(1 comment)
> I usually end up tailoring the debug output to the specific test.
You can
Hello Vadim Yanitskiy, Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, Jenkins
Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12017
to look at the new patch set (#9).
Change subject: msgb: add test helpers
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/12017
To unsubscribe, or for help
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 5: Code-Review+1
(1 comment)
nice idea to add general tests helpers. Things that
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 5:
> I think we should avoid using printf() in libosmocore
In general I'd agree but those are
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12017/5/src/msgb.c
File
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/12017
To unsubscribe, or for help
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 3: Code-Review-1
(5 comments)
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12017
to look at the new patch set (#3).
Change subject: msgb: add test helpers
..
msgb: add test
Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
Patch Set 2:
> what about having it return an int like memcmp?
What for?
> after all we are using memcmp,
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/12017
to look at the new patch set (#2).
Change subject: msgb: add test helpers
..
msgb: add test
18 matches
Mail list logo
