Harald Welte has submitted this change and it was merged.
Change subject: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp()
for 3-digit MNC
..
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6663
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/6663/7/tests/gsm23003/gsm23003_test.ok
File tests/gsm23003/gsm23003_test.ok:
Line 63
looks like gerrit gets mixed up with the \r character above. The patch
colorizing is off by two lines.
--
To view, visit
Patch Set 7:
(added a str decoding test)
--
To view, visit https://gerrit.osmocom.org/6663
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6663
to look at the new patch set (#7).
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:
Line 233: if (mnc_3_digits)
> I can understand the f(mnc_3_digits) as the caller might not be interested
a user of this is CTRL interface verification, which is not interested in
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:
Line 233: if (mnc_3_digits)
I can understand the f(mnc_3_digits) as the caller might not be interested in
that. But do you thin that mnc=NULL is a valid API use of
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6663
to look at the new patch set (#6).
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string
Patch Set 5:
mncc_from_str: we always have the output argument first, thee input arguments
last (think of memcpy)
--
To view, visit https://gerrit.osmocom.org/6663
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Neels Hofmeyr has abandoned this change.
Change subject: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp()
for 3-digit MNC
..
Abandoned
change-id mixup
--
To view, visit https://gerrit.osmocom.org/6959
To
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6663
to look at the new patch set (#5).
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string
Review at https://gerrit.osmocom.org/6959
gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC
osmo_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing (osmo-bsc, osmo-msc, osmo-sgsn, osmo-pcu).
osmo_{plmn,mnc}_cmp() takes care of
12 matches
Mail list logo
