While we're whinging:
- I'm looking at the Discussion page for an MR
(https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904) and I see a
comment Simon made, beginning with "No, I am not!". I wanted a bit more
context. So I click on the filename above the Discussion and am warped to
Simon Peyton Jones writes:
> | Another issue is that apparently GitLab still sends one email per comment
> | instead of one comment per batch. This will evidently be fixed in GitLab
> | 11.6 [1].
>
> yes that is TERRIBLE. When does 11.6 land?
>
It is the next release. I will poke our contact
Simon Peyton Jones via ghc-devs writes:
> * When looking at a comment on a MR, I see some snippet of code. How
> can I see what module that snippet is in? Apart from scrolling up to
> find the file header - being careful not to miss it and scroll into
> the previous file.
>
Sigh,
| Another issue is that apparently GitLab still sends one email per comment
| instead of one comment per batch. This will evidently be fixed in GitLab
| 11.6 [1].
yes that is TERRIBLE. When does 11.6 land?
What I want is to have a batch of comments with an overview message. We used
that
Simon Peyton Jones via ghc-devs writes:
> | > When submitting a review, I often want to add an overall comment, not
> | related to a particular line of code? How do I do that?
> |
> | I do that by going back to the "Discussion" tab and adding something at the
> | bottom.
>
> But alas
* If I respond to a comment (in review mode) but forget to check
"resolved", it says "Discussion stays unresolved" correctly. But how do I now
change it to "resolved"??
From: ghc-devs On Behalf Of Simon Peyton Jones
via ghc-devs
Sent: 10 January 2019 17:16
To: ghc-devs
Subject: More
To return to the original question, how do I add an overall comment for a
(multi-comment) review?
Simon
| -Original Message-
| From: Ben Gamari
| Sent: 10 January 2019 17:41
| To: Evan Laforge ; Simon Peyton Jones
|
| Cc: ghc-devs
| Subject: Re: Reviews
|
| Evan Laforge
Evan Laforge writes:
> On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones
> wrote:
>> | > When submitting a review, I often want to add an overall comment, not
>> | related to a particular line of code? How do I do that?
>> |
>> | I do that by going back to the "Discussion" tab and adding
Moritz Angermann writes:
> Alright let me add some example that is really painful with submodules.
>
> Say I have a custom ghc fork angerman/ghc, because I really don't want
> to overload CI with all my stupidity and I *know* I'd forget to mark
> every commit with [skip ci] or something.
>
> Now
Ömer Sinan Ağacan writes:
>> As I mention in the documentation, those with commits bits should feel
>> free to push branches to ghc/ghc.
>
> This is sometimes not ideal as it wastes GHC's CI resources. For example I
> make
> a lot of WIP commits to my work branches, and I don't want to keep CI
Ömer Sinan Ağacan writes:
> while making the case of contributing patches with submodule changes more
> difficult
>
> I don't understand this, can you give an example of what absolute paths make
> harder?
>
> Looking at the wiki pages and scripts we need to make relative paths work for
>
Alright let me add some example that is really painful with submodules.
Say I have a custom ghc fork angerman/ghc, because I really don't want
to overload CI with all my stupidity and I *know* I'd forget to mark
every commit with [skip ci] or something.
Now I need to modify a bunch of submodules
On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones wrote:
> | > When submitting a review, I often want to add an overall comment, not
> | related to a particular line of code? How do I do that?
> |
> | I do that by going back to the "Discussion" tab and adding something at the
> | bottom.
>
Hi all,
Last night my patch got merged which changed some aspects of the
hadrian settings file.
If you have a custom settings file (ie hadrian/UserSettings.hs), you
need to remove reference to the `stage1Only` variable and
add a new variable called `finalStage` which should default to `Stage2`.
14 matches
Mail list logo
