Re: CI build failures

2021-07-27 Thread Gergő Érdi
Thanks, this is all great news On Tue, Jul 27, 2021, 21:56 Ben Gamari wrote: > ÉRDI Gergő writes: > > > Hi, > > > > I'm seeing three build failures in CI: > > > Hi, > > > 1. On perf-nofib, it fails with: > > > Don't worry about this one for the moment. This job is marked as > accepting of

Re: CI build failures

2021-07-27 Thread Ben Gamari
ÉRDI Gergő writes: > Hi, > > I'm seeing three build failures in CI: > Hi, > 1. On perf-nofib, it fails with: > Don't worry about this one for the moment. This job is marked as accepting of failure for a reason (hence the job state being an orange exclamation mark rather than a red X). > ==

Re: CI build failures

2021-07-27 Thread Gergő Érdi
The other two are resilient to restarts. On Tue, Jul 27, 2021, 18:49 Moritz Angermann wrote: > You can safely ignore the x86_64-darwin failure. I can get you the juicy > details over a beverage some time. It boils down to some odd behavior using > rosetta2 on AArch64 Mac mini’s to build x86_64

Re: CI build failures

2021-07-27 Thread Moritz Angermann
You can safely ignore the x86_64-darwin failure. I can get you the juicy details over a beverage some time. It boils down to some odd behavior using rosetta2 on AArch64 Mac mini’s to build x86_64 GHCs. There is a fix somewhere from Ben, so it’s just a question of time until it’s properly fixed.

CI build failures

2021-07-27 Thread ÉRDI Gergő
Hi, I'm seeing three build failures in CI: 1. On perf-nofib, it fails with: == make boot -j --jobserver-fds=3,4 --no-print-directory; in /builds/cactus/ghc/nofib/real/smallpt /builds/cactus/ghc/ghc/bin/ghc -M

Re: Where else do I need to register fixity declarations?

2021-07-27 Thread Gergő Érdi
Thanks, this works! I guess this is the kind of problems I run into by using `mkIface_` directly instead of via `mkIfaceTc`. Unfortunately, if I try that, I end up with a panic in `GHC.Iface.Recomp.mkHashFun` in my real program (see separate email earlier). On Tue, Jul 27, 2021, 16:14 Sylvain

Re: Where else do I need to register fixity declarations?

2021-07-27 Thread Sylvain Henry
> What am I doing wrong? Is filling the `mi_fixities` field of the `ModIface` not enough to let importers see the correct fixities? It seems like the renamer is looking for the fixities via `mi_fix_fn (mi_final_exts iface)`, not `mi_fixities`. You should try to replace:   , mi_final_exts =

Re: Where else do I need to register fixity declarations?

2021-07-27 Thread Gergő Érdi
I should add that I've also tried adding the just-loaded module to the EPS but that also doesn't fix the issue. On Tue, Jul 27, 2021, 15:14 Erdi, Gergo via ghc-devs wrote: > > > Hi, > > > > In the attached program, I am typechecking two Haskell modules with GHC > 9.0.1: `Imported.hs` defines

Where else do I need to register fixity declarations?

2021-07-27 Thread Erdi, Gergo via ghc-devs
PUBLIC Hi, In the attached program, I am typechecking two Haskell modules with GHC 9.0.1: `Imported.hs` defines some infix operators, and `Importer.hs` uses them. After typechecking the first one, I put it in the moduleNameProvidersMap and the HPT. However, when I am typechecking the second