Re: [GSoC][PATCH v6 2/2] submodule: port subcommand foreach from shell to C

On Fri, Jun 2, 2017 at 4:24 AM, Prathamesh Chavan wrote: > This aims to make git-submodule foreach a builtin. This is the very > first step taken in this direction. Hence, 'foreach' is ported to > submodule--helper, and submodule--helper is called from git-submodule.sh. > The

Re: public inbox links, was: Re: preserve untracked cache, was Re: What's cooking in git.git (Jun 2017, #01; Thu, 1)

Stefan Beller wrote: > Today I learned again how public-inbox is awesome! Thanks Eric! You're welcome :) > * You can just copy the message ID INCLUDING the surrounding < > > and public inbox still just shows you the correct message. I had assumed > you would need to

Re: Wrong gitattributes documentation?

On 06/03/2017 02:01 AM, Junio C Hamano wrote: > Your "/images/*" is the "Otherwise" case, isn't it? Ok, sorry, didn't read your answer thoroughly enough the first time. The problem is, when I have an entry in .gitignore like this: /images Then git will ignore that whole directory (and all of

Re: Wrong gitattributes documentation?

On 06/03/2017 02:01 AM, Junio C Hamano wrote: > Your "/images/*" is the "Otherwise" case, isn't it? Yes, true. I forgot to mention in my first mail that I also tried '/images/', which had the same (=none) effect as '/images/*', sorry about the confusion.

public inbox links, was: Re: preserve untracked cache, was Re: What's cooking in git.git (Jun 2017, #01; Thu, 1)

On Fri, Jun 2, 2017 at 5:26 PM, Junio C Hamano wrote: > > Issue #06 of May marked it to be merged to 'next': > https://public-inbox.org/git/ > > Issue #07 of May marked it for 'master': >

[PATCH] submodule foreach: correct $sm_path in nested submodules from a dir

When running 'git submodule foreach' from a subdirectory of your repository, nested submodules get a bogus value for $sm_path: For a submodule 'sub' that contains a nested submodule 'nested', running 'git -C dir submodule foreach echo $path' would report path='../nested' for the nested submodule.

Re: pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

Jonathan Nieder writes: > 2. Hard-coded object ids in tests: As Stefan hinted, many tests beyond >t00* make assumptions about the exact values of object ids. That's >bad for maintainability for other reasons beyond the hash function >transition, too. > >It

Re: preserve untracked cache, was Re: What's cooking in git.git (Jun 2017, #01; Thu, 1)

Johannes Schindelin writes: > Hi Junio, > > On Fri, 2 Jun 2017, Junio C Hamano wrote: > >> Samuel Lijin writes: >> >> >> What is holding this topic up? Anything Ben or I can do to move this >> >> closer to `next` or even `master`? >> > >> > It's

Re: Unaligned accesses in sha1dc

Ævar Arnfjörð Bjarmason writes: > On Fri, Jun 2, 2017 at 4:46 PM, Liam R. Howlett > wrote: > >> 2.13.0 is very much broken for me on SPARC. >> {maint//git} $ make -j120 >> [...] >> {maint//git} $ ./git log >> [1]1004506 bus error (core dumped)

Re: Unaligned accesses in sha1dc

Linus Torvalds writes: > Dereferencing an unaligned pointer may be "undefined" in some > technical meaning, but it sure as hell isn't undefined in reality, and > compilers that willfully do stupid things should not be catered to > overly. Reality is a lot more

Re: Wrong gitattributes documentation?

Rene Pasing writes: > The problem is, the documentation[1] says: "The rules how the pattern > matches paths are the same as in .gitignore files; see gitignore[5].", > so when I have a pattern like '/images/', it should match on all > files+folders under /images, even the

Re: [PATCH] perf: work around the tested repo having an index.lock

Jeff King writes: > But I think a more compelling case is that there may be an ongoing > operation in the original repo (e.g., say you are in the middle of > writing a commit message) when we do a blind copy of the filesystem > contents. You might racily pick up a lockfile. > >

Re: How to avoid "Please tell me who you are..."?

Ævar Arnfjörð Bjarmason writes: > On Fri, Jun 2, 2017 at 9:15 AM, Junio C Hamano wrote: >> Jeffrey Walton writes: >> >>> Is there no switch? Its the most efficient way to accomplish the task. >> >> This is a safety to help normal human

Re: [PATCH 25/33] notes-merge: convert verify_notes_filepair to struct object_id

Brandon Williams writes: > On 06/02, Junio C Hamano wrote: >> >> > -static int path_to_sha1(const char *path, unsigned char *sha1) >> > +static int path_to_oid(const char *path, struct object_id *oid) >> > { >> > - char hex_sha1[40]; >> > + char hex_oid[GIT_SHA1_HEXSZ]; >>

Re: [PATCH 00/33] object id conversion (grep and diff)

Brandon Williams writes: > On 06/02, Junio C Hamano wrote: >> >> I lied. This also conflicts somewhat with Peff's diff-blob topic. >> I think I resolved them correctly (there needs evil merges applied >> to two files when merging this topic), and hopefully can push out >>

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

Jeff King wrote: > On Fri, Jun 02, 2017 at 12:38:45PM -0700, Jonathan Tan wrote: >> +--blob-max-bytes=:: >> +This option can only be used with --stdout. If specified, a blob >> +larger than this will not be packed unless a to-be-packed tree >> +has that blob with a filename beginning

Re: git-gui ignores core.hooksPath

Thanks Philip, I've created a pull request there - https://github.com/patthoyts/git-gui/pull/12 signature.asc Description: OpenPGP digital signature

Please i need your urgent and sincere reply

Dear Good day, I sent this mail praying for it to reach you in good health, since I myself are in a very critical health condition in which I sleep every night without knowing if I may be alive to see the next day. I am a widow suffering from long time illness. I have some funds I inherited from

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On Sat, Jun 3, 2017 at 12:05 AM, Ben Peart wrote: > > > On 6/2/2017 6:28 AM, Ævar Arnfjörð Bjarmason wrote: >> >> Add a performance test for the new core.fsmonitor facility using the >> sample query-fsmonitor hook. >> >> This is WIP code for the reasons explained in the setup

Re: git-gui ignores core.hooksPath

From: "Ævar Arnfjörð Bjarmason" On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote: Hi git devs, First off, thanks for your awesome work! I've been unhappy for quite a while that I had to configure the hooks manually for each of my repos - until I

Re: git-2.13.0: log --date=format:%z not working

On Sat, Jun 03, 2017 at 12:47:59AM +0200, Ulrich Mueller wrote: > > On Fri, 2 Jun 2017, Jeff King wrote: > > > The remaining question is whether we want to care about preserving the > > system %Z for the local-timezone case. > > No strong preference here. Maybe go for consistency, and have

Re: git-2.13.0: log --date=format:%z not working

> On Fri, 2 Jun 2017, Jeff King wrote: > The remaining question is whether we want to care about preserving the > system %Z for the local-timezone case. No strong preference here. Maybe go for consistency, and have %Z always return the same format (either empty, or same as %z). That would at

Re: git-2.13.0: log --date=format:%z not working

On Sat, Jun 03, 2017 at 12:04:32AM +0200, Ulrich Mueller wrote: > Actually, the POSIX definition for %Z continues: "or by no bytes if no > timezone information exists." So also returning an empty string would > be compliant (but maybe not very helpful). > [...] > I agree that GMT+0200 could be

Re: [WIP v2 2/2] pack-objects: support --blob-max-bytes

On Fri, Jun 02, 2017 at 12:38:45PM -0700, Jonathan Tan wrote: > +--blob-max-bytes=:: > + This option can only be used with --stdout. If specified, a blob > + larger than this will not be packed unless a to-be-packed tree > + has that blob with a filename beginning with ".git". The

Re: [PATCH v4 0/6] Fast git status via a file system watcher

On Thu, Jun 01, 2017 at 02:13:10PM -0700, Stefan Beller wrote: > > > >> $ git am /tmp/original_msg.txt > >> Applying: fsmonitor: add documentation for the fsmonitor extension. > >> error: patch failed: Documentation/githooks.txt:448 > >> error: Documentation/githooks.txt:

Re: [WIP v2 0/2] Modifying pack objects to support --blob-max-bytes

On Fri, Jun 02, 2017 at 12:38:43PM -0700, Jonathan Tan wrote: > > Do we need to future-proof the output format so that we can later > > use 32-byte hash? The input to pack-objects (i.e. rev-list --objects) > > is hexadecimal text, and it may not be so bad to make this also > > text, e.g. " SP

Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

On 6/2/2017 6:28 AM, Ævar Arnfjörð Bjarmason wrote: Add a performance test for the new core.fsmonitor facility using the sample query-fsmonitor hook. This is WIP code for the reasons explained in the setup comments, unfortunately the perf code doesn't easily allow you to run different setup

Re: git-2.13.0: log --date=format:%z not working

> On Fri, 2 Jun 2017, Jeff King wrote: > On Fri, Jun 02, 2017 at 07:25:43PM +0200, René Scharfe wrote: >> On Linux "%z %Z" is expanded to "+0200 CEST" for me, while on Windows I >> get "Mitteleurop▒ische Sommerzeit Mitteleurop▒ische Sommerzeit". (That >> "▒" is probably supposed to be an

Re: git-2.13.0: log --date=format:%z not working

On Fri, Jun 02, 2017 at 11:23:30AM +0900, Junio C Hamano wrote: > René Scharfe writes: > > > Am 27.05.2017 um 23:46 schrieb Jeff King: > >> On Sat, May 27, 2017 at 06:57:08PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > >>> There's another test which breaks if we just

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 1:17 PM, demerphq wrote: > Most hash function implementations have code like the following > (extracted and reduced from hv_macro.h in perl.git [which only > supports little-endian hash functions]): Yes. Please do *not* try to make things overly

RE: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

BTW, a medium-sized (~250k files across 40k dirs) synthetic repo is available over bittorrent at: http://bitmover.com/2015-04-03-1M-git-bare.tar.bz2.torrent I tried Ævar's perf test with that (on a beefy laptop with SSD), and got significantly slower results with bp/fsmonitor: Test

Re: [PATCH v2] docs: fix formatting and grammar

On Fri, Jun 02, 2017 at 10:45:38AM +0900, Junio C Hamano wrote: > > ...I should have read to the end of the sentence. It should also be "in > > the `$GIT_DIR/remotes/` file". Or just drop "file". > > There is another one nearby. Here is what I understand as your > suggestion (the "just drop"

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 10:17 PM, demerphq wrote: > On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren wrote: >>> On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason

Re: [PATCH] respect core.hooksPath, falling back to .git/hooks

Dear Philip, the previous mail contains a patch against the master of http://repo.or.cz/git-gui.git Could you please review it? I am not a TCL developer, so please take extra care! Thanks, Philipp signature.asc Description: OpenPGP digital signature

Re: pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

On Fri, Jun 2, 2017 at 7:54 PM, Jonathan Nieder wrote: > Hi Dscho, > > Johannes Schindelin wrote: >> On Thu, 1 Jun 2017, Stefan Beller wrote: > >>> We had a discussion off list how much of the test suite is in bad shape, >>> and "$ git grep ^index" points out a lot of places

Re: Unaligned accesses in sha1dc

On 2 June 2017 at 22:14, Ævar Arnfjörð Bjarmason wrote: > On Fri, Jun 2, 2017 at 10:11 PM, Martin Ågren wrote: >> On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason wrote: >>> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren

[PATCH] respect core.hooksPath, falling back to .git/hooks

Signed-off-by: Philipp Gortan --- The following patch tries to fix git-gui to respect the core.hooksPath config variable, falling back to the old behavior. git-gui.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/git-gui.sh b/git-gui.sh index

Re: Unaligned accesses in sha1dc

On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason wrote: > On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren wrote: >> On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason wrote: >>> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano

Re: [PATCH 0/3] Use skip_prefix() in handle_revision_{,pseudo_}opt()

On Fri, Jun 02, 2017 at 09:10:07PM +0200, SZEDER Gábor wrote: > While at it, the first one fixes a minor bug, which allowed e.g. 'git > log --no-min-parents-foobarbaz' to succeed. > > The other two are fairly straightforward starts_with() -> > skip_prefix() conversions. These all look fine to

Re: [PATCH 2/3] revision.c: use skip_prefix() in handle_revision_opt()

On Fri, Jun 02, 2017 at 04:11:43PM -0400, Jeff King wrote: > if (match_opt(arg, "--early-output"), )) { > int count = optarg ? atoi(optarg) : 100; > ... > } > > which is a little nicer and could maybe help other options (I didn't see > any, though). I take it back. This would

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 10:11 PM, Martin Ågren wrote: > On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren wrote: >>> On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason

Re: [PATCH] perf: work around the tested repo having an index.lock

On Fri, Jun 2, 2017 at 8:45 PM, Jeff King wrote: > On Fri, Jun 02, 2017 at 10:33:30AM +, Ævar Arnfjörð Bjarmason wrote: > >> When the tested repo has an index.lock file it should be removed. This >> file may be present if e.g. git-status previously crashed in that >> repo, and

Re: [PATCH 2/3] revision.c: use skip_prefix() in handle_revision_opt()

On Fri, Jun 02, 2017 at 09:10:09PM +0200, SZEDER Gábor wrote: > @@ -1785,15 +1785,15 @@ static int handle_revision_opt(struct rev_info *revs, > int argc, const char **arg > } else if (!strcmp(arg, "--author-date-order")) { > revs->sort_order = REV_SORT_BY_AUTHOR_DATE; >

Re: Unaligned accesses in sha1dc

On 2 June 2017 at 21:32, Ævar Arnfjörð Bjarmason wrote: > On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren wrote: >> On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason wrote: >>> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano

Re: [PATCH] perf: work around the tested repo having an index.lock

On Fri, Jun 02, 2017 at 10:33:30AM +, Ævar Arnfjörð Bjarmason wrote: > When the tested repo has an index.lock file it should be removed. This > file may be present if e.g. git-status previously crashed in that > repo, and it will make a lot of git commands fail. Let's try harder > and remove

[WIP v2 2/2] pack-objects: support --blob-max-bytes

As part of an effort to improve Git support for very large repositories in which clients typically have only a subset of all version-controlled blobs, teach pack-objects to support --blob-max-bytes, packing only blobs not exceeding that size unless the blob corresponds to a file whose name starts

Re: [PATCH 04/31] setup: don't perform lazy initialization of repository state

On Thu, Jun 01, 2017 at 12:23:25PM -0700, Stefan Beller wrote: > On Wed, May 31, 2017 at 2:43 PM, Brandon Williams wrote: > > Under some circumstances (bogus GIT_DIR value or the discovered gitdir > > is '.git') 'setup_git_directory()' won't initialize key repository > >

[WIP v2 1/2] pack-objects: rename want_.* to ignore_.*

Currently, in pack_objects, add_object_entry() distinguishes between 2 types of non-preferred-base objects: (1) objects that should not be in "to_pack" because an option like --local or --honor-pack-keep is set (2) objects that should be in "to_pack" A subsequent commit will teach

[WIP v2 0/2] Modifying pack objects to support --blob-max-bytes

Here's a new version addressing Junio's comments. > Hmph, that statement is a hard to read and agree to. I thought an > ignored object that is not going to be packed is one that won't hit > to_pack? That is true currently, but will not be the full truth once the 2nd patch is applied. I have

Re: git-2.13.0: log --date=format:%z not working

On Fri, Jun 02, 2017 at 07:25:43PM +0200, René Scharfe wrote: > Am 02.06.2017 um 05:08 schrieb Jeff King: > > In theory the solution is: > > > >1. Start using localtime() instead of gmtime() with an adjustment when > > we are converting to the local timezone (i.e., format-local). We >

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 11:49 AM, Martin Ågren wrote: > On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason wrote: >> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: >>> Martin Ågren writes: >>> I

[PATCH] Documentation/git-rm: correct submodule description

Since 3ccd681c2a (Merge branch 'sb/submodule-rm-absorb', 2017-01-18) git-rm tries to absorb any submodules git dir before deleting the submodule. Correct the documentation to say so. Signed-off-by: Stefan Beller --- Documentation/git-rm.txt | 9 + 1 file changed, 5

Re: [PATCH 00/33] object id conversion (grep and diff)

On 05/31, brian m. carlson wrote: > On Tue, May 30, 2017 at 10:30:36AM -0700, Brandon Williams wrote: > > A month or so ago I thought I would lend a hand to Brian and do a round of > > conversions from sha1 -> struct object_id. Now that Brian's latest series > > has > > hit master I can finally

[PATCH 0/3] Use skip_prefix() in handle_revision_{,pseudo_}opt()

While at it, the first one fixes a minor bug, which allowed e.g. 'git log --no-min-parents-foobarbaz' to succeed. The other two are fairly straightforward starts_with() -> skip_prefix() conversions. SZEDER Gábor (3): revision.c: stricter parsing of '--no-{min,max}-parents' revision.c: use

[PATCH 1/3] revision.c: stricter parsing of '--no-{min,max}-parents'

These two options are parsed using starts_with(), allowing things like 'git log --no-min-parents-foobarbaz' to succeed. Use strcmp() instead. Signed-off-by: SZEDER Gábor --- revision.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/revision.c

[PATCH 3/3] revision.c: use skip_prefix() in handle_revision_pseudo_opt()

Instead of starts_with() and a bunch of magic numbers. Signed-off-by: SZEDER Gábor --- revision.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/revision.c b/revision.c index 2b64b7e0e..ab0279572 100644 --- a/revision.c +++

[PATCH 2/3] revision.c: use skip_prefix() in handle_revision_opt()

Instead of starts_with() and a bunch of magic numbers. While at it, there is an indentation fix where processing '--early-output', and a coding style fix where processing '--show-notes'. Signed-off-by: SZEDER Gábor --- revision.c | 54

Re: [PATCH 25/33] notes-merge: convert verify_notes_filepair to struct object_id

On 06/02, Junio C Hamano wrote: > Brandon Williams writes: > > > Signed-off-by: Brandon Williams > > --- > > notes-merge.c | 20 ++-- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/notes-merge.c b/notes-merge.c >

Re: [PATCH 22/33] notes-merge: convert notes_merge* to struct object_id

On 05/31, brian m. carlson wrote: > On Tue, May 30, 2017 at 10:30:58AM -0700, Brandon Williams wrote: > > @@ -596,47 +596,47 @@ int notes_merge(struct notes_merge_options *o, > > /* Find merge bases */ > > bases = get_merge_bases(local, remote); > > if (!bases) { > > -

Re: [PATCH 00/33] object id conversion (grep and diff)

On 06/02, Junio C Hamano wrote: > Junio C Hamano writes: > > > Junio C Hamano writes: > > > >> Brandon Williams writes: > >> > >>> A month or so ago I thought I would lend a hand to Brian and do a round of > >>> conversions from sha1 ->

Re: pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

Jonathan Nieder wrote: > Here's a rough list of some useful tasks, in no particular order: > > 1. bc/object-id: This patch series continues, eliminating assumptions >about the size of object ids by encapsulating them in a struct. >One straightforward way to find code that still needs to

Re: pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

Hi Dscho, Johannes Schindelin wrote: > On Thu, 1 Jun 2017, Stefan Beller wrote: >> We had a discussion off list how much of the test suite is in bad shape, >> and "$ git grep ^index" points out a lot of places as well. > > Maybe we should call out a specific month (or even a longer period)

Re: git-2.13.0: log --date=format:%z not working

Am 02.06.2017 um 05:08 schrieb Jeff King: In theory the solution is: 1. Start using localtime() instead of gmtime() with an adjustment when we are converting to the local timezone (i.e., format-local). We should be able to do this portably. This is easy to do, and it's

Wrong gitattributes documentation?

Hi all, I have noticed a strange behaviour when using git-lfs. If I understood correctly, git-lfs adds patterns to .gitattributes, for which git then calls lfs for any matches with this pattern. The problem is, the documentation[1] says: "The rules how the pattern matches paths are the same

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 4:46 PM, Liam R. Howlett wrote: > * ?var Arnfj?r? Bjarmason [170602 04:53]: >> On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: >> > Martin Ågren writes: >> > >> >> I looked into

Re: [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes

On Fri, Jun 2, 2017 at 6:10 PM, Johannes Schindelin wrote: > Hi, > > On Fri, 2 Jun 2017, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason writes: >> >> > See <20170525200528.22037-1-ava...@gmail.com> for v3 >> >

Re: git-gui ignores core.hooksPath

On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote: > Hi git devs, > > First off, thanks for your awesome work! > > I've been unhappy for quite a while that I had to configure the hooks > manually for each of my repos - until I found out recently that there is > the

Re: [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes

Hi, On Fri, 2 Jun 2017, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > See <20170525200528.22037-1-ava...@gmail.com> for v3 > > (https://public-inbox.org/git/20170525200528.22037-1-ava...@gmail.com/). > > > > This is on top of "[PATCH v4 00/31] Easy to review

Re: Unaligned accesses in sha1dc

* ?var Arnfj?r? Bjarmason [170602 04:53]: > On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: > > Martin Ågren writes: > > > >> I looked into this some more. It turns out it is possible to trigger > >> undefined behavior on

Re: git-gui ignores core.hooksPath

On Fri, Jun 2, 2017 at 9:41 AM, Philipp Gortan wrote: > Hi git devs, > > First off, thanks for your awesome work! > > I've been unhappy for quite a while that I had to configure the hooks > manually for each of my repos - until I found out recently that there is > the

git-gui ignores core.hooksPath

Hi git devs, First off, thanks for your awesome work! I've been unhappy for quite a while that I had to configure the hooks manually for each of my repos - until I found out recently that there is the core.hooksPath config variable that (when set globally) allows me to specify a hooks directory

pushing for a new hash, was Re: [PATCH 2/3] rebase: Add tests for console output

Hi, On Thu, 1 Jun 2017, Stefan Beller wrote: > On Thu, Jun 1, 2017 at 4:40 PM, Junio C Hamano wrote: > > Johannes Schindelin writes: > > > >> Also, about the commit IDs. As long as the tests are consistent (i.e. they > >> use test_commit rather

[GSoC][PATCH v6 1/2] submodule: fix buggy $path and $sm_path variable's value

According to the documentation about git-submodule foreach subcommand's $path variable: $path is the name of the submodule directory relative to the superproject But it was observed when the value of the $path value deviates from this for the nested submodules when the is run from a

[GSoC][PATCH v6 2/2] submodule: port subcommand foreach from shell to C

This aims to make git-submodule foreach a builtin. This is the very first step taken in this direction. Hence, 'foreach' is ported to submodule--helper, and submodule--helper is called from git-submodule.sh. The code is split up to have one function to obtain all the list of submodules. This

[PATCH] perf: work around the tested repo having an index.lock

When the tested repo has an index.lock file it should be removed. This file may be present if e.g. git-status previously crashed in that repo, and it will make a lot of git commands fail. Let's try harder and remove the lock. Signed-off-by: Ævar Arnfjörð Bjarmason ---

[WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

Add a performance test for the new core.fsmonitor facility using the sample query-fsmonitor hook. This is WIP code for the reasons explained in the setup comments, unfortunately the perf code doesn't easily allow you to run different setup code for different versions you're testing. This test

Re: preserve untracked cache, was Re: What's cooking in git.git (Jun 2017, #01; Thu, 1)

Hi Junio, On Fri, 2 Jun 2017, Junio C Hamano wrote: > Samuel Lijin writes: > > >> What is holding this topic up? Anything Ben or I can do to move this > >> closer to `next` or even `master`? > > > > It's in `next` right now (3196d093d6). > > Thanks for pinging and checking

Re: Unaligned accesses in sha1dc

On 2 June 2017 at 10:51, Ævar Arnfjörð Bjarmason wrote: > On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: >> Martin Ågren writes: >> >>> I looked into this some more. It turns out it is possible to trigger >>> undefined behavior

Re: Unaligned accesses in sha1dc

On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: > Martin Ågren writes: > >> I looked into this some more. It turns out it is possible to trigger >> undefined behavior on "next". Here's what I did: >> ... >> >> This "fixes" the problem: >> ... >>

Re: How to avoid "Please tell me who you are..."?

On Fri, Jun 2, 2017 at 9:15 AM, Junio C Hamano wrote: > Jeffrey Walton writes: > >> Is there no switch? Its the most efficient way to accomplish the task. > > This is a safety to help normal human users from hurting themselves, > and it does not make any

Re: [PATCH 00/33] object id conversion (grep and diff)

Junio C Hamano writes: > Junio C Hamano writes: > >> Brandon Williams writes: >> >>> A month or so ago I thought I would lend a hand to Brian and do a round of >>> conversions from sha1 -> struct object_id. Now that Brian's latest

Re: How to avoid "Please tell me who you are..."?

Jeffrey Walton writes: > Is there no switch? Its the most efficient way to accomplish the task. This is a safety to help normal human users from hurting themselves, and it does not make any sense to have "I have no name, so record garbage, please" option, switch or setting

Re: How to avoid "Please tell me who you are..."?

On Fri, Jun 2, 2017 at 3:00 AM, Konstantin Khomoutov wrote: > On Fri, Jun 02, 2017 at 02:02:22AM -0400, Jeffrey Walton wrote: > >> I'm working on a test machine. It mostly needs to be a clone of >> upstream. On occasion it needs to test a particular commit. >> >> When I

Re: How to avoid "Please tell me who you are..."?

On Fri, Jun 02, 2017 at 02:02:22AM -0400, Jeffrey Walton wrote: > I'm working on a test machine. It mostly needs to be a clone of > upstream. On occasion it needs to test a particular commit. > > When I attempt to test a commit it produces: > > $ git cherry-pick eb3b27a6a543 > > ***

What's cooking in git.git (Jun 2017, #02; Fri, 2)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. As much I hate to send a new

Re: How to avoid "Please tell me who you are..."?

On Fri, Jun 2, 2017 at 2:30 AM, Davide Fiorentino wrote: > Is there a reason why you don't want or can't set those details? Well, they don't exist so there's nothing to set. The machine below its a CubieBoard used for testing. I remote into it with test@. As a

How to avoid "Please tell me who you are..."?

I'm working on a test machine. It mostly needs to be a clone of upstream. On occasion it needs to test a particular commit. When I attempt to test a commit it produces: $ git cherry-pick eb3b27a6a543 *** Please tell me who you are. Run git config --global user.email