On Thu, Jun 07, 2018 at 10:53:13PM -0400, Theodore Y. Ts'o wrote:
> The problem is you've left undefined who is "you"? With an open
> source project, anyone who has contributed to open source project has
> a copyright interest. That hobbyist in German who submitted a patch?
> They have a copyrigh
On Thu, Jun 07, 2018 at 04:53:16PM -0700, David Lang wrote:
> the license is granted to the world, so the world has an interest in it.
Certainly, but you need to have overriding legitimate grounds. An
interest is not enough for justification. You have to weight your
interests against those of th
Am 07.06.2018 um 16:12 schrieb g...@jeffhostetler.com:
> From: Jeff Hostetler
>
> Add a series of jw_ routines and "struct json_writer" structure to compose
> JSON data. The resulting string data can then be output by commands wanting
> to support a JSON output format.
>
> The json-writer routi
On Thu, Jun 07, 2018 at 08:15:16PM -0700, Lars Schneider wrote:
> > In fact, this patch probably should give the user some advice in that
> > regard (either in the documentation, or as a warning when we skip the
> > rejection). If you _do_ have a bogus credential and set the new option,
> > you'd
On Tue, Jan 02, 2018 at 09:35:16PM -0800, Jonathan Nieder wrote:
> > bturner@ubuntu:~$ ssh -V
> > OpenSSH_6.6.1p1 Ubuntu-2ubuntu2.8, OpenSSL 1.0.1f 6 Jan 2014
> >
> > bturner@ubuntu:~$ ssh -G -p 7999 localhost
> > unknown option -- G
> > usage: ssh [-1246AaCfgKkMNnqsTtVvXxYy] [-b bind_address] [-c
All these 144 new messages in this round of Git l10n are introduced by
commit f318d73915 (generate-cmds.sh: export all commands to
command-list.h). The updated script `generate-cmds.sh` will export
more commands and one line introductions in file `command-list.h` than
v2.18.0-rc0:
$ git checko
> On 04 Jun 2018, at 11:55, Jeff King wrote:
>
> On Mon, Jun 04, 2018 at 12:18:59PM -0400, Martin-Louis Bright wrote:
>
>> Why must the credentials must be deleted after receiving the 401 (or
>> any) error? What's the rationale for this?
>
> Because Git only tries a single credential per invo
On Fri, Jun 08, 2018 at 01:21:29AM +0200, Peter Backes wrote:
> On Thu, Jun 07, 2018 at 03:38:49PM -0700, David Lang wrote:
> > > Again: The GDPR certainly allows you to keep a proof of copyright
> > > privately if you have it. However, it does not allow you to keep
> > > publishing it if someone e
--
Good day,
i know you do not know me personally but i have checked your profile
and i see generosity in you, There's an urgent offer attach
to your name here in the office of Mr. Fawaz KhE. Al Saleh Member of
the Board of Directors, Kuveyt Türk Participation Bank (Turkey) and
head of pri
Hi,
Git 2.18.0-rc1 has been released, and introduced 36 more messages (144
total) need to be translated. Let's start the 2nd round of l10n for
Git 2.18.0.
The new "git.pot" is generated in commit v2.18.0-rc1:
l10n: git.pot: v2.18.0 round 2 (144 new, 6 removed)
Generate po/git.pot from v
On Thu, May 17, 2018 at 12:46 PM, Stefan Beller wrote:
>>> * sb/diff-color-move-more (2018-04-25) 7 commits
>>...
>>>
>>> Will merge to 'next'.
>>
>>I did not get around to fix it up, there are still review
>>comments outstanding. (The test is broken in the last commit.)
>
> This is a reroll of s
On Fri, 8 Jun 2018, Peter Backes wrote:
On Thu, Jun 07, 2018 at 03:38:49PM -0700, David Lang wrote:
Again: The GDPR certainly allows you to keep a proof of copyright
privately if you have it. However, it does not allow you to keep
publishing it if someone exercises his right to be forgotten.
s
On Thu, Jun 07, 2018 at 03:38:49PM -0700, David Lang wrote:
> > Again: The GDPR certainly allows you to keep a proof of copyright
> > privately if you have it. However, it does not allow you to keep
> > publishing it if someone exercises his right to be forgotten.
> someone is granting the world th
On Fri, 8 Jun 2018, Peter Backes wrote:
On Thu, Jun 07, 2018 at 10:28:47PM +0100, Philip Oakley wrote:
Some of Peter's fine distinctions may be technically valid, but that does
not stop there being legal grounds. The proof of copyright is a legal
grounds.
Again: The GDPR certainly allows you
On Thu, Jun 07, 2018 at 10:28:47PM +0100, Philip Oakley wrote:
> Some of Peter's fine distinctions may be technically valid, but that does
> not stop there being legal grounds. The proof of copyright is a legal
> grounds.
Again: The GDPR certainly allows you to keep a proof of copyright
privately
Hi Peter, David,
I thought that the legal notice (aka 'disclaimer') was pretty reaonable.
Some of Peter's fine distinctions may be technically valid, but that does
not stop there being legal grounds. The proof of copyright is a legal
grounds.
Unfortunately once one gets into legal nitpicking
Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com:
From: Jeff Hostetler
I've been working to add code to Git to optionally collect telemetry data.
The goal is to be able to collect performance data from Git commands and
allow it to be aggregated over a user community to find "slow commands"
On Thu, Jun 07 2018, Matthew Wilcox wrote:
> On Thu, Jun 07, 2018 at 09:09:25PM +0200, Ævar Arnfjörð Bjarmason wrote:
>> On Thu, Jun 07 2018, Matthew Wilcox wrote:
>> > If the first atom of a regex is a bracket expression with an inverted
>> > range,
>> > git grep is very slow.
>>
>> I have som
On Thu, Jun 07, 2018 at 09:09:25PM +0200, Ævar Arnfjörð Bjarmason wrote:
> On Thu, Jun 07 2018, Matthew Wilcox wrote:
> > If the first atom of a regex is a bracket expression with an inverted range,
> > git grep is very slow.
>
> I have some WIP patches to fix all of this, which I'll hopefully sub
On Thu, Jun 07 2018, Matthew Wilcox wrote:
> If the first atom of a regex is a bracket expression with an inverted range,
> git grep is very slow.
>
> $ time git grep 'struct_size' >/dev/null
>
> real 0m0.368s
> user 0m0.563s
> sys 0m0.453s
>
> $ time git grep '[^t]truct_size' >/dev/null
>
>
Add a function to free struct bitmap_index instances, and use it where
needed (except when rebuild_existing_bitmaps() is used, since it creates
references to the bitmaps within the struct bitmap_index passed to it).
Note that the hashes field in struct bitmap_index is not freed because
it points t
This is a continuation of the object store refactoring effort.
We cannot truly free an object store without ensuring that any generated
bitmaps are first freed, so here are patches to drastically reduce the
lifetime of any bitmaps generated. As a bonus, the API is also improved,
and global state r
Remove the bitmap_git global variable. Instead, generate on demand an
instance of struct bitmap_index for code that needs to access it.
This allows us significant control over the lifetime of instances of
struct bitmap_index. In particular, packs can now be closed without
worrying if an unnecessar
On 07/06/18 03:23, Jeff King wrote:
> On Thu, Jun 07, 2018 at 01:16:14AM +0100, Ramsay Jones wrote:
>
>>> Probably. We may want to go the same route as we did for perl in
>>> a0e0ec9f7d (t: provide a perl() function which uses $PERL_PATH,
>>> 2013-10-28) so that test writers don't have to reme
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt
> index dcaeb1a91b..919283fdd8 100644
> --- a/Documentation/git-midx.txt
> +++ b/Documentation/git-midx.txt
> @@ -23,6 +23,11 @@ OPTIONS
> /packs/multi-pack-index fo
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char *object_dir)
> m->num_chunks = *(m->data + 6);
> m->num_packs = get_be32(m->data + 8);
>
> + for (i = 0; i < m->num_chunks; i++) {
> + uint32
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> @@ -114,14 +119,56 @@ int write_midx_file(const char *object_dir)
> midx_name);
> }
>
> + strbuf_addf(&pack_dir, "%s/pack", object_dir);
> + dir = opendir(pack_dir.buf);
> +
> + if (!dir) {
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> As we build the multi-pack-index feature by adding chunks at a time,
> we want to test that the data is being written correctly.
>
> Create struct midxed_git to store an in-memory representation of a
A word play on 'packed_git'? Amusing. Som
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> +static char *get_midx_filename(const char *object_dir)
> +{
> + struct strbuf midx_name = STRBUF_INIT;
> + strbuf_addstr(&midx_name, object_dir);
> + strbuf_addstr(&midx_name, "/pack/multi-pack-index");
> + return str
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> diff --git a/builtin/midx.c b/builtin/midx.c
> index 59ea92178f..dc0a5acd3f 100644
> --- a/builtin/midx.c
> +++ b/builtin/midx.c
> @@ -3,9 +3,10 @@
> #include "config.h"
> #include "git-compat-util.h"
> #include "parse-options.h"
> +#inclu
On Thu, Jun 7, 2018 at 10:12 AM, wrote:
> Add a series of jw_ routines and "struct json_writer" structure to compose
> JSON data. The resulting string data can then be output by commands wanting
> to support a JSON output format.
> [...]
> Signed-off-by: Jeff Hostetler
> ---
> diff --git a/t/t0
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote:
> diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt
> new file mode 100644
> index 00..2bd886f1a2
> --- /dev/null
> +++ b/Documentation/git-midx.txt
> @@ -0,0 +1,29 @@
> +git-midx(1)
> +
> +
> +NAME
> +---
Interactive rebases are implemented in terms of cherry-pick rather than
the merge-recursive builtin, but cherry-pick also calls into the recursive
merge machinery by default and can accept special merge strategies and/or
special strategy options. As such, there really is not any need for
having bo
am-based rebases suffer from an reduced ability to detect directory
renames upstream, which is fundamental to the fact that it throws away
information about the history: in particular, it dispenses with the
original commits involved by turning them into patches, and without the
knowledge of the ori
This series:
* deletes git-rebase--merge, making git-rebase--interactive handle
those cases instead
* adds an --am option to git rebase, and changes the rebase default
from using git-rebase--am to git-rebase--interactive, fixing
directory rename detection for default rebases.
Howe
While 'quiet' and 'interactive' may sound like antonyms, the interactive
machinery actually has logic that implements several
interactive_rebase=implied cases (--exec, --keep-empty, --rebase-merges)
which won't pop up an editor. Further, we want to make the interactive
machinery also take over for
On Thu, Jun 7, 2018 at 10:12 AM, wrote:
> Test json-writer output using perl script.
>
> Signed-off-by: Jeff Hostetler
> ---
> diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl
> @@ -0,0 +1,52 @@
> +#!/usr/bin/perl
> +use strict;
> +use warnings;
> +use JSON;
This new script is goi
On 6/7/2018 10:45 AM, Ævar Arnfjörð Bjarmason wrote:
On Thu, Jun 07 2018, Derrick Stolee wrote:
To test the performance in this situation, I created a
script that organizes the Linux repository in a similar
fashion. I split the commit history into 50 parts by
creating branches on every 10,000 c
If the first atom of a regex is a bracket expression with an inverted range,
git grep is very slow.
$ time git grep 'struct_size' >/dev/null
real0m0.368s
user0m0.563s
sys 0m0.453s
$ time git grep '[^t]truct_size' >/dev/null
real0m31.529s
user1m54.909s
sys 0m0.805s
If
On Thu, Jun 7, 2018 at 9:41 AM, Elijah Newren wrote:
> Subject line: unpack-trees rather than unpack-tress.
>
>
>
> On Wed, Jun 6, 2018 at 9:49 AM, Nguyễn Thái Ngọc Duy
> wrote:
>> Prior to fba92be8f7, this code implicitly (and incorrectly) assumes
>> the_index when running the exclude machinery
On Thu, Jun 7, 2018 at 10:34 AM, Eric Sunshine wrote:
> On Wed, Jun 6, 2018 at 3:16 PM, Duy Nguyen wrote:
>> On Wed, May 30, 2018 at 10:03 AM, Eric Sunshine
>> wrote:
>>> Dscho recently implemented a 'tbdiff' replacement as a Git builtin named
>>> git-branch-diff[1] which computes differences b
From: Jeff Hostetler
I've been working to add code to Git to optionally collect telemetry data.
The goal is to be able to collect performance data from Git commands and
allow it to be aggregated over a user community to find "slow commands".
I'm going to break this up into several parts rather t
From: Jeff Hostetler
Create design documentation to describe the telemetry feature.
Signed-off-by: Jeff Hostetler
---
Documentation/technical/telemetry.txt | 475 ++
1 file changed, 475 insertions(+)
create mode 100644 Documentation/technical/telemetry.txt
dif
On Thu, Jun 07 2018, Derrick Stolee wrote:
> To test the performance in this situation, I created a
> script that organizes the Linux repository in a similar
> fashion. I split the commit history into 50 parts by
> creating branches on every 10,000 commits of the first-
> parent history. Then, `
From: Jeff Hostetler
Add a series of jw_ routines and "struct json_writer" structure to compose
JSON data. The resulting string data can then be output by commands wanting
to support a JSON output format.
The json-writer routines can be used to generate structured data in a
JSON-like format. W
From: Jeff Hostetler
Test json-writer output using perl script.
Signed-off-by: Jeff Hostetler
---
t/t0019-json-writer.sh | 38
t/t0019/parse_json.perl | 52 +
2 files changed, 90 insertions(+)
create mode 10
From: Jeff Hostetler
Here is V8 of my json-writer patches. Please replace the existing V5/V6/V7
version of the jh/json-writer branch with this one.
This version uses perl rather than python to test the generated JSON.
Jeff Hostetler (2):
json_writer: new routines to create data in JSON forma
On 6/7/2018 10:03 AM, Derrick Stolee wrote:
This patch series includes a rewrite of the previous
multi-pack-index RFC [1] using the feedback from the
commit-graph feature.
Sorry to everyone who got a duplicate copy of this series. I misspelled
'kernel.org' and it didn't go to the list.
I als
As we build the multi-pack-index file format, we want to test the format
on real repoasitories. Add tests to t5319-midx.sh that create repository
data including multiple packfiles with both version 1 and version 2
formats.
The current 'git midx write' command will always write the same file
with n
As we build the multi-pack-index feature by adding chunks at a time,
we want to test that the data is being written correctly.
Create struct midxed_git to store an in-memory representation of a
multi-pack-index and a memory-map of the binary file. Initialize this
struct in load_midxed_git(object_d
When constructing a multi-pack-index file for a given object directory,
read the files within the enclosed pack directory and find matches that
end with ".idx" and find the correct paired packfile using
add_packed_git().
Signed-off-by: Derrick Stolee
---
midx.c | 51
Signed-off-by: Derrick Stolee
---
midx.c | 96 --
midx.h | 2 ++
object-store.h | 1 +
packfile.c | 8 -
4 files changed, 104 insertions(+), 3 deletions(-)
diff --git a/midx.c b/midx.c
index 5e9290ca8f..6eca8f1b12 100644
The multi-pack-index (MIDX) feature generalizes the existing pack-
index (IDX) feature by indexing objects across multiple pack-files.
Describe the basic file format, using a 12-byte header followed by
a lookup table for a list of "chunks" which will be described later.
The file ends with a footer
As we begin writing the multi-pack-index format to disk, start with
the basics: the 12-byte header and the 20-byte checksum footer. Start
with these basics so we can add the rest of the format in small
increments.
As we implement the format, we will use a technique to check that our
computed offse
If the multi-pack-index contains a packfile, then we do not need to add
that packfile to the packed_git linked list or the MRU list.
Signed-off-by: Derrick Stolee
---
midx.c | 23 +++
midx.h | 1 +
packfile.c | 7 +++
3 files changed, 31 insertions(+)
diff --gi
The core.midx config setting controls the multi-pack-index (MIDX)
feature. If false, the setting will disable all reads from the
multi-pack-index file.
Add comparison commands in t5319-midx.sh to check typical Git behavior
remains the same as the config setting is turned on and off. This
currently
Signed-off-by: Derrick Stolee
---
midx.c | 68 +-
1 file changed, 63 insertions(+), 5 deletions(-)
diff --git a/midx.c b/midx.c
index 25d8142c2a..388d79b7d9 100644
--- a/midx.c
+++ b/midx.c
@@ -389,6 +389,23 @@ static int midx_oid_compare(c
The final pair of chunks for the multi-pack-index (MIDX) file stores the
object offsets. We default to using 32-bit offsets as in the pack-index
version 1 format, but if there exists an offset larger than 32-bits, we
use a trick similar to the pack-index version 2 format by storing all
offsets at l
Signed-off-by: Derrick Stolee
---
packfile.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/packfile.c b/packfile.c
index 638e113972..059b2aa097 100644
--- a/packfile.c
+++ b/packfile.c
@@ -819,11 +819,14 @@ unsigned long approximate_object_count(void)
{
if (!the
If a 'git repack' command replaces existing packfiles, then we must
clear the existing multi-pack-index before moving the packfiles it
references.
Signed-off-by: Derrick Stolee
---
builtin/repack.c | 8
midx.c | 8
midx.h | 1 +
3 files changed, 17 insertion
Signed-off-by: Derrick Stolee
---
Documentation/technical/pack-format.txt | 5 +++
builtin/midx.c | 4 +-
midx.c | 53 +++--
object-store.h | 1 +
t/t5319-midx.sh | 18
Signed-off-by: Derrick Stolee
---
midx.c | 11
midx.h | 3 +++
packfile.c | 6 +
packfile.h | 1 +
sha1-name.c | 70 +
t/t5319-midx.sh | 3 ++-
6 files changed, 93 insertions(+), 1 deletion(-)
diff -
Signed-off-by: Derrick Stolee
---
midx.c | 2 +-
midx.h | 1 +
packfile.c | 15 +++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/midx.c b/midx.c
index 3242646fe0..e46f392fa4 100644
--- a/midx.c
+++ b/midx.c
@@ -214,7 +214,7 @@ struct object_id *nth_midxed_o
Before writing a list of objects and their offsets to a multi-pack-index
(MIDX), we need to collect the list of objects contained in the
packfiles. There may be multiple copies of some objects, so this list
must be deduplicated.
It is possible to artificially get into a state where there are many
Signed-off-by: Derrick Stolee
---
Documentation/technical/midx.txt | 109 +++
1 file changed, 109 insertions(+)
create mode 100644 Documentation/technical/midx.txt
diff --git a/Documentation/technical/midx.txt b/Documentation/technical/midx.txt
new file mode 100644
i
Signed-off-by: Derrick Stolee
---
Documentation/technical/pack-format.txt | 5 +++
builtin/midx.c | 7
midx.c | 56 +++--
object-store.h | 2 +
t/t5319-midx.sh |
In anticipation of writing multi-pack-indexes (MIDX files), add a
'git midx write' subcommand and send the options to a write_midx_file()
method. Also create a basic test file that tests the 'write' subcommand.
Signed-off-by: Derrick Stolee
---
Documentation/git-midx.txt | 22 +++
Signed-off-by: Derrick Stolee
---
Documentation/technical/pack-format.txt | 4 ++
builtin/midx.c | 2 +
midx.c | 50 +++--
object-store.h | 1 +
t/t5319-midx.sh | 4 +
This patch series includes a rewrite of the previous
multi-pack-index RFC [1] using the feedback from the
commit-graph feature.
I based this series on 'next' as it requires the
recent object-store patches.
The multi-pack-index (MIDX) is explained fully in
the design document 'Documentation/techni
This new 'git midx' builtin will be the plumbing access for writing,
reading, and checking multi-pack-index (MIDX) files. The initial
implementation is a no-op.
Signed-off-by: Derrick Stolee
---
.gitignore | 1 +
Documentation/git-midx.txt | 29 +
Mak
The multi-pack-index (MIDX) needs to track which pack-files are covered
by the MIDX file. Store these in our first required chunk. Since
filenames are not well structured, add padding to keep good alignment in
later chunks.
Modify the 'git midx read' subcommand to output the existence of the
pack-
Signed-off-by: Derrick Stolee
---
midx.c | 22 ++
midx.h | 2 ++
object-store.h | 7 +++
packfile.c | 6 +-
4 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/midx.c b/midx.c
index a49300bf75..5e9290ca8f 100644
--- a/midx.c
+++ b/midx
Bryan
Thank you. I didn't realize that when you set up a remote repository, it is
just a folder. I thought the fact that I had it setup as a website, was going
to handle what I needed.
It wasn't until your email that I realized I had to use some type of client. I
installed Bonobo as the remo
The zsh script expects the bash completion script to be available so
that might be the issue here.
To reproduce this is what I do. First, a sparse checkout:
# mkdir ~/git
# cd ~/git
# git init
# git remote add origin g...@github.com:git/git.git
# git config core.sparseCheckout true
# mkdir .git/in
Randall
Thank you, I tried it but that didn't work either. I did find out what my
issue was. I need some type of client that would be setup to listen for the
requests.
Steve
-Original Message-
From: Randall S. Becker
Sent: Tuesday, June 05, 2018 6:19 PM
To: Heinz, Steve ; git@vger.
On Thu, Jun 7, 2018 at 1:48 AM Jonathan Nieder wrote:
> Whatever
> I try, I end up with one of two results: either it uses zsh's standard
> completion, or it spews a stream of errors about missing functions
> like compgen. What am I doing wrong?
Try adding to the top of your .zshrc:
autoload -U
Use the obvious consensus of hyphenated "remote-tracking branch", and
fix an obvious typo, all in documentation and comments.
Signed-off-by: Robert P. J. Day
---
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index 4a5cc38a6f..ef9d9d28a9 100644
--- a/Documentat
This rewrites append_todo_help() from shell to C. It also incorporates
some parts of initiate_action() and complete_action() that also write
help texts to the todo file.
Two flags are added to rebase--helper.c: one to call
append_todo_help() (`--append-todo-help`), and another one to tell
append_t
This patch rewrites append_todo_help() from shell to C. The C version
covers a bit more than the old shell version. To achieve that, some
parameters were added to rebase--helper.
This is part of the effort to rewrite interactive rebase in C.
Changes since v2:
- Renaming the variable `edit_todo`
On Wed, Jun 6, 2018 at 3:16 PM, Duy Nguyen wrote:
> On Wed, May 30, 2018 at 10:03 AM, Eric Sunshine
> wrote:
>> Dscho recently implemented a 'tbdiff' replacement as a Git builtin named
>> git-branch-diff[1] which computes differences between two versions of a
>> patch series. Such a diff can be
On Wed, Jun 6, 2018 at 9:49 AM, Nguyễn Thái Ngọc Duy wrote:
> v4 fixes some commit messages and killed a couple more the_index
> references after I tried to merge this with 'pu'
Thanks for tackling this. The first 8 patches look good to me other
than the typo I pointed out on patch 4. However,
Subject line: unpack-trees rather than unpack-tress.
On Wed, Jun 6, 2018 at 9:49 AM, Nguyễn Thái Ngọc Duy wrote:
> Prior to fba92be8f7, this code implicitly (and incorrectly) assumes
> the_index when running the exclude machinery. fba92be8f7 helps show
> this problem clearer because unpack-tree
82 matches
Mail list logo