[PATCH v2 02/36] sha1_file: add prepare_external_alt_odb()

2018-03-19 Thread Christian Couder
This new function adds the external odb cache to all the other odbs. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + sha1_file.c | 17 + 2 files changed, 18 insertions(+) diff --git a/cache.h b/cache.h index d06932ed0b..2ac7d63e5c

[PATCH v2 04/36] external-odb: add has_external_odb()

2018-03-19 Thread Christian Couder
This function will be used to check if the external odb mechanism is actually used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 7 +++ external-odb.h | 1 + 2 files changed, 8 insertions(+) diff --git a/external-odb.c b/external-odb.c index 3909

[PATCH v2 07/36] odb-helper: add 'enum odb_helper_type'

2018-03-19 Thread Christian Couder
r of a specific kind by adding a new find_odb_helper() function. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 13 + external-odb.h | 10 ++ odb-helper.h | 3 +++ 3 files changed, 26 insertions(+) diff --git a/external-odb.c b/exter

[PATCH v2 05/36] external-odb: implement external_odb_get_direct

2018-03-19 Thread Christian Couder
This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 1 + odb-helper.c | 13 + odb-helper.h | 3 ++- 4 files chang

[PATCH v2 01/36] Add initial external odb support

2018-03-19 Thread Christian Couder
functions or the external scripts or processes that will manage and provide external git objects. For now only infrastructure to create helpers from the config and to manage a cache for the 'have' command is implemented. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christia

[PATCH v2 06/36] sha1_file: prepare for external odbs

2018-03-19 Thread Christian Couder
split out 'sha1_file_name_alt()' from 'sha1_file_name()' and 'open_sha1_file_alt()' from 'open_sha1_file()', as we will need both of these new functions too. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 8

Re: [PATCH 28/40] pack-objects: don't pack objects in external odbs

2018-03-19 Thread Christian Couder
On Thu, Jan 4, 2018 at 9:54 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > On 1/3/2018 11:33 AM, Christian Couder wrote: >> >> Objects managed by an external ODB should not be put into >> pack files. They should be transfered using other mechanism >>

Re: [PATCH 15/40] external-odb: add script mode support

2018-03-19 Thread Christian Couder
On Thu, Jan 4, 2018 at 8:55 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > On 1/3/2018 11:33 AM, Christian Couder wrote: >> >> diff --git a/odb-helper.c b/odb-helper.c >> index 4b70b287af..c1a3443dc7 100644 >> --- a/odb-helper.c >> +++ b/o

Re: Draft of Git Rev News edition 37

2018-03-18 Thread Christian Couder
On Sun, Mar 18, 2018 at 11:41 PM, Jacob Keller wrote: > > I don't have a good summary yet, but I think a section about the > discussion regarding the new recreate-merges and rebasing merges > that's been on going might be useful? Yeah sure, we would gladly accept a

Draft of Git Rev News edition 37

2018-03-18 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-37.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [GSoC] Scripts to be conversted into builtins

2018-03-17 Thread Christian Couder
On Sat, Mar 17, 2018 at 7:26 PM, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Mar 17 2018, Yash Yadav jotted: > >> Hello, >> >> I am a student going through the GSoC process. >> >> In the project ideas listed there is one idea talking of conversion of >> scripts to builtins. This

Re: [RFC][GSoC] Project proposal: convert interactive rebase to C

2018-03-17 Thread Christian Couder
Hi, On Sat, Mar 17, 2018 at 8:14 PM, Alban Gruin wrote: > > Weeks 3 & 4 — May 18, 2018 – June 11, 2018 > Then, I would start to rewrite git-rebase--interactive, and get rid of git- > rebase--helper. Usually to rewrite a shell script in C, we first rewrite shell functions

Running some tests with -x fails

2018-03-14 Thread Christian Couder
I don't know if this is well known already, but when when I run some tests using -x on master they consistently fail (while they consistently pass without -x). For example: ./t5500-fetch-pack.sh -x gives: # failed 3 among 353 test(s) ./t0008-ignores.sh -x gives: # failed 208 among 394 test(s)

Re: Use of uninitialised value of size 8 in sha1_name.c

2018-02-26 Thread Christian Couder
On Mon, Feb 26, 2018 at 3:06 PM, Derrick Stolee wrote: > > Christian: do you want to submit the patch, or should I put one together? I'd rather have you put one together. Thanks, Christian.

Re: Use of uninitialised value of size 8 in sha1_name.c

2018-02-26 Thread Christian Couder
On Mon, Feb 26, 2018 at 10:53 AM, Jeff King <p...@peff.net> wrote: > On Mon, Feb 26, 2018 at 10:04:22AM +0100, Christian Couder wrote: > >> ==21455== Use of uninitialised value of size 8 >> ==21455==at 0x2D2A73: get_hex_char_from_oid (sha1_name.c:492) >

Use of uninitialised value of size 8 in sha1_name.c

2018-02-26 Thread Christian Couder
Hi Derrick, These days when running: ./t5616-partial-clone.sh --valgrind on master, I get a bunch of: ==21455== Use of uninitialised value of size 8 ==21455==at 0x2D2A73: get_hex_char_from_oid (sha1_name.c:492) ==21455==by 0x2D2AFE: extend_abbrev_len (sha1_name.c:502) ==21455==by

[ANNOUNCE] Git Rev News edition 36

2018-02-21 Thread Christian Couder
Hi everyone, The 36th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/02/21/edition-36/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Draft of Git Rev News edition 36

2018-02-18 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-36.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

GSoC 2018: Git has been accepted as a mentor organization!

2018-02-18 Thread Christian Couder
Hi, Just a quick message to let everyone know that Git has been accepted as a mentor organization for the Google Summer of Code 2018. If anyone wants to mentor or co-mentor, that is still possible. Just let us know so that we can invite you to register on the GSoC web site. Dscho, I just sent

Re: totally confused as to what "git bisect skip" is supposed to do

2018-02-13 Thread Christian Couder
On Tue, Feb 13, 2018 at 1:28 PM, Robert P. J. Day wrote: > > p.s. i suspect i should RTFS to see exactly how git bisect does its > work. You might want to read https://git-scm.com/docs/git-bisect-lk2009.html before reading the source code.

Re: totally confused as to what "git bisect skip" is supposed to do

2018-02-12 Thread Christian Couder
On Mon, Feb 12, 2018 at 11:44 AM, Robert P. J. Day wrote: > On Fri, 9 Feb 2018, Junio C Hamano wrote: > >> "Robert P. J. Day" writes: >> >> > i'm confused ... why, after skipping a good chunk in the interval >> > [v4.13,v4.14], do i still have

Re: "git bisect run make" adequate to locate first unbuildable commit?

2018-02-09 Thread Christian Couder
On Fri, Feb 9, 2018 at 2:20 PM, Robert P. J. Day wrote: > > writing a short tutorial on "git bisect" and, all the details of > special exit code 125 aside, if one wanted to locate the first > unbuildable commit, would it be sufficient to just run? > > $ git bisect run

[PATCH v2 3/3] perf/aggregate: sort JSON fields in output

2018-02-01 Thread Christian Couder
It is much easier to diff the output against a previous one when the fields are sorted. Helped-by: Philip Oakley <philipoak...@iee.org> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The

[PATCH v2 2/3] perf/aggregate: add --reponame option

2018-02-01 Thread Christian Couder
This makes it easier to use the aggregate script on the command line when one wants to get the "environment" fields set in the codespeed output. Previously setting GIT_REPO_NAME was needed for this purpose. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by:

[PATCH v2 1/3] perf/aggregate: add --subsection option

2018-02-01 Thread Christian Couder
This makes it easier to use the aggregate script on the command line, to get results from subsections. Previously setting GIT_PERF_SUBSECTION was needed for this purpose. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.per

Re: Shawn Pearce has died

2018-01-29 Thread Christian Couder
On Mon, Jan 29, 2018 at 6:21 PM, Jeff King wrote: > On Mon, Jan 29, 2018 at 10:33:08AM +0100, Johannes Schindelin wrote: > >> I found these sad news in my timeline today: >> >> https://twitter.com/cdibona/status/957822400518696960 > > Thanks for posting this. Yeah, thanks. > I

Re: [PATCH 2/3] perf/aggregate: add --reponame option

2018-01-28 Thread Christian Couder
On Sun, Jan 28, 2018 at 8:57 PM, Eric Sunshine wrote: > > Not a big deal, but the extra indentation (and noisy diff) could be > avoided like this: > > my $environment; > if ($reponame) { > $environment = $reponame; > } else if (exists ...) { >

[PATCH 2/3] perf/aggregate: add --reponame option

2018-01-28 Thread Christian Couder
This makes it easier to use the aggregate script on the command line when one wants to get the "environment" fields set in the codespeed output. Previously setting GIT_REPO_NAME was needed for this purpose. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/agg

[PATCH 1/3] perf/aggregate: add --subsection option

2018-01-28 Thread Christian Couder
This makes it easier to use the aggregate script on the command line, to get results from subsections. Previously setting GIT_PERF_SUBSECTION was needed for this purpose. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.per

[PATCH 3/3] perf/aggregate: sort JSON fields in output

2018-01-28 Thread Christian Couder
It is much easier to diff the output against a preivous one when the fields are sorted. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl

Re: Please review my code

2018-01-26 Thread Christian Couder
On Fri, Jan 26, 2018 at 11:32 AM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > 2018-01-25 23:22 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная <olyatelezhn...@gmail.com> >> wrote: >>> Plea

Re: Please review my code

2018-01-25 Thread Christian Couder
Hi Olga, On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная wrote: > Hi everyone, > I haven't sent the code by mailing lists because 25 commits (every > commit in separate message) look like a spam. Yeah, so now that you added tests, it might be interesting to see if the

Re: [PATCH] mru: Replace mru.[ch] with list.h implementation

2018-01-19 Thread Christian Couder
On Tue, Jan 16, 2018 at 2:46 AM, Gargi Sharma wrote: > Replace the custom calls to mru.[ch] with calls to list.h. This patch is the > final step in removing the mru API completely and inlining the logic. You might want to say that this provides a significant code reduction

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-19 Thread Christian Couder
On Fri, Jan 19, 2018 at 6:22 PM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > 2018-01-19 20:14 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Thu, Jan 18, 2018 at 7:20 AM, Оля Тележная <olyatelezhn...@gmail.com> >> wrote: >>> And anot

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-19 Thread Christian Couder
On Fri, Jan 19, 2018 at 6:23 PM, Jeff King <p...@peff.net> wrote: > On Fri, Jan 19, 2018 at 06:14:56PM +0100, Christian Couder wrote: > >> > Let's discuss, what behavior we are waiting for >> > when atom seems useless for the command. Die or ignore? >> >>

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-19 Thread Christian Couder
On Thu, Jan 18, 2018 at 7:20 AM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > 2018-01-18 1:39 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Wed, Jan 17, 2018 at 10:43 PM, Jeff King <p...@peff.net> wrote: >>> On Tue, Jan 16, 2018 at

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-19 Thread Christian Couder
On Fri, Jan 19, 2018 at 1:24 PM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > 2018-01-18 17:23 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Thu, Jan 18, 2018 at 12:49 PM, Оля Тележная <olyatelezhn...@gmail.com> >> wrote: >>&

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-18 Thread Christian Couder
On Thu, Jan 18, 2018 at 12:49 PM, Оля Тележная wrote: > 2018-01-18 9:20 GMT+03:00 Оля Тележная : >> >> I think it's important to finish migrating process at first. I mean, >> now we are preparing and collecting everything in ref-filter, but we

[PATCH v3 2/2] sha1_file: improve sha1_file_name() perfs

2018-01-18 Thread Christian Couder
As sha1_file_name() could be performance sensitive, let's make it faster by using strbuf_addstr() and strbuf_addc() instead of strbuf_addf(). Helped-by: Derrick Stolee <sto...@gmail.com> Helped-by: Jeff Hostetler <g...@jeffhostetler.com> Signed-off-by: Christian Couder <chrisc..

[PATCH v3 1/2] sha1_file: remove static strbuf from sha1_file_name()

2018-01-18 Thread Christian Couder
Helped-by: Kevin Daudt <m...@ikke.info> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 8 +++- http-walker.c | 6 -- http.c| 16 ++-- sha1_file.c | 38 +- 4 files changed, 42 insertion

Re: What's cooking in git.git (Jan 2018, #02; Tue, 9)

2018-01-18 Thread Christian Couder
On Wed, Jan 10, 2018 at 11:03 PM, Jeff Hostetler wrote: > > > On 1/10/2018 2:57 PM, Junio C Hamano wrote: >> >> Jeff Hostetler writes: >> >>> On 1/9/2018 6:33 PM, Junio C Hamano wrote: --

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-18 Thread Christian Couder
On Thu, Jan 18, 2018 at 7:22 AM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > 2018-01-18 2:04 GMT+03:00 Christian Couder <christian.cou...@gmail.com>: >> On Wed, Jan 17, 2018 at 10:49 PM, Jeff King <p...@peff.net> wrote: >>> On Tue, Jan 16, 2018 at

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-17 Thread Christian Couder
On Wed, Jan 17, 2018 at 10:49 PM, Jeff King wrote: > On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: > >> >> In other words, I think the endgame is that expand_atom() isn't there at >> >> all, and we're calling the equivalent of format_ref_item() for each >> >> object

Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter

2018-01-17 Thread Christian Couder
On Wed, Jan 17, 2018 at 10:43 PM, Jeff King wrote: > On Tue, Jan 16, 2018 at 09:55:22AM +0300, Оля Тележная wrote: > >> > IOW, the progression I'd expect in a series like this is: >> > >> > 1. Teach ref-filter.c to support everything that cat-file can do. >> > >> > 2. Convert

Re: [PATCH v2 2/2] sha1_file: improve sha1_file_name() perfs

2018-01-17 Thread Christian Couder
On Wed, Jan 17, 2018 at 9:37 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > > On 1/17/2018 12:54 PM, Christian Couder wrote: >> >> As sha1_file_name() could be performance sensitive, let's >> try to make it faster by seeding the initial buffer siz

Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

2018-01-17 Thread Christian Couder
On Tue, Jan 16, 2018 at 8:00 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > > On 1/16/2018 9:01 AM, Derrick Stolee wrote: >> >> On 1/16/2018 2:18 AM, Christian Couder wrote: >>> >>> Using a static buffer in sha1_file_name() is error prone

[PATCH v2 1/2] sha1_file: remove static strbuf from sha1_file_name()

2018-01-17 Thread Christian Couder
Helped-by: Kevin Daudt <m...@ikke.info> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 8 +++- http-walker.c | 6 -- http.c| 16 ++-- sha1_file.c | 38 +- 4 files changed, 42 insertion

[PATCH v2 2/2] sha1_file: improve sha1_file_name() perfs

2018-01-17 Thread Christian Couder
ler <g...@jeffhostetler.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- sha1_file.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sha1_file.c b/sha1_file.c index f66c21b2da..1a94716962 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -323,8 +323

[ANNOUNCE] Git Rev News edition 35

2018-01-17 Thread Christian Couder
Hi everyone, The 35th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/01/17/edition-35/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: GSoC 2018 Org applications. Deadline = January 23, 2018 at 18:00 (CET)

2018-01-17 Thread Christian Couder
On Tue, Jan 16, 2018 at 9:08 PM, Stefan Beller wrote: > > I'll be fine as a co-mentor this year. Great! It looks like you also accepted the invite to be an admin, so we are 3 admins now (Matthieu, you and me), maybe 4 if Dscho joins, so our application is complete. We can

Re: [PATCH 14/40] sha1_file: prepare for external odbs

2018-01-15 Thread Christian Couder
On Thu, Jan 4, 2018 at 7:00 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > > On 1/3/2018 11:33 AM, Christian Couder wrote: >> diff --git a/sha1_file.c b/sha1_file.c >> index 261baf800f..785e8dda03 100644 >> --- a/sha1_file.c >> +++ b/sha1_file

[PATCH] sha1_file: remove static strbuf from sha1_file_name()

2018-01-15 Thread Christian Couder
Using a static buffer in sha1_file_name() is error prone and the performance improvements it gives are not needed in most of the callers. So let's get rid of this static buffer and, if necessary or helpful, let's use one in the caller. --- cache.h | 8 +++- http-walker.c | 6 --

Re: [PATCH 10/40] external-odb: implement external_odb_get_direct

2018-01-15 Thread Christian Couder
On Thu, Jan 4, 2018 at 6:44 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote: > > > On 1/3/2018 11:33 AM, Christian Couder wrote: >> >> This is implemented only in the promisor remote mode >> for now by calling fetch_object(). >> >> Signed-off-

Re: [PATCH 01/40] Add initial external odb support

2018-01-15 Thread Christian Couder
On Thu, Jan 4, 2018 at 8:59 PM, Jeff Hostetler wrote: > >> diff --git a/odb-helper.h b/odb-helper.h >> new file mode 100644 >> index 00..9395e606ce >> --- /dev/null >> +++ b/odb-helper.h >> @@ -0,0 +1,24 @@ >> +#ifndef ODB_HELPER_H >> +#define ODB_HELPER_H >> + >>

Draft of Git Rev News edition 35

2018-01-14 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-35.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: GSoC 2018 Org applications. Deadline = January 23, 2018 at 18:00 (CET)

2018-01-13 Thread Christian Couder
On Mon, Jan 8, 2018 at 12:03 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Fri, Jan 5, 2018 at 12:18 PM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> On Fri, 5 Jan 2018, Matthieu Moy wrote: >> >>> If we go for it, we need:

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-08 Thread Christian Couder
Hi, On Mon, Jan 8, 2018 at 3:45 PM, Yasushi SHOJI wrote: > Hi all, > > Thank you guys for insightful help. I just read the code and now I understand > what you guys are saying. Yeah, I can say the fix is "spot on". > > But, to be honest, it's hard to see why you need

Re: GSoC 2018 Org applications. Deadline = January 23, 2018 at 18:00 (CET)

2018-01-07 Thread Christian Couder
Hi, On Fri, Jan 5, 2018 at 12:18 PM, Johannes Schindelin wrote: > Hi, > > On Fri, 5 Jan 2018, Matthieu Moy wrote: > >> If we go for it, we need: >> >> * Admins >> >> * Potential mentors > > Count me in as a potential mentor. I am ok to be admin and mentor. >> * List

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-06 Thread Christian Couder
Hi Yasushi, On Sat, Jan 6, 2018 at 3:27 PM, Yasushi SHOJI wrote: > best_bisection_sorted() seems to do > > - get the commit list along with the number of elements in the list > - walk the list one by one to check whether a element have TREESAME or not > - if

[PATCH v3 3/7] perf/aggregate: implement codespeed JSON output

2018-01-05 Thread Christian Couder
Git performance evolves over time and releases, let's implement a Codespeed output in "perf/aggregate.perl". Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/pe

[PATCH v3 2/7] perf/aggregate: refactor printing results

2018-01-05 Thread Christian Couder
As we want to implement another kind of output than the current output for the perf test results, let's refactor the existing code that outputs the results in its own print_default_results() function. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.per

[PATCH v3 5/7] perf/run: learn about perf.codespeedOutput

2018-01-05 Thread Christian Couder
Let's make it possible to set in a config file the output format (regular or codespeed) of the perf tests. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 214d

[PATCH v3 0/7] Codespeed perf results

2018-01-05 Thread Christian Couder
perf-run-config patch series: v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@mail.gmail.com/ Christian Couder (7): perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION} perf/

[PATCH v3 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

2018-01-05 Thread Christian Couder
The way we check ENV{GIT_PERF_SUBSECTION} could trigger comparison between undef and "" that may be flagged by use of strict & warnings. Let's fix that. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 7/7] perf/run: read GIT_PERF_REPO_NAME from perf.repoName

2018-01-05 Thread Christian Couder
The GIT_PERF_REPO_NAME env variable is used in the `aggregate.perl` script to set the 'environment' field in the JSON Codespeed output. Let's make it easy to set this variable by setting it in a config file. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 3

Re: Rewrite cat-file.c : need help to find a bug

2018-01-04 Thread Christian Couder
On Thu, Jan 4, 2018 at 11:23 PM, Оля Тележная wrote: > > So for now 2 of my last commits fail, and I am tired of searching for the > error. > I was also trying to leave cat_file_info variable and fill in both new > and old variables and then compare resulting values by

[PATCH 04/40] fsck: introduce promisor objects

2018-01-03 Thread Christian Couder
From: Jonathan Tan Currently, Git does not support repos with very large numbers of objects or repos that wish to minimize manipulation of certain blobs (for example, because they are very large) very well, even if the user operates mostly on part of the repo, because

[PATCH 05/40] fsck: support refs pointing to promisor objects

2018-01-03 Thread Christian Couder
From: Jonathan Tan Teach fsck to not treat refs referring to missing promisor objects as an error when extensions.partialclone is set. For the purposes of warning about no default refs, such refs are still treated as legitimate refs. Signed-off-by: Jonathan Tan

[PATCH 02/40] Add GIT_NO_EXTERNAL_ODB env variable

2018-01-03 Thread Christian Couder
This new environment variable will be used to perform git commands without involving any external odb mechanism. This makes it possible for example to create new blobs that will not be sent to an external odb even if the external odb supports "put_*" instructions. Signed-off-by: Christ

[PATCH 06/40] fsck: support referenced promisor objects

2018-01-03 Thread Christian Couder
From: Jonathan Tan Teach fsck to not treat missing promisor objects indirectly pointed to by refs as an error when extensions.partialclone is set. Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano ---

[PATCH 03/40] external-odb: add has_external_odb()

2018-01-03 Thread Christian Couder
This function will be used to check if the external odb mechanism is actually used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 7 +++ external-odb.h | 1 + 2 files changed, 8 insertions(+) diff --git a/external-odb.c b/external-odb.c index 3909

[PATCH 15/40] external-odb: add script mode support

2018-01-03 Thread Christian Couder
This adds support for the script command mode where an helper script or command is called to retrieve or manage objects. This implements the 'have' and 'get_git_obj' instructions for the script mode. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c

[PATCH 01/40] Add initial external odb support

2018-01-03 Thread Christian Couder
functions or the external scripts or processes that will manage and provide external git objects. For now only infrastructure to create helpers from the config and to manage a cache for the 'have' command is implemented. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christia

[PATCH 16/40] odb-helper: add 'enum odb_helper_type'

2018-01-03 Thread Christian Couder
As there will be different kinds of helpers, let's add an "enum odb_helper_type" to tell between the different kinds. Let's add a field with this type in "struct odb_helper", and set it when reading the config file. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org

[PATCH 07/40] fsck: support promisor objects as CLI argument

2018-01-03 Thread Christian Couder
From: Jonathan Tan Teach fsck to not treat missing promisor objects provided on the CLI as an error when extensions.partialclone is set. Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano --- builtin/fsck.c

[PATCH 17/40] odb-helper: add odb_helper_init() to send 'init' instruction

2018-01-03 Thread Christian Couder
variable in struct odb_helper to store them. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 13 +++- odb-helper.c| 54 + odb-helper.h| 12 +++ t/t0400-external-

[PATCH 14/40] sha1_file: prepare for external odbs

2018-01-03 Thread Christian Couder
split out 'sha1_file_name_alt()' from 'sha1_file_name()' and 'open_sha1_file_alt()' from 'open_sha1_file()', as we will need both of these new functions too. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 8

[PATCH 13/40] gc: do not repack promisor packfiles

2018-01-03 Thread Christian Couder
From: Jonathan Tan Teach gc to stop traversal at promisor objects, and to leave promisor packfiles alone. This has the effect of only repacking non-promisor packfiles, and preserves the distinction between promisor packfiles and non-promisor packfiles. Signed-off-by:

[PATCH 00/40] Promisor remotes and external ODB support

2018-01-03 Thread Christian Couder
://public-inbox.org/git/20171019123030.17338-1-chrisc...@tuxfamily.org/ Ben Peart (1): Add t0450 to test 'get_direct' mechanism Christian Couder (30): Add initial external odb support Add GIT_NO_EXTERNAL_ODB env variable external-odb: add has_external_odb() external-odb: implement

[PATCH 39/40] external-odb: use 'odb=magic' attribute to mark odb blobs

2018-01-03 Thread Christian Couder
To tell which blobs should be sent to the "magic" external odb, let's require that the blobs be marked using the 'odb=magic' attribute. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 25 ++---

[PATCH 20/40] external-odb: accept only blobs for now

2018-01-03 Thread Christian Couder
The mechanism to decide which blobs should be sent to which external object database will be very simple for now. If the external odb helper support any "put_*" instruction all the new blobs will be sent to it. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- ex

[PATCH 22/40] Add t0410 to test external ODB transfer

2018-01-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0410-transfer-e-odb.sh | 144 ++ 1 file changed, 144 insertions(+) create mode 100755 t/t0410-transfer-e-odb.sh diff --git a/t/t0410-transfer-e-odb.sh b/t/t0410-transfer-e-odb.

[PATCH 19/40] external odb: add 'put_raw_obj' support

2018-01-03 Thread Christian Couder
by an odb helper. This is not a great default, but let's leave it to following commits to tweak that. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 2 ++ odb-helper.c | 43 ++- odb-he

[PATCH 10/40] external-odb: implement external_odb_get_direct

2018-01-03 Thread Christian Couder
This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 1 + odb-helper.c | 13 + odb-helper.h | 3 ++- 4 files chang

[PATCH 36/40] Add t0470 to test passing raw objects

2018-01-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0470-read-object-http-e-odb.sh | 109 ++ t/t0470/read-object-plain | 83 + 2 files changed, 192 insertions(+) create mode 100755 t/t0470-read-object-

[PATCH 40/40] Add Documentation/technical/external-odb.txt

2018-01-03 Thread Christian Couder
This describes the external odb mechanism's purpose and how it works. Helped-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/technical/external-odb.txt | 342 +++ 1 file changed, 34

[PATCH 38/40] Add t0480 to test "have" capability and raw objects

2018-01-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0480-read-object-have-http-e-odb.sh | 109 + t/t0480/read-object-plain-have | 103 +++ 2 files changed, 212 insertions(+) create mode 100755 t/t0480-read-

[PATCH 37/40] odb-helper: add have_object_process()

2018-01-03 Thread Christian Couder
This adds the infrastructure to handle 'have' instructions in process mode. The answer from the helper sub-process should be like the output in script mode, that is lines like this: sha1 SPACE size SPACE type NEWLINE Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-he

[PATCH 35/40] odb-helper: add put_object_process()

2018-01-03 Thread Christian Couder
This adds the infrastructure to send objects to a sub-process handling the communication with an external odb. For now we only handle sending raw blobs using the 'put_raw_obj' instruction. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.

[PATCH 34/40] Add t0460 to test passing git objects

2018-01-03 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0460-read-object-git.sh | 28 + t/t0460/read-object-git| 78 ++ 2 files changed, 106 insertions(+) create mode 100755 t/t0460-read-object-git.sh create mode 10

[PATCH 33/40] Add t0450 to test 'get_direct' mechanism

2018-01-03 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0450-read-object.sh | 28 + t/t0450/read-object| 68 +

[PATCH 26/40] lib-httpd: add apache-e-odb.conf

2018-01-03 Thread Christian Couder
This is an apache config file to test external object databases. It uses the upload.sh and list.sh cgi that have been added previously to make apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd/apache-e-odb.conf

[PATCH 31/40] odb-helper: add 'script_mode' to 'struct odb_helper'

2018-01-03 Thread Christian Couder
rs defined using the existing "odb..scriptcommand" are marked with the 'script_mode' field set to 1. Implementation of the different capabilities/instructions in the new (sub-)process mode is left for following commits. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH 23/40] lib-httpd: pass config file to start_httpd()

2018-01-03 Thread Christian Couder
This makes it possible to start an apache web server with different config files. This will be used in a later patch to pass a config file that makes apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh | 6 -- 1 file chan

[PATCH 09/40] introduce fetch-object: fetch one promisor object

2018-01-03 Thread Christian Couder
From: Jonathan Tan Introduce fetch-object, providing the ability to fetch one object from a promisor remote. This uses fetch-pack. To do this, the transport mechanism has been updated with 2 flags, "from-promisor" to indicate that the resulting pack comes from a

[PATCH 11/40] sha1_file: support lazily fetching missing objects

2018-01-03 Thread Christian Couder
From: Jonathan Tan Teach sha1_file to fetch objects from the remote configured in extensions.partialclone whenever an object is requested but missing. The fetching of objects can be suppressed through a global variable. This is used by fsck and index-pack. However, by

[PATCH 28/40] pack-objects: don't pack objects in external odbs

2018-01-03 Thread Christian Couder
Objects managed by an external ODB should not be put into pack files. They should be transfered using other mechanism that can be specific to the external odb. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/pack-objects.c | 4 1 file changed, 4 insertions(+)

[PATCH 30/40] external-odb: add 'get_direct' support

2018-01-03 Thread Christian Couder
me kind of mechanism to "put" objects into an external odb, where the odb helper would access blobs it wants to send to an external odb directly from files, but it would be strange to call that a fault-in mode too. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- e

[PATCH 24/40] lib-httpd: add upload.sh

2018-01-03 Thread Christian Couder
This cgi will be used to upload objects to, or to delete objects from, an apache web server. This way the apache server can work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh| 1 + t/lib-httpd/upload.s

[PATCH 25/40] lib-httpd: add list.sh

2018-01-03 Thread Christian Couder
This cgi script can list Git objects that have been uploaded as files to an apache web server. This script can also retrieve the content of each of these files. This will help make apache work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> ---

<    1   2   3   4   5   6   7   8   9   10   >