Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

> On 02 Nov 2016, at 19:17, Jeff King wrote: > > This avoids us fooling around with $SHELL_PATH and the > executable bit ourselves. > > Signed-off-by: Jeff King > --- > t/t0021-conversion.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff

Re: [PATCH v5 08/27] sequencer: completely revamp the "todo" script parsing

> On 21 Oct 2016, at 14:24, Johannes Schindelin > wrote: > > When we came up with the "sequencer" idea, we really wanted to have > kind of a plumbing equivalent of the interactive rebase. Hence the > choice of words: the "todo" script, a "pick", etc. > > ... > >

Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)

> On 2 Nov 2016, at 17:43, Johannes Sixt wrote: > > Am 02.11.2016 um 18:04 schrieb Torsten Bögershausen: >>> * ls/filter-process (2016-10-17) 14 commits >>> (merged to 'next' on 2016-10-19 at ffd0de042c) >> >> Some (late, as I recently got a new battery for the Mac OS 10.6 test

Re: [PATCH v11 13/14] convert: add filter..process option

> On 2 Nov 2016, at 18:03, Johannes Sixt wrote: > >> Am 17.10.2016 um 01:20 schrieb larsxschnei...@gmail.com: >> +# Compare two files and ensure that `clean` and `smudge` respectively are >> +# called at least once if specified in the `expect` file. The actual >> +# invocation

Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)

On 2 Nov 2016, at 17:04, Torsten Bögershausen wrote: >> * ls/filter-process (2016-10-17) 14 commits >> (merged to 'next' on 2016-10-19 at ffd0de042c) > > Some (late, as I recently got a new battery for the Mac OS 10.6 test system) > comments: > t0021 failes here: > > > Can't

Re: [PATCH v3 0/3] quick reroll of Lars's git_open() w/ O_CLOEXEC

> On 25 Oct 2016, at 20:16, Junio C Hamano wrote: > > Here is to make sure everybody is on the same page regarding the > series. The patches are adjusted for comments from Eric and Dscho. Thank you, Junio! Your v3 looks good to me and I compiled and tested it on Windows.

Re: [PATCH v2 2/2] read-cache: make sure file handles are not inherited by child processes

> On 24 Oct 2016, at 21:22, Johannes Sixt <j...@kdbg.org> wrote: > > Am 24.10.2016 um 20:03 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> This fixes "convert: add filter..process option" (edcc8581) o

Re: [PATCH 0/3] fix travis TAP/--verbose conflict

> On 21 Oct 2016, at 12:41, Jeff King wrote: > > On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote: > >> The obvious fix would be to send "--verbose" output to stderr, but I >> suspect that would end up annoying for people who do: >> >> ./t5547-push-quarantine.sh -v |

Re: What's cooking in git.git (Oct 2016, #05; Thu, 20)

> On 21 Oct 2016, at 06:08, Johannes Schindelin > wrote: > > Hi Junio & Lars, > > On Thu, 20 Oct 2016, Junio C Hamano wrote: > >> * ls/filter-process (2016-10-17) 14 commits >> (merged to 'next' on 2016-10-19 at ffd0de042c) >> + contrib/long-running-filter: add

Prove "Tests out of sequence" Error

Hi, on TravisCI I see these weird "Tests out of sequence" errors with prove and they seem to not go away. I assume the reason that they not go away is that the ".prove" file is carried over from on build to another (but I can't look into this file on TravisCI). Has anyone an idea where these

Re: What's cooking in git.git (Oct 2016, #04; Mon, 17)

> On 17 Oct 2016, at 15:28, Junio C Hamano wrote: > ... > > * ls/filter-process (2016-10-17) 14 commits > - contrib/long-running-filter: add long running filter example > - convert: add filter..process option > - convert: prepare filter..process option > - convert: make

[RFC] Case insensitive Git attributes

Hi, Git attributes for path names are generally case sensitive. However, on a case insensitive file system (e.g. macOS/Windows) they appear to be case insensitive (`*.bar` would match `foo.bar` and `foo.BAR`). That works great until a Git users joins the party with a case sensitive file

Re: [PATCH v10 13/14] convert: add filter..process option

> On 11 Oct 2016, at 03:09, Torsten Bögershausen <tbo...@web.de> wrote: > > On Tue, Oct 11, 2016 at 10:11:22AM +0200, Lars Schneider wrote: >> >>> On 10 Oct 2016, at 21:58, Junio C Hamano <gits...@pobox.com> wrote: >

Re: [PATCH v10 04/14] run-command: add clean_on_exit_handler

> On 16 Oct 2016, at 01:03, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Lars, > > On Sat, 15 Oct 2016, Lars Schneider wrote: > >> >>> On 11 Oct 2016, at 05:12, Johannes Schindelin <johannes.schinde...@gmx.de> >>>

Re: [PATCH] convert: mark a file-local symbol static

> On 15 Oct 2016, at 14:01, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > > On 15/10/16 16:05, Lars Schneider wrote: >>> On 11 Oct 2016, at 16:46, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > [snip] >>> -void stop_multi_file_f

Re: [PATCH] convert: mark a file-local symbol static

> On 11 Oct 2016, at 16:46, Ramsay Jones wrote: > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into commit 85290197 > ("convert: add filter..process option", 08-10-2016). > > > -void stop_multi_file_filter(struct

Re: [PATCH v10 04/14] run-command: add clean_on_exit_handler

> On 11 Oct 2016, at 05:12, Johannes Schindelin > wrote: > > Hi Lars, > > On Sat, 8 Oct 2016, larsxschnei...@gmail.com wrote: > >> @@ -31,6 +32,15 @@ static void cleanup_children(int sig, int in_signal) >> while (children_to_clean) { >> struct

Re: [PATCH v10 14/14] contrib/long-running-filter: add long running filter example

> On 08 Oct 2016, at 22:42, Torsten Bögershausen <tbo...@web.de> wrote: > > On 08.10.16 13:25, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Add a simple pass-thru filter as example implementation for th

Re: [PATCH v10 13/14] convert: add filter..process option

@Peff: If you have time, it would be great if you could comment on one question below prefixed with "@Peff". Thanks! > On 12 Oct 2016, at 03:54, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 12.10.2016 o 00:26, Lars Schneider pisze: >>> On 09 Oct 2

Re: [PATCH v10 13/14] convert: add filter..process option

> On 09 Oct 2016, at 01:06, Jakub Narębski <jna...@gmail.com> wrote: > > Part 1 of review, starting with the protocol v2 itself. > > W dniu 08.10.2016 o 13:25, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >

Re: [PATCH v10 13/14] convert: add filter..process option

> On 09 Oct 2016, at 07:32, Torsten Bögershausen wrote: > > On 09.10.16 01:06, Jakub Narębski wrote: >>> + +packet: git< status=abort +packet: git< + + +After the filter has processed

Re: [PATCH v10 13/14] convert: add filter..process option

> On 10 Oct 2016, at 21:58, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > > [...] >> +# Count unique lines except clean invocations in two files and compare >> +# them. Clean invocations are not counted because their number can vary. >> +# c.f. >>

Re: [PATCH v8 11/11] convert: add filter..process option

> On 04 Oct 2016, at 23:00, Jakub Narębski <jna...@gmail.com> wrote: > > [Some of answers and comments may got invalidated by v9] > > W dniu 30.09.2016 o 21:38, Lars Schneider pisze: >>> On 27 Sep 2016, at 17:37, Jakub Narębski <jna...@gmail.com> wrote: >

Re: [PATCH v8 11/11] convert: add filter..process option

> On 04 Oct 2016, at 22:50, Jakub Narębski <jna...@gmail.com> wrote: > > [Some of answers may get invalidated by v9] > > W dniu 30.09.2016 o 20:56, Lars Schneider pisze: >>> On 27 Sep 2016, at 00:41, Jakub Narębski <jna...@gmail.com> wrote: >>>

Re: [PATCH v8 00/11] Git filter protocol

> On 04 Oct 2016, at 21:04, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 03.10.2016 o 19:13, Lars Schneider pisze: >>> On 01 Oct 2016, at 22:48, Jakub Narębski <jna...@gmail.com> wrote: >>> W dniu 01.10.2016 o 20:59, Lars Schneider pisze: >&g

Re: [PATCH v9 04/14] run-command: add wait_on_exit

> On 06 Oct 2016, at 11:32, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Junio & Lars, > > On Wed, 5 Oct 2016, Junio C Hamano wrote: > >> Lars Schneider <larsxschnei...@gmail.com> writes: >> >>> OK. Something like

Re: [PATCH v9 04/14] run-command: add wait_on_exit

> On 04 Oct 2016, at 21:30, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The flag 'clean_on_exit' kills child processes spawned by Git on exit. >> A

Re: [PATCH v9 09/14] pkt-line: add packet_write_gently()

> On 04 Oct 2016, at 21:33, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> >> +static int packet_write_gently(const int fd_out, const char

Re: [PATCH v9 10/14] pkt-line: add functions to read/write flush terminated packet streams

> On 04 Oct 2016, at 21:53, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> > >> +int write_packetized_from_buf(const char *src_in, size_t l

Re: What's cooking in git.git (Oct 2016, #01; Mon, 3)

> On 04 Oct 2016, at 00:31, Junio C Hamano wrote: > > > * ls/filter-process (2016-09-23) 11 commits > - convert: add filter..process option > - convert: make apply_filter() adhere to standard Git error handling > - convert: modernize tests > - convert: quote filter names in

Merge conflicts in .gitattributes can cause trouble

Hi, If there is a conflict in the .gitattributes during a merge then it looks like as if the attributes are not applied (which kind of makes sense as Git would not know what to do). As a result Git can treat e.g. binary files as text and they can end up with changed line endings in the

Re: [PATCH v8 00/11] Git filter protocol

> On 03 Oct 2016, at 19:02, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If the filter process refuses to die forever when Git told it to >>> shutdown (by closing the pipe to it, for example), t

Re: [PATCH v8 00/11] Git filter protocol

> On 01 Oct 2016, at 22:48, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 01.10.2016 o 20:59, Lars Schneider pisze: >> On 29 Sep 2016, at 23:27, Junio C Hamano <gits...@pobox.com> wrote: >>> Lars Schneider <larsxschnei...@gmail.com> writes: >

Re: [PATCH v8 00/11] Git filter protocol

> On 29 Sep 2016, at 23:27, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> We discussed that issue in v4 and v6: >> http://public-inbox.org/git/20160803225313.pk3tfe5ovz4y3...@sigill.intra.peff

Re: [PATCH v8 11/11] convert: add filter..process option

> On 29 Sep 2016, at 01:14, Jakub Narębski wrote: > > Part third (and last) of the review of v8 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com napisał: > > >> @@ -31,7 +31,10 @@ test_expect_success setup ' >> cat test >test.i && >> git add test

Re: [PATCH v8 11/11] convert: add filter..process option

> On 27 Sep 2016, at 17:37, Jakub Narębski wrote: > > Part second of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> + >> +if (!drv->process && (CAP_CLEAN & wanted_capability) && drv->clean) > > This is just a very minor

Re: [PATCH v8 11/11] convert: add filter..process option

> On 27 Sep 2016, at 00:41, Jakub Narębski <jna...@gmail.com> wrote: > > Part first of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> diff --git a/Docume

Re: [PATCH v8 00/11] Git filter protocol

> On 29 Sep 2016, at 18:57, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >>> 1) Git exits >>> 2) The filter process receives EOF and prints "STOP" to the log >>> 3) t0021 checks the content of the log >>> >>> Sometimes 3 happened before 2 which

Re: [PATCH v8 00/11] Git filter protocol

> On 29 Sep 2016, at 18:57, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >>> 1) Git exits >>> 2) The filter process receives EOF and prints "STOP" to the log >>> 3) t0021 checks the content of the log >>> >>> Sometimes 3 happened before 2 which

Re: [PATCH v8 00/11] Git filter protocol

> On 28 Sep 2016, at 23:49, Junio C Hamano wrote: > > I suspect that you are preparing a reroll already, but the one that > is sitting in 'pu' seems to be flaky in t/t0021 and I seem to see > occasional failures from it. > > I didn't trace where the test goes wrong, but one

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

> On 27 Sep 2016, at 11:00, Jeff King <p...@peff.net> wrote: > > On Tue, Sep 27, 2016 at 10:14:16AM +0200, Lars Schneider wrote: > >>>>> + strbuf_grow(sb_out, PKTLINE_DATA_MAXLEN+1); >>>>> + paket_len = packet_read(fd_in, NULL, NU

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

On 26 Sep 2016, at 22:23, Lars Schneider <larsxschnei...@gmail.com> wrote: > > On 25 Sep 2016, at 15:46, Jakub Narębski <jna...@gmail.com> wrote: > >> W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >>> From: Lars

Re: [PATCH v8 07/11] pkt-line: add functions to read/write flush terminated packet streams

On 25 Sep 2016, at 15:46, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> +{ >> +static char buf[PKTLINE_DATA_MAXLEN]; > > Sidenote: we have L

Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

On 25 Sep 2016, at 13:26, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> ... >> >> +static int packet_write_gently(const int fd_out, const char *

Re: [PATCH v8 02/11] pkt-line: extract set_packet_header()

On 24 Sep 2016, at 23:22, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Subject: [PATCH v8 02/11] pkt-line: extract set_packet_header()

Re: [PATCH v8 01/11] pkt-line: rename packet_write() to packet_write_fmt()

On 24 Sep 2016, at 23:14, Jakub Narębski <jna...@gmail.com> wrote: > Hello Lars, > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write() should be called packet_

Re: [PATCH v8 03/11] run-command: move check_pipe() from write_or_die to run_command

> On 25 Sep 2016, at 00:12, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Move check_pipe() to run_command and make it public. This is nec

Re: [PATCH] run-command: async_exit no longer needs to be public

> On 23 Sep 2016, at 19:13, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If you need to re-roll your 'ls/filter-process' branch, could you please >>> squash this into the relevant commit c4

Re: [PATCH] run-command: async_exit no longer needs to be public

> On 22 Sep 2016, at 18:56, Ramsay Jones wrote: > > > Signed-off-by: Ramsay Jones > --- > > Hi Lars, > > If you need to re-roll your 'ls/filter-process' branch, could you please > squash this into the relevant commit c42a4cbc

Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it

> On 21 Sep 2016, at 18:42, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 21 Sep 2016, at 11:31, stefan.na...@atlas-elektronik.com wrote: >>> >>> In the Subject: s/the // >>>

Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it

> On 21 Sep 2016, at 11:31, stefan.na...@atlas-elektronik.com wrote: > > In the Subject: s/the // > > Am 21.09.2016 um 10:45 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The TravisCI macOS build is broken bec

Re: [PATCH v2 1/1] git-p4: Add --checkpoint-period option to sync/clone

> On 15 Sep 2016, at 23:17, Ori Rawlings wrote: > > Importing a long history from Perforce into git using the git-p4 tool > can be especially challenging. The `git p4 clone` operation is based > on an all-or-nothing transactionality guarantee. Under real-world >

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

> On 15 Sep 2016, at 21:44, Jeff King <p...@peff.net> wrote: > > On Thu, Sep 15, 2016 at 05:42:58PM +0100, Lars Schneider wrote: > >>>>>> +int packet_flush_gently(int fd) >>>>>> +{ >>>>>> +packet_tr

Re: [PATCH v7 10/10] convert: add filter..process option

> On 13 Sep 2016, at 17:22, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> diff --git a/contrib/long-running-filter/example.pl >> b/contrib/long-running-filter/example.pl >> ... >> +sub packet_read { >> +my $buffer; >> +my $bytes_read = read STDIN,

Re: [PATCH v7 10/10] convert: add filter..process option

> On 13 Sep 2016, at 17:42, Junio C Hamano wrote: > > Torsten Bögershausen writes: > >> I would really consider to treat pathnames as binary, and not add a trailing >> '\n', >> are there other opinions ? > > It would be the most consistent if the same

Re: [PATCH] pkt-line: mark a file-local symbol static

> On 14 Sep 2016, at 14:31, Ramsay Jones wrote: > > > Signed-off-by: Ramsay Jones > --- > > Hi Lars, > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into the relevant patch; commit 2afd9b22

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

> On 13 Sep 2016, at 23:44, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 13 Sep 2016, at 00:30, Junio C Hamano <gits...@pobox.com> wrote: >>> >>> larsxschnei...@gmai

Re: [PATCH v7 04/10] pkt-line: add packet_flush_gently()

> On 13 Sep 2016, at 00:30, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_flush() would die in case of a write error even though for some &g

Re: [PATCH v7 10/10] convert: add filter..process option

> On 10 Sep 2016, at 17:40, Torsten Bögershausen wrote: > > [] > > One general question up here, more comments inline. > The current order for a clean-filter is like this, I removed the error > handling: > > int convert_to_git() > { > ret |= apply_filter(path, src, len,

Re: [ANNOUNCE] Git User's Survey 2016

> On 13 Sep 2016, at 17:54, Jakub Narębski wrote: > > On 13 September 2016 at 18:15, David Bainbridge > wrote: >> Hi Jakub, >> >> You said: >> P.S. At request I can open a separate channel in survey, with >> a separate survey URL, so that

Re: Git Miniconference at Plumbers

> On 12 Sep 2016, at 21:11, Junio C Hamano wrote: > > [..] > properly; supporting "huge objects" better in the object layer, > without having to resort to ugly hacks like GitLFS that will never > be part of the core Git. [...] I agree with you that GitLFS is an ugly hack.

Re: [PATCH v7 10/10] convert: add filter..process option

> On 10 Sep 2016, at 08:29, Torsten Bögershausen wrote: > > On Thu, Sep 08, 2016 at 08:21:32PM +0200, larsxschnei...@gmail.com wrote: > [] >> +packet: git> git-filter-client >> +packet: git> version=2 >> +packet: git> version=42 >> +packet:

Re: [PATCH v7 03/10] pkt-line: add packet_write_fmt_gently()

> On 11 Sep 2016, at 18:01, Stefan Beller <sbel...@google.com> wrote: > > On Sun, Sep 11, 2016 at 4:36 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: > >>> >>> call check_pipe from write_or_die here instead of >>> reproducin

Re: [PATCH v7 08/10] convert: modernize tests

> On 09 Sep 2016, at 00:05, Stefan Beller <sbel...@google.com> wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Use `test_config` to set the config, check tha

Re: [PATCH v7 06/10] pkt-line: add functions to read/write flush terminated packet streams

> On 08 Sep 2016, at 23:49, Stefan Beller <sbel...@google.com> wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> write_packetized_from_fd() and write_packetized

Re: [PATCH v7 05/10] pkt-line: add packet_write_gently()

> On 08 Sep 2016, at 23:24, Stefan Beller wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, wrote: > >> >> Add packet_write_gently() which writes arbitrary data and returns `0` >> for success and `-1` for an error. > > I think documenting the return

Re: [PATCH v7 03/10] pkt-line: add packet_write_fmt_gently()

> On 08 Sep 2016, at 23:18, Stefan Beller wrote: > > On Thu, Sep 8, 2016 at 11:21 AM, wrote: > >> +static int packet_write_fmt_1(int fd, int gently, >> + const char *fmt, va_list args) >> +{ >> + struct strbuf

Re: [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes

> On 07 Sep 2016, at 20:23, Junio C Hamano wrote: > > Eric Wong writes: > >> We probably should be using O_NOATIME for all O_RDONLY cases >> to get the last bit of performance out (especially since >> non-modern-Linux systems probably still lack relatime). >

Re: [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes

> On 06 Sep 2016, at 23:06, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: >> static int ce_compare_data(const struct cache_entry *ce, struct stat *st) >> { >> int match = -1; >> -int fd = open(ce->name, O_RDONLY); >> +int fd = open(ce->name, O_RDONLY |

Re: [PATCH v1 1/2] sha1_file: open window into packfiles with CLOEXEC

> On 06 Sep 2016, at 13:38, Johannes Schindelin > wrote: > > Hi Eric & Lars, > > On Mon, 5 Sep 2016, Eric Wong wrote: > >> larsxschnei...@gmail.com wrote: >>> All processes that the Git main process spawns inherit the open file >>> descriptors of the main process.

Re: [PATCH v6 12/13] convert: add filter..process option

> On 30 Aug 2016, at 22:46, Jakub Narębski wrote: > >>> The filter can exit right after the "error-all". If the filter does >>> not exit then Git will kill the filter. I'll add this to the docs. >> >> OK. > > Is it explicit kill, or implicit kill: close pipe and end process?

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 21:45, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> I see. Thanks for the explanation. > > I expect the updated log message to explain the issue correctly > then. Sure! &g

Re: [PATCH v6 10/13] convert: generate large test files only once

> On 29 Aug 2016, at 19:52, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 25 Aug 2016, at 21:17, Stefan Beller <sbel...@google.com> wrote: >>> >>>> On Thu, Aug 25, 2016 at

Re: [PATCH v6 10/13] convert: generate large test files only once

> On 29 Aug 2016, at 19:46, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh >> index 7b45136..34c8eb9 100755 >> --- a/t/t0021-conversion.sh >> +++ b/t/t0021-conversion.sh >> @@ -4,6 +4,15 @@

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 20:05, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Consider the case of a file that requires filtering and is present in >> branch

Re: [PATCH v6 00/13] Git filter protocol

> On 25 Aug 2016, at 13:07, larsxschnei...@gmail.com wrote: > > From: Lars Schneider <larsxschnei...@gmail.com> > > The goal of this series is to avoid launching a new clean/smudge filter > process for each file that is filtered. > > A short summary about v1 to

Re: [PATCH v6 09/13] convert: modernize tests

> On 26 Aug 2016, at 22:03, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Use `test_config` to set the config, check that files are empty with >> `t

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

> On 26 Aug 2016, at 19:21, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> OK, what function names would be more clear from your point of view? >> >> write_packetized_stream_fro

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

> On 26 Aug 2016, at 19:15, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> Do you anticipate future need of non-gently variant of this >>> function? If so, perhaps a helper that takes a boolea

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

> On 26 Aug 2016, at 00:27, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_stream_with_flush_from_fd() and >> packet_write_stream_with

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

> On 25 Aug 2016, at 23:50, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_fmt() has two shortcomings. First, it uses format_packet() >> whi

Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()

> On 25 Aug 2016, at 23:41, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_fmt() would die in case of a write error even though for >>

Re: [PATCH v6 06/13] pkt-line: add functions to read/write flush terminated packet streams

> On 25 Aug 2016, at 20:46, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write_stream_with_flush_from_fd() and &g

Re: [PATCH v6 10/13] convert: generate large test files only once

> On 25 Aug 2016, at 21:17, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Generate more interesting large test files &g

Re: [PATCH v6 07/13] pack-protocol: fix maximum pkt-line size

> On 25 Aug 2016, at 20:59, Stefan Beller <sbel...@google.com> wrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> According to LARGE_PACKET_MAX in pkt-line.h the

Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()

On 25 Aug 2016, at 20:12, Stefan Beller wrote: >> +int packet_write_fmt_gently(int fd, const char *fmt, ...) >> +{ >> + static struct strbuf buf = STRBUF_INIT; >> + va_list args; >> + >> + strbuf_reset(); >> + va_start(args, fmt); >> +

Re: [PATCH 1/3] diff-highlight: add some tests.

> On 16 Aug 2016, at 22:48, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 30 Jul 2016, at 17:11, Brian Henderson <henderson...@gmail.com> wrote: >>> >>> --- >>> contrib

Re: [PATCH 2/2] mingw: ensure temporary file handles are not inherited by child processes

> On 17 Aug 2016, at 14:41, Johannes Schindelin > wrote: > > From: Ben Wijen > > When the index is locked and child processes inherit the handle to > said lock and the parent process wants to remove the lock before the > child process exits, on

Re: [PATCH 1/3] diff-highlight: add some tests.

> On 30 Jul 2016, at 17:11, Brian Henderson wrote: > > --- > contrib/diff-highlight/Makefile | 5 ++ > contrib/diff-highlight/t/Makefile| 19 +++ > contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ >

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 19:13, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If we do the success first and then error out halfway, we >>> still have to clean up, so I do not see how this impac

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 19:07, Stefan Beller <sbel...@google.com> wrote: > > On Fri, Aug 12, 2016 at 9:59 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >> The welcome message is necessary to distinguish the long running >> filter protocol (v2)

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 18:48, Stefan Beller wrote: > > On Fri, Aug 12, 2016 at 9:38 AM, Jeff King wrote: >> On Fri, Aug 12, 2016 at 09:33:18AM -0700, Stefan Beller wrote: >> If the result content is empty then the filter is expected to respond with a

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 18:33, Stefan Beller <sbel...@google.com> wrote: > > On Wed, Aug 10, 2016 at 6:04 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an ext

Re: `git stash --help` tries to pull up nonexistent file gitstack.html

> On 12 Aug 2016, at 17:48, Junio C Hamano wrote: > > Joseph Musser writes: > >> Looks like a simple typo. > > Unfortunately this does not reproduce to me (built from source on > Ubuntu Linux). I tried it with the latest released version on Windows and OSX

Re: [PATCH v5 05/15] pkt-line: add packet_write_gently_fmt()

> On 10 Aug 2016, at 15:43, Jeff King wrote: > > On Wed, Aug 10, 2016 at 03:04:01PM +0200, larsxschnei...@gmail.com wrote: > >> +int packet_write_gently_fmt(int fd, const char *fmt, ...) >> +{ >> +static struct strbuf buf = STRBUF_INIT; >> +va_list args; >> + >> +

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

> On 10 Aug 2016, at 15:37, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:29:26PM +0200, Lars Schneider wrote: > >> >>> On 10 Aug 2016, at 15:15, Jeff King <p...@peff.net> wrote: >>> >>> On Wed, Aug 10, 2016 at 03:03:5

Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

> On 10 Aug 2016, at 15:13, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:03:58PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The packet_trace() call is not ideal in format_

Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()

> On 10 Aug 2016, at 15:28, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:04:00PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write() has two shortcomings. First, it use

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

> On 10 Aug 2016, at 15:15, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> format_packet() dies if the caller wants to forma

Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()

> On 10 Aug 2016, at 20:21, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 10 Aug 2016, at 19:17, Junio C Hamano <gits...@pobox.com> wrote: >>> >> OK. Does this mean I can leave

<    2   3   4   5   6   7   8   9   10   11   >