Re: [msysGit] [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

2015-04-24 Thread Johannes Schindelin
Hi Rupert, On 2015-04-23 21:25, rupert thurner wrote: On Thursday, April 16, 2015 at 2:45:11 PM UTC+2, Johannes Schindelin wrote: However, using this code for `getppid()` would be serious overkill (not to mention an unbearable performance hit because you have to enumerate *all* processes to

Re: [PATCH 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread Johannes Schindelin
Hi Peff, On 2015-04-23 17:53, Jeff King wrote: What about plink-0.83 that was mentioned earlier in the thread? I was working a lot with Java projects where the base name is often considered to be the part before a version number that is encoded into the file name, so I think it would be a

Re: [PATCH 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread Johannes Schindelin
Hi Brian, On 2015-04-24 01:14, brian m. carlson wrote: On Thu, Apr 23, 2015 at 11:53:04AM -0400, Jeff King wrote: If I were writing from scratch, I would probably keep things as tight as possible, like: const char *base = basename(ssh); plink = !strcasecmp(base, plink) ||

Re: About git log

2015-04-24 Thread Kevin Daudt
On Mon, Apr 06, 2015 at 10:21:37PM +0800, niu2x wrote: I'm a beginner. Please tell me the log of git commit is exist forever or 90 days As long as a commit is (indirectly) referenced by a branch or tag, it will be kept forever. Only if you rewrite history causing commits to be unreferenced (for

[PATCH 3/5] write_ref_sha1(): inline function at callers

2015-04-24 Thread Michael Haggerty
Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/refs.c b/refs.c index 9b68aec..a55d541 100644 --- a/refs.c +++ b/refs.c @@ -2770,8 +2770,10 @@ static int

[PATCH 5/5] ref_transaction_commit(): only keep one lockfile open at a time

2015-04-24 Thread Michael Haggerty
The old code locked all of the references in the first loop, leaving all of the lockfiles open until later loops. Since we might be updating a lot of references, this could cause file descriptor exhaustion. But there is no reason to keep the lockfiles open after the first loop: * For references

[PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Michael Haggerty
In ref_transaction_commit(), close the reference lockfiles immediately to avoid keeping too many file descriptors open at a time. This is pretty easy, because in the first loop (where we create the locks) we already know what, if anything, has to be written into the lockfile. So write it and close

[PATCH 1/5] write_ref_to_lockfile(): new function, extracted from write_ref_sha1()

2015-04-24 Thread Michael Haggerty
This is the first step towards separating the checking and writing of the new reference value to committing the change. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/refs.c b/refs.c index

[PATCH 2/5] commit_ref_update(): new function, extracted from write_ref_sha1()

2015-04-24 Thread Michael Haggerty
Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/refs.c b/refs.c index 72dae21..9b68aec 100644 --- a/refs.c +++ b/refs.c @@ -3052,16 +3052,9 @@ static int write_ref_to_lockfile(struct

[PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Michael Haggerty
Instead, work directly with update-flags. This has the advantage that the REF_DELETING bit, set in the first loop, can be read in the third loop instead of having to compute the same expression again. Plus, it was kindof confusing having both update-flags and flags, which sometimes had different

Re: git-p4 Question

2015-04-24 Thread Luke Diamand
On 23/04/15 14:42, FusionX86 wrote: Hi Luke, I found a silly mistake I was making in the command I've been using. The folder under the depot should have been capitalized, but it wasn't. Also, I expected that if there was a problem with the command, it would fail with some message instead of

Re: [PATCH] fast-import: add options to enable/disable case folding

2015-04-24 Thread Luke Diamand
On 18/04/15 08:36, Mike Hommey wrote: On Fri, Apr 17, 2015 at 11:44:00AM -0700, Junio C Hamano wrote: So perhaps we should rip the case folding out altogether instead? The entry for the change in the Release Notes may say: * git fast-import incorrectly case-folded the paths recorded in

Re: git-completion.tcsh

2015-04-24 Thread SZEDER Gábor
Hi, Quoting Marc Khouzam marc.khou...@gmail.com: Hi, I did notice the problem a while ago and had traced it back to the fact that the bash completion scripts no longer adds the trailing '/' at the end of directories. Tcsh needs that '/' to know not to add that annoying extra space. Bash 3

Re: URL not displaying change made with git.

2015-04-24 Thread Matthieu Moy
Scott Meyer dutch...@gmail.com writes: When I use my browser to bring up the site the change is not visible. Which site are you talking about? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

URL not displaying change made with git.

2015-04-24 Thread Scott Meyer
I used git in the following steps. This is a local directory on a Mac, with Yosemite, using the latest git version. The directory name is development. using eclipse I created a branch WO_1 I made a change to the file eclipse indicates the change I use the plus to add it to the Index I commit

Re: URL not displaying change made with git.

2015-04-24 Thread Matthieu Moy
[ Please, don't top-post on this list ] Scott Meyer dutch...@gmail.com writes: The site is local to my laptop. I am attempting to establish a development environment where I can view and test changes before moving to production. OK, so you're doing web development, right? Then, the problem

Re: URL not displaying change made with git.

2015-04-24 Thread Scott Meyer
The site is local to my laptop. I am attempting to establish a development environment where I can view and test changes before moving to production. On Fri, Apr 24, 2015 at 8:50 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Scott Meyer dutch...@gmail.com writes: When I use my browser

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Stefan Beller
On Fri, Apr 24, 2015 at 11:12 AM, Jonathan Nieder jrnie...@gmail.com wrote: Stefan Beller wrote: I understood that you were talking about Could being capitalized. Though it's distributed 30/70 which hints to me we do not care in enough to explain the capitalized letters as slip-throughs on

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Jonathan Nieder
Stefan Beller wrote: I understood that you were talking about Could being capitalized. Though it's distributed 30/70 which hints to me we do not care in enough to explain the capitalized letters as slip-throughs on review or such, but it looks like the authors choice to me. Lowercase, brief,

Re: [PATCH v2 01/16] refs: convert struct ref_entry to use struct object_id

2015-04-24 Thread brian m. carlson
On Wed, Apr 22, 2015 at 05:52:09PM -0700, Stefan Beller wrote: So you're switching the code for a possible future In an earlier series/cover letter you wrote The goal of this series to improve type-checking in the codebase and to make it easier to move to a different hash function if the

Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Michael Haggerty
On 04/24/2015 11:51 PM, Eric Sunshine wrote: On Fri, Apr 24, 2015 at 7:35 AM, Michael Haggerty mhag...@alum.mit.edu wrote: Instead, work directly with update-flags. This has the advantage that the REF_DELETING bit, set in the first loop, can be read in the third loop instead of having to

[PATCH v2 1/2] connect: simplify SSH connection code path

2015-04-24 Thread brian m. carlson
The code path used in git_connect pushed the majority of the SSH connection code into an else block, even though the if block returns. Simplify the code by eliminating the else block, as it is unneeded. Signed-off-by: Jeff King p...@peff.net Signed-off-by: brian m. carlson

[PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread brian m. carlson
The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH. However, the match was done by checking for plink case-insensitively in the string, which led to false positives when GIT_SSH contained uplink. Improve

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread brian m. carlson
On Fri, Apr 24, 2015 at 03:46:30PM -0700, Pete Harlan wrote: On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH.

Re: Verbose as default for commit (optional)

2015-04-24 Thread Eloy Espinaco
Ok, now I found [this thread](http://thread.gmane.org/gmane.comp.version-control.git/251376) that seems abandoned, but implements this config, a --no-verbose that disable it for one-time and the tests, but was not merged (don't know why) This was the patch I've intended to attach:

Re: [PATCH v2 2/2] connect: improve check for plink to reduce false positives

2015-04-24 Thread Pete Harlan
On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson sand...@crustytoothpaste.net wrote: The git_connect function has code to handle plink and tortoiseplink specially, as they require different command line arguments from OpenSSH. However, the match was done by checking for plink

Re: [PATCH v2 02/16] refs: convert for_each_tag_ref to struct object_id

2015-04-24 Thread brian m. carlson
On Thu, Apr 23, 2015 at 03:27:23PM -0400, Jeff King wrote: +static int do_for_each_ref(struct ref_cache *refs, const char *base, +each_ref_fn fn, int trim, int flags, void *cb_data) +{ + return do_for_each_ref_generic(refs, base, fn, NULL, trim, flags, cb_data);

Re: git-p4 Question

2015-04-24 Thread FusionX86
I get an error if I misspell part of the path. For example, if I type //depot/maain instead of //depot/main I will get the no such files message you indicated. BUT using incorrect case like //depot/main instead of //depot/Main doesn't return any error, but still completes and creates an empty

Re: git-completion.tcsh

2015-04-24 Thread Marc Khouzam
On Fri, Apr 24, 2015 at 7:30 AM, SZEDER Gábor sze...@ira.uka.de wrote: Hi, Quoting Marc Khouzam marc.khou...@gmail.com: Hi, I did notice the problem a while ago and had traced it back to the fact that the bash completion scripts no longer adds the trailing '/' at the end of directories.

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 09:23:16PM -0700, Junio C Hamano wrote: The proposals so far, including this one, assume that the bug reporter will first fail the operation with normal invocation of Git (e.g. without GIT_DIE_ABORT exported) and then retry the same operation in a different way (e.g.

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Jeff King
On Sat, Apr 25, 2015 at 01:00:58AM -0400, Jeff King wrote: A better solution to what I proposed earlier is perhaps: git config alias.debug '!gdb --quiet \ -ex break exit \ -ex run \ -ex bt full \ -ex continue \ -ex quit \

bug report : 2.3.5 ssh repo not found

2015-04-24 Thread Chris
Hello, Using git version 2.3.5 with kernel 3.19.3-3-ARCH #1 SMP PREEMPT x86_64 I see the following error message when pulling or cloning a repo over ssh: git clone ssh://user@mydomain:/home/user/path/to/project.git Cloning into 'project'... ssh: Could not resolve hostname mydomain:: Name or

[PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Fredrik Gustafsson
When using `-v` to add a unified diff to the commit message, this is stripped and not a part of the commit message. This is not mentioned. Add a note about this with the `-v` description and slightly modify the description for the default `--cleanup` mode. Signed-off-by: Fredrik Gustafsson

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Junio C Hamano
Jeff King p...@peff.net writes: So if anything, I think my inclination would be to make it easier to help people (and ourselves) get a backtrace from gdb. One can get a core for a running process with gcore, or trigger a coredump by killing with SIGABRT. But catching it at the exact moment

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: In ref_transaction_commit(), close the reference lockfiles immediately to avoid keeping too many file descriptors open at a time. This is pretty easy, because in the first loop (where we create the locks) we already know what, if anything, has to

Re: [PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Junio C Hamano
Fredrik Gustafsson iv...@iveqy.com writes: diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index 617e29b..e31d828 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -180,8 +180,9 @@ OPTIONS + -- strip:: - Strip leading and

Re: Verbose as default for commit (optional)

2015-04-24 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Fri, Apr 24, 2015 at 7:51 PM, Eloy Espinaco eloy...@gmail.com wrote: Ok, now I found [this thread](http://thread.gmane.org/gmane.comp.version-control.git/251376) that seems abandoned, but implements this config, a --no-verbose that disable it

Re: [PATCH 1/5] status: document the -v/--verbose option

2015-04-24 Thread Michael Haggerty
On 04/24/2015 02:27 AM, Pete Harlan wrote: Junio writes: Michael Haggerty mhag...@alum.mit.edu writes: Document `git status -v`, including its new doubled `-vv` form. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- Will queue on mg/status-v-v series, which did add description for

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 01:35:44PM +0200, Michael Haggerty wrote: In ref_transaction_commit(), close the reference lockfiles immediately to avoid keeping too many file descriptors open at a time. This is pretty easy, because in the first loop (where we create the locks) we already know what,

Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 01:35:48PM +0200, Michael Haggerty wrote: Instead, work directly with update-flags. This has the advantage that the REF_DELETING bit, set in the first loop, can be read in the third loop instead of having to compute the same expression again. Plus, it was kindof

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Stefan Beller
On Thu, Apr 23, 2015 at 6:37 PM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: On Thu, Apr 23, 2015 at 10:56 AM, Junio C Hamano gits...@pobox.com wrote: + int save_errno = errno; + error(Couldn't reopen %s, lock-lk-filename.buf);

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 09:16:28AM -0700, Stefan Beller wrote: I think it's a mistake to s/Could/could/g for all errors in the code base as it reduces the information provided in the error messages. Just 3 days ago (Regular Rebase Failure). I used different capitalization to get a better

Verbose as default for commit (optional)

2015-04-24 Thread Eloy Espinaco
Hi, It is my first mail to the list, so hello world. I wanted to make a feature-request about a config setting to make the commit always verbose. I'm not the only one asking for that, there is an old question in [Stack Overflow][1]. So I was thinking if it was possible to make a pull request

Re: [PATCH 0/5] Avoid file descriptor exhaustion in ref_transaction_commit()

2015-04-24 Thread Stefan Beller
On Fri, Apr 24, 2015 at 10:26 AM, Jeff King p...@peff.net wrote: On Fri, Apr 24, 2015 at 01:35:44PM +0200, Michael Haggerty wrote: In ref_transaction_commit(), close the reference lockfiles immediately to avoid keeping too many file descriptors open at a time. This is pretty easy, because in

[PATCH] t0027: Add repoMIX and LF_nul

2015-04-24 Thread Torsten Bögershausen
new safer autocrlf handling: Check if eols in a file are converted at commit, when the file has CR (or CLLF) in the repo (technically speaking in the index). Add a test-file repoMIX with mixed line-endings. When converting LF-CRLF or CRLF-LF: check the warnings checkout_files():

[PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Fredrik Gustafsson
When using `-v` to add a unified diff to the commit message, this is stripped and not a part of the commit message. This is not mentioned. Add a note about this with the `-v` description as well as description for the default `--cleanup` mode. Signed-off-by: Fredrik Gustafsson iv...@iveqy.com

Re: [PATCH] t0027: Add repoMIX and LF_nul

2015-04-24 Thread Eric Sunshine
On Fri, Apr 24, 2015 at 3:46 PM, Torsten Bögershausen tbo...@web.de wrote: new safer autocrlf handling: Check if eols in a file are converted at commit, when the file has CR (or CLLF) in the repo (technically speaking in the index). Add a test-file repoMIX with mixed line-endings.

Re: [PATCHv3] refs.c: enable large transactions

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 11:12:36AM -0700, Jonathan Nieder wrote: Actually, I wouldn't mind an environment variable that tells error() to include a backtrace if someone wants it. (See backtrace(3) for implementation hints if interested in doing that.) Thanks, I didn't know about backtrace(3),

Re: Verbose as default for commit (optional)

2015-04-24 Thread Matthieu Moy
Eloy Espinaco eloy...@gmail.com writes: Hi, It is my first mail to the list, so hello world. Hi, and welcome to the list. I wanted to make a feature-request about a config setting to make the commit always verbose. I'm not the only one asking for that, there is an old question in [Stack

Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Michael Haggerty
On 04/24/2015 07:30 PM, Jeff King wrote: On Fri, Apr 24, 2015 at 01:35:48PM +0200, Michael Haggerty wrote: Instead, work directly with update-flags. This has the advantage that the REF_DELETING bit, set in the first loop, can be read in the third loop instead of having to compute the same

Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Jeff King
On Fri, Apr 24, 2015 at 11:15:09PM +0200, Michael Haggerty wrote: Hmm. I think this is losing the distinction of flags the caller has passed in to us versus flags we are using locally only during the transaction_commit routine. If callers look at the flags in the REF_TRANSACTION_CLOSED

Re: [PATCH 4/5] ref_transaction_commit(): remove the local flags variables

2015-04-24 Thread Eric Sunshine
On Fri, Apr 24, 2015 at 7:35 AM, Michael Haggerty mhag...@alum.mit.edu wrote: Instead, work directly with update-flags. This has the advantage that the REF_DELETING bit, set in the first loop, can be read in the third loop instead of having to compute the same expression again. Plus, it was