Re: use of PWD

On Tue, Nov 07, 2017 at 03:22:39PM -0400, Joey Hess wrote: > In strbuf_add_absolute_path, git uses PWD if set when making relative > paths absolute, otherwise it falls back to getcwd(3). Using PWD may not > be a good idea. Here's one case where it confuses git badly: > > joey@darkstar:/>sudo ln

What's cooking in git.git (Nov 2017, #03; Wed, 8)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The tip of 'next' has been

[no subject]

Re: [PATCH v3 0/6] Partial clone part 1: object filtering

Jeff Hostetler writes: > From: Jeff Hostetler > > Here is V3 of the list-object filtering. This addresses the > comments on the mailing list for the V2 series as well as the > various TODO items I left in the code. I also documented some > of

Re: [PATCH v3 4/6] list-objects: filter objects in traverse_commit_list

Jonathan Tan writes: > Having said that, though, it might be safer to still introduce one, and > relax it later if necessary - it is much easier to relax a constraint > than to increase one. It would also be more error prone to have such a long switch () statement,

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

On Wed, Nov 08, 2017 at 10:44:46AM +0900, Junio C Hamano wrote: > > We could also consider it a #leftoverbits that perhaps some other > > Outreachy candidate would pick up[1]. > > > > In the meantime, Junio, I think we'd want to queue this with the intent > > to graduate it to "pu" or possibly

Re: [PATCH] completion: add missing completions for log, diff, show

Max Rothman writes: > How about this: > > The bash completion script knows some options to "git log" and > "git show" only in the positive form, (e.g. "--abbrev-commit"), but not > in their negative form (e.g. "--no-abbrev-commit"). Adds them. s/Adds them/Add them/; we

Re: [PATCH] completion: add missing completions for log, diff, show

>> Teach git-log tab completion about the --no-* options for ease of use >> at the command line. >> >> Similarly, teach git-show tab completion about the --no-abbrev-commit, >> --expand-tabs, and --no-expand-tabs options. >> >> Also, teach git-diff (and all commands that use its options) tab >>

Re: [PATCH v3 1/2] builtin/merge-base: free commit lists

Martin Ågren writes: > In several functions, we iterate through a commit list by assigning > `result = result->next`. As a consequence, we lose the original pointer > and eventually leak the list. > > Rewrite the loops so that we keep the original pointers, then call >

Re: [PATCH] completion: add missing completions for log, diff, show

Max Rothman writes: > From: Max Rothman Thanks. > > Teach git-log tab completion about the --no-* options for ease of use > at the command line. > > Similarly, teach git-show tab completion about the --no-abbrev-commit, > --expand-tabs,

Re: [PATCH v5 0/7] namespace support

Antoine Beaupré writes: > Yet another reroll to fix a typo. Thanks. Will replace. Let's wait for a few more days and then merge it to 'next' and down to 'master'.

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

"Philip Oakley" writes: > But... >> ... >> This change causes quite a few tests to fall over; however, they >> all have truncated-something-longer-ellipses in their >> raw-diff-output expected sections, and removing the ellipses >> from there makes the tests pass again, :-)

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

Jeff King writes: > I do think there are a few ugly bits in the result (like that > initializer for packed_git_mru :) ), so I'd prefer not to merge this > down until we do that final step. > > So the big question is: who wants to do it? > > I think you've done a good job here, and

Re: [PATCH v3 0/3] for-each-ref: add :remoteref and :remotename specifiers

Johannes Schindelin writes: > Changes since v2: > > - fixed the commit message of 1/3 to no longer talk about :remote. OK. It now matches what we have had since October 5th in my tree. > - used the push atom in 2/3, made the code look more as suggested by Junio. I

Re: [PATCH v1 4/8] commit: move print_commit_summary() to libgit

Phillip Wood writes: > On 07/11/17 03:38, Junio C Hamano wrote: >> Phillip Wood writes: >> >>> From: Phillip Wood >>> >>> Move print_commit_summary() from builtin/commit.c to sequencer.c so it >>> can be shared

Re: [PATCH v16 Part II 6/8] bisect--helper: `get_terms` & `bisect_terms` shell function in C

On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement the `get_terms` and `bisect_terms` shell function in C and > add `bisect-terms` subcommand to `git bisect--helper` to call it from > git-bisect.sh . > > Using `--bisect-terms` subcommand is a temporary measure to port shell > function in C so

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

Jonathan Tan writes: > I can see some use for this parameter - for example, when doing a report > for statistical purposes (percentage of objects missing, for example) or > for a background task that downloads missing objects into a cache. Also, > power users who know

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

Junio C Hamano writes: > These "--ignore-*" whitespace options are to help reviewing _other_ > changes without getting distracted by the class of changes these > options represent. I guess I may have to update the log message (I > do not think I wrote anything like that in

Re: [PATCH v16 Part II 5/8] bisect--helper: `bisect_next_check` shell function in C

On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement `bisect_next_check` shell function in C and add > `bisect-next-check` subcommand to `git bisect--helper` to call it from > git-bisect.sh . > > `bisect_voc` shell function is no longer useful now and is replaced by > using a char *[] of

Re: [PATCH v3 6/6] pack-objects: add list-objects filtering

On Tue, 7 Nov 2017 19:35:46 + Jeff Hostetler wrote: > +--filter-ignore-missing: > + Ignore missing objects without error. This may be used with > + or without and of the above filtering. There is a discussion about this parameter (and the corresponding ones

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

Johannes Schindelin writes: > On Tue, 7 Nov 2017, Junio C Hamano wrote: > >> A new option --ignore-cr-at-eol tells the diff machinery to treat a >> carriage-return at the end of a (complete) line as if it does not >> exist. >> >> This would make it easier to review a

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

On Fri, 3 Nov 2017 14:34:39 -0400 Jeff Hostetler wrote: > > Assuming we eventually get promisor support working, would there be > > any use case where "any missing is OK" mode would be useful in a > > sense more reasonable than "because we could have such a mode" and > >

Re: [PATCH v16 Part II 4/8] bisect--helper: `check_and_set_terms` shell function in C

On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement the `check_and_set_terms` shell function in C and add > `check-and-set-terms` subcommand to `git bisect--helper` to call it from > git-bisect.sh > > Using `--check-and-set-terms` subcommand is a temporary measure to port > shell function in C

Re: [PATCH v2 1/1] Introduce git add --renormalize .

Torsten Bögershausen writes: >> > +--renormalize:: >> > + Normalizes the line endings from CRLF to LF of tracked files. >> > + This applies to files which are either "text" or "text=auto" >> > + in .gitattributes (or core.autocrlf is true or input) >> > + --renormalize implies

Re: [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C

On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement the `bisect_write` shell function in C and add a > `bisect-write` subcommand to `git bisect--helper` to call it from > git-bisect.sh > > Using `--bisect-write` subcommand is a temporary measure to port shell > function in C so as to use the

Re: sb/submodule-recursive-checkout-detach-head

Stefan Beller writes: >>> Detaching the submodule HEAD is in line with the current thinking >>> of submodules, though I am about to send out a plan later >>> asking if we want to keep it that way long term. >> >> Did this "send out a plan" ever happen? > > No. (Not yet?) > >>

Re: bp/read-index-from-skip-verification, was Re: What's cooking in git.git (Nov 2017, #02; Mon, 6)

Johannes Schindelin writes: > On Mon, 6 Nov 2017, Junio C Hamano wrote: > >> * bp/read-index-from-skip-verification (2017-11-01) 1 commit >> - read_index_from(): speed index loading by skiping verification of the >> entry order >> >> Drop (perhaps overly cautious)

Re: js/early-config, was Re: What's cooking in git.git (Nov 2017, #02; Mon, 6)

Johannes Schindelin writes: >> * js/early-config (2017-11-03) 1 commit >> - setup: avoid double slashes when looking for HEAD >> >> Correct start-up sequence so that a repository could hang >> immediately under the root directory again (which was broken at >>

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` > subcommand to `git bisect--helper` to call it from git-bisect.sh . > > Using `bisect_reset` subcommand is a temporary measure to port shell > functions to C so as to use the

Your long awaited part payment of $2.5.000.00Usd

Attention: Beneficiary, Your long awaited part payment of $2.5.000.00Usd (TWO MILLION FIVE Hundred Thousand United State Dollars) is ready for immediate release to you, and it was electronically credited into an ATM Visa Card for easy delivery. Your new Payment Reference No.- 6363836, Password

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

From: "Ann T Ropea" Thanks for all the feedback provided! I'd like to summarise what consensus we have reached so far and then propose a way forward: * we'll use the term "ellipsis (pl. ellipses)" for what's been referred to as "3dots", "n-dots", "many dots" and so

Re: [PATCH v3 4/6] list-objects: filter objects in traverse_commit_list

On Tue, 7 Nov 2017 19:35:44 + Jeff Hostetler wrote: > +/* > + * Reject the arg if it contains any characters that might > + * require quoting or escaping when handing to a sub-command. > + */ > +static int reject_injection_chars(const char *arg) > +{ [snip] > +}

Re: [PATCH v2 3/9] ref_transaction_update(): die on disallowed flags

On 11/07, Martin Ågren wrote: > On 5 November 2017 at 09:42, Michael Haggerty wrote: > > Callers shouldn't be passing disallowed flags into > > `ref_transaction_update()`. So instead of masking them off, treat it > > as a bug if any are set. > > > > Signed-off-by: Michael

[PATCH] completion: add missing completions for log, diff, show

From: Max Rothman Teach git-log tab completion about the --no-* options for ease of use at the command line. Similarly, teach git-show tab completion about the --no-abbrev-commit, --expand-tabs, and --no-expand-tabs options. Also, teach git-diff (and all commands

Re: [PATCH v2 3/9] ref_transaction_update(): die on disallowed flags

On 5 November 2017 at 09:42, Michael Haggerty wrote: > Callers shouldn't be passing disallowed flags into > `ref_transaction_update()`. So instead of masking them off, treat it > as a bug if any are set. > > Signed-off-by: Michael Haggerty > --- >

Re: No log --no-decorate completion?

On Tue, Nov 7, 2017 at 12:31 PM, Max Rothman wrote: > Thanks for the feedback! > >>> * Add bash completion for the missing --no-* options on git log >>> * Add bash completion for --textconv and --indent-heuristic families to >>> git diff and all commands that use diff's

Re: [PATCH/DONOTAPPLY 0/4] first steps towards pager.foo.{command,enable}

On 6 November 2017 at 11:48, Jeff King wrote: > On Sun, Nov 05, 2017 at 12:58:18PM +0100, Martin Ågren wrote: >> In particular, they do not teach `--paginate` to use the pager >> configured by `pager.foo.command`. It is already now possible to use >> `pager.foo` to say "I don't

[PATCH v3 1/2] builtin/merge-base: free commit lists

In several functions, we iterate through a commit list by assigning `result = result->next`. As a consequence, we lose the original pointer and eventually leak the list. Rewrite the loops so that we keep the original pointers, then call `free_commit_list()`. Various alternatives were considered:

[PATCH v3 2/2] reduce_heads: fix memory leaks

We currently have seven callers of `reduce_heads(foo)`. Six of them do not use the original list `foo` again, and actually, all six of those end up leaking it. Introduce and use `reduce_heads_replace()` as a leak-free version of `foo = reduce_heads(foo)` to fix several of these. Fix the remaining

Re: No log --no-decorate completion?

Thanks for the feedback! >> * Add bash completion for the missing --no-* options on git log >> * Add bash completion for --textconv and --indent-heuristic families to >> git diff and all commands that use diff's options >> * Add bash completion for --no-abbrev-commit, --expand-tabs, and >>

[PATCH v3 4/6] list-objects: filter objects in traverse_commit_list

From: Jeff Hostetler Create traverse_commit_list_filtered() and add filtering interface to allow certain objects to be omitted from the traversal. Update traverse_commit_list() to be a wrapper for the above with a null filter to minimize the number of callers that needed

[PATCH v3 1/6] dir: allow exclusions from blob in addition to file

From: Jeff Hostetler Refactor add_excludes() to separate the reading of the exclude file into a buffer and the parsing of the buffer into exclude_list items. Add add_excludes_from_blob_to_list() to allow an exclude file be specified with an OID without assuming a local

[PATCH v3 6/6] pack-objects: add list-objects filtering

From: Jeff Hostetler Teach pack-objects to use the filtering provided by the traverse_commit_list_filtered() interface to omit unwanted objects from the resulting packfile. This feature is intended for partial clone/fetch. Filtering requires the use of the "--stdout"

[PATCH v3 5/6] rev-list: add list-objects filtering support

From: Jeff Hostetler Teach rev-list to use the filtering provided by the traverse_commit_list_filtered() interface to omit unwanted objects from the result. This feature is intended to help with partial clone. Object filtering is only allowed when one of the

[PATCH v3 2/6] oidmap: add oidmap iterator methods

From: Jeff Hostetler Add the usual map iterator functions to oidmap. Signed-off-by: Jeff Hostetler --- oidmap.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/oidmap.h b/oidmap.h index 18f54cd..d3cd2bb 100644 ---

[PATCH v3 3/6] oidset: add iterator methods to oidset

From: Jeff Hostetler Add the usual iterator methods to oidset. Add oidset_remove(). Signed-off-by: Jeff Hostetler --- oidset.c | 10 ++ oidset.h | 36 2 files changed, 46 insertions(+) diff --git

[PATCH v3 0/6] Partial clone part 1: object filtering

From: Jeff Hostetler Here is V3 of the list-object filtering. This addresses the comments on the mailing list for the V2 series as well as the various TODO items I left in the code. I also documented some of the bit flags and fields that I added. In the blob size

use of PWD

In strbuf_add_absolute_path, git uses PWD if set when making relative paths absolute, otherwise it falls back to getcwd(3). Using PWD may not be a good idea. Here's one case where it confuses git badly: joey@darkstar:/>sudo ln -s /media/hd/repo hd joey@darkstar:/>cd /hd/repo

Re: Git Open Source Weekend London 11th/12th November

> Hi Patrick, > > libgit2 tasks are welcome! Feel free to bring your ideas > along. Also, Peff could add some to the task list if they are > appropriate for others to participate on. That's nice. I don't want to populate the list with too much libgit2 specific things, but we do have a summary

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/2/2017 3:32 PM, Jonathan Tan wrote: On Thu, 2 Nov 2017 17:50:11 + Jeff Hostetler wrote: + if (skip_prefix(v0, "oid=", )) { + filter_options->choice = LOFC_SPARSE_OID; + if (!get_oid_with_context(v1,

[PATCH v2] Tests: clean up and document submodule helpers

Factor out the commonalities from test_submodule_switch() and test_submodule_forced_switch() in lib-submodule-update.sh, and document their usage. This also makes explicit (through the KNOWN_FAILURE_FORCED_SWITCH_TESTS variable) the fact that, currently, all functionality tested using

Re: [PATCH v2 0/2] Teach "diff" to ignore only CR at EOL

On Tue, Nov 7, 2017 at 7:12 AM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> Good. I was wishing for such a feature in the past. >> >> However, the short and sweet `-b` or `-w` switches are really, really >> nice. `--ignore-cr-at-eol` is

Re: [PATCH] Tests: document test_submodule_{,forced_}switch()

On Mon, Nov 6, 2017 at 5:52 PM, Junio C Hamano wrote: > Jonathan Tan writes: > >> Factor out the commonalities from test_submodule_switch() and >> test_submodule_forced_switch() in lib-submodule-update.sh, and document >> their usage. >> >> This also

Re: [PATCH v2 1/1] Introduce git add --renormalize .

[snip] > > > @@ -175,6 +175,12 @@ for "git add --no-all ...", i.e. ignored > > removed files. > > warning (e.g., if you are manually performing operations on > > submodules). > > > > +--renormalize:: > > + Normalizes the line endings from CRLF to LF of tracked files. > > + This

Re: sb/submodule-recursive-checkout-detach-head

On Mon, Nov 6, 2017 at 6:00 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits >>> (merged to 'next' on 2017-10-26 at 30994b4c76) >>> + Documentation/checkout: clarify submodule

[PATCH v3 3/3] for-each-ref: test :remotename and :remoteref

This not only prevents regressions, but also serves as documentation what this new feature is expected to do. Signed-off-by: Johannes Schindelin --- t/t6300-for-each-ref.sh | 32 1 file changed, 32 insertions(+) diff --git

[PATCH v3 2/3] for-each-ref: let upstream/push report the remote ref name

From: J Wyman There are times when scripts want to know not only the name of the push branch on the remote, but also the name of the branch as known by the remote repository. An example of this is when a tool wants to push to the very same branch from which it would pull

[PATCH v3 0/3] for-each-ref: add :remoteref and :remotename specifiers

This introduces support for git for-each-ref \ --format="%(merge:remotename),%(merge:remoteref)" git for-each-ref \ --format="%(push:remotename),%(push:remoteref)" to figure out the remote nickname as well as the name of the corresponding branch on

[PATCH v3 1/3] for-each-ref: let upstream/push optionally report the remote name

There are times when e.g. scripts want to know not only the name of the upstream branch on the remote repository, but also the name of the remote. This patch offers the new suffix :remotename for the upstream and for the push atoms, allowing to show exactly that. Example: $ cat

[PATCH v5 2/7] remote-mediawiki: allow fetching namespaces with spaces

From: Ingo Ruhnke we still want to use spaces as separators in the config, but we should allow the user to specify namespaces with spaces, so we use underscore for this. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré ---

[PATCH v5 0/7] namespace support

Yet another reroll to fix a typo.

Re: [PATCH v4 3/7] remote-mediawiki: show known namespace choices on failure

On 2017-11-07 10:45:27, Thomas Adam wrote: > On Mon, Nov 06, 2017 at 04:19:49PM -0500, Antoine Beaupré wrote: >> If we fail to find a requested namespace, we should tell the user >> which ones we know about, since those were already fetched. This >> allows users to fetch all namespaces by

[PATCH v5 7/7] remote-mediawiki: show progress while fetching namespaces

Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately:

[PATCH v5 4/7] remote-mediawiki: skip virtual namespaces

Virtual namespaces do not correspond to pages in the database and are automatically generated by MediaWiki. It makes little sense, therefore, to fetch pages from those namespaces and the MW API doesn't support listing those pages. According to the documentation, those virtual namespaces are

[PATCH v5 6/7] remote-mediawiki: process namespaces in order

Ideally, we'd process them in numeric order since that is more logical, but we can't do that yet since this is where we find the numeric identifiers in the first place. Lexicographic order is a good compromise. Signed-off-by: Antoine Beaupré ---

[PATCH v5 3/7] remote-mediawiki: show known namespace choices on failure

If we fail to find a requested namespace, we should tell the user which ones we know about, since those were already fetched. This allows users to fetch all namespaces by specifying a dummy namespace, failing, then copying the list of namespaces in the config. Eventually, we should have a flag

[PATCH v5 5/7] remote-mediawiki: support fetching from (Main) namespace

When we specify a list of namespaces to fetch from, by default the MW API will not fetch from the default namespace, refered to as "(Main)" in the documentation: https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces I haven't found a way to address that "(Main)" namespace when

[PATCH v5 1/7] remote-mediawiki: add namespace support

From: Kevin This introduces a new remote.origin.namespaces argument that is a space-separated list of namespaces. The list of pages extract is then taken from all the specified namespaces. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré

Re: [PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces

On 2017-11-07 07:08:08, Thomas Adam wrote: > On Mon, Nov 06, 2017 at 04:19:48PM -0500, Antoine Beaupré wrote: >> From: Ingo Ruhnke >> >> we still want to use spaces as separators in the config, but we should >> allow the user to specify namespaces with spaces, so we use

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

Junio C Hamano writes: > And this step is going in the right direction, but I am not sure if > this made the function safe enough to be called repeatedly from the > rebase machinery and we are ready to unleash this to the end users > and tell them it is safe to use it.

Re: future of the mediawiki extension?

Matthieu Moy writes: > I realize I didn't answer this point. The reason you didn't see any > update recently is just that there haven't been any release and > actually not much development for a while on git-multimail. That is perfectly fine. > I still have a list of

Re: [PATCH v2 0/2] Teach "diff" to ignore only CR at EOL

Johannes Schindelin writes: > Good. I was wishing for such a feature in the past. > > However, the short and sweet `-b` or `-w` switches are really, really > nice. `--ignore-cr-at-eol` is just very cumbersome to type out. So I think > you will want to add this patch

Re: [PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

Johannes Schindelin writes: >> diff --git a/xdiff/xdiff.h b/xdiff/xdiff.h >> index b090ad8eac..cbf5d8e166 100644 >> --- a/xdiff/xdiff.h >> +++ b/xdiff/xdiff.h >> @@ -27,22 +27,26 @@ >> extern "C" { >> #endif /* #ifdef __cplusplus */ >> >> +/* xpparm_t.flags */ >>

Greetings in the name of God, Business proposal in God we trust

Greetings in the name of God Dear Friend Greetings in the name of God,please let this not sound strange to you for my only surviving lawyer who would have done this died early this year.I prayed and got your email id from your country guestbook. I am Mrs Suran Yoda from London,I am 72 years

Re: [PATCH v1 6/8] sequencer: simplify adding Signed-off-by: trailer

On 07/11/17 04:52, Junio C Hamano wrote: > Phillip Wood writes: > >> diff --git a/sequencer.c b/sequencer.c >> index >> ae24405c23d021ed7916e5e2d9df6de27f867a2e..3e4c3bbb265db58df22cfcb5a321fb74d822327e >> 100644 >> --- a/sequencer.c >> +++ b/sequencer.c >> @@ -477,9

Re: [PATCH v1 4/8] commit: move print_commit_summary() to libgit

On 07/11/17 03:38, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> Move print_commit_summary() from builtin/commit.c to sequencer.c so it >> can be shared with other commands. The function is modified by >>

Re: [PATCH v1 3/8] commit: move post-rewrite code to libgit

On 07/11/17 03:03, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can >> be shared with other commands and add a new function >>

Re: [PATCH v1 2/8] Add a function to update HEAD after creating a commit

On 07/11/17 03:02, Johannes Schindelin wrote: > Hi Junio, > > On Tue, 7 Nov 2017, Junio C Hamano wrote: > >> Phillip Wood writes: >> >>> @@ -751,6 +751,42 @@ int template_untouched(const struct strbuf *sb, const >>> char *template_file, >>> return

Re: [PATCH v1 1/8] commit: move empty message checks to libgit

On 07/11/17 00:43, Johannes Schindelin wrote: > Hi Phillip, > > On Mon, 6 Nov 2017, Phillip Wood wrote: > >> From: Phillip Wood >> >> Move the functions that check for empty messages from bulitin/commit.c >> to sequencer.c so they can be shared with other commands.

Re: [PATCH v1 8/8] sequencer: try to commit without forking 'git commit'

Hi Phillip, On Tue, 7 Nov 2017, Phillip Wood wrote: > On 07/11/17 01:36, Johannes Schindelin wrote: > > > > On Mon, 6 Nov 2017, Phillip Wood wrote: > > > >> From: Phillip Wood > >> > >> +static int try_to_commit(struct strbuf *msg, const char *author, > >> +

Re: [PATCH v2 2/2] diff: --ignore-cr-at-eol

Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > A new option --ignore-cr-at-eol tells the diff machinery to treat a > carriage-return at the end of a (complete) line as if it does not > exist. > > This would make it easier to review a change whose only effect is to > turn line endings

Re: [PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > We have packed the bits too tightly in such a way that it is not > easy to add a new type of whitespace ignoring option, a new type > of LCS algorithm, or a new type of post-cleanup heuristics. > > Reorder bits a bit to give room for these

Re: "Cannot fetch git.git" ( iworktrees at fault? or origin/HEAD) ?

On Fri, 2017-11-03 at 12:11 -0700, Stefan Beller wrote: > On Fri, Nov 3, 2017 at 2:32 AM, Kaartic Sivaraam > wrote: > > BTW, this is what I call _way way_ faster. Unfortunately due to the limited > > configuration of my system, the test suite has following timing > >

Re: [PATCH v2 0/2] Teach "diff" to ignore only CR at EOL

Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > This time with doc updates and tests. The previous one is at > > https://public-inbox.org/git/xmqqshe7j0af@gitster.mtv.corp.google.com > > A change that is supposed to only change the end-of-line convention > between LF <-> CRLF and

bp/read-index-from-skip-verification, was Re: What's cooking in git.git (Nov 2017, #02; Mon, 6)

Hi Junio, On Mon, 6 Nov 2017, Junio C Hamano wrote: > * bp/read-index-from-skip-verification (2017-11-01) 1 commit > - read_index_from(): speed index loading by skiping verification of the > entry order > > Drop (perhaps overly cautious) sanity check before using the index > read from the

js/early-config, was Re: What's cooking in git.git (Nov 2017, #02; Mon, 6)

Hi Junio, On Mon, 6 Nov 2017, Junio C Hamano wrote: > * js/early-config (2017-11-03) 1 commit > - setup: avoid double slashes when looking for HEAD > > Correct start-up sequence so that a repository could hang > immediately under the root directory again (which was broken at > around Git

Re: [PATCH v1 8/8] sequencer: try to commit without forking 'git commit'

On 07/11/17 01:36, Johannes Schindelin wrote: > Hi Phillip, > > On Mon, 6 Nov 2017, Phillip Wood wrote: > >> From: Phillip Wood >> >> If the commit message does not need to be edited then create the >> commit without forking 'git commit'. Taking the best time of ten

Re: [PATCH v1 7/8] sequencer: load commit related config

Thanks for looking at these patches On 07/11/17 01:02, Johannes Schindelin wrote: > Hi Phillip, > > On Mon, 6 Nov 2017, Phillip Wood wrote: > >> From: Phillip Wood >> >> Load default values for message cleanup and gpg signing of commits in >> preparation for

Re: [PATCH v4 3/7] remote-mediawiki: show known namespace choices on failure

On Mon, Nov 06, 2017 at 04:19:49PM -0500, Antoine Beaupré wrote: > If we fail to find a requested namespace, we should tell the user > which ones we know about, since those were already fetched. This > allows users to fetch all namespaces by specifying a dummy namespace, > failing, then copying

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > Phillip Wood writes: > > > From: Phillip Wood > > > > Return an error rather than dying so that the sequencer can exit > > cleanly once it starts committing without forking 'git

Re: [PATCH v1 2/8] Add a function to update HEAD after creating a commit

Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > Phillip Wood writes: > > > @@ -751,6 +751,42 @@ int template_untouched(const struct strbuf *sb, const > > char *template_file, > > return rest_is_empty(sb, start - sb->buf); > > } > > > > +int