[PATCH] t9824: fix wrong reference value

0492eb4 fixed a broken &&-chain in this test which broke the test as it checked for a wrong size. The expected size of the file under test is 39 bytes. The test checked that the size is 13 bytes. Fix the reference value to make the test pass, again. Signed-off-by: Lars Schneider <

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

On 26 Apr 2016, at 01:10, SZEDER Gábor wrote: > > Quoting Junio C Hamano : > >> SZEDER Gábor writes: >> >>> You can have a look at these patches at >>> >>> https://github.com/szeder/git completion-test-multiple-bash-versions >>>

Re: [PATCH v3 2/3] travis-ci: express Linux/OS X dependency versions more clearly

nux build installs fixed versions. Consequently >> new >> LFS/Perforce versions can brake the OS X build even if there is no change in > > s/brake/break/ Thank you! > >> Git. >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> -- To unsubs

Re: [PATCH v1] travis-ci: build documentation

On 22 Apr 2016, at 11:07, Matthieu Moy wrote: > larsxschnei...@gmail.com writes: > >> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; > > [[ is a bashism, and doesn't bring anything here compared to the POSIX > [ ... ], or "test" which is prefered

Re: [PATCH v3 3/3] git-p4: fix Git LFS pointer parsing

On 24 Apr 2016, at 21:16, Sebastian Schuberth wrote: > On Sun, Apr 24, 2016 at 8:58 PM, wrote: > >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -1064,8 +1064,15 @@ class GitLFS(LargeFileSystem): >> if pointerProcess.wait(): >>

Re: [PATCH v1] travis-ci: build documentation

On 22 Apr 2016, at 12:45, stefan.na...@atlas-elektronik.com wrote: > Am 22.04.2016 um 10:34 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Run "make doc" to check if all documentation can be build without errors.

Re: [PATCH v1] travis-ci: build documentation

On 23 Apr 2016, at 05:39, Jeff King <p...@peff.net> wrote: > On Fri, Apr 22, 2016 at 10:34:02AM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Run "make doc" to check if all documentation can be bu

Re: [PATCH v1] travis-ci: build documentation

On 22 Apr 2016, at 20:14, Junio C Hamano wrote: > Matthieu Moy writes: > >> larsxschnei...@gmail.com writes: >> >>> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; >> >> [[ is a bashism, and doesn't bring anything here

[RFC] How to pass Git config command line instructions to Submodule commands?

Hi, a few folks from the Git LFS project and I try to make cloning of repositories with a lot of LFS files faster. The core problem is that Git LFS uses a Git smudge filter to replace LFS pointers with the actual file content. Right now, a smudge filter can only be executed on an individual

Re: [PATCH v2] travis-ci: build documentation

On 29 Apr 2016, at 19:27, Stefan Beller wrote: > On Fri, Apr 29, 2016 at 5:21 AM, Matthieu Moy > wrote: >> Jeff King writes: >> >>> On Fri, Apr 29, 2016 at 11:35:34AM +0200, larsxschnei...@gmail.com wrote: >>> +# The

Re: [PATCH] t9824: fix wrong reference value

On 29 Apr 2016, at 19:34, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> 0492eb4 fixed a broken &&-chain in this test which broke the test as it >> checked for a wrong size. The expected size of the fi

Re: [PATCH 4/5] submodule--helper: move config-sanitizing to submodule.c

> On 28 Apr 2016, at 15:38, Jeff King wrote: > > These functions should be used by any code which spawns a > submodule process, which may happen in submodule.c (e.g., > for spawning fetch). Let's move them there and make them > public so that submodule--helper can continue to

Re: [PATCH 1/3] clone: add `--shallow-submodules` flag

> On 16 Mar 2016, at 02:12, Stefan Beller wrote: > > When creating a shallow clone of a repository with submodules, the depth > argument does not influence the submodules, i.e. the submodules are done > as non-shallow clones. It is unclear what the best default is for the >

Re: [PATCH 1/3] submodule clone: pass along `local` option

> On 13 Apr 2016, at 01:48, Stefan Beller wrote: > > When cloning a local repository, the user may choose to use an optimization > such that the transfer uses a Git agnostic protocol. Propagate the users > choice to submodules or if they don't choose, propagate nothing. > A

Re: [PATCH 3/3] clone: add t5614 to test cloning submodules with shallowness involved

> On 13 Apr 2016, at 01:48, Stefan Beller wrote: > > There are some inherent issues with shallow clones and submodules, such > as having not having a commit available the superproject may point to > in the submodule due to being shallow. Use the new file t5614 to document >

Re: [BUG] t9801 and t9803 broken on next

On 17 May 2016, at 14:13, Jeff King <p...@peff.net> wrote: > On Tue, May 17, 2016 at 10:07:16AM +0200, Lars Schneider wrote: > >> I think that is pretty much the problem. Here is what is happening: >> >> 1. git-p4 imports all changelists for the "ma

Re: [BUG] t9801 and t9803 broken on next

> On 19 May 2016, at 19:03, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> From my point of view little packs are no problem. I run fast-import on >> a dedicated migration machine. After fast-import comp

Re: [PATCH v1 3/3] travis-ci: run Git bisect on failed tests

> On 22 May 2016, at 17:35, Christian Couder wrote: > > On Sun, May 22, 2016 at 1:00 PM, wrote: > > [...] > >> +# >> +# Run Git bisect >> +# >> +run_bisect () { >> + TEST_SCRIPT=$1 >> + BAD_REV=$2 >> + GOOD_RV=$3 >> +

Re: [PATCH v1 3/3] travis-ci: run Git bisect on failed tests

> On 22 May 2016, at 19:21, Pranit Bauva <pranit.ba...@gmail.com> wrote: > > Hey Lars, > > On Sun, May 22, 2016 at 4:30 PM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> ... >>

Re: [PATCH v1 2/2] travis-ci: enable sequential test execution for t9113 and 9126

> On 19 May 2016, at 19:11, Junio C Hamano wrote: > > Eric Wong writes: > >> Anyways, how about making the tests run on separate ports and >> not worry about serializing them at all? > > Yeah, that does sound like a more sensible approach. Makes sense.

Re: [Opinion gathering] Git remote whitelist/blacklist

> On 24 May 2016, at 06:12, Francois Beutin > wrote: > On May 20, 2016 10:22 AM, Francois Beutin wrote: We (Ensimag students) plan to implement the "remote whitelist/blacklist" feature described in the SoC 2016 ideas, but first I would like to be

Re: [Opinion gathering] Git remote whitelist/blacklist

> On 24 May 2016, at 12:07, Junio C Hamano wrote: > > On Tue, May 24, 2016 at 5:55 AM, Matthieu Moy > wrote: >> So, when trying a forbidden push, Git would deny it and the only way to >> force the push would be to remove the blacklist from the

Re: [BUG] t9801 and t9803 broken on next

> On 14 May 2016, at 20:15, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 13 May 2016, at 18:37, Junio C Hamano <gits...@pobox.com> wrote: >>> >>> Are you saying that "gi

[BUG] t9801 and t9803 broken on next

Hi, t9801 and t9803 seem to be broken on next. A quick bisect indicates that d9545c7 "fast-import: implement unpack limit" might be the reason. (@gmane/292562). Did anyone look into that already? Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a

Re: [PATCH v4 2/2] travis-ci: build documentation

> On 10 May 2016, at 19:12, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Build documentation as separate Travis CI job to check for >> documentat

Re: [BUG] t9801 and t9803 broken on next

> On 13 May 2016, at 18:37, Junio C Hamano <gits...@pobox.com> wrote: > > Eric Wong <e...@80x24.org> writes: > >> Lars Schneider <larsxschnei...@gmail.com> wrote: >>> Hi, >>> >>> t9801 and t9803 seem to be broken on next. A quick

Re: What's cooking in git.git (May 2016, #02; Fri, 6)

> On 10 May 2016, at 07:52, Johannes Schindelin > wrote: > > Hi Junio, > > On Fri, 6 May 2016, Junio C Hamano wrote: > >> * jk/submodule-c-credential (2016-05-06) 6 commits >> - submodule: stop sanitizing config options >> - submodule: use

Re: [PATCH v3 1/2] Documentation: fix linkgit references

On 02 May 2016, at 22:34, Jeff King <p...@peff.net> wrote: > On Mon, May 02, 2016 at 10:20:04PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com>

Re: [PATCH v2] Documentation: add setup instructions for Travis CI

On 02 May 2016, at 10:48, Matthieu Moy wrote: > larsxschnei...@gmail.com writes: > >> +on open source projects), you can use their Travis CI integration to >> +test your changes on Linux, Mac, and (hopefully soon) Windows. See > > Nit: I'd write Linux, Mac (and

Re: [PATCH v3 2/2] travis-ci: build documentation

On 02 May 2016, at 22:45, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> +set -e >> + >> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >> +'(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >> +| sort -u \ >> +) >> + >> +for LINK

Re: [PATCH v6 1/2] http: support sending custom HTTP headers

On 04 May 2016, at 08:14, Johannes Schindelin wrote: > We introduce a way to send custom HTTP headers with all requests. > > This allows us, for example, to send an extra token from build agents > for temporary access to private repositories. (This is the use case

Re: What's cooking in git.git (May 2016, #02; Fri, 6)

> On 07 May 2016, at 00:46, Junio C Hamano wrote: > > [...] > > > * jc/doc-lint (2016-05-04) 2 commits > - Documentation: fix linkgit references > - ci: validate "gitlink:" in documentation The first patch "Documentation: fix linkgit references" seems not to be on the

Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

> On 09 May 2016, at 08:18, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Lars Schneider noticed that the configuration introduced to test the extra > HTTP headers cannot be used with Apache 2.2 (which is still actively > maintained, as pointed out by Ju

Re: [PATCH v4 1/2] Documentation: fix linkgit references

On 04 May 2016, at 10:38, larsxschnei...@gmail.com wrote: > From: Lars Schneider <larsxschnei...@gmail.com> > > Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> > --- > Documentation/config.txt| 4 ++-- > Documentation/git-check-ignore.txt | 2

Re: [PATCH v3 2/2] travis-ci: build documentation

On 03 May 2016, at 17:43, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> On 02 May 2016, at 22:45, Junio C Hamano <gits...@pobox.com> wrote: >> >>> larsxschnei...@gmail.com writes: >>&g

Re: [PATCH v1 2/2] git-p4: fix Git LFS pointer parsing

> On 19 Apr 2016, at 22:30, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer' >> co

Re: [PATCH v1] Documentation: add setup instructions for Travis CI

On 13 Apr 2016, at 19:39, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >

Re: 0 bot for Git

On 13 Apr 2016, at 19:29, Stefan Beller <sbel...@google.com> wrote: > On Wed, Apr 13, 2016 at 10:09 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >>> On 13 Apr 2016, at 18:27, Junio C Hamano <gits...@pobox.com> wrote: >>> >

Re: [PATCH] Adding list of p4 jobs to git commit message

Hi Jan, Please look closely at the Travis CI output: non-executable tests: t9829-git-p4-jobs.sh make[1]: *** [test-lint-executable] Error 1 You haven't set the execution bit for your new test script. Did you try to run your tests locally? If yes, then I wonder how it worked... On Linux/Mac you

Re: [PATCH v2] git-p4: add P4 jobs to git commit message

On 16 Apr 2016, at 21:58, Jan Durovec wrote: > When migrating from Perforce to git the information about P4 jobs > associated with P4 changelists is lost. > > Having these jobs listed on messages of related git commits enables smooth > migration for projects that take

Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

On 09 May 2016, at 08:19, Johannes Schindelin wrote: > To test that extra HTTP headers are passed correctly, t5551 verifies that > a fetch succeeds when two required headers are passed, and that the fetch > does not succeed when those headers are not passed. > >

Re: [Opinion gathering] Git remote whitelist/blacklist

> On 24 May 2016, at 12:16, Randall S. Becker wrote: > > On May 24, 2016 12:08 PM, Matthieu Moy wrote: >>> So, when trying a forbidden push, Git would deny it and the only way >>> to force the push would be to remove the blacklist from the config, right? >>> >>>

Re: What's cooking in git.git (Jul 2016, #07; Mon, 25)

On 26 Jul 2016, at 00:50, Junio C Hamano wrote: > [...] > > > * ew/git-svn-http-tests (2016-07-25) 2 commits > - git svn: migrate tests to use lib-httpd > - t/t91*: do not say how to avoid the tests > > Reuse the lib-httpd test infrastructure when testing the subversion >

Re: [PATCH v2 3/5] pkt-line: extract and use `set_packet_header` function

> On 27 Jul 2016, at 02:20, Junio C Hamano <gits...@pobox.com> wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> `set_packet_header` converts an integer to a 4 byte hex string. Make >> this

Re: [PATCH v5 2/8] add smudgeToFile and cleanFromFile filter configs

> On 12 Jul 2016, at 00:45, Joey Hess wrote: > > This adds new smudgeToFile and cleanFromFile filter commands, > which are similar to smudge and clean but allow direct access to files on > disk. > > This interface can be much more efficient when operating on large files, >

Re: [RFC] Long running Git clean/smudge filter

> On 10 Jul 2016, at 17:10, Joey Hess wrote: > > larsxschnei...@gmail.com wrote: >> (2) Joey's topic, which is the base for my patch, looks stalled for more than >> 2 weeks: >> http://thread.gmane.org/gmane.comp.version-control.git/297994/focus=298006 >> I would be happy to

Re: [PATCH v2 0/5] Git filter protocol

> On 27 Jul 2016, at 21:08, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-27 o 02:06, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Hi, >> >> thanks a lot for the extensive re

Re: [PATCH v2 1/5] convert: quote filter names in error messages

> On 27 Jul 2016, at 22:01, Jakub Narębski wrote: > > W dniu 2016-07-27 o 02:06, larsxschnei...@gmail.com pisze: > >> Git filter with spaces (e.g. `filter.sh foo`) are hard to read in >> error messages. Quote them to improve the readability. > > This is not something very

Alternatives to mid.gmane.org?

Hi, gmane is down and I wonder if there are alternatives to find a message based on the message ID in the Git mailing list archive? Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 4/5] convert: generate large test files only once

> On 27 Jul 2016, at 15:32, Jeff King wrote: > > On Wed, Jul 27, 2016 at 04:35:32AM +0200, Torsten Bögershausen wrote: > >>> + mkdir -p generated-test-data && >>> + for i in $(test_seq 1 $T0021_LARGE_FILE_SIZE) >>> + do >>> + # Generate 1MB of empty data and 100

Re: [PATCH v2 5/5] convert: add filter..process option

> On 27 Jul 2016, at 03:32, Jeff King wrote: > > On Wed, Jul 27, 2016 at 02:06:05AM +0200, larsxschnei...@gmail.com wrote: > >> +static off_t multi_packet_read(struct strbuf *sb, const int fd, const >> size_t size) >> +{ >> +off_t bytes_read; >> +off_t total_bytes_read

Re: [PATCH v2 5/5] convert: add filter..process option

> On 27 Jul 2016, at 20:11, Jeff King <p...@peff.net> wrote: > > On Wed, Jul 27, 2016 at 07:31:26PM +0200, Lars Schneider wrote: > >>>> + strbuf_grow(sb, size + 1); // we need one extra byte for the >>>> packet flush >>> >>> Wh

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 01:19, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > On 22/07/16 16:49, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an external filter process for ever

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 10:14, Eric Wong wrote: > larsxschnei...@gmail.com wrote: >> Please note that the protocol filters do not support stream processing >> with this implemenatation because the filter needs to know the length of >> the result in advance. A protocol version 2 could

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 02:11, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> > > Nb. this line is only needed if you want author name and/or date > different fr

Re: [PATCH v1 0/3] Git filter protocol

On 22 Jul 2016, at 23:39, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> The first two patches are cleanup patches which are not really necessary >> for the feature. > > These two looked trivially good. Thanks! > I think I can agree with what 3/3 wants to

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 23 Jul 2016, at 00:32, Torsten Bögershausen <tbo...@web.de> wrote: > On 07/22/2016 05:49 PM, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> [...] >> >> 1. Git starts the filter on first usage and expec

Re: [PATCH v2 5/5] convert: add filter..process option

> On 29 Jul 2016, at 13:24, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-29 o 12:38, Lars Schneider pisze: >> On 27 Jul 2016, at 11:41, Eric Wong <e...@80x24.org> wrote: >>> larsxschnei...@gmail.com wrote: > >>>> +static off_

Re: [PATCH v2 5/5] convert: add filter..process option

> On 27 Jul 2016, at 11:41, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: >> +static off_t multi_packet_read(struct strbuf *sb, const int fd, const >> size_t size) > > I'm no expert in C, but this might be const-correctness taken > too far. I think basing this on the

Re: [PATCH v2 0/5] Git filter protocol

> On 29 Jul 2016, at 09:40, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-28 o 15:29, Jeff King pisze: >> On Thu, Jul 28, 2016 at 09:16:18AM +0200, Lars Schneider wrote: >> >>> But Peff ($gmane/299902), Duy, and Eric, seemed to prefer the

Re: [PATCH v2 5/5] convert: add filter..process option

> On 28 Jul 2016, at 01:31, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-27 o 02:06, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an external filter process fo

Re: [PATCH v2 5/5] convert: add filter..process option

> On 30 Jul 2016, at 01:11, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 2016-07-29 o 19:35, Junio C Hamano pisze: >> Lars Schneider <larsxschnei...@gmail.com> writes: >> >>> I think sending it upfront is nice for buffer allocations of big files

Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

> On 30 Jul 2016, at 12:30, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> set_packet_header() converts an integer to a 4 byte hex string. Mak

Re: [PATCH v3 04/10] pkt-line: call packet_trace() only if a packet is actually send

> On 30 Jul 2016, at 14:29, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The packet_trace() call is not ideal in format_packet(

Re: [PATCH v3 10/10] convert: add filter..process option

> On 31 Jul 2016, at 00:05, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:38, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an external filter process fo

Re: [PATCH v3 06/10] run-command: add clean_on_exit_handler

> On 30 Jul 2016, at 11:50, Johannes Sixt <j...@kdbg.org> wrote: > > Am 30.07.2016 um 01:37 schrieb larsxschnei...@gmail.com: >> Some commands might need to perform cleanup tasks on exit. Let's give >> them an interface for doing this. >> >> Sig

Re: [PATCH v3 05/10] pack-protocol: fix maximum pkt-line size

> On 30 Jul 2016, at 15:58, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> According to LARGE_PACKET_MAX in pkt-line.h the maximal lenght

Re: [PATCH v3 03/10] pkt-line: add packet_flush_gentle()

> On 30 Jul 2016, at 14:04, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_flush() would die in case of a write error even though

Re: [PATCH v3 02/10] pkt-line: add direct_packet_write() and direct_packet_write_data()

> On 30 Jul 2016, at 12:49, Jakub Narębski <jna...@gmail.com> wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Sometimes pkt-line data is already available in a buffer and it wo

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 24 Jul 2016, at 22:14, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 2016-07-24 o 20:36, Lars Schneider pisze: >> On 23 Jul 2016, at 02:11, Jakub Narębski <jna...@gmail.com> wrote: >>> W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: >>

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 24 Jul 2016, at 23:30, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 2016-07-24 o 22:14, Jakub Narębski pisze: >> W dniu 2016-07-24 o 20:36, Lars Schneider pisze: > >>> I agree that the name is not ideal. "UseProtocol" as it is would be a >>

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 25 Jul 2016, at 01:22, Jakub Narębski <jna...@gmail.com> wrote: > W dniu 2016-07-25 o 00:36, Ramsay Jones pisze: >> On 24/07/16 18:16, Lars Schneider wrote: >>> On 23 Jul 2016, at 01:19, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >>>> On 22/0

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

On 25 Jul 2016, at 00:36, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > On 24/07/16 18:16, Lars Schneider wrote: >> >> On 23 Jul 2016, at 01:19, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: >> >>> On 22/07/16 16:49, larsxschnei...@

Re: [PATCH v3 10/10] convert: add filter..process option

1:38, larsxschnei...@gmail.com pisze: >>> From: Lars Schneider <larsxschnei...@gmail.com> >>> >>> Git's clean/smudge mechanism invokes an external filter process for every >>> single blob that is affected by a filter. If Git filters a lot of blo

Re: [PATCH v3 03/10] pkt-line: add packet_flush_gentle()

> On 31 Jul 2016, at 22:36, Torstem Bögershausen <tbo...@web.de> wrote: > > > >> Am 29.07.2016 um 20:37 schrieb larsxschnei...@gmail.com: >> >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_flush() would die in case of a wr

Re: [PATCH v3 10/10] convert: add filter..process option

> On 01 Aug 2016, at 00:19, Jakub Narębski wrote: > > W dniu 30.07.2016 o 01:38, larsxschnei...@gmail.com pisze: > [...] >> +Please note that you cannot use an existing filter..clean >> +or filter..smudge command as filter..process >> +command. > > I think it would be more

Re: What's cooking in git.git (Aug 2016, #03; Mon, 8)

> On 10 Aug 2016, at 19:36, Stefan Beller <sbel...@google.com> wrote: > > On Wed, Aug 10, 2016 at 10:30 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >>> >>> * sb/submodule-update-dot-branch (2016-08-03) 7 commits >>> (m

Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()

> On 10 Aug 2016, at 19:17, Junio C Hamano <gits...@pobox.com> wrote: > > Jeff King <p...@peff.net> writes: > >> On Wed, Aug 10, 2016 at 03:36:45PM +0200, Lars Schneider wrote: >> >>>> So now we have packet_write() and packet_write_gently()

Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()

> On 10 Aug 2016, at 20:21, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> On 10 Aug 2016, at 19:17, Junio C Hamano <gits...@pobox.com> wrote: >>> >> OK. Does this mean I can leave

Re: What's cooking in git.git (Aug 2016, #03; Mon, 8)

> > * sb/submodule-update-dot-branch (2016-08-03) 7 commits > (merged to 'next' on 2016-08-04 at 47bff41) > + submodule update: allow '.' for branch value > + submodule--helper: add remote-branch helper > + submodule-config: keep configured branch around > + submodule--helper: fix usage string

Re: [PATCH v5 05/15] pkt-line: add packet_write_gently_fmt()

> On 10 Aug 2016, at 19:18, Junio C Hamano wrote: > > Jeff King writes: > >> On Wed, Aug 10, 2016 at 03:04:01PM +0200, larsxschnei...@gmail.com wrote: >> >>> +int packet_write_gently_fmt(int fd, const char *fmt, ...) >>> +{ >>> + static struct strbuf buf =

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

> On 10 Aug 2016, at 15:15, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> format_packet() dies if the caller wants to forma

Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()

> On 10 Aug 2016, at 15:28, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:04:00PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> packet_write() has two shortcomings. First, it use

Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

> On 10 Aug 2016, at 15:13, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:03:58PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The packet_trace() call is not ideal in format_

Re: What's cooking in git.git (Aug 2016, #01; Tue, 2)

> > * jk/push-force-with-lease-creation (2016-07-26) 3 commits > - push: allow pushing new branches with --force-with-lease > - push: add shorthand for --force-with-lease branch creation > - Documentation/git-push: fix placeholder formatting > > "git push --force-with-lease" already had enough

Re: What's cooking in git.git (Aug 2016, #01; Tue, 2)

> On 04 Aug 2016, at 13:32, John Keeping <j...@keeping.me.uk> wrote: > > On Thu, Aug 04, 2016 at 10:03:39AM +0200, Lars Schneider wrote: >> >>> >>> * jk/push-force-with-lease-creation (2016-07-26) 3 commits >>> - push: allow pushing new

Re: `git stash --help` tries to pull up nonexistent file gitstack.html

> On 12 Aug 2016, at 17:48, Junio C Hamano wrote: > > Joseph Musser writes: > >> Looks like a simple typo. > > Unfortunately this does not reproduce to me (built from source on > Ubuntu Linux). I tried it with the latest released version on Windows and OSX

Re: [PATCH] t7406: fix breakage on OSX

whitespace > between `--depth` and the actual number. Prefer the solution of rev-list > counting as that is expected to be slightly faster and more self-sustained > within Git. > > Reported-by: Lars Schneider <larsxschnei...@gmail.com> > Helped-by: Junio C Hamano <gits...@pob

Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

> On 10 Aug 2016, at 15:30, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:24:38PM +0200, Lars Schneider wrote: > >>> On Wed, Aug 10, 2016 at 03:03:58PM +0200, larsxschnei...@gmail.com wrote: >>> >>>> From: Lars Schneider <la

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

> On 10 Aug 2016, at 15:37, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:29:26PM +0200, Lars Schneider wrote: > >> >>> On 10 Aug 2016, at 15:15, Jeff King <p...@peff.net> wrote: >>> >>> On Wed, Aug 10, 2016 at 03:03:5

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 18:48, Stefan Beller wrote: > > On Fri, Aug 12, 2016 at 9:38 AM, Jeff King wrote: >> On Fri, Aug 12, 2016 at 09:33:18AM -0700, Stefan Beller wrote: >> If the result content is empty then the filter is expected to respond with a

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 18:33, Stefan Beller <sbel...@google.com> wrote: > > On Wed, Aug 10, 2016 at 6:04 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Git's clean/smudge mechanism invokes an ext

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 19:13, Junio C Hamano <gits...@pobox.com> wrote: > > Lars Schneider <larsxschnei...@gmail.com> writes: > >>> If we do the success first and then error out halfway, we >>> still have to clean up, so I do not see how this impac

Re: [PATCH v5 14/15] convert: add filter..process option

> On 12 Aug 2016, at 19:07, Stefan Beller <sbel...@google.com> wrote: > > On Fri, Aug 12, 2016 at 9:59 AM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> >> The welcome message is necessary to distinguish the long running >> filter protocol (v2)

Re: [PATCH v5 05/15] pkt-line: add packet_write_gently_fmt()

> On 10 Aug 2016, at 15:43, Jeff King wrote: > > On Wed, Aug 10, 2016 at 03:04:01PM +0200, larsxschnei...@gmail.com wrote: > >> +int packet_write_gently_fmt(int fd, const char *fmt, ...) >> +{ >> +static struct strbuf buf = STRBUF_INIT; >> +va_list args; >> + >> +

Re: [ANNOUNCE] Git v2.9.1

On 13 Jul 2016, at 22:43, Junio C Hamano wrote: > Junio C Hamano writes: > >> It is somewhat disturbing that nobody seems to be regularly building >> on 32-bit platforms these days, which is the only reason I can think >> of why this was never reported

Re: [PATCH] t5541: fix url scrubbing test when GPG is not set

On 20 Jul 2016, at 13:32, Jeff King <p...@peff.net> wrote: > On Wed, Jul 20, 2016 at 10:20:33AM +0200, Lars Schneider wrote: > >>> * jk/push-scrub-url (2016-07-14) 1 commit >>> (merged to 'next' on 2016-07-19 at 6ada3f1) >>> + push: anonymize URL in status

Re: [PATCH] list: avoid incompatibility with *BSD sys/queue.h

> On 17 Jul 2016, at 02:25, Eric Wong <e...@80x24.org> wrote: > > Eric Wong <e...@80x24.org> wrote: >> Lars Schneider <larsxschnei...@gmail.com> wrote: >>> It looks like as if this topic breaks the OS X build because >>> it defines LIST_HEAD

Looking for help to understand external filter driver code

Hi, a long time ago in aa4ed4 Junio introduced the external filter driver definition. Since that time we fork the Git process and then we fork again to run the external filter. This is probably a super stupid question with an obvious answer... but can anyone help me to understand the code and

Re: Looking for help to understand external filter driver code

On 19 Jul 2016, at 23:33, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> Git writes --> 4 byte filename length >> Git writes --> filename string > > Why limit to 32GB? Perhaps NUL termination is m

<    1   2   3   4   5   6   7   8   9   10   >