On Wed, Dec 10, 2014 at 11:49:49PM +, brian m. carlson wrote:
From: brian m. carlson brian.carl...@cpanel.net
Thin packs are enabled when pushing by default, but with a large number
of refs and a fast network, git may spend more time trying to find a
good delta than it would spend simply
. Thanks for the suggestion.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
clones with lots of refs (23.322 seconds vs.
4.785 seconds with 22400 refs). Limit this extra edge-marking to
shallow clones to avoid poor performance.
Suggested-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
list-objects.c | 5 -
1 file
that providing a password will necessarily work.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital
like Git isn't sending the username and password.
I'll try to look at this a little more this weekend.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C
remote
helpers, which we don't want. We know what the right decision is here,
so let's just do it.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C
, much worse with pack bitmaps. The server has
bitmaps enabled, but it doesn't have any patches for this issue applied
to it.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B
--objects-edge to provide more performant behavior.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-rev-list.txt | 3 ++-
Documentation/rev-list-options.txt | 4
list-objects.c | 4 ++--
revision.c | 6
of the
decreased time spent marking edges push times will dwarf the increase in
time it takes for a slightly larger pack to go over the wire, so it
doesn't make sense to make this a tunable.
The original fix was suggested by Duy Nguyen.
brian m. carlson (3):
Documentation: add missing article in rev-list
history), the smaller pack size is advantageous there.
Adjust pack-objects to use --objects-edge-aggressive only for shallow
repositories.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/rev-list-options.txt | 3 ++-
builtin/pack-objects.c | 4 +++-
2
Add the missing article a.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/rev-list-options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/rev-list-options.txt
b/Documentation/rev-list-options.txt
index afccfdc..2277fcb
pain points with perl and curl, among others.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital
history), the smaller pack size is advantageous there.
Adjust pack-objects to use --objects-edge-aggressive only for shallow
repositories.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/rev-list-options.txt | 3 ++-
builtin/pack-objects.c | 4 +++-
2
Add the missing article a.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/rev-list-options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/rev-list-options.txt
b/Documentation/rev-list-options.txt
index afccfdc..2277fcb
the remote side is shallow.
The original fix was suggested by Duy Nguyen.
brian m. carlson (4):
Documentation: add missing article in rev-list-options.txt
rev-list: add an option to mark fewer edges as uninteresting
pack-objects: use --objects-edge-aggressive only for shallow repos
upload-pack
--objects-edge to provide more performant behavior.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-rev-list.txt | 3 ++-
Documentation/rev-list-options.txt | 4
list-objects.c | 4 ++--
revision.c | 6
is shallow
based on stdin; however, by the time we get to parsing stdin, we already
will have called setup_revisions and won't be able to change our
decision anymore. Teach pack-objects a --shallow option to indicate
that the remote side is shallow and use it in upload-pack.
Signed-off-by: brian m
the failure. I had an epiphany on how
to do that last night, so I'll reroll sometime today.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
decide between
--objects-edge and --objects-edge-aggressive.
Okay. I'll try to push it up the stack a little bit.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994
higher-level
commands pass --shallow for any shallow pushing and fetching instead of
trying to have pack-objects determine it.
The original fix was suggested by Duy Nguyen.
brian m. carlson (3):
Documentation: add missing article in rev-list-options.txt
rev-list: add an option to mark fewer
--objects-edge to provide more performant behavior.
Preserve the current behavior for the moment by using the aggressive
option.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-rev-list.txt | 3 ++-
Documentation/rev-list-options.txt | 4
builtin/pack
with a
shallow repository.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/git-pack-objects.txt | 7 ++-
Documentation/rev-list-options.txt | 3 ++-
builtin/pack-objects.c | 7 ++-
send-pack.c| 3 +++
upload-pack.c
Add the missing article a.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/rev-list-options.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/rev-list-options.txt
b/Documentation/rev-list-options.txt
index afccfdc..2277fcb
authentication if the ticket is missing or expired.
Teach the HTTP client code to stop trying authentication mechanisms that
don't use a password (currently Negotiate) after the first failure,
since if they failed the first time, they will never succeed.
Signed-off-by: brian m. carlson sand
On Sat, Dec 27, 2014 at 12:56:04PM -0500, Jeff King wrote:
On Sat, Dec 27, 2014 at 04:01:33AM +, brian m. carlson wrote:
Apache servers using mod_auth_kerb can be configured to allow the user
to authenticate either using Negotiate (using the Kerberos ticket) or
Basic authentication
and
hence always get the same response.
libcurl could theoretically be linked against any shared library
implementing the GSSAPI version 2. I only know if it being used in
Kerberos and NTLM in practice.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
and might have other
suggestions.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
authentication mechanisms that
don't use a password (currently Negotiate) after the first failure,
since if they failed the first time, they will never succeed.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
http.c| 16
http.h| 3 +++
remote-curl.c
know that it needs an extra layer of abstraction).
This does seem to handle both cases well. It also has the pleasant
side effect of being static.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4
things worse.
For what it's worth, I'll often sketch out a script at the command line
before putting it in a file (either because I realize I'll need to do
the same thing again or I want to share it with others), so I think this
might be a useful addition.
--
brian m. carlson / brian with sandals
extremely uncommon. So
they've already become used to using the bracketed notation, because
it's already required for the usual form and it's required in the IPv6
URL standard.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My
the bracketed form to deal with the case in which somebody
creates a directory called 1 in their home directory and writes:
git push 2001:470:1f05:79::1:1 master
when they mean
git push [2001:470:1f05:79::1]:1 master
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791
tree. You can use `no` to have `git status`
+time in a large working tree.
+Consider to enable untracked cache and split index if supported (see
This might sound more natural (at least to my ears) if you wrote
Consider enabling untracked cache….
--
brian m. carlson / brian with sandals: Houston
for
noticing.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
compile with debugging symbols and provide a backtrace? I'm not
seeing any such behavior on my end, and I'm not sure whether it's my
patch or something else that might be present in master.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
accepted URLs missing
the brackets required by RFC 2732. Note that this behavior is
deprecated and that other protocol handlers will not accept this syntax.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/urls.txt | 4
1 file changed, 4 insertions(+)
diff --git
that supports AT_SYMLINK_NOFOLLOW. Linux is
not one of those systems.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
of Getopt::Long or
explicitly handle this in the parsing code itself. I think the former
is a better choice, since no security-supported OS still ships with such
a positively ancient version.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
/etc/krb5.apache.keytab
When I was testing, I set KrbMethodK5Passwd to on and it did in fact
work. I'm using Debian's Apache 2.4.10-9 with mod_auth_kerb 5.4-2.2.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
for username/password).
2. Teach the http code to pull the bearer field out and stick it in an
Authorization header.
For the benefit of someone trying to implement this, libcurl has the
CURLOPT_XOAUTH2_BEARER option. It does requires libcurl 7.33, though.
--
brian m. carlson / brian
(prior to 2.32).
Obviously, tc/t9001-noxmailer topic will become unnecessary and be
dropped when that happens.
I think this is a good fix. It preserves the documented behavior even
on less capable systems.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
now, you only have Negotiate set up, so if
you don't have a ticket, it's going to fail.
I'd recommend making sure that you can access it using a web browser
after running kdestroy. That will ensure that it's working properly.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832
authentication mechanisms that
don't use a password (currently Negotiate) after the first failure,
since if they failed the first time, they will never succeed.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
Signed-off-by: Jeff King p...@peff.net
---
Peff's original change
On Fri, Feb 20, 2015 at 11:08:55PM +0100, Sebastian Schuberth wrote:
On 20.02.2015 01:03, brian m. carlson wrote:
If you want good performance, I'd recommend the latest version of Git
both client- and server-side. Newer versions of Git provide pack
bitmaps, which can dramatically speed up
performance problems and people
are generally responsive.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description
^| | gpg: Good signature actual
'
+test_expect_success 'forbid log --graph --no-walk' '
+test_must_fail git log --graph --no-walk
And here as well.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP
On Sun, Mar 15, 2015 at 01:55:28AM +0200, epilys wrote:
On 03/15/2015 01:47 AM, brian m. carlson wrote:
It looks like you indented here with four spaces instead of a tab.
We prefer tabs in Git.
Messed that up. Do you think I should resubmit a v3 or am I hogging
the mailing list too much
that we will actually be using.
If people have suggestions on how to improve it, I'm eager to hear them
and submit a reroll or follow-up patches, as appropriate. Making
changes now would be much better than having to do it down the line.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1
even looking at your patch, as
you just claimed it was confidential and proprietary and nobody wants to
be sued.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994
Convert the callers as well.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
refs.c | 4 ++--
refs.h | 2 +-
revision.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index 75d8970..758bdd9 100644
--- a/refs.c
+++ b/refs.c
.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/rev-parse.c | 27 +++
builtin/show-ref.c | 23 +--
log-tree.c | 19 +++
reachable.c | 13 -
shallow.c | 33
Convert head_ref and head_ref_submodule to use struct object_id.
Introduce some wrappers in some of the callers to handle
incompatibilities between each_ref_fn and each_ref_fn_oid.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/show-ref.c | 7 ++-
log-tree.c
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
refs.c | 46 +++---
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/refs.c b/refs.c
index 9edf18b..689a46d 100644
--- a/refs.c
+++ b/refs.c
@@ -129,7 +129,7 @@ struct ref_value
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
refs.c | 22 +++---
refs.h | 2 +-
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/refs.c b/refs.c
index 941e466..b54525a 100644
--- a/refs.c
+++ b/refs.c
@@ -2099,16 +2099,16 @@ static struct
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/fsck.c | 2 +-
builtin/reflog.c | 4 ++--
refs.c | 10 +-
refs.h | 2 +-
revision.c | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/builtin/fsck.c b/builtin
Convert head_ref_namespaced and for_each_namespaced_ref to use struct
object_id. Update the various callbacks to use struct object_id
internally as well.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
http-backend.c | 14 +++---
refs.c | 12 ++--
refs.h
do_for_each_ref was unused due to previous patches, so rename
do_for_each_ref_oid to do_for_each_ref. Similarly, remove the unused fn
member from struct ref_entry in favor of renaming the fn_oid member.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
refs.c | 43
each_ref_fn is no longer used, so rename each_ref_fn_oid to each_ref_fn.
Update the documentation to note the change in function signature.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
Documentation/technical/api-ref-iteration.txt | 2 +-
refs.c
/git.git
brian m. carlson (16):
refs: convert struct ref_entry to use struct object_id
refs: convert for_each_tag_ref to struct object_id
refs: convert remaining users of for_each_ref_in to object_id
refs: convert for_each_ref_in_submodule to object_id
refs: convert head_ref to struct object_id
Convert for_each_ref_in_submodule and all of its caller. Introduce two
temporary wrappers in revision.c to handle the incompatibilities between
each_ref_fn and each_ref_fn_oid.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
refs.c | 10 +-
refs.h | 8
On Fri, Mar 20, 2015 at 12:52:20PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
This is part 1 of n in converting code to use struct object_id.
OK --- 'n' up there looked funny ;-)
It is, unfortunately, a large task. I wish I could quantify it better
, convert modified
functions to use struct object_id instead of unsigned char [20].
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/checkout.c | 4 ++--
builtin/fetch.c| 6 +++---
builtin/name-rev.c | 6 +++---
builtin/pack-objects.c | 10 +-
builtin
Update callbacks to take the proper parameters and use struct object_id
elsewhere in the callbacks.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/replace.c | 14 +++---
refs.c| 4 ++--
refs.h| 2 +-
replace_object.c | 4 ++--
4 files
Convert callbacks to use struct object_id internally as well.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/branch.c | 4 ++--
builtin/describe.c | 12 ++--
builtin/for-each-ref.c | 4 ++--
builtin/fsck.c | 16
refs.c
Now that all the callers of handle_refs are gone, rename handle_refs_oid
to handle_refs and update the callers accordingly.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
revision.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git
suffix these new entries with _oid to distinguish
them. Convert for_each_tag_ref and its callers to use the new _oid
functions, introducing temporary wrapper functions to avoid type
mismatches.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/pack-objects.c | 4
Remove the temporary for_each_ref_in_oid function and update the users
of it. Convert the users of for_each_branch_ref and
for_each_remote_ref (which use for_each_ref_in under the hood) as well.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bisect.c| 8
On Wed, Mar 11, 2015 at 07:33:05PM +, Dan Langille (dalangil) wrote:
On Mar 10, 2015, at 6:29 PM, brian m. carlson sand...@crustytoothpaste.net
wrote:
Does it work with a ticket if you specify a username, as in the
following URL?
https://b...@git.crustytoothpaste.net/git/bmc/homedir.git
On Wed, Mar 11, 2015 at 05:26:56PM -0700, Junio C Hamano wrote:
brian m. carlson sand...@crustytoothpaste.net writes:
Michael Haggerty recommended that I call the structure element sha1
instead of oid in case we want to turn this into a union if we decide to
go the additional hash route.
I'd
, especially since it makes it more
obvious what code has been converted already.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
On Wed, Mar 11, 2015 at 03:20:08PM +0100, Michael Haggerty wrote:
On 03/08/2015 12:23 AM, brian m. carlson wrote:
struct directory {
struct directory *up;
- unsigned char sha1[20];
+ unsigned char sha1[GIT_SHA1_RAWSZ];
This is a local struct, and I think it is only
-documenting than my current set of patches,
so I'm going to go with it for now. It should be easy to change if the
consensus goes back the other way.
[0] I personally think globals are a bit gross, but they don't seem to
have the problems that they would if git were a shared library.
--
brian m. carlson
On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote:
On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson
sand...@crustytoothpaste.net wrote:
Perhaps this is better?
Unfortunately when running the test, that message is found in the standard
output of git show -s --show-signature
the new updateInstead functionality in git 2.3.0,
and you can use git pull from a remote location instead of the push/pull
pair if that suits you better.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bulk-checkin.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bulk-checkin.c b/bulk-checkin.c
index 0c4b8a7..e50f60e 100644
--- a/bulk-checkin.c
+++ b/bulk-checkin.c
@@ -24,7 +24,7 @@ static struct
Convert some constants to GIT_SHA1_HEXSZ.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bisect.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/bisect.c b/bisect.c
index 8c6d843..2692d54 100644
--- a/bisect.c
Also, convert a constant to GIT_SHA1_HEXSZ.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
combine-diff.c | 56
diff-lib.c | 10 +-
diff.h | 5 +++--
tree-diff.c| 10 +-
4 files changed
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/patch-id.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/builtin/patch-id.c b/builtin/patch-id.c
index 77db873..c208e7e 100644
--- a/builtin/patch-id.c
+++ b/builtin
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
archive-zip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/archive-zip.c b/archive-zip.c
index 4bde019..b669e50 100644
--- a/archive-zip.c
+++ b/archive-zip.c
@@ -427,12 +427,12 @@ static void
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/apply.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 65b97ee..75c5342 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -208,7 +208,7
Convert struct commit_graft and necessary local parts of commit.c.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c | 32
commit.h | 4 ++--
log-tree.c| 2 +-
send-pack.c | 2 +-
shallow.c | 8
upload
Convert a hard-coded 20 as well.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
archive.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/archive.c b/archive.c
index 96057ed..46d9025 100644
--- a/archive.c
+++ b/archive.c
@@ -101,7 +101,7
performance improvements will be passed
through to the new functions.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
I'm not very excited about having to put the #include in the middle of
cache.h. The alternative, of course, is to move enum object_type up,
which I can do if necessary
of compile-time checking for misuse. The structure is expected to remain
the same size and have the same alignment requirements on all known
platforms, compared to the array of unsigned char, although this is not
required for correctness.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
that this
deprived others of the ability to use the new structure and required me
to rebase extremely frequently.
brian m. carlson (10):
Define a structure for object IDs.
Define utility functions for object IDs.
bisect.c: convert leaf functions to use struct object_id
archive.c: convert to use struct
Also, convert a constant to GIT_SHA1_HEXSZ.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
combine-diff.c | 56
diff-lib.c | 10 +-
diff.h | 5 +++--
tree-diff.c| 10 +-
4 files changed
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
archive.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/archive.c b/archive.c
index 96057ed..d37c41d 100644
--- a/archive.c
+++ b/archive.c
@@ -101,7 +101,7 @@ static void
Convert some constants to GIT_SHA1_HEXSZ.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bisect.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/bisect.c b/bisect.c
index 8c6d843..10f5e57 100644
--- a/bisect.c
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/apply.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 65b97ee..c2c8f39 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -208,7 +208,7
performance improvements will be passed
through to the new functions.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
cache.h | 32
hex.c | 16 +---
2 files changed, 41 insertions(+), 7 deletions(-)
diff --git a/cache.h b/cache.h
index
Convert some magic numbers to the new GIT_SHA1 constants.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
builtin/patch-id.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/builtin/patch-id.c b/builtin/patch-id.c
index
immediately because it
looked like a bunch of work.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital
on the object-id branch (may be rebased) at
https://github.com/bk2204/git.git
https://git.crustytoothpaste.net/git/bmc/git.git
Both repositories are pushed at the same time.
brian m. carlson (10):
Define a structure for object IDs.
Define utility functions for object IDs.
bisect.c: convert
of compile-time checking for misuse. The structure is expected to remain
the same size and have the same alignment requirements on all known
platforms, compared to the array of unsigned char, although this is not
required for correctness.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
Convert struct commit_graft and necessary local parts of commit.c.
Also, convert several constants based on the hex length of an SHA-1 to
use GIT_SHA1_HEXSZ, and move several magic constants into variables for
readability.
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
commit.c
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
bulk-checkin.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bulk-checkin.c b/bulk-checkin.c
index 0c4b8a7..c80e503 100644
--- a/bulk-checkin.c
+++ b/bulk-checkin.c
@@ -24,7 +24,7 @@ static struct
Signed-off-by: brian m. carlson sand...@crustytoothpaste.net
---
archive-zip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/archive-zip.c b/archive-zip.c
index 4bde019..b669e50 100644
--- a/archive-zip.c
+++ b/archive-zip.c
@@ -427,12 +427,12 @@ static void
On Fri, Mar 13, 2015 at 11:39:26PM +, brian m. carlson wrote:
Changes since v1:
I just realized that I sent this out as v2 instead of v3. It really is
v3. My apologies for the error.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http
m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
?
Unfortunately when running the test, that message is found in the
standard output of git show -s --show-signature, but in the standard
error of git verify-commit -v causing the comparisons of both standard
output and standard error to fail.
--
brian m. carlson / brian with sandals: Houston
301 - 400 of 2261 matches
Mail list logo
