[PATCH] Documentation: build technical/multi-pack-index

The git-multi-pack-index doc links to technical/multi-pack-index.html. Ensure it is built to prevent a broken link. Signed-off-by: Todd Zullinger --- While building 2.20.0-rc0 I noticed the broken link from git-multi-pack-index to technical/multi-pack-index.html. Documentation/Makefile | 1

Re: [PATCH] t5551-http-fetch-smart.sh: sort cookies before comparing

Jeff King wrote: > On Fri, Sep 07, 2018 at 07:22:05PM -0400, Todd Zullinger wrote: > >> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output >> used in the 'cookies stored in http.cookiefile when http.savecookies >> set' test before comparing it

[PATCH] t5551-http-fetch-smart.sh: sort cookies before comparing

ibute for cookies", 2018-08-28) Signed-off-by: Todd Zullinger --- [Resending with the list in Cc; sorry for spamming you, Junio, Jeff, and Gábor.] The in-development version of Fedora updated to the recently released curl-7.61.1 in the past few days. This isn't breakage from the 2.19.0 cycle, but

Re: [RFC/PATCH] drop vcs-svn experiment

Hi Jeff, Jeff King wrote: > .gitignore | 1 - > Makefile | 22 -- > contrib/svn-fe/.gitignore | 4 - > contrib/svn-fe/Makefile| 105 --- > contrib/svn-fe/svn-fe.c| 18 -- > contrib/svn-fe/svn-fe.txt | 71 - >

Re: [RFC PATCH 1/1] recover: restoration of deleted worktree files

Hi, Robert P. J. Day wrote: > On Sat, 4 Aug 2018, Junio C Hamano wrote: >> In other words, I think this patch can be a fine addition to >> somebody else's project (i.e. random collection of scripts that may >> help Git users), so let's see how I can offer comments/inputs to >> help you improve

Re: [PATCH] doc: substitute ETC_GIT(CONFIG|ATTRIBUTES) in generated docs

stomized via the DOC_ETC_GITCONFIG and DOC_ETC_GITATTRIBUTES variables. Define DOC_GENERIC in dist-doc make target to ensure generic paths are used in the generated html and manpage tarballs. Helped-by: Jeff King Signed-off-by: Todd Zullinger --- Documentation/Makefile | 22 +

Re: [PATCH] doc: substitute ETC_GIT(CONFIG|ATTRIBUTES) in generated docs

Junio C Hamano wrote: > Jeff King writes: > >> Specifically, I'm thinking of: >> >> 1. The pre-built documentation that Junio builds for >> quick-install-doc. This _could_ be customized during the "quick" >> step, but it's probably not worth the effort. However, we'd want >>

Re: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path

Junio C Hamano wrote: > Todd Zullinger writes: > >> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore. >> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset, > > ... because $HOME/.config is the default value for XDG_CONFIG

Re: [PATCH] doc: substitute ETC_GIT(CONFIG|ATTRIBUTES) in generated docs

I wrote: > Jeff King wrote: >> (Related, there's a build target in the local Makefile for using >> asciidoctor; does it need updated, too?) > > I didn't test asciidoctor specficially, but it also respects > the ASCIIDOC_EXTRA parameters, so I think it will work just > as well. I'll try

Re: [PATCH] doc: substitute ETC_GIT(CONFIG|ATTRIBUTES) in generated docs

Jeff King wrote: > On Wed, Jun 27, 2018 at 12:56:37AM -0400, Todd Zullinger wrote: > >> Replace `$(prefix)/etc/gitconfig` and `$(prefix)/etc/gitattributes` in >> generated documentation with the paths chosen when building. Readers of >> the documentation should not ne

[PATCH] doc: substitute ETC_GIT(CONFIG|ATTRIBUTES) in generated docs

times using `/etc/gitconfig` to refer to the system-wide config file. Update the SYNOPSIS of gitattributes(5) to include the system-wide config file as well. Signed-off-by: Todd Zullinger --- I noticed this while looking to update gitattributes.txt to note the system-wide config file. I tested

[PATCH 1/2] gitignore.txt: clarify default core.excludesfile path

The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore. $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset, as described later in the document. Signed-off-by: Todd Zullinger --- Documentation/gitignore.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] dir.c: fix typos in core.excludesfile comment

Make it easier to find references to core.excludesfile and the default $XDG_CONFIG_HOME/git/ignore path. Signed-off-by: Todd Zullinger --- I noticed the typo in core.excludesfile and $XDG_CONFIG_HOME while I was verifing the previous change to clarify the documentation matched the code. Fixing

Re: [PATCH] t3404: check root commit in 'rebase -i --root reword root commit'

Junio C Hamano wrote: > Todd Zullinger writes: >> Or Junio may just squash this onto js/rebase-i-root-fix. > > Nah, not for a hotfix on the last couple of days before the final. > We'd need to build on top, not "squash". Indeed. I somehow missed that you'd m

[PATCH] t3404: check root commit in 'rebase -i --root reword root commit'

When testing a reworded root commit, ensure that the squash-onto commit which is created and amended is still the root commit. Suggested-by: Phillip Wood Helped-by: Johannes Schindelin Signed-off-by: Todd Zullinger --- Hi Johannes, Johannes Schindelin wrote: >On Mon, 18 Jun 2018, T

Re: What's cooking in git.git (Jun 2018, #05; Mon, 18)

Hi Junio, Junio C Hamano wrote: > * tz/cred-netrc-cleanup (2018-06-18) 3 commits > - git-credential-netrc: fix exit status when tests fail > - git-credential-netrc: use in-tree Git.pm for tests > - git-credential-netrc: minor whitespace cleanup in test script > > Build and test procedure for

Re: [PATCH 1/2] rebase --root: demonstrate a bug while amending rootcommit messages

Hi Phillip, Phillip Wood wrote: > On 15/06/18 05:31, Johannes Schindelin via GitGitGadget wrote: >> >> From: Todd Zullinger >> >> +test_expect_failure 'rebase -i --root reword root commit' ' >> +test_when_finished "test_might_fail git rebase --abort&q

Re: [PATCH 0/2] rebase --root: fix `reword` on a root commit

Hi, Junio C Hamano wrote: > Todd Zullinger writes: > >> Hi Johannes, >> >> Johannes Schindelin via GitGitGadget wrote: >>> From: GitGitGadget >>> >>> Todd Zullinger reported this bug in >>> https://public-inbox.org/git/201806150431

Re: [PATCH 0/2] rebase --root: fix `reword` on a root commit

Hi Johannes, Johannes Schindelin via GitGitGadget wrote: > From: GitGitGadget > > Todd Zullinger reported this bug in > https://public-inbox.org/git/20180615043111.gs3...@zaya.teonanacatl.net/: > when calling git rebase --root and trying to reword the > root commit's message,

BUG: sequencer.c:795: root commit without message -- when rewording root commit

Hi Johannes, I was splitting a repository tonight and ran 'rebase -i --root' to reword the initial commit. Then git died with 'BUG: sequencer.c:795: root commit without message.' A simple test case to show the failure: -- >8 -- diff --git a/t/t3404-rebase-interactive.sh

Re: [PATCH] git-credential-netrc: remove use of "autodie"

Hi, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Per my reading of the file this was the only thing autodie was doing >> in this file (there was no other code it altered). So let's remove it, >> both to fix the logic error and to get rid of the dependency. >> >> 1.

Re: [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script

Eric Sunshine wrote: > On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger wrote: >> Signed-off-by: Todd Zullinger >> --- >> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh >> b/contrib/credential/netrc/t-git-credential-netrc.sh >> in

[RFC PATCH v2 3/4] git-credential-netrc: use in-tree Git.pm for tests

From: Luis Marsano The netrc test.pl script calls git-credential-netrc which imports the Git module. Pass GITPERLLIB to git-credential-netrc via PERL5LIB to ensure the in-tree Git module is used for testing. Signed-off-by: Luis Marsano --- contrib/credential/netrc/t-git-credential-netrc.sh |

[RFC PATCH v2 4/4] git-credential-netrc: fix exit status when tests fail

From: Luis Marsano Signed-off-by: Luis Marsano --- contrib/credential/netrc/test.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contrib/credential/netrc/test.pl b/contrib/credential/netrc/test.pl index 2b5280ad6a..c0fb3718b2 100755 ---

[RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements

ree Git.pm for tests git-credential-netrc: fix exit status when tests fail Todd Zullinger (2): git-credential-netrc: make "all" default target of Makefile git-credential-netrc: minor whitespace cleanup in test script contrib/credential/netrc/Makefile | 3 +++ contri

[RFC PATCH v2 1/4] git-credential-netrc: make "all" default target of Makefile

Running "make" in contrib/credential/netrc should run the "all" target rather than the "test" target. Add an empty "all::" target like most of our other Makefiles. Signed-off-by: Todd Zullinger --- contrib/credential/netrc/Makefile | 3 +++ 1 file change

[RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script

Signed-off-by: Todd Zullinger --- contrib/credential/netrc/t-git-credential-netrc.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh b/contrib/credential/netrc/t-git-credential-netrc.sh index 58191a62f8..c5661087fe

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

Hi, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Jun 10 2018, Todd Zullinger wrote: > >>> I added 'use autodie;' without realizing it had external dependencies. >>> According to the documentation >>> http://perldoc.perl.org/autodie.html >>> it's

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

Hi Luis, Luis Marsano wrote: > Thanks for looking into this and addressing these issues. And thank you for digging further. :) > On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote: >> I noticed failures from the contrib/credential/netrc tests >> while building 2.18.0 rele

[RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

st git-credential-netrc was ok make: Leaving directory '/builddir/build/BUILD/git-2.18.0.rc1/contrib/credential/netrc' netrc test exit status: 0 Todd Zullinger (2): git-credential-netrc: make "all" default target of Makefile git-credential-netrc: use in-tree Git.pm for tests cont

[RFC PATCH 1/2] git-credential-netrc: make "all" default target of Makefile

Running "make" in contrib/credential/netrc should run the "all" target rather than the "test" target. Add an empty "all::" target like most of our other Makefiles. Signed-off-by: Todd Zullinger --- contrib/credential/netrc/Makefile | 3 +++ 1 file change

[RFC PATCH 2/2] git-credential-netrc: use in-tree Git.pm for tests

The netrc test.pl script calls git-credential-netrc which imports the Git module. Pass GITPERLLIB to git-credential-netrc via PERL5LIB to ensure the in-tree Git module is used for testing. Signed-off-by: Todd Zullinger --- contrib/credential/netrc/test.pl | 3 +++ 1 file changed, 3 insertions

Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test

Ramsay Jones wrote: [...] > I don't run the p4 or svn tests, so ... :-D Heh, lucky you. :) I try to run them all as part of the fedora builds since they cover much more than I'd ever use. That's the main reason I noticed the bare python. That would trip me up when it came time to build on a

Re: git rm bug

Thomas Fischer wrote: > I agree that the entire chain of empty directories should not be tracked, as > git tracks content, not files. > > However, when I run 'rm path/to/some/file', I expect path/to/some/ to still > exist. > > Similarly, when I run 'git rm path/to/some/file', I expect

Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test

g...@jeffhostetler.com wrote: > +# As a sanity check, ask Python to parse our generated JSON. Let Python > +# recursively dump the resulting dictionary in sorted order. Confirm that > +# that matches our expectations. > +test_expect_success PYTHON 'parse JSON using Python' ' [...] > + python

Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

Hi Jeff, Jeff Felchner wrote: > Ever since 2.17.0, when saving a patch (using add --patch > but probably other ways as well), if the whitespace is > removed from the initial column, the patch doesn't apply. This sounds a bit like the issue discussed in this thread a few weeks ago:

Re: [PATCH] packfile: Correct zlib buffer handling

Jeremy Linton wrote: > The buffer being passed to zlib includes a null terminator that > git needs to keep in place. unpack_compressed_entry() attempts to > detect the case that the source buffer hasn't been fully consumed > by checking to see if the destination buffer has been over consumed. > >

Re: [PATCH v2] rev-parse: check lookup'ed commit references for NULL

rt of > their logic. Neither usage checked the returned commit to see if it was > non-NULL before using it. Check for NULL and ensure an appropriate error > is reported to the user. > > Reported by Florian Weimer and Todd Zullinger. > > Helped-by: Jeff King <p...@peff.

Re: [PATCH 2/2] rev-parse: verify that commit looked up is not NULL

I wrote: > Thanks. This fixes the segfault. While I was testing this, > I wondered if the following cases should differ: Nevermind me. Jeff beat me to a reply and included much more useful details about why this occurs and suggestions for fixing it. :) > # f*40 > $ ./git-rev-parse

Re: [PATCH 2/2] rev-parse: verify that commit looked up is not NULL

Elijah Newren wrote: > In commit 2122f8b963d4 ("rev-parse: Add support for the ^! and ^@ syntax", > 2008-07-26), try_parent_shorthands() was introduced to parse the special > ^! and ^@ syntax. However, it did not check the commit returned from > lookup_commit_reference() before proceeding to use

Re: BUG: rev-parse segfault with invalid input

Hi, Elijah Newren wrote: > Thanks for the detailed report. This apparently goes back to > git-1.6.0 with commit 2122f8b963d4 ("rev-parse: Add support for the ^! > and ^@ syntax", 2008-07-26). We aren't checking that the commit from > lookup_commit_reference() is non-NULL before proceeding.

BUG: rev-parse segfault with invalid input

Hi, Certain invalid input causes git rev-parse to crash rather than return a 'fatal: ambiguous argument ...' error. This was reported against the Fedora git package: https://bugzilla.redhat.com/1581678 Simple reproduction recipe and analysis, from the bug: $ git init Initialized

Re: [PATCH v2] completion: reduce overhead of clearing cached --options

Hi Matthew, Matthew Coleman wrote: > I haven't seen any discussion about this recently. What > are the chances of getting it merged? I'd like to see this > included in 2.18. Junio's last few "What's cooking" updates have mentioned it: > * sg/completion-clear-cached (2018-04-18) 1 commit >

Re: [PATCH v2 12/18] branch-diff: use color for the commit pairs

Hi Johannes, Johannes Schindelin wrote: > Hi Todd, > > On Sat, 5 May 2018, Todd Zullinger wrote: > >>> @@ -430,6 +451,8 @@ int cmd_branch_diff(int argc, const char **argv, const >>> char *prefix) >>> struct string_list branch1 = STRING_LIST_INIT_

Re: [PATCH v2 02/18] Add a new builtin: branch-diff

I wrote: > Would it be possible and reasonable to teach 'git branch' to > call this as a subcommand, i.e. as 'git branch diff'? Then > the completion wouldn't offer git branch-diff. Of course right after I sent this, it occurred to me that 'git branch diff' would make mask the ability to create

Re: [PATCH v2 02/18] Add a new builtin: branch-diff

Hi Johannes, Johannes Schindelin wrote: > On Sat, 5 May 2018, Jeff King wrote: >> One minor point about the name: will it become annoying as a tab >> completion conflict with git-branch? > > I did mention this in the commit message of 18/18: > > Without this patch, we would only complete

Re: [PATCH v2 12/18] branch-diff: use color for the commit pairs

Hi Johannes, As many others have already said, thanks for this series! I've used tbdiff a bit over the years, but having a builtin will make it much more convenient (and the speed boost from a C implementation will be a very nice bonus). Johannes Schindelin wrote: > @@ -430,6 +451,8 @@ int

[PATCH] doc/clone: update caption for GIT URLS cross-reference

oid any confusion. Signed-off-by: Todd Zullinger <t...@pobox.com> --- Martin Ågren wrote: > On 18 April 2018 at 22:56, Todd Zullinger <t...@pobox.com> wrote: >> Subject: [PATCH] doc/clone: update caption for GIT URLS cross-reference >> >> The description of the arg

Re: man page for "git remote set-url" seems confusing/contradictory

or GIT URLS cross-reference The description of the argument directs readers to "See the URLS section below". When generating HTML this becomes a link to the "GIT URLS" section. When reading the man page in a terminal, the caption is slightly misleading. Use "GIT URLS&

Re: [PATCH v4] git{,-blame}.el: remove old bitrotting Emacs code

Thanks for working on this cruft cleanup Ævar and to Jonathan & Junio for asking questions about how to improve this transition for packagers & users. Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> On the other hand, the 6-lines of e-lisp you wrote for git.el

Re: [PATCH v14 2/4] ref-filter: make ref_array_item allocation more consistent

Hi Stefan, Stefan Beller wrote: > Please see the "What's cooking?" email on the mailing list that is > sent out periodically by Junio. > the last one is > https://public-inbox.org/git/xmqqd0z865pk@gitster-ct.c.googlers.com/ > which says: > >> * jk/ref-array-push (2018-04-09) 3 commits >> -

Re: [PATCH] Fix condition for redirecting stderr

Lucas Werkmeister wrote: > Since the --log-destination option was added in 0c591cacb ("daemon: add > --log-destination=(stderr|syslog|none)", 2018-02-04) with the explicit > goal of allowing logging to stderr when running in inetd mode, we should > not always redirect stderr to /dev/null in inetd

[PATCH] completion: complete tags with git tag --delete/--verify

the options", 2011-08-28). Extend tag name completion to --delete/--verify. Signed-off-by: Todd Zullinger <t...@pobox.com> --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/

Re: [PATCH] RelNotes: add details on Perl module changes

I wrote: > Document changes to core and non-core Perl module handling in 2.17. This should have: Signed-off-by: Todd Zullinger <t...@pobox.com> And perhaps also: Helped-by: Junio C Hamano <gits...@pobox.com> since I borrowed liberally from your initial text. :) > --- >

[PATCH] RelNotes: add details on Perl module changes

Document changes to core and non-core Perl module handling in 2.17. --- Junio C Hamano writes: >> I haven't wordsmithed it fully, but it should say something along >> the lines of ... >> >> Documentation/RelNotes/2.16.0.txt | 10 ++ >> 1 file changed, 10 insertions(+)

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

Hi, marmot1123 wrote: > In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions > `submodule’s`. > It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes. If replacing the non-ASCI apostrophes is the goal, aren't there a number of others in the same file worth cleaning up

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

I wrote: > Hi Jonathan, > > Jonathan Nieder wrote: >> Todd Zullinger wrote: > [...] >>> +++ b/Makefile >>> @@ -296,6 +296,9 @@ all:: >>> # >>> # Define NO_PERL if you do not want Perl scripts or libraries at all. >>> # >

[PATCH] Makefile: remove *.spec from clean target

Support for generating an rpm was dropped in ab214331cf ("Makefile: stop pretending to support rpmbuild", 2016-04-04). We don't generate any *.spec files so there is no need to clean them up. Signed-off-by: Todd Zullinger <t...@pobox.com> --- I noticed this minor cruft today.

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

Hi Jonathan, Jonathan Nieder wrote: > Todd Zullinger wrote: [...] >> +++ b/Makefile >> @@ -296,6 +296,9 @@ all:: >> # >> # Define NO_PERL if you do not want Perl scripts or libraries at all. >> # >> +# Define NO_PERL_CPAN_FALLBACKS if you do not want t

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

Ævar Arnfjörð Bjarmason wrote: > On Thu, Feb 15 2018, Todd Zullinger jotted: >> What about moving perl/Git/FromCPAN to perl/FromCPAN and >> then including perl/FromCPAN in LIB_PERL{,_GEN} only if >> NO_PERL_CPAN_FALLBACKS is unset? >> >> LIB_PERL := $(wildcard p

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

[I dropped bbour...@slb.com from the Cc: list, as it bounced on my previous reply.] Ævar Arnfjörð Bjarmason wrote: > That makes sense, I'll incorporate that in a re-roll. I like > NO_PERL_CPAN_FALLBACKS or just NO_CPAN_FALLBACKS better. Either is an improvement. Starting with NO_PERL_ seems

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

Hi Jonathan, Jonathan Nieder wrote: > Ævar Arnfjörð Bjarmason wrote: > [...] >> +++ b/perl/Git/LoadCPAN.pm >> @@ -0,0 +1,74 @@ > [...] >> +The Perl code in Git depends on some modules from the CPAN, but we >> +don't want to make those a hard requirement for anyone building from >> +source. > >

Re: [PATCH 3/8] perl: generalize the Git::LoadCPAN facility

ter make install? If so, would it be useful to add a Makefile knob to not install the FromCPAN bits, which may be generally useful to packagers? Something like the following, perhaps? (I'd feel bad suggesting this without a patch, after all the work you've already done to simplify and improve th

Re: categorization, documentation and packaging of "git core" commands

Robert P. J. Day wrote: > not to belabour this (and i'm sure it's *way* too late for that), > but fedora has the following packaging scheme. first, there's a bunch > of stuff in "git-core", which has no dependencies on any other > git-related packages. The split in Fedora between git and

Re: categorization, documentation and packaging of "git core" commands

Robert P. J. Day wrote: > On Wed, 7 Feb 2018, Todd Zullinger wrote: > >> Robert P. J. Day wrote: >>> first, here are the executables under /usr/libexec/git-core/ that >>> are unreferenced by that web page, but that should be fine as >>> almost all of them

Re: categorization, documentation and packaging of "git core" commands

ackage but it's not there now. It hasn't been in Fedora since 2011. The tla command which is required for git-archimport was retired, thus we removed the git-arch package. The rpm changelog shows this: * Tue Jul 26 2011 Todd Zullinger <t...@pobox.com> - 1.7.6-4 - Drop git-arch on fedora >= 1

Re: "git branch" issue in 2.16.1

Hi Jason, Jason Racey wrote: > After upgrading git from 2.16.0 to 2.16.1 (via Homebrew - > I’m on macOS) I noticed that the “git branch” command > appears to display the branch listing in something similar > to a vi editor - though not quite the same. I don’t know > the technical term for this

Re: t9128 failing randomly with svn 1.9?

I wrote: > The 'git svn' tests are not run in Travis because the perl > subversion bindings are not installed. I haven't made time > to try installing them and running the tests in Travis to > see if the failures occur there, but I suspect they would. Before anyone spends time wondering about

Re: t9128 failing randomly with svn 1.9?

Eric Wong wrote: > Todd Zullinger <t...@pobox.com> wrote: > Just a guess, but it might be related to destruction order. > Running t9128 on a 32-bit Pentium-M, it took me 39 tries to > fail. > > diff --git a/git-svn.perl b/git-svn.perl > index 76a75d0b3d..2ba14269bb

Re: t9128 failing randomly with svn 1.9?

brian m. carlson wrote: > While running tests for my object_id part 11 series, I noticed a random > segfault in git svn while running t9128. I've reproduced this on a > different machine as well, using both Subversion 1.9.5 and 1.9.7 (Debian > stable and unstable). It is reproducible on master.

[PATCH] doc: mention 'git show' defaults to HEAD

he default. Signed-off-by: Todd Zullinger <t...@pobox.com> --- This was mentioned in #git today by qaz. It seems reasonable to document the default. Documentation/git-show.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-show.txt b/Documentat

Re: [PATCH v4 1/4] Add tar extract install options override in installation processing.

Junio C Hamano wrote: > randall.s.bec...@rogers.com writes: >> +# Define TAR_EXTRACT_OPTIONS if you want to change the default behaviour >> +# from xvf to something else during installation. The option only includes ^^^ Shouldn't this be xof? >> +# "o" as xf are required. -- Todd

Re: Segmentation fault on clone

Hi Stephen, Stephen M. McQuay wrote: > I submitted a bug against the brew project when git > version 2.16.0 started segfaulting: > > https://github.com/Homebrew/homebrew-core/issues/23045#issuecomment-358891009 This seems likely to be the same segfault as:

Re: git 2.16.0 segfaults on clone of specific repo

Eric Sunshine wrote: > Nice detective work. This particular manifestation is caught by the > following test which fails without brian's patch on MacOS (and > presumably Windows) and succeeds with it. On Linux and BSD, it will of > course succeed always, so I'm not sure how much practical value it

Re: Git uses wrong subkey for signing commits with GPG key

Andrzej Ośmiałowski wrote: > On Sat, Jan 13, 2018 at 1:22 AM, Todd Zullinger <t...@pobox.com> wrote: >> I could be wrong, but I think you need to append '!' to >> KEYID to force gpg to use that specific signing subkey. [...] > thanks for reply. You just solved my is

Re: Git uses wrong subkey for signing commits with GPG key

Hi Andrzej, Andrzej Ośmiałowski wrote: > I have an issue with git and signing commits with GPG subkey. > > My setup: > - master key used for certification only > - subkey for my main workstation > - subkey for my mobile workstation (a notebook). > > Both subkeys are used for signing only. > >

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

Jeff King wrote: > On Tue, Jan 02, 2018 at 07:39:46PM -0500, Todd Zullinger wrote: >> I don't know if there's a clean way to do that >> automatically, short of parsing the output of 'httpd -v' >> should we ever need to add such a prereq. > > In the general cas

Re: [PATCH] http: fix v1 protocol tests with apache httpd < 2.4

Brandon Williams wrote: > Seems good to me. I think I was just being overly cautious when i was > implementing those patches. Thanks! Cool, thanks for taking a look. In this case, the test isn't dependent on apache > 2.4, but before I checked that I wondered if we had any way to run a test

[PATCH] doc/SubmittingPatches: improve text formatting

it easier for them. Signed-off-by: Todd Zullinger <t...@pobox.com> --- I missed this in the initial discussion. It was mentioned by Junio and brian explained the reasoning for using it in <20171031012710.jfemqb6ybiog4...@genre.crustytoothpaste.net>: > > The +fixed width with

[PATCH] http: fix v1 protocol tests with apache httpd < 2.4

irective work with lower versions, at least as far back as 2.0, according to the httpd documentation: https://httpd.apache.org/docs/2.0/mod/mod_setenvif.html Drop the restriction. Tested with httpd 2.2 and 2.4. Signed-off-by: Todd Zullinger <t...@pobox.com> --- These tests fail with 2

Re: [PATCH] Add shell completion for git remote rm

Ævar Arnfjörð Bjarmason wrote: >> I think adding 'rm' to completion definitely counts as advertisement. >> It doesn't have much practical use, after all: typing 'rm' with >> completion is actually one more keystroke than without (rm vs. rm). > > This is only one use of the completion interface,

Re: [PATCH] diff-tree: obey the color.ui configuration

Ævar Arnfjörð Bjarmason wrote: > No idea how to test this, in particular trying to pipe the output of > color.ui=never v.s. color.ui=auto to a file as "auto" will disable > coloring when it detects a pipe, but this fixes the issue. You might be able to use similar methods as those Jeff used in

Re: [PATCH] Add shell completion for git remote rm

Keith Smiley wrote: > It looks like that was just about preferring remove in documentation > and the like, I think it would still make sense to have both for > completion since rm is still supported. I read it as a first step in a long process to eventually remove 'remote rm', but if that's never

Re: [PATCH] Add shell completion for git remote rm

Hi Keith, Keith Smiley wrote: > Previously git remote rm did not complete your list of removes as remove > does. Looking through the history, the rm subcomand completion was explicitly removed in e17dba8fe1 ("remote: prefer subcommand name 'remove' to 'rm'", 2012-09-06). -- Todd

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

Ævar Arnfjörð Bjarmason wrote: > On Wed, Dec 20, 2017 at 6:41 PM, Todd Zullinger <t...@pobox.com> wrote: >> /usr/share/perl5/vendor_perl/Git >> /usr/share/perl5/vendor_perl/Git.pm >> /usr/share/perl5/vendor_perl/Git/Error.pm >> [...] >> /usr/share/perl

Re: [PATCH v5] Makefile: replace perl/Makefile.PL with simple make rules

Ævar Arnfjörð Bjarmason wrote: > [Sorry for not CC-ing you on the last version. Forgot to update the > giant send-email line I'm juggling for this series]. No worries. It is a rather large CC list at this point. :) > This *.pmc thing is just me being overly clever. Here's a v5 that gets > rid

Re: [PATCH v4] Makefile: replace perl/Makefile.PL with simple make rules

Hi Ævar, Ævar Arnfjörð Bjarmason wrote: > Here's a hopefully final version. The only difference with v3 is: > > -local @_ = ($caller, @_); > +unshift @_, $caller; > > As it turns out localizing @_ isn't something that worked properly > until >

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

Hi Michael, Michael J Gruber wrote: > This patch (currently in origin/next) makes a ton of tests from our test > suite fail for me on pretty standard systems (Fedora 27, CentOS 7.4.1708). > > Is there anything I'm supposed to do differently now to make our test > suite run? If yes then a clear

Re: [PATCH] git-svn: convert CRLF to LF in commit message to SVN

Hi Brian, Bennett, Brian wrote: > Thank you for your fast response, > > I haven't done a build of this type before (so I could > test the patch first) so I'm trying to do that and get > this far: ... > I don't want to drag out testing the patch, so if either > of you are able to quickly guide me

Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Junio C Hamano wrote: > Todd Zullinger <t...@pobox.com> writes: >> I wanted to check if this minor patch series had slipped >> under your radar. > > Totally. Queued. > > As they come with Ack by the area maintainer, I'll fast-track them > down to 'master' (

[PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Hi Junio, I wanted to check if this minor patch series had slipped under your radar. If it's waiting patiently in your queue for other topics to advance, that's fine, of course. :) Finished patches: <20171201155653.29553-1-...@pobox.com> and <20171201155653.29553-2-...@pobox.com>. Thanks, --

[PATCH] RelNotes: minor typo fixes in 2.16.0 draft

Signed-off-by: Todd Zullinger <t...@pobox.com> --- Documentation/RelNotes/2.16.0.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/RelNotes/2.16.0.txt b/Documentation/RelNotes/2.16.0.txt index 3eeeb83674..f7fca7123f 100644 --- a/Documentation/Re

Re: [PATCH] t/helper: ignore everything but sources

Hi Stefan, Stefan Beller wrote: >> If we ignore everything but resurrect *.[ch] with negative exclude >> rules, can we do the same without moving things around? > > Yes, there is also one lonely shell script in there, which also needs > exclusion. There aren't currently any .h files, but I

Re: [PATCH] doc: clarify usage of XDG_CONFIG_HOME config file

Hi Jacob, Jacob Keller wrote: > The documentation for git config and how it reads the user specific > configuration file is misleading. In some places it implies that > $XDG_CONFIG_HOME/git/config will always be read. In others, it implies > that only one of ~/.gitconfig and

Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)

Jeff Hostetler wrote: I'm looking at t5616 now on my mac. Looks like the MAC doesn't like my line counting in the tests. I'll fix in my next version. Perhaps that's as simple as using the test_line_counts helper? diff --git i/t/t5616-partial-clone.sh w/t/t5616-partial-clone.sh index

Re: What's cooking in git.git (Dec 2017, #01; Mon, 4)

Johannes Schindelin wrote: That is not the only thing going wrong: https://travis-ci.org/git/git/builds/312551566 It would seem that t9001 is broken on Linux32, t5616 is broken on macOS, and something really kinky is going on with the GETTEXT_POISON text, as it seems to just abort

Re: [PATCH] Add a sample hook which saves push certs as notes

Hi Shikher, I'm not familiar with push certs, but I did notice some general issues in the sample hook. I hope they're helpful. Shikher Verma wrote: index 0..b4366e43f --- /dev/null +++ b/templates/hooks--post-receive.sample +#!/bin/sh ... +if test -z GIT_PUSH_CERT ; then +exit 0

[PATCH v2 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

alse' or 'auto' to enable these tests. Acked-by: Eric Wong <e...@80x24.org> Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> Signed-off-by: Todd Zullinger <t...@pobox.com> --- t/lib-git-svn.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/lib-git-svn

[PATCH v2 1/2] t/lib-git-svn: cleanup inconsistent tab/space usage

Acked-by: Eric Wong <e...@80x24.org> Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> Signed-off-by: Todd Zullinger <t...@pobox.com> --- t/lib-git-svn.sh | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/t/lib-git-svn.sh b/t/li

Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Jonathan Nieder wrote: Yep, with this description it is Reviewed-by: Jonathan Nieder Thanks for putting up with my nits. :) Thank you for taking the time and looking at the details. :) I'll send a v2 with the changes in the morning, in case there are any other comments

  1   2   >