kasakrisz commented on code in PR #3761:
URL: https://github.com/apache/hive/pull/3761#discussion_r1035633744
##
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java:
##
@@ -104,44 +106,43 @@ private HiveSubQueryRemoveRule(RelOptRuleOperand o
deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035630068
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##
@@ -120,16 +114,11 @@ public void initialize(@Nullable Configuration
confi
deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035628537
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -236,11 +236,25 @@ public void
commitCreateTable(org.apache.hadoop.h
deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035625885
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -236,11 +236,25 @@ public void
commitCreateTable(org.apache.hadoop.h
deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035623871
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##
@@ -236,11 +236,25 @@ public void
commitCreateTable(org.apache.hadoop.h
xiuzhu9527 commented on PR #3762:
URL: https://github.com/apache/hive/pull/3762#issuecomment-1331742477
@ayushtkn Have you had a chance to look over the PR I sent you? THX！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
xiuzhu9527 commented on PR #3764:
URL: https://github.com/apache/hive/pull/3764#issuecomment-1331742130
@deniskuzZ Have you had a chance to look over the PR I sent you? THX！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
shameersss1 commented on PR #3807:
URL: https://github.com/apache/hive/pull/3807#issuecomment-1331643135
@kasakrisz - I have addressed your comments. Please review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sonarcloud[bot] commented on PR #3813:
URL: https://github.com/apache/hive/pull/3813#issuecomment-1331633764
Kudos, SonarCloud Quality Gate passed! [.
This patch introduced support for DBCP as a connection pool for the me
nrg4878 merged PR #3776:
URL: https://github.com/apache/hive/pull/3776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or
ayushtkn commented on PR #3813:
URL: https://github.com/apache/hive/pull/3813#issuecomment-1331264062
Thanx @cnauroth for the review, Have addressed the review comments, my
initial use case was around the queries only so ignored setting user in the
other places, I have now added everywhere
ayushtkn commented on code in PR #3813:
URL: https://github.com/apache/hive/pull/3813#discussion_r1035251314
##
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##
@@ -250,7 +250,8 @@ CommandProcessorResponse processLocalCmd(String cmd,
CommandProcessor proc, CliS
ayushtkn commented on code in PR #3813:
URL: https://github.com/apache/hive/pull/3813#discussion_r1035250375
##
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:
##
@@ -328,7 +328,8 @@ public Object run() throws HiveSQLException {
if (!embedded
ayushtkn commented on code in PR #3813:
URL: https://github.com/apache/hive/pull/3813#discussion_r1035247107
##
service/src/java/org/apache/hive/service/cli/operation/Operation.java:
##
@@ -237,7 +238,9 @@ protected void createOperationLog() {
* Set up some preconditions, or
yigress commented on PR #3781:
URL: https://github.com/apache/hive/pull/3781#issuecomment-1331243809
@pvary can you help review this? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cnauroth commented on code in PR #3813:
URL: https://github.com/apache/hive/pull/3813#discussion_r1035232269
##
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:
##
@@ -328,7 +328,8 @@ public Object run() throws HiveSQLException {
if (!embedded
ayushtkn merged PR #3810:
URL: https://github.com/apache/hive/pull/3810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o
saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1035187132
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##
@@ -1363,18 +1363,62 @@ private void create_databas
sonarcloud[bot] commented on PR #3814:
URL: https://github.com/apache/hive/pull/3814#issuecomment-1331130659
Kudos, SonarCloud Quality Gate passed! [ {
: AcidUtils.isCompactionTable(get
veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034448421
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java:
##
@@ -115,6 +115,7 @@ enum MUTEX_KEY {
// Compactor types
sonarcloud[bot] commented on PR #3812:
URL: https://github.com/apache/hive/pull/3812#issuecomment-1330272664
Kudos, SonarCloud Quality Gate passed! [ under
deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034414269
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##
@@ -273,6 +273,7 @@ public CompactionInfo
find
deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034413527
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java:
##
@@ -115,6 +115,7 @@ enum MUTEX_KEY {
// Compactor types
deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034411726
##
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MRCompactor.java:
##
@@ -261,7 +285,7 @@ public void run(HiveConf conf, String jobName, Table t,
Partition p, Sto
56 matches
Mail list logo
