Re: [PR] HIVE-27118: Add HMS token to UGI,for iceberg table insert on HiveClient [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4821: URL: https://github.com/apache/hive/pull/4821#issuecomment-1788492600 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27663 - implement array_position UDF in Hive [hive]

2023-10-31 Thread via GitHub
tarak271 commented on PR #4653: URL: https://github.com/apache/hive/pull/4653#issuecomment-1788462021 @okumin could you pls help with review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] HIVE-27833: Hive Acid Replication Support for Dell Powerscale [hive]

2023-10-31 Thread via GitHub
harshal-16 commented on code in PR #4841: URL: https://github.com/apache/hive/pull/4841#discussion_r1378379278 ## shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java: ## @@ -172,6 +173,10 @@ public static boolean checkFileSystemXAttrSupport(FileSystem fs) throws

Re: [PR] HIVE-27118: Add HMS token to UGI,for iceberg table insert on HiveClient [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4821: URL: https://github.com/apache/hive/pull/4821#issuecomment-1788376030 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27833: Hive Acid Replication Support for Dell Powerscale [hive]

2023-10-31 Thread via GitHub
ayushtkn commented on code in PR #4841: URL: https://github.com/apache/hive/pull/4841#discussion_r1378357966 ## shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java: ## @@ -172,6 +173,10 @@ public static boolean checkFileSystemXAttrSupport(FileSystem fs) throws IO

Re: [PR] HIVE-27118: Add HMS token to UGI,for iceberg table insert on HiveClient [hive]

2023-10-31 Thread via GitHub
hzxiongyinke commented on PR #4821: URL: https://github.com/apache/hive/pull/4821#issuecomment-1788339654 > You must run the test inside `itests/hive-unit` directory using the command - `mvn test -Dtest=` > > Again all of this information is available here - https://cwiki.apache.org/

Re: [PR] HIVE-27499: Include optional db/table names in the NotificationEvent … [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4569: URL: https://github.com/apache/hive/pull/4569#issuecomment-1788285575 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27023: Add setting to prevent tez session from being opened duri… [hive]

2023-10-31 Thread via GitHub
github-actions[bot] commented on PR #4015: URL: https://github.com/apache/hive/pull/4015#issuecomment-1788209629 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-27531: Unparse identifiers in show create table output [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4779: URL: https://github.com/apache/hive/pull/4779#issuecomment-1788131376 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-24706: add the HiveHBaseTableInputFormatV2 to fix the compatible… [hive]

2023-10-31 Thread via GitHub
alexdongli0829 commented on PR #4199: URL: https://github.com/apache/hive/pull/4199#issuecomment-1788115137 Waiting for the review and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] HIVE-27593: Iceberg: Keep iceberg properties in sync with hms properties [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4573: URL: https://github.com/apache/hive/pull/4573#issuecomment-1788101157 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27828: Iceberg integration: enable copy on write update when split update is on [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4832: URL: https://github.com/apache/hive/pull/4832#issuecomment-1787845972 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27533: Incorrect FOREIGN KEY constraints in SHOW CREATE TABLE [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4837: URL: https://github.com/apache/hive/pull/4837#issuecomment-1787689988 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27593: Iceberg: Keep iceberg properties in sync with hms properties [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4573: URL: https://github.com/apache/hive/pull/4573#issuecomment-1787512737 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27662: Incorrect parsing of nested complex types containing map during vectorized text processing [hive]

2023-10-31 Thread via GitHub
Aggarwal-Raghav commented on PR #4664: URL: https://github.com/apache/hive/pull/4664#issuecomment-1787356752 @ayushtkn, can you please review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HIVE-24815: Remove IDXS Table from Metastore Schema [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4370: URL: https://github.com/apache/hive/pull/4370#issuecomment-1787321579 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27833: Hive Acid Replication Support for Dell Powerscale [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4841: URL: https://github.com/apache/hive/pull/4841#issuecomment-1787291638 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27113: Increasing default for hive.thrift.client.max.message.size to 2147483647 bytes [hive]

2023-10-31 Thread via GitHub
rtrivedi12 commented on code in PR #4704: URL: https://github.com/apache/hive/pull/4704#discussion_r1377584726 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -2928,10 +2928,10 @@ public static enum ConfVars { HIVE_STATS_MAX_NUM_STATS("hive.stats.max.num

[PR] HIVE-27833: Hive Acid Replication Support for Dell Powerscale [hive]

2023-10-31 Thread via GitHub
harshal-16 opened a new pull request, #4841: URL: https://github.com/apache/hive/pull/4841 Issue : Hive Acid Replication on Dell Powerscale Isilon fails because it throws Exception while checking support for XAttrs. Isilon only supports getXAttrs on /.reserved/raw paths Testing : Tes

Re: [PR] HIVE-27593: Iceberg: Keep iceberg properties in sync with hms properties [hive]

2023-10-31 Thread via GitHub
sonarcloud[bot] commented on PR #4573: URL: https://github.com/apache/hive/pull/4573#issuecomment-1786947110 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27593: Iceberg: Keep iceberg properties in sync with hms properties [hive]

2023-10-31 Thread via GitHub
zhangbutao commented on code in PR #4573: URL: https://github.com/apache/hive/pull/4573#discussion_r1377304025 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -972,14 +972,43 @@ private boolean isOrcOnlyFiles(org.apache.hadoop

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-31 Thread via GitHub
veghlaci05 merged PR #4577: URL: https://github.com/apache/hive/pull/4577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377297690 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ## @@ -1933,6 +1934,16 @@ public List dropPartitions(St

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377289288 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -5026,7 +5026,8 @@ static boolean isMustPurge(EnvironmentC

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377289288 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -5026,7 +5026,8 @@ static boolean isMustPurge(EnvironmentC

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377289288 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -5026,7 +5026,8 @@ static boolean isMustPurge(EnvironmentC

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377255204 ## ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java: ## @@ -565,8 +565,14 @@ public static Map> getFullPartitionSpecs( CommonTree ast, Table table, Co

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377247881 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java: ## @@ -292,4 +295,12 @@ public static void performMetadataDelete(Table iceber

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377240091 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -997,6 +1011,62 @@ public void postGetTable(org.apache.hadoop.hive.m

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377235028 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -997,6 +1011,62 @@ public void postGetTable(org.apache.hadoop.hive.m

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377227408 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -997,6 +1011,62 @@ public void postGetTable(org.apache.hadoop.hive.m

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377221838 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -997,6 +1011,62 @@ public void postGetTable(org.apache.hadoop.hive.m

Re: [PR] HIVE-27779: Iceberg: Drop partition support [hive]

2023-10-31 Thread via GitHub
deniskuzZ commented on code in PR #4785: URL: https://github.com/apache/hive/pull/4785#discussion_r1377214386 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ## @@ -129,7 +143,7 @@ public class HiveIcebergMetaHook implements HiveMeta