Re: [PR] HIVE-27951: hcatalog dynamic partitioning fails with partition alread… [hive]

2023-12-16 Thread via GitHub
sunchao commented on code in PR #4937: URL: https://github.com/apache/hive/pull/4937#discussion_r1429005528 ## hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java: ## @@ -538,17 +538,17 @@ private void moveTaskOutputs(final Configurat

Re: [PR] Bump org.apache.kafka:kafka_2.12 from 2.5.0 to 2.6.3 in /itests/qtest-druid [hive]

2023-12-16 Thread via GitHub
dependabot[bot] commented on PR #4668: URL: https://github.com/apache/hive/pull/4668#issuecomment-1858996179 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] Bump org.apache.kafka:kafka-clients from 2.5.0 to 2.6.3 in /itests/qtest-druid [hive]

2023-12-16 Thread via GitHub
dependabot[bot] commented on PR #4669: URL: https://github.com/apache/hive/pull/4669#issuecomment-1858996173 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] Bump com.github.tomakehurst:wiremock-jre8-standalone from 2.32.0 to 2.35.1 in /standalone-metastore/metastore-server [hive]

2023-12-16 Thread via GitHub
dependabot[bot] commented on PR #4676: URL: https://github.com/apache/hive/pull/4676#issuecomment-1858996170 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] Bump org.apache.kafka:kafka-clients from 2.5.0 to 2.6.3 in /itests/qtest-druid [hive]

2023-12-16 Thread via GitHub
github-actions[bot] closed pull request #4669: Bump org.apache.kafka:kafka-clients from 2.5.0 to 2.6.3 in /itests/qtest-druid URL: https://github.com/apache/hive/pull/4669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Bump org.apache.kafka:kafka_2.12 from 2.5.0 to 2.6.3 in /itests/qtest-druid [hive]

2023-12-16 Thread via GitHub
github-actions[bot] closed pull request #4668: Bump org.apache.kafka:kafka_2.12 from 2.5.0 to 2.6.3 in /itests/qtest-druid URL: https://github.com/apache/hive/pull/4668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump com.github.tomakehurst:wiremock-jre8-standalone from 2.32.0 to 2.35.1 in /standalone-metastore/metastore-server [hive]

2023-12-16 Thread via GitHub
github-actions[bot] closed pull request #4676: Bump com.github.tomakehurst:wiremock-jre8-standalone from 2.32.0 to 2.35.1 in /standalone-metastore/metastore-server URL: https://github.com/apache/hive/pull/4676 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] HIVE-27509: query-executors fail to start: java.lang.NoSuchFieldError… [hive]

2023-12-16 Thread via GitHub
github-actions[bot] commented on PR #4758: URL: https://github.com/apache/hive/pull/4758#issuecomment-1858996147 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-12-16 Thread via GitHub
simhadri-g commented on code in PR #4761: URL: https://github.com/apache/hive/pull/4761#discussion_r1428900076 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: ## @@ -469,12 +470,13 @@ private Long getSnapshotId(Table table, St

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-12-16 Thread via GitHub
simhadri-g commented on code in PR #4761: URL: https://github.com/apache/hive/pull/4761#discussion_r1428899967 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -2231,7 +2231,6 @@ public static enum ConfVars { "If this is set to true the URI for auth w

Re: [PR] HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables [hive]

2023-12-16 Thread via GitHub
sonarcloud[bot] commented on PR #4744: URL: https://github.com/apache/hive/pull/4744#issuecomment-1858879490 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
sonarcloud[bot] commented on PR #4517: URL: https://github.com/apache/hive/pull/4517#issuecomment-1858858431 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables [hive]

2023-12-16 Thread via GitHub
wecharyu commented on code in PR #4744: URL: https://github.com/apache/hive/pull/4744#discussion_r1428843202 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/impl/FindColumnsWithStatsHandler.java: ## @@ -37,11 +37,16 @@ public class Fin

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
wecharyu commented on PR #4517: URL: https://github.com/apache/hive/pull/4517#issuecomment-1858840850 @deniskuzZ Thanks for the patient review, here is the refactor jira: [HIVE-27958](https://issues.apache.org/jira/browse/HIVE-27958). Please help take a look, and I'm willing to take it o

Re: [PR] HIVE-27749: SchemaTool initSchema fails on Mariadb 10.2 [hive]

2023-12-16 Thread via GitHub
SourabhBadhya commented on PR #4949: URL: https://github.com/apache/hive/pull/4949#issuecomment-1858835095 @deniskuzZ This syntax is supported by MySQL 8.0+ and MariaDB 10.2+. Any versions prior to this has effectively been declared End of Life (EOL) already. -- This is an automated messa

Re: [PR] Multi-stream JDBC changes [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4902: URL: https://github.com/apache/hive/pull/4902#discussion_r1428820807 ## jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java: ## @@ -30,6 +30,8 @@ * */ public class HiveResultSetMetaData implements java.sql.ResultSetMetaData

Re: [PR] HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4744: URL: https://github.com/apache/hive/pull/4744#discussion_r1428819534 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/impl/FindColumnsWithStatsHandler.java: ## @@ -37,11 +37,16 @@ public class Fi

Re: [PR] HIVE-27725: Remove redundant columns in TAB_COL_STATS and PART_COL_STATS tables [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4744: URL: https://github.com/apache/hive/pull/4744#discussion_r1428819534 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/impl/FindColumnsWithStatsHandler.java: ## @@ -37,11 +37,16 @@ public class Fi

Re: [PR] HIVE-27939: Many UNION ALL throws SemanticException when trying to remove partition predicates: fail to find child from parent [hive]

2023-12-16 Thread via GitHub
sonarcloud[bot] commented on PR #4950: URL: https://github.com/apache/hive/pull/4950#issuecomment-1858826901 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4517: URL: https://github.com/apache/hive/pull/4517#discussion_r1428808671 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java: ## @@ -0,0 +1,1536 @@ +/* + * Licensed to the Apache So

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4517: URL: https://github.com/apache/hive/pull/4517#discussion_r1428806834 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java: ## @@ -0,0 +1,1536 @@ +/* + * Licensed to the Apache So

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4517: URL: https://github.com/apache/hive/pull/4517#discussion_r1428804335 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java: ## @@ -0,0 +1,1536 @@ +/* + * Licensed to the Apache So

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4517: URL: https://github.com/apache/hive/pull/4517#discussion_r1428802963 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdate.java: ## @@ -0,0 +1,1541 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] HIVE-27530: Implement direct SQL for alter partitions to improve performance [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4517: URL: https://github.com/apache/hive/pull/4517#discussion_r1428801804 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdate.java: ## @@ -0,0 +1,1541 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] HIVE-26537: Deprecate older APIs in the HMS thrift interface. [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on PR #3599: URL: https://github.com/apache/hive/pull/3599#issuecomment-1858807021 @nrg4878, @saihemanth-cloudera should this be part of 4.0 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HIVE-27161: MetaException when executing CTAS query in Druid storage handler [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4945: URL: https://github.com/apache/hive/pull/4945#discussion_r1428778085 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)

Re: [PR] HIVE-27161: MetaException when executing CTAS query in Druid storage handler [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4945: URL: https://github.com/apache/hive/pull/4945#discussion_r1428778085 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)

Re: [PR] HIVE-27161: MetaException when executing CTAS query in Druid storage handler [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on code in PR #4945: URL: https://github.com/apache/hive/pull/4945#discussion_r1428778085 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -7949,7 +7949,15 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)

Re: [PR] HIVE-27749: SchemaTool initSchema fails on Mariadb 10.2 [hive]

2023-12-16 Thread via GitHub
deniskuzZ commented on PR #4949: URL: https://github.com/apache/hive/pull/4949#issuecomment-1858785188 @SourabhBadhya, have you checked if that syntax is compliant with all Hive supported versions of mariaDb and MySQL? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] HIVE-27850: Major Compaction for Iceberg tables [hive]

2023-12-16 Thread via GitHub
deniskuzZ merged PR #4855: URL: https://github.com/apache/hive/pull/4855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.