Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462849842 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java: ## @@ -231,25 +229,27 @@ public Long visitInteger

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462860748 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString() {

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462870262 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString() {

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462870262 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString() {

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462881002 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString() {

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
deniskuzZ commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462887944 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString() {

Re: [PR] HIVE-28016: Iceberg: NULL column values handling in COW mode [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5016: URL: https://github.com/apache/hive/pull/5016#issuecomment-1905570435 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28017: Add generated protobuf code. [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5018: URL: https://github.com/apache/hive/pull/5018#issuecomment-1905584072 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462952331 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java: ## @@ -749,6 +753,22 @@ public Object getBoolean(boolean

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462954845 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java: ## @@ -749,6 +753,22 @@ public Object getBoolean(boolean

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462954845 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java: ## @@ -749,6 +753,22 @@ public Object getBoolean(boolean

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462958051 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java: ## @@ -749,6 +753,22 @@ public Object getBoolean(boolean

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462960233 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1422,29 +1420,34 @@ public void visit(LeafNode

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462965305 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -1422,29 +1420,34 @@ public void visit(LeafNode

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462968615 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString()

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462972085 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java: ## @@ -263,26 +235,124 @@ public String toString()

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4959: URL: https://github.com/apache/hive/pull/4959#discussion_r1462980458 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java: ## @@ -231,25 +229,27 @@ public Long visitInteg

Re: [PR] HIVE-27984: Support backward compatibility of hms thrift struct about column stats [hive]

2024-01-23 Thread via GitHub
dengzhhu653 commented on code in PR #4984: URL: https://github.com/apache/hive/pull/4984#discussion_r1462990381 ## standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: ## @@ -725,7 +725,7 @@ struct SetPartitionsStatsRequest { 2: optional bool needMerge,

[PR] HIVE-28019 Fix query type information in proto files for load, export, import and explain queries [hive]

2024-01-23 Thread via GitHub
ramesh0201 opened a new pull request, #5022: URL: https://github.com/apache/hive/pull/5022 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the

Re: [PR] HIVE-27984: Support backward compatibility of hms thrift struct about column stats [hive]

2024-01-23 Thread via GitHub
zhangbutao commented on code in PR #4984: URL: https://github.com/apache/hive/pull/4984#discussion_r1463047089 ## standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: ## @@ -725,7 +725,7 @@ struct SetPartitionsStatsRequest { 2: optional bool needMerge, /

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2024-01-23 Thread via GitHub
SourabhBadhya commented on code in PR #4740: URL: https://github.com/apache/hive/pull/4740#discussion_r1463084357 ## ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/handler/TestAbortedTxnCleaner.java: ## @@ -282,9 +284,19 @@ public void testCleaningOfAbortedDirectoriesBelowB

Re: [PR] HIVE-28019 Fix query type information in proto files for load, export, import and explain queries [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5022: URL: https://github.com/apache/hive/pull/5022#issuecomment-1905820316 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463130882 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/MultiDataSourceJdbcResource.java: ## @@ -191,32 +191,23 @@ public Integ

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463174371 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/LatestTxnIdInConflictHandler.java: ## @@ -65,9 +66,12 @@ public

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463177349 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/ReleaseMaterializationRebuildLocks.java: ## @@ -53,14 +53,16

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463177819 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/LatestTxnIdInConflictHandler.java: ## @@ -65,9 +66,12 @@ public

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463174371 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/LatestTxnIdInConflictHandler.java: ## @@ -65,9 +66,12 @@ public

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-23 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1463174371 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/queries/LatestTxnIdInConflictHandler.java: ## @@ -65,9 +66,12 @@ public

[PR] HIVE-28020: Iceberg: Upgrade iceberg version to 1.4.3 [hive]

2024-01-23 Thread via GitHub
simhadri-g opened a new pull request, #5023: URL: https://github.com/apache/hive/pull/5023 ### What changes were proposed in this pull request? Upgrade iceberg version to 1.4.3. ### Why are the changes needed? Iceberg version 1.4.3 has been released -

Re: [PR] HIVE-28016: Iceberg: NULL column values handling in COW mode [hive]

2024-01-23 Thread via GitHub
deniskuzZ merged PR #5016: URL: https://github.com/apache/hive/pull/5016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2024-01-23 Thread via GitHub
InvisibleProgrammer commented on code in PR #4740: URL: https://github.com/apache/hive/pull/4740#discussion_r1463281761 ## ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/handler/TestAbortedTxnCleaner.java: ## @@ -282,9 +284,19 @@ public void testCleaningOfAbortedDirectories

Re: [PR] HIVE-28017: Add generated protobuf code. [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5018: URL: https://github.com/apache/hive/pull/5018#issuecomment-1906087051 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28020: Iceberg: Upgrade iceberg version to 1.4.3 [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5023: URL: https://github.com/apache/hive/pull/5023#issuecomment-1906094580 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27942: Missing aux jar errors during LLAP launch [hive]

2024-01-23 Thread via GitHub
zhangbutao commented on PR #4927: URL: https://github.com/apache/hive/pull/4927#issuecomment-1906122320 Ping @ayushtkn If no future comment, we can merge this change. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HIVE-27942: Missing aux jar errors during LLAP launch [hive]

2024-01-23 Thread via GitHub
ayushtkn commented on PR #4927: URL: https://github.com/apache/hive/pull/4927#issuecomment-1906126399 Thanx @zhangbutao for following up, feel free to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] HIVE-28017: Add generated protobuf code. [hive]

2024-01-23 Thread via GitHub
ayushtkn commented on PR #5018: URL: https://github.com/apache/hive/pull/5018#issuecomment-1906130076 > BTW, should we enforce check on protobuf & thrift when mvn building? For example: mvn clean install -Pthriftif -Pprotobuf ... Yep, I created https://issues.apache.org/jira/browse

Re: [PR] HIVE-27942: Missing aux jar errors during LLAP launch [hive]

2024-01-23 Thread via GitHub
zhangbutao merged PR #4927: URL: https://github.com/apache/hive/pull/4927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache

Re: [PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

2024-01-23 Thread via GitHub
zhangbutao commented on PR #5006: URL: https://github.com/apache/hive/pull/5006#issuecomment-1906185225 @abstractdog Could you please take a look as well? Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] HIVE-28021: escape percent symbol [hive]

2024-01-23 Thread via GitHub
tthorpeIBM opened a new pull request, #5024: URL: https://github.com/apache/hive/pull/5024 In order to allow the percent symbol to be used as a schema or table name, the percent symbol needs to be escaped. ### What changes were proposed in this pull request? In alpha 2 and earlier,

[PR] Bump org.springframework:spring-core from 5.2.24.RELEASE to 6.0.15 [hive]

2024-01-23 Thread via GitHub
dependabot[bot] opened a new pull request, #5026: URL: https://github.com/apache/hive/pull/5026 Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 5.2.24.RELEASE to 6.0.15. Release notes Sourced from https://github.com/spring-projects

[PR] Bump org.springframework:spring-core from 5.2.24.RELEASE to 6.0.15 in /standalone-metastore [hive]

2024-01-23 Thread via GitHub
dependabot[bot] opened a new pull request, #5025: URL: https://github.com/apache/hive/pull/5025 Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 5.2.24.RELEASE to 6.0.15. Release notes Sourced from https://github.com/spring-projects

Re: [PR] HIVE-28021: escape percent symbol [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5024: URL: https://github.com/apache/hive/pull/5024#issuecomment-1906539458 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

[PR] HIVE-28000: Fix scenarios where 'not in' gives incorrect results due … [hive]

2024-01-23 Thread via GitHub
AnmolSun opened a new pull request, #5027: URL: https://github.com/apache/hive/pull/5027 …to type coercion ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[PR] HIVE-27980: Hive Iceberg Compaction: add support for OPTIMIZE TABLE s… [hive]

2024-01-23 Thread via GitHub
difin opened a new pull request, #5028: URL: https://github.com/apache/hive/pull/5028 …yntax ### What changes were proposed in this pull request? Support for Hive Iceberg major compaction using OPTIMIZE TABLE tableName REWRITE DATA syntax. ### Why are the changes

Re: [PR] HIVE-28019 Fix query type information in proto files for load, export, import and explain queries [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5022: URL: https://github.com/apache/hive/pull/5022#issuecomment-1906893380 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28000: Fix scenarios where 'not in' gives incorrect results due … [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5027: URL: https://github.com/apache/hive/pull/5027#issuecomment-1907038896 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] [WIP] HIVE-28000: Fix scenarios where 'not in' gives incorrect results due. [hive]

2024-01-23 Thread via GitHub
sonarcloud[bot] commented on PR #5007: URL: https://github.com/apache/hive/pull/5007#issuecomment-1907188045 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27914: Fix the missing partitions judgement in drop_partitions_req [hive]

2024-01-23 Thread via GitHub
zhangbutao commented on code in PR #4905: URL: https://github.com/apache/hive/pull/4905#discussion_r1464194112 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -5158,20 +5157,27 @@ public DropPartitionsResult drop_par

[PR] Branch 3 hive 24808 new [hive]

2024-01-23 Thread via GitHub
amanraj2520 opened a new pull request, #5029: URL: https://github.com/apache/hive/pull/5029 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the cha

Re: [PR] HIVE-28021: escape percent symbol [hive]

2024-01-23 Thread via GitHub
moibulsardar commented on PR #5024: URL: https://github.com/apache/hive/pull/5024#issuecomment-1907490924 site:mraldardo.com how to install 69phisher tool in termux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] LLAP util code refactor [hive]

2024-01-23 Thread via GitHub
deniskuzZ opened a new pull request, #5030: URL: https://github.com/apache/hive/pull/5030 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chang