[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464859899 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464312615 ## File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java ## @@ -618,7 +618,13 @@ public void testMultipleInserts() throws Exception {

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464311382 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1641,28 +1645,26 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464310228 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464309265 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,20 +1577,23 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464308530 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -2493,7 +2514,7 @@ private static Path chooseFile(Path baseOrDeltaDir, FileSystem

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464306341 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +126,217 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r464304647 ## File path: llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java ## @@ -250,18 +255,71 @@ public void testGetOrcTailForPath()

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463406580 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,45 +1576,46 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463171159 ## File path: ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidInputFormat.java ## @@ -83,6 +94,34 @@ public void testDeltaMetaConstructWithState() throws

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463169065 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,45 +1576,46 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463168246 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1574,45 +1576,46 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463166514 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -680,14 +681,15 @@ public void setBaseAndInnerReader(

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463163936 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -1165,8 +1168,14 @@ private static ParsedDelta parseDelta(Path path, String

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463163160 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java ## @@ -1113,10 +1119,13 @@ else if(statementId != parsedDelta.statementId) {

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463159912 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +123,183 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463156735 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +123,183 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463156327 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +123,183 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463151233 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +123,183 @@ */ private long visibilityTxnId; +

[GitHub] [hive] pvary commented on a change in pull request #1339: HIVE-23956: Delete delta fileIds should be pushed execution

pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463150602 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java ## @@ -118,70 +123,183 @@ */ private long visibilityTxnId; +