[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736804288 Thank you @sunchao This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736771936 Thank you @sunchao. I think this is ready to go, or we need to wait for a couple days? This is an automated

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736192230 > Yes, my main question is whether it is safe to skip the changes on `HiveSubQueryRemoveRule` and `HiveRelDecorrelator`. It looks fine to me since we've already shaded calcite

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-736018282 > Thanks @viirya ! the new PR looks almost good to me except one nit. > > Also comparing to the original patch, we don't have changes to `HiveRelDecorrelator`,

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-735950137 Internally we test this patch and pass all Spark tests. I think it gives us more confidence to have this. This is

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-729488760 @sunchao The CI test results look much better now. Seems to me the failed tests are not related to shading guava.

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-698556409 Thanks @sunchao for adding jenkins file to branch-2.3. Re-open this. This is an automated message from the Apache

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-698556409 Thanks @sunchao for adding jenkins file to branch-2.3. Re-open this. This is an automated message from the Apache

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-675752255 Ok, thanks @sunchao This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-675646583 @sunchao Thanks for merging it in branch-2. Does this also need to be merged? Or just close it? This is an

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-669633077 @sunchao Do you know how to trigger the tests? This is an automated message from the Apache Git Service. To respond

[GitHub] [hive] viirya commented on pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

viirya commented on pull request #1356: URL: https://github.com/apache/hive/pull/1356#issuecomment-668358395 cc @sunchao This is an automated message from the Apache Git Service. To respond to the message, please log on to