[GitHub] [arrow] ursabot edited a comment on pull request #12300: ARROW-15253: [Python] Error in to_pandas for empty dataframe with index with extension type

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12300: URL: https://github.com/apache/arrow/pull/12300#issuecomment-1028867740 Benchmark runs are scheduled for baseline = 360252b6bedbc69c4191bc3102282a1e7d57ad29 and contender = 56d060ca197352f575edced64e6a1fbc9331b336. 56d060ca197352f575edced64

[GitHub] [arrow] ursabot edited a comment on pull request #12277: ARROW-15480: [R] Expand on schema/colnames mismatch error messages

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12277: URL: https://github.com/apache/arrow/pull/12277#issuecomment-1029028853 Benchmark runs are scheduled for baseline = d885d8203efa465cc21cfce3ea8a4fb84868755d and contender = f48cabee64fe0719e5e6f28d89ca86277373ca2b. f48cabee64fe0719e5e6f28d8

[GitHub] [arrow-rs] viirya commented on pull request #1263: wip. Implement DictionaryArray support in eq_dyn

2022-02-03 Thread GitBox
viirya commented on pull request #1263: URL: https://github.com/apache/arrow-rs/pull/1263#issuecomment-1029709894 Thanks for the review comments! I will address them and finish soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow-datafusion] Jimexist closed issue #1328: `function` module in python binding is broken in 6.0

2022-02-03 Thread GitBox
Jimexist closed issue #1328: URL: https://github.com/apache/arrow-datafusion/issues/1328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow] framlog commented on issue #12329: An unhandled race condition exists in `ThreadPool`

2022-02-03 Thread GitBox
framlog commented on issue #12329: URL: https://github.com/apache/arrow/issues/12329#issuecomment-1029665533 You are right. The fix that I give is to use 0 as an intermediate state(we set `pid_` to 0 when we try to reset everything and then set `pid_` to the `current_pid_`). Other

[GitHub] [arrow] ursabot edited a comment on pull request #12327: ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12327: URL: https://github.com/apache/arrow/pull/12327#issuecomment-1029011202 Benchmark runs are scheduled for baseline = 76decf67328d40a314a24adadc2b8f3e2190340f and contender = d885d8203efa465cc21cfce3ea8a4fb84868755d. d885d8203efa465cc21cfce3e

[GitHub] [arrow] ursabot edited a comment on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1028601746 Benchmark runs are scheduled for baseline = c89e67d7f85556f21438f95b9f8eafe8b53294bb and contender = 360252b6bedbc69c4191bc3102282a1e7d57ad29. 360252b6bedbc69c4191bc310

[GitHub] [arrow] github-actions[bot] commented on pull request #12332: ARROW-15556: [Release] Add a script to update Homebrew packages

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12332: URL: https://github.com/apache/arrow/pull/12332#issuecomment-1029617481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12331: URL: https://github.com/apache/arrow/pull/12331#issuecomment-1029611146 Benchmark runs are scheduled for baseline = bcf3d3e5a2ae5e70034b104ce69f774b78bbb4de and contender = 1ff2e195a751221cf2a64aeedbe019037848471d. 1ff2e195a751221cf2a64aeed

[GitHub] [arrow] ursabot commented on pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
ursabot commented on pull request #12331: URL: https://github.com/apache/arrow/pull/12331#issuecomment-1029611146 Benchmark runs are scheduled for baseline = bcf3d3e5a2ae5e70034b104ce69f774b78bbb4de and contender = 1ff2e195a751221cf2a64aeedbe019037848471d. 1ff2e195a751221cf2a64aeedbe01903

[GitHub] [arrow] kou closed pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
kou closed pull request #12331: URL: https://github.com/apache/arrow/pull/12331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] kou commented on pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
kou commented on pull request #12331: URL: https://github.com/apache/arrow/pull/12331#issuecomment-1029608983 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow] ursabot edited a comment on pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12162: URL: https://github.com/apache/arrow/pull/12162#issuecomment-1029002935 Benchmark runs are scheduled for baseline = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a and contender = 76decf67328d40a314a24adadc2b8f3e2190340f. 76decf67328d40a314a24adad

[GitHub] [arrow-rs] HaoYang670 commented on issue #1254: Fix all clippy lints in parquet crate

2022-02-03 Thread GitBox
HaoYang670 commented on issue #1254: URL: https://github.com/apache/arrow-rs/issues/1254#issuecomment-1029598846 There are many dead code and unused public functions. I am not sure whether to clean them up. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow] ursabot edited a comment on pull request #12325: ARROW-15539: [Archery] Add ARROW_JEMALLOC to build options

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12325: URL: https://github.com/apache/arrow/pull/12325#issuecomment-1028576540 Benchmark runs are scheduled for baseline = fb5a4f6c4158178608be475a07ddeaab59fff149 and contender = c89e67d7f85556f21438f95b9f8eafe8b53294bb. c89e67d7f85556f21438f95b9

[GitHub] [arrow] westonpace commented on issue #12329: An unhandled race condition exists in `ThreadPool`

2022-02-03 Thread GitBox
westonpace commented on issue #12329: URL: https://github.com/apache/arrow/issues/12329#issuecomment-1029593224 It's been a little bit since I've looked at this but if I recall correctly the condition `pid_ != current_pid` will only be true after a fork. When a fork happens the child (the

[GitHub] [arrow] vibhatha commented on a change in pull request #12275: ARROW-15262: [C++] Create a ToTable sink node

2022-02-03 Thread GitBox
vibhatha commented on a change in pull request #12275: URL: https://github.com/apache/arrow/pull/12275#discussion_r799121866 ## File path: cpp/src/arrow/compute/exec/options.h ## @@ -270,5 +270,23 @@ class ARROW_EXPORT SelectKSinkNodeOptions : public SinkNodeOptions { Selec

[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2022-02-03 Thread GitBox
rok commented on pull request #11889: URL: https://github.com/apache/arrow/pull/11889#issuecomment-1029582807 @lidavidm using [your repro](https://issues.apache.org/jira/browse/ARROW-14708) this change now only complains of flight not having grpc symbols. Any idea how to approach this?

[GitHub] [arrow] ursabot edited a comment on pull request #12307: ARROW-3016: [Docs][C++] Memory profiling with perf

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12307: URL: https://github.com/apache/arrow/pull/12307#issuecomment-1029002921 Benchmark runs are scheduled for baseline = 7d34a7cad4ed11642641c4eca9d32e0724cd245c and contender = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a. 5ab41120378d1944cfb607ad7

[GitHub] [arrow] vibhatha commented on pull request #12185: ARROW-15020: [R] Add bindings for new dataset writing options

2022-02-03 Thread GitBox
vibhatha commented on pull request #12185: URL: https://github.com/apache/arrow/pull/12185#issuecomment-1029556800 @jonkeane thank you for looking into this and making an update 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow] github-actions[bot] commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029548468 Revision: 89a0790cde0aa1e604c59e87a8ab8504e02dfdad Submitted crossbow builds: [ursacomputing/crossbow @ actions-1578](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
kszucs commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029547980 @github-actions crossbow submit verify-rc-source-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow-datafusion] andygrove opened a new issue #1744: Add support for `stable-aarch64-unknown-linux-gnu`

2022-02-03 Thread GitBox
andygrove opened a new issue #1744: URL: https://github.com/apache/arrow-datafusion/issues/1744 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I would like to be able to use DataFusion on a Raspberry Pi running Ubuntu 20.04.3 bu

[GitHub] [arrow] paleolimbot commented on a change in pull request #11971: ARROW-15040: [R] Enable write_csv_arrow to take a RecordBatchReader as input

2022-02-03 Thread GitBox
paleolimbot commented on a change in pull request #11971: URL: https://github.com/apache/arrow/pull/11971#discussion_r799077998 ## File path: r/R/csv.R ## @@ -707,7 +707,7 @@ write_csv_arrow <- function(x, x <- Table$create(x) } - assert_that(is_writable_table(x)) +

[GitHub] [arrow] github-actions[bot] commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029515588 Revision: b70ac1df1b4f307bae7a5512e4578d109422f3ce Submitted crossbow builds: [ursacomputing/crossbow @ actions-1577](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
kszucs commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029514799 @github-actions crossbow submit verify-rc-source-cpp-linux-conda-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12322: URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005 Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca

[GitHub] [arrow] ursabot edited a comment on pull request #11738: ARROW-14169: [R] altrep for factors

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #11738: URL: https://github.com/apache/arrow/pull/11738#issuecomment-1029263907 Benchmark runs are scheduled for baseline = d403fd5b781cefe7910ac49efa2376fa1994bfdb and contender = b39c5a0ee859aa77a25baef08b9046e2beba81a7. b39c5a0ee859aa77a25baef08

[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
yordan-pavlov commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r799061079 ## File path: arrow/src/buffer/mutable.rs ## @@ -475,35 +475,36 @@ impl MutableBuffer { let (_, upper) = iterator.size_hint(); le

[GitHub] [arrow] ursabot edited a comment on pull request #12321: ARROW-15532: [C++] Fix unused warning for StringClassifyDoc

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12321: URL: https://github.com/apache/arrow/pull/12321#issuecomment-1029190772 Benchmark runs are scheduled for baseline = f48cabee64fe0719e5e6f28d89ca86277373ca2b and contender = d403fd5b781cefe7910ac49efa2376fa1994bfdb. d403fd5b781cefe7910ac49ef

[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
yordan-pavlov commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r799052565 ## File path: arrow/benches/filter_kernels.rs ## @@ -42,68 +42,140 @@ fn add_benchmark(c: &mut Criterion) { let dense_filter_array = create_bo

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #1727: Remove duplicate tests from `test_const_evaluator_scalar_functions`

2022-02-03 Thread GitBox
HaoYang670 commented on issue #1727: URL: https://github.com/apache/arrow-datafusion/issues/1727#issuecomment-1029496111 Sure. Thank you, @bridyash13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ursabot edited a comment on pull request #12277: ARROW-15480: [R] Expand on schema/colnames mismatch error messages

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12277: URL: https://github.com/apache/arrow/pull/12277#issuecomment-1029028853 Benchmark runs are scheduled for baseline = d885d8203efa465cc21cfce3ea8a4fb84868755d and contender = f48cabee64fe0719e5e6f28d89ca86277373ca2b. f48cabee64fe0719e5e6f28d8

[GitHub] [arrow] github-actions[bot] commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029493204 Revision: b70ac1df1b4f307bae7a5512e4578d109422f3ce Submitted crossbow builds: [ursacomputing/crossbow @ actions-1576](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
kszucs commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029492362 @github-actions crossbow submit verify-rc-source-*-linux-almalinux-8-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] jonkeane commented on pull request #12185: ARROW-15020: [R] Add bindings for new dataset writing options

2022-02-03 Thread GitBox
jonkeane commented on pull request #12185: URL: https://github.com/apache/arrow/pull/12185#issuecomment-1029489818 Hmmm the only build that's failing looks like it's an issue with version numbers. I thought that rebasing on the latest master (which does have the version bump) would solve t

[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
yordan-pavlov commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r799041843 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -119,17 +147,83 @@ impl<'a> Iterator for SlicesIterator<'a> { } } +/// An iterator

[GitHub] [arrow] ursabot edited a comment on pull request #12327: ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12327: URL: https://github.com/apache/arrow/pull/12327#issuecomment-1029011202 Benchmark runs are scheduled for baseline = 76decf67328d40a314a24adadc2b8f3e2190340f and contender = d885d8203efa465cc21cfce3ea8a4fb84868755d. d885d8203efa465cc21cfce3e

[GitHub] [arrow] kszucs commented on a change in pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
kszucs commented on a change in pull request #12320: URL: https://github.com/apache/arrow/pull/12320#discussion_r799037165 ## File path: dev/archery/setup.py ## @@ -50,7 +46,7 @@ maintainer_email='d...@arrow.apache.org', packages=find_packages(), include_package_

[GitHub] [arrow] ursabot edited a comment on pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12162: URL: https://github.com/apache/arrow/pull/12162#issuecomment-1029002935 Benchmark runs are scheduled for baseline = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a and contender = 76decf67328d40a314a24adadc2b8f3e2190340f. 76decf67328d40a314a24adad

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
codecov-commenter edited a comment on pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#issuecomment-1025014491 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow] ursabot edited a comment on pull request #12307: ARROW-3016: [Docs][C++] Memory profiling with perf

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12307: URL: https://github.com/apache/arrow/pull/12307#issuecomment-1029002921 Benchmark runs are scheduled for baseline = 7d34a7cad4ed11642641c4eca9d32e0724cd245c and contender = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a. 5ab41120378d1944cfb607ad7

[GitHub] [arrow] jonkeane commented on pull request #12185: ARROW-15020: [R] Add bindings for new dataset writing options

2022-02-03 Thread GitBox
jonkeane commented on pull request #12185: URL: https://github.com/apache/arrow/pull/12185#issuecomment-1029462418 You're right — it wasn't the linter that was an issue, but there was a function from a previous PR that was causing documentation issues here. I've pushed those docs so that t

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r799021711 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -696,7 +1273,8 @@ mod tests { .flat_map(|(idx, v)| v.then(|| idx)) .co

[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12322: URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005 Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1743: Move more tests out of context.rs

2022-02-03 Thread GitBox
alamb commented on a change in pull request #1743: URL: https://github.com/apache/arrow-datafusion/pull/1743#discussion_r799012291 ## File path: datafusion/tests/sql/partitioned_csv.rs ## @@ -0,0 +1,95 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [arrow-datafusion] alamb opened a new pull request #1743: Move more tests out of context.rs

2022-02-03 Thread GitBox
alamb opened a new pull request #1743: URL: https://github.com/apache/arrow-datafusion/pull/1743 Built on https://github.com/apache/arrow-datafusion/pull/1742 so draft until that is merged # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/

[GitHub] [arrow] ursabot edited a comment on pull request #12277: ARROW-15480: [R] Expand on schema/colnames mismatch error messages

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12277: URL: https://github.com/apache/arrow/pull/12277#issuecomment-1029028853 Benchmark runs are scheduled for baseline = d885d8203efa465cc21cfce3ea8a4fb84868755d and contender = f48cabee64fe0719e5e6f28d89ca86277373ca2b. f48cabee64fe0719e5e6f28d8

[GitHub] [arrow] ursabot edited a comment on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1028601746 Benchmark runs are scheduled for baseline = c89e67d7f85556f21438f95b9f8eafe8b53294bb and contender = 360252b6bedbc69c4191bc3102282a1e7d57ad29. 360252b6bedbc69c4191bc310

[GitHub] [arrow] ursabot edited a comment on pull request #12307: ARROW-3016: [Docs][C++] Memory profiling with perf

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12307: URL: https://github.com/apache/arrow/pull/12307#issuecomment-1029002921 Benchmark runs are scheduled for baseline = 7d34a7cad4ed11642641c4eca9d32e0724cd245c and contender = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a. 5ab41120378d1944cfb607ad7

[GitHub] [arrow] ursabot edited a comment on pull request #12325: ARROW-15539: [Archery] Add ARROW_JEMALLOC to build options

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12325: URL: https://github.com/apache/arrow/pull/12325#issuecomment-1028576540 Benchmark runs are scheduled for baseline = fb5a4f6c4158178608be475a07ddeaab59fff149 and contender = c89e67d7f85556f21438f95b9f8eafe8b53294bb. c89e67d7f85556f21438f95b9

[GitHub] [arrow] ursabot edited a comment on pull request #12327: ARROW-15546: [FlightRPC][C++] Remove quotes from cookie header

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12327: URL: https://github.com/apache/arrow/pull/12327#issuecomment-1029011202 Benchmark runs are scheduled for baseline = 76decf67328d40a314a24adadc2b8f3e2190340f and contender = d885d8203efa465cc21cfce3ea8a4fb84868755d. d885d8203efa465cc21cfce3e

[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12322: URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005 Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca

[GitHub] [arrow] ursabot edited a comment on pull request #12300: ARROW-15253: [Python] Error in to_pandas for empty dataframe with index with extension type

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12300: URL: https://github.com/apache/arrow/pull/12300#issuecomment-1028867740 Benchmark runs are scheduled for baseline = 360252b6bedbc69c4191bc3102282a1e7d57ad29 and contender = 56d060ca197352f575edced64e6a1fbc9331b336. 56d060ca197352f575edced64

[GitHub] [arrow] ursabot edited a comment on pull request #11738: ARROW-14169: [R] altrep for factors

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #11738: URL: https://github.com/apache/arrow/pull/11738#issuecomment-1029263907 Benchmark runs are scheduled for baseline = d403fd5b781cefe7910ac49efa2376fa1994bfdb and contender = b39c5a0ee859aa77a25baef08b9046e2beba81a7. b39c5a0ee859aa77a25baef08

[GitHub] [arrow] ursabot edited a comment on pull request #12321: ARROW-15532: [C++] Fix unused warning for StringClassifyDoc

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12321: URL: https://github.com/apache/arrow/pull/12321#issuecomment-1029190772 Benchmark runs are scheduled for baseline = f48cabee64fe0719e5e6f28d89ca86277373ca2b and contender = d403fd5b781cefe7910ac49efa2376fa1994bfdb. d403fd5b781cefe7910ac49ef

[GitHub] [arrow] ursabot edited a comment on pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-02-03 Thread GitBox
ursabot edited a comment on pull request #12162: URL: https://github.com/apache/arrow/pull/12162#issuecomment-1029002935 Benchmark runs are scheduled for baseline = 5ab41120378d1944cfb607ad745cd3c6e6e4f71a and contender = 76decf67328d40a314a24adadc2b8f3e2190340f. 76decf67328d40a314a24adad

[GitHub] [arrow-datafusion] alamb commented on issue #348: Reduce compile time of DataFusion?

2022-02-03 Thread GitBox
alamb commented on issue #348: URL: https://github.com/apache/arrow-datafusion/issues/348#issuecomment-1029436437 I ran the following to see where the time was going in my normal development loop: ``` cargo +nightly test -p datafusion -Z timings ``` And the output was

[GitHub] [arrow-datafusion] alamb opened a new pull request #1742: Move optimize test out of context.rs

2022-02-03 Thread GitBox
alamb opened a new pull request #1742: URL: https://github.com/apache/arrow-datafusion/pull/1742 # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/743 Follow on to https://github.com/apache/arrow-datafusion/pull/1684 # Rationale for

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798959128 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -696,7 +1273,8 @@ mod tests { .flat_map(|(idx, v)| v.then(|| idx)) .co

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798959128 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -696,7 +1273,8 @@ mod tests { .flat_map(|(idx, v)| v.then(|| idx)) .co

[GitHub] [arrow-datafusion] alamb edited a comment on issue #348: Reduce compile time of DataFusion?

2022-02-03 Thread GitBox
alamb edited a comment on issue #348: URL: https://github.com/apache/arrow-datafusion/issues/348#issuecomment-1029413337 I have a coworker reports that they can't work on datafusion with a mac mini with 8GB of RAM due to `rust_analyzer` swapping too much It would be great to make t

[GitHub] [arrow-datafusion] alamb commented on issue #348: Reduce compile time of DataFusion?

2022-02-03 Thread GitBox
alamb commented on issue #348: URL: https://github.com/apache/arrow-datafusion/issues/348#issuecomment-1029413337 I coworker reports that they can't work on datafusion with a mac mini with 8GB of RAM due to `rust_analyzer` swapping too much It would be great to make this better som

[GitHub] [arrow-datafusion] alamb commented on issue #1736: Parquet files without `.parquet` extension inferred as having no schema

2022-02-03 Thread GitBox
alamb commented on issue #1736: URL: https://github.com/apache/arrow-datafusion/issues/1736#issuecomment-1029410536 Change this description to be a bug, which I think better reflects what is going on -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-datafusion] alamb commented on issue #1740: Support CREATE/DROP/ALTER VIEW (and associated DataFrame functions)

2022-02-03 Thread GitBox
alamb commented on issue #1740: URL: https://github.com/apache/arrow-datafusion/issues/1740#issuecomment-1029409619 🤔 since `SchemaProvider` already allows registering a new table provider, we might be able to implement this without any new traits https://github.com/apache/arrow-d

[GitHub] [arrow-datafusion] alamb commented on pull request #1739: Fix typos in crate documentation

2022-02-03 Thread GitBox
alamb commented on pull request #1739: URL: https://github.com/apache/arrow-datafusion/pull/1739#issuecomment-1029404650 This inspired https://github.com/apache/arrow-datafusion/issues/1741 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] kou commented on pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
kou commented on pull request #12331: URL: https://github.com/apache/arrow/pull/12331#issuecomment-1029401932 I'm taking a look CI failure... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029401017 Revision: 3148f5eef1dda4946db06e77fd3d4b1cab381f2a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1575](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12320: [Release] Revamp the verification scripts [WIP]

2022-02-03 Thread GitBox
kszucs commented on pull request #12320: URL: https://github.com/apache/arrow/pull/12320#issuecomment-1029400129 @github-actions crossbow submit verify-rc-source-*-linux-almalinux-8-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] kou commented on a change in pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
kou commented on a change in pull request #12331: URL: https://github.com/apache/arrow/pull/12331#discussion_r798965981 ## File path: dev/release/post-12-bump-versions.sh ## @@ -107,11 +107,8 @@ if [ ${BUMP_PUSH} -gt 0 ]; then fi if [ ${BUMP_TAG} -gt 0 ]; then - version_ta

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798959128 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -696,7 +1273,8 @@ mod tests { .flat_map(|(idx, v)| v.then(|| idx)) .co

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798958224 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798953803 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798951573 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798951408 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798949820 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798949820 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-datafusion] alamb commented on pull request #1677: Abstract over logical and physical plan representations in Ballista

2022-02-03 Thread GitBox
alamb commented on pull request #1677: URL: https://github.com/apache/arrow-datafusion/pull/1677#issuecomment-1029377749 > [6bdfa1f](https://github.com/apache/arrow-datafusion/commit/6bdfa1f5d63994a1bbd7a6e39dcd81ed342c135b) clippy is a cruel tyrant 😆 -- This is an automated me

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1266: Run rustdoc in CI and error if warnings

2022-02-03 Thread GitBox
codecov-commenter edited a comment on pull request #1266: URL: https://github.com/apache/arrow-rs/pull/1266#issuecomment-1029331548 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798945289 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798943316 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -185,79 +279,559 @@ pub fn prep_null_mask_filter(filter: &BooleanArray) -> BooleanArray { ///

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1248: Specialized filter kernels

2022-02-03 Thread GitBox
tustvold commented on a change in pull request #1248: URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798942622 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -119,17 +147,83 @@ impl<'a> Iterator for SlicesIterator<'a> { } } +/// An iterator of `u

[GitHub] [arrow-datafusion] alamb commented on issue #1587: Proposal: new release of DataFusion: 7.0.0

2022-02-03 Thread GitBox
alamb commented on issue #1587: URL: https://github.com/apache/arrow-datafusion/issues/1587#issuecomment-102931 I can drive the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1268: Fix warnings in `cargo doc`

2022-02-03 Thread GitBox
codecov-commenter commented on pull request #1268: URL: https://github.com/apache/arrow-rs/pull/1268#issuecomment-1029365598 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1737: add `cargo build --release` to ci

2022-02-03 Thread GitBox
alamb commented on a change in pull request #1737: URL: https://github.com/apache/arrow-datafusion/pull/1737#discussion_r798930974 ## File path: .github/workflows/rust.yml ## @@ -58,12 +58,18 @@ jobs: rustup toolchain install ${{ matrix.rust }} rustup defa

[GitHub] [arrow-rs] alamb opened a new pull request #1268: Fix warnings in documentation

2022-02-03 Thread GitBox
alamb opened a new pull request #1268: URL: https://github.com/apache/arrow-rs/pull/1268 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/1267 # Rationale for this change Non broken links are nice! See https://github.com/apac

[GitHub] [arrow] github-actions[bot] commented on pull request #12331: ARROW-15555: [Release] Don't push the release tag since it already exists

2022-02-03 Thread GitBox
github-actions[bot] commented on pull request #12331: URL: https://github.com/apache/arrow/pull/12331#issuecomment-1029343845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1266: Run rustdoc in CI and error if warnings

2022-02-03 Thread GitBox
codecov-commenter commented on pull request #1266: URL: https://github.com/apache/arrow-rs/pull/1266#issuecomment-1029331548 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] alamb commented on a change in pull request #1266: Run rustdoc in CI and error if warnings

2022-02-03 Thread GitBox
alamb commented on a change in pull request #1266: URL: https://github.com/apache/arrow-rs/pull/1266#discussion_r798897841 ## File path: .github/workflows/rust.yml ## @@ -247,6 +247,12 @@ jobs: export CARGO_HOME="/github/home/.cargo" export CARGO_TARGET_DI

[GitHub] [arrow-rs] alamb commented on a change in pull request #1266: Run rustdoc in CI and error if warnings

2022-02-03 Thread GitBox
alamb commented on a change in pull request #1266: URL: https://github.com/apache/arrow-rs/pull/1266#discussion_r798895512 ## File path: .github/workflows/rust.yml ## @@ -247,6 +247,12 @@ jobs: export CARGO_HOME="/github/home/.cargo" export CARGO_TARGET_DI

[GitHub] [arrow-rs] alamb opened a new issue #1267: Ensure links in the docs are correct

2022-02-03 Thread GitBox
alamb opened a new issue #1267: URL: https://github.com/apache/arrow-rs/issues/1267 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** There are several links in the rustdoc that are not correct or broken, such as https://docs.rs/ar

[GitHub] [arrow-rs] alamb opened a new pull request #1266: Run rustdoc in CI and error if warnings

2022-02-03 Thread GitBox
alamb opened a new pull request #1266: URL: https://github.com/apache/arrow-rs/pull/1266 # Which issue does this PR close? Re https://github.com/apache/arrow-datafusion/issues/1741 # Rationale for this change Once we have doc links fixed, ensure they don't get broken again

[GitHub] [arrow-datafusion] alamb merged pull request #1739: Fix typos in crate documentation

2022-02-03 Thread GitBox
alamb merged pull request #1739: URL: https://github.com/apache/arrow-datafusion/pull/1739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb opened a new issue #1741: Ensure links in the docs are correct

2022-02-03 Thread GitBox
alamb opened a new issue #1741: URL: https://github.com/apache/arrow-datafusion/issues/1741 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** There are several links in the rustdoc that are not correct or broken, such as https://do

[GitHub] [arrow] bkmgit commented on pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-02-03 Thread GitBox
bkmgit commented on pull request #11882: URL: https://github.com/apache/arrow/pull/11882#issuecomment-1029311842 @edponce @pitrou @kou Let me know if any further comments, there are a number of follow up issues, but this should allow people to try out the interfaces. -- This is an autom

[GitHub] [arrow-datafusion] pjmore closed pull request #1485: Add experimental Tokomak optimizer

2022-02-03 Thread GitBox
pjmore closed pull request #1485: URL: https://github.com/apache/arrow-datafusion/pull/1485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow-rs] alamb opened a new pull request #1265: Prepare for 9.0.0 release: Update version + CHANGELOG

2022-02-03 Thread GitBox
alamb opened a new pull request #1265: URL: https://github.com/apache/arrow-rs/pull/1265 Preparing for arrow 9.0.0 release. See rendered form of changelog here; https://github.com/alamb/arrow-rs/blob/alamb/prepare_for_9.0.0/CHANGELOG.md Lots of good stuff is happening! -- Th

[GitHub] [arrow-rs] alamb commented on pull request #1154: Add `async` arrow parquet reader

2022-02-03 Thread GitBox
alamb commented on pull request #1154: URL: https://github.com/apache/arrow-rs/pull/1154#issuecomment-1029291168 tracking API change in https://github.com/apache/arrow-rs/issues/1264 (for changelog) -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow-rs] alamb closed issue #1264: Add `Send` + `Sync` to `DataType`, `RowGroupReader`, `FileReader`, `ChunkReader`.

2022-02-03 Thread GitBox
alamb closed issue #1264: URL: https://github.com/apache/arrow-rs/issues/1264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb opened a new issue #1264: Add `Send` + `Sync` to `DataType`, `RowGroupReader`, `FileReader`, `ChunkReader`.

2022-02-03 Thread GitBox
alamb opened a new issue #1264: URL: https://github.com/apache/arrow-rs/issues/1264 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Needed for https://github.com/apache/arrow-rs/pull/1154 async parquet reader. Filing its own tick

  1   2   3   >