vibhatha commented on PR #13468:
URL: https://github.com/apache/arrow/pull/13468#issuecomment-1172819882
@jvanstraten some `R` test cases are failing. May be it need some work
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912310969
##
cpp/src/arrow/engine/substrait/relation_internal.cc:
##
@@ -106,17 +106,16 @@ Result FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
00Masato opened a new pull request, #13495:
URL: https://github.com/apache/arrow/pull/13495
Fix description in "Build and Test" section of python.rst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
westonpace commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912308625
##
cpp/src/arrow/engine/substrait/relation_internal.cc:
##
@@ -106,17 +106,16 @@ Result FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
westonpace commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912308625
##
cpp/src/arrow/engine/substrait/relation_internal.cc:
##
@@ -106,17 +106,16 @@ Result FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
westonpace commented on PR #13494:
URL: https://github.com/apache/arrow/pull/13494#issuecomment-1172809983
At the moment there are some places where our support is excessively limited
(e.g. functions). It's maybe debateable whether we want to document something
so limited or just say "Subs
westonpace commented on PR #13494:
URL: https://github.com/apache/arrow/pull/13494#issuecomment-1172809497
--
This is an automated message from the Apache Git Service.
To res
github-actions[bot] commented on PR #13494:
URL: https://github.com/apache/arrow/pull/13494#issuecomment-1172809450
https://issues.apache.org/jira/browse/ARROW-16966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vibhatha commented on PR #13468:
URL: https://github.com/apache/arrow/pull/13468#issuecomment-1172805189
@jvanstraten thank you for working on this one. I added a few comments.
@westonpace Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to
vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912301625
##
cpp/src/arrow/engine/substrait/type_internal.cc:
##
@@ -196,10 +196,11 @@ Result, bool>>
FromProto(
field("value", std::move(value_nullable.first),
valu
vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912301240
##
cpp/src/arrow/engine/substrait/serde_test.cc:
##
@@ -185,7 +185,8 @@ TEST(Substrait, SupportedExtensionTypes) {
ASSERT_OK_AND_ASSIGN(
auto buf,
vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912300942
##
cpp/src/arrow/engine/substrait/relation_internal.cc:
##
@@ -106,17 +106,16 @@ Result FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
vibhatha commented on PR #13468:
URL: https://github.com/apache/arrow/pull/13468#issuecomment-1172802233
> @vibhatha do you mind taking a look at this PR?
Of course 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vibhatha commented on code in PR #13426:
URL: https://github.com/apache/arrow/pull/13426#discussion_r912299882
##
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##
@@ -0,0 +1,1023 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
kou merged PR #13486:
URL: https://github.com/apache/arrow/pull/13486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on code in PR #13453:
URL: https://github.com/apache/arrow/pull/13453#discussion_r912251599
##
.github/actions/sync-nightlies/action.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. S
vibhatha commented on PR #13426:
URL: https://github.com/apache/arrow/pull/13426#issuecomment-1172799266
>
@icexelloss You can find a simple `write` operator example here:
https://github.com/apache/arrow/blob/998cca30c70a7e0bbc3f83957923f2e3019b314b/cpp/examples/arrow/execution_plan_
liukun4515 commented on code in PR #2821:
URL: https://github.com/apache/arrow-datafusion/pull/2821#discussion_r912296214
##
datafusion/core/src/config.rs:
##
@@ -152,8 +153,9 @@ impl BuiltInConfigs {
.iter()
.sorted_by_key(|c| c.key.as_str())
westonpace merged PR #13489:
URL: https://github.com/apache/arrow/pull/13489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
github-actions[bot] commented on PR #13493:
URL: https://github.com/apache/arrow/pull/13493#issuecomment-1172788542
https://issues.apache.org/jira/browse/ARROW-14182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172788458
Revision: fafe20aaf306103756415b1d430755ef19cff55f
Submitted crossbow builds: [ursacomputing/crossbow @
actions-0b61e7d1b0](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #13493:
URL: https://github.com/apache/arrow/pull/13493#issuecomment-1172788338
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
nealrichardson commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172788246
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer
test-r-offline-minimal r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912291015
##
cpp/src/arrow/dataset/file_base.cc:
##
@@ -89,6 +89,12 @@ Result>
FileSource::OpenCompressed(
return io::CompressedInputStream::Make(codec.get(), std::move(file)
github-actions[bot] commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172787190
```
Failed to render template `r/github.packages.yml` with UndefinedError:
'matrix' is undefined
The Archery job run can be found at:
https://github.com/apache/arrow/act
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912290663
##
cpp/src/arrow/dataset/test_util.h:
##
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bin
nealrichardson commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172786980
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer
test-r-offline-minimal r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172785937
```
Failed to render template `r/github.packages.yml` with UndefinedError:
'matrix' is undefined
The Archery job run can be found at:
https://github.com/apache/arrow/act
nealrichardson commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172785736
@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer
test-r-offline-minimal r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to
djnavarro commented on PR #12154:
URL: https://github.com/apache/arrow/pull/12154#issuecomment-1172776358
I think this one is ready for re-review and possibly even ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
alamb commented on issue #1981:
URL: https://github.com/apache/arrow-rs/issues/1981#issuecomment-1172745566
Related arrow2 code: Example
https://github.com/jorgecarleitao/arrow2/blob/main/examples/cow.rs#L23
Looks like it was added by @jorgecarleitao in
https://github.com/jorgecarlei
avantgardnerio commented on issue #159:
URL:
https://github.com/apache/arrow-datafusion/issues/159#issuecomment-1172740021
Resolved in [this
branch](https://github.com/spaceandtimelabs/arrow-datafusion/blob/85a47463a4c692bdcf9d687cdabf655bade04df2/datafusion/core/tests/sql/subqueries.rs#L10
HaoYang670 commented on PR #1986:
URL: https://github.com/apache/arrow-rs/pull/1986#issuecomment-1172739283
Thank you for your review @tustvold @liukun4515!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
avantgardnerio commented on issue #168:
URL:
https://github.com/apache/arrow-datafusion/issues/168#issuecomment-1172738776
Resolved in [this
branch](https://github.com/spaceandtimelabs/arrow-datafusion/blob/85a47463a4c692bdcf9d687cdabf655bade04df2/datafusion/core/tests/sql/subqueries.rs#L10
avantgardnerio commented on issue #160:
URL:
https://github.com/apache/arrow-datafusion/issues/160#issuecomment-1172738360
Resolved by PR #2813 & PR #2797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kou commented on code in PR #13453:
URL: https://github.com/apache/arrow/pull/13453#discussion_r912251599
##
.github/actions/sync-nightlies/action.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. S
github-actions[bot] commented on PR #13473:
URL: https://github.com/apache/arrow/pull/13473#issuecomment-1172710816
Revision: 53b3e1ad684c197b3228ccc5f7f7e89184bf186d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-9ee34a15ca](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13473:
URL: https://github.com/apache/arrow/pull/13473#issuecomment-1172709886
@github-actions crossbow submit almalinux-* amazon-linux-* centos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
assignUser commented on code in PR #13453:
URL: https://github.com/apache/arrow/pull/13453#discussion_r912248381
##
.github/actions/sync-nightlies/action.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
kou commented on PR #13473:
URL: https://github.com/apache/arrow/pull/13473#issuecomment-1172705696
https://app.travis-ci.com/github/ursacomputing/crossbow/builds/252684277#L4242
```text
/root/rpmbuild/BUILD/apache-arrow-9.0.0.dev305/cpp/src/arrow/compute/kernels/codegen_internal.
github-actions[bot] commented on PR #13486:
URL: https://github.com/apache/arrow/pull/13486#issuecomment-1172702613
Revision: 1aaa8a436587da957429a6d886d5471444160c09
Submitted crossbow builds: [ursacomputing/crossbow @
actions-a857ef232f](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13486:
URL: https://github.com/apache/arrow/pull/13486#issuecomment-1172702028
@github-actions crossbow submit example-cpp-minimal-build-static*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on code in PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812#discussion_r912231041
##
datafusion/common/src/scalar.rs:
##
@@ -1433,6 +1433,14 @@ impl ScalarValue {
})
}
+/// Try to parse `value` into a ScalarValue of type `ta
alamb merged PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb closed issue #2776: Allow configuration settings to be specified with
environment variables
URL: https://github.com/apache/arrow-datafusion/issues/2776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb commented on issue #2529:
URL:
https://github.com/apache/arrow-datafusion/issues/2529#issuecomment-1172680938
Thank you very much @mrob95 -- we have appreciated all your other fine work
to date as well!
--
This is an automated message from the Apache Git Service.
To respond to the
kou commented on code in PR #13453:
URL: https://github.com/apache/arrow/pull/13453#discussion_r912220398
##
.github/actions/sync-nightlies/action.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. S
github-actions[bot] commented on PR #13473:
URL: https://github.com/apache/arrow/pull/13473#issuecomment-1172664564
Revision: 3dff162d1ef739adf144f602895ad1b3566b873b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-3521dc848c](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #13473:
URL: https://github.com/apache/arrow/pull/13473#issuecomment-1172664024
@github-actions crossbow submit amazon-linux-2-arm64 centos-7-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mrob95 commented on issue #2529:
URL:
https://github.com/apache/arrow-datafusion/issues/2529#issuecomment-1172660756
I'll have a go at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb merged PR #2778:
URL: https://github.com/apache/arrow-datafusion/pull/2778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
lidavidm commented on PR #13458:
URL: https://github.com/apache/arrow/pull/13458#issuecomment-1172651015
This needs to be rebased since I merged Larry's PR first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lidavidm merged PR #13481:
URL: https://github.com/apache/arrow/pull/13481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
AssHero opened a new pull request, #2823:
URL: https://github.com/apache/arrow-datafusion/pull/2823
# Which issue does this PR close?
Closes #2822
# Rationale for this change
For logical plans, if upper offset is equal or greater than current's limit,
replaces with an [Logical
AssHero opened a new issue, #2822:
URL: https://github.com/apache/arrow-datafusion/issues/2822
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
For such query: select * from (select * from limit n offset ..) a limit
n offset
mrob95 commented on code in PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812#discussion_r912190166
##
datafusion/core/src/execution/context.rs:
##
@@ -1041,6 +1041,22 @@ impl SessionConfig {
Default::default()
}
+/// Create an execution con
tustvold closed issue #1985: Move the `DecimalArray` to a new file.
URL: https://github.com/apache/arrow-rs/issues/1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
tustvold merged PR #1986:
URL: https://github.com/apache/arrow-rs/pull/1986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
alamb commented on PR #2778:
URL:
https://github.com/apache/arrow-datafusion/pull/2778#issuecomment-1172618185
This PR is now ready for review (and hopefully merge!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #13492:
URL: https://github.com/apache/arrow/pull/13492#issuecomment-1172615298
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
mrob95 commented on code in PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812#discussion_r912168516
##
datafusion/core/src/execution/context.rs:
##
@@ -1041,6 +1041,22 @@ impl SessionConfig {
Default::default()
}
+/// Create an execution con
github-actions[bot] commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172602489
Revision: a8fc7d6364cf1a5119048fd47549f1c45934c8dd
Submitted crossbow builds: [ursacomputing/crossbow @
actions-b16d0a678e](https://github.com/ursacomputing/crossbow/bra
nealrichardson commented on PR #13464:
URL: https://github.com/apache/arrow/pull/13464#issuecomment-1172601638
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on code in PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812#discussion_r912165234
##
datafusion/core/src/execution/context.rs:
##
@@ -1041,6 +1041,22 @@ impl SessionConfig {
Default::default()
}
+/// Create an execution
raulcd commented on PR #13478:
URL: https://github.com/apache/arrow/pull/13478#issuecomment-1172570807
No, I didn't. I did run the job twice and it finished successfully in both
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #13483:
URL: https://github.com/apache/arrow/pull/13483#issuecomment-1172565847
Revision: beb4ccde5b00e18b59a3776e3196f85657ce429c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-dcd03cec4c](https://github.com/ursacomputing/crossbow/bra
assignUser commented on PR #13483:
URL: https://github.com/apache/arrow/pull/13483#issuecomment-1172565102
@github-actions crossbow submit revdep-r-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
westonpace commented on code in PR #13489:
URL: https://github.com/apache/arrow/pull/13489#discussion_r912127376
##
cpp/src/arrow/compute/kernels/aggregate_benchmark.cc:
##
@@ -308,8 +308,21 @@ BENCHMARK_TEMPLATE(ReferenceSum,
SumBitmapVectorizeUnroll)
using arrow::compute::
github-actions[bot] commented on PR #13481:
URL: https://github.com/apache/arrow/pull/13481#issuecomment-1172552178
Revision: f5226ecd97c77418463e900d22f76fe6c61e8722
Submitted crossbow builds: [ursacomputing/crossbow @
actions-6e6c6a526d](https://github.com/ursacomputing/crossbow/bra
lidavidm commented on PR #13481:
URL: https://github.com/apache/arrow/pull/13481#issuecomment-1172551077
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on PR #13478:
URL: https://github.com/apache/arrow/pull/13478#issuecomment-1172544983
Did you find out anything here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
tustvold commented on PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#issuecomment-1172541578
> I got worried about where should i pass the column index info
Give me a day or so and I'll get a PR up with some stuff stubbed out, I
think this exercise will help us both :smil
Ted-Jiang commented on PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#issuecomment-1172540557
> Edit: I'll try and stub out some APIs for what I mean over the next couple
of days. This will also help me validate my mental model checks out 😅
Got it, i will delete the `
alamb commented on PR #2821:
URL:
https://github.com/apache/arrow-datafusion/pull/2821#issuecomment-1172517622
Merging to unblock other pRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
alamb commented on PR #2821:
URL:
https://github.com/apache/arrow-datafusion/pull/2821#issuecomment-1172517412
I added some comments on the description so it is clear why this change is
needed. THanks @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to
alamb merged PR #2821:
URL: https://github.com/apache/arrow-datafusion/pull/2821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
lidavidm commented on PR #13246:
URL: https://github.com/apache/arrow/pull/13246#issuecomment-1172516358
I'm not going to have time. Since Larry is also working on reorganizing the
JNI code anyways I'll leave it up to him whether/how to approach this
--
This is an automated message from t
alamb commented on code in PR #2821:
URL: https://github.com/apache/arrow-datafusion/pull/2821#discussion_r912100850
##
datafusion/core/src/config.rs:
##
@@ -152,8 +153,9 @@ impl BuiltInConfigs {
.iter()
.sorted_by_key(|c| c.key.as_str())
{
-
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912100719
##
cpp/src/arrow/dataset/test_util.h:
##
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bin
liyongjing closed issue #1969: close function instead of mutable reference
URL: https://github.com/apache/arrow-rs/issues/1969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
liyongjing commented on issue #1969:
URL: https://github.com/apache/arrow-rs/issues/1969#issuecomment-1172503242
thanks for you comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
tustvold commented on PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#issuecomment-1172493031
I think small incremental PRs is a good approach. However, I have concerns
with this specific PR:
* It introduces public APIs that don't have clear semantics (the skipped
rows ar
alistaire47 opened a new pull request, #226:
URL: https://github.com/apache/arrow-cookbook/pull/226
Just a little PR to add an example of how to make a Table from a list of
rows with
[`pyarrow.Table.from_pylist()`](https://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Ta
Ted-Jiang commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r912083556
##
parquet/src/file/page_index/filer_offset_index.rs:
##
@@ -0,0 +1,293 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
github-actions[bot] commented on PR #13458:
URL: https://github.com/apache/arrow/pull/13458#issuecomment-1172490100
Revision: 499f0bbdabaff9f44d3ad44a1a66b26c61e1e179
Submitted crossbow builds: [ursacomputing/crossbow @
actions-4a99bf50b5](https://github.com/ursacomputing/crossbow/bra
lidavidm commented on PR #13458:
URL: https://github.com/apache/arrow/pull/13458#issuecomment-1172489133
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Ted-Jiang commented on PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#issuecomment-1172476897
> I've had a quick review, unfortunately I think this is missing a key
detail. In particular the arrow writer must read the same records from each of
its columns. As written this simpl
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912069046
##
cpp/src/arrow/dataset/file_base.h:
##
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result> OpenCompressed(
util::optional compression = util::nul
vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912067303
##
cpp/src/arrow/dataset/test_util.h:
##
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
ASSERT_OK_AND_ASSIGN(predicate, predicate.Bin
wjones127 commented on code in PR #13486:
URL: https://github.com/apache/arrow/pull/13486#discussion_r912064619
##
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -3834,7 +3834,55 @@ macro(build_grpc)
list(APPEND
ARROW_BUNDLED_STATIC_LIBS
- ${GRPC_GPR_ABSL_
lidavidm commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912062334
##
cpp/src/arrow/dataset/file_base.h:
##
@@ -114,6 +114,9 @@ class ARROW_DS_EXPORT FileSource {
Result> OpenCompressed(
util::optional compression = util::nul
lidavidm commented on code in PR #13481:
URL: https://github.com/apache/arrow/pull/13481#discussion_r912041576
##
cpp/CMakeLists.txt:
##
@@ -980,6 +980,9 @@ endif()
if(ARROW_JNI)
add_subdirectory(src/jni)
+ if(ARROW_DATASET)
+ add_subdirectory(../java/dataset/src/ma
lwhite1 commented on PR #13481:
URL: https://github.com/apache/arrow/pull/13481#issuecomment-1172383392
> The CMake project currently under java/dataset is just for generating the
JNI header so I don't think it needs modifications right now
the change here was to reset it to the origi
lwhite1 commented on code in PR #13481:
URL: https://github.com/apache/arrow/pull/13481#discussion_r911989870
##
cpp/CMakeLists.txt:
##
@@ -980,6 +980,7 @@ endif()
if(ARROW_JNI)
add_subdirectory(src/jni)
+ add_subdirectory(../java/dataset/src/main/cpp ./java/jni)
Review
liukun4515 opened a new pull request, #2821:
URL: https://github.com/apache/arrow-datafusion/pull/2821
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chang
tustvold commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911963350
##
parquet/src/file/page_index/filer_offset_index.rs:
##
@@ -0,0 +1,293 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
liukun4515 commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911945307
##
parquet/src/file/serialized_reader.rs:
##
@@ -248,21 +286,23 @@ impl SerializedFileReader {
}
if options.enable_page_index {
-//To
liukun4515 commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911943811
##
parquet/src/file/serialized_reader.rs:
##
@@ -248,21 +286,23 @@ impl SerializedFileReader {
}
if options.enable_page_index {
-//To
liukun4515 commented on code in PR #1977:
URL: https://github.com/apache/arrow-rs/pull/1977#discussion_r911943811
##
parquet/src/file/serialized_reader.rs:
##
@@ -248,21 +286,23 @@ impl SerializedFileReader {
}
if options.enable_page_index {
-//To
github-actions[bot] commented on PR #13483:
URL: https://github.com/apache/arrow/pull/13483#issuecomment-1172321726
Revision: 7cdc83766650136a6d2a78af3a7c491263fe2b37
Submitted crossbow builds: [ursacomputing/crossbow @
actions-f81df7c83a](https://github.com/ursacomputing/crossbow/bra
1 - 100 of 160 matches
Mail list logo
