Re: [PR] GH-499: Require PR labels for changelog [arrow-java]

2025-02-09 Thread via GitHub
kou commented on code in PR #594: URL: https://github.com/apache/arrow-java/pull/594#discussion_r1948510028 ## .github/pull_request_template.md: ## @@ -0,0 +1,8 @@ + Review Comment: I'm not sure whether comment in PR template works or not...: https://github.com/apache/arrow

Re: [PR] MINOR: Bump checker.framework.version from 3.48.4 to 3.49.0 [arrow-java]

2025-02-09 Thread via GitHub
jbonofre commented on PR #598: URL: https://github.com/apache/arrow-java/pull/598#issuecomment-2647130271 By the way, in the meantime, when needed, we can add a commit on the dependabot PR to update LICENSE/NOTICE. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] MINOR: Bump checker.framework.version from 3.48.4 to 3.49.0 [arrow-java]

2025-02-09 Thread via GitHub
jbonofre commented on PR #598: URL: https://github.com/apache/arrow-java/pull/598#issuecomment-2647120002 @lidavidm yes that should do the trick. I can make a try with ant or exec in maven to check that. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] MINOR: Bump checker.framework.version from 3.48.4 to 3.49.0 [arrow-java]

2025-02-09 Thread via GitHub
lidavidm commented on PR #598: URL: https://github.com/apache/arrow-java/pull/598#issuecomment-2647116893 @jbonofre for dependency upgrades like this...I wonder if there's a way to set up CI to check if the dependencies of one of the bundled JARs has changed so we can know we need to update

Re: [PR] GH-44629: [C++][Acero] Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output` [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #44616: URL: https://github.com/apache/arrow/pull/44616#discussion_r1948487464 ## python/pyarrow/_dataset.pyx: ## @@ -4111,7 +4113,9 @@ class ScanNodeOptions(_ScanNodeOptions): **kwargs : dict, optional Scan options. See `Scanner

Re: [PR] GH-44629: [C++][Acero] Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output` [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #44616: URL: https://github.com/apache/arrow/pull/44616#discussion_r1948487464 ## python/pyarrow/_dataset.pyx: ## @@ -4111,7 +4113,9 @@ class ScanNodeOptions(_ScanNodeOptions): **kwargs : dict, optional Scan options. See `Scanner

Re: [PR] GH-44629: [C++][Acero] Use `implicit_ordering` for `asof_join` rather than `require_sequenced_output` [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #44616: URL: https://github.com/apache/arrow/pull/44616#discussion_r1948487464 ## python/pyarrow/_dataset.pyx: ## @@ -4111,7 +4113,9 @@ class ScanNodeOptions(_ScanNodeOptions): **kwargs : dict, optional Scan options. See `Scanner

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
mapleFU commented on PR #45268: URL: https://github.com/apache/arrow/pull/45268#issuecomment-2647103099 > and the problem lies in the recursive call to `ScheduleMore` Ahh got this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on PR #45268: URL: https://github.com/apache/arrow/pull/45268#issuecomment-2647086749 > Also, so If i'm right, can we also encapsulate failed task `PostExecuteTask` also in `TaskSchedulerImpl::ExecuteTask`? Or this should handled by outside caller This is a grea

Re: [PR] GH-45482: [CI][Python] Don't use Ubuntu 20.04 for wheel test [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45483: URL: https://github.com/apache/arrow/pull/45483#issuecomment-2647080694 Revision: 68bce83579568ebabe2ac40d428f0d6e37c77148 Submitted crossbow builds: [ursacomputing/crossbow @ actions-040f1597db](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45482: [CI][Python] Don't use Ubuntu 20.04 for wheel test [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45483: URL: https://github.com/apache/arrow/pull/45483#issuecomment-2647077121 @github-actions crossbow submit wheel-manylinux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-45482: [CI][Python] Don't use Ubuntu 20.04 for wheel test [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45483: URL: https://github.com/apache/arrow/pull/45483#issuecomment-2647076890 :warning: GitHub issue #45482 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45482: [CI][Python] Don't use Ubuntu 20.04 for wheel test [arrow]

2025-02-09 Thread via GitHub
kou opened a new pull request, #45483: URL: https://github.com/apache/arrow/pull/45483 ### Rationale for this change Ubuntu 20.04 will reach EOL on 2025-05. ### What changes are included in this PR? Remove a wheel test that uses Ubuntu 20.04. ### Are these changes

Re: [PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45477: URL: https://github.com/apache/arrow/pull/45477#issuecomment-2647071616 Revision: 9d4229f1eaaadb6d7893fdb635246d3649da18a7 Submitted crossbow builds: [ursacomputing/crossbow @ actions-7f9be82710](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45477: URL: https://github.com/apache/arrow/pull/45477#issuecomment-2647068509 @github-actions crossbow submit debian-* ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-45436: [Docs][Packaging][Linux] Update how to build .deb/.rpm [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45481: URL: https://github.com/apache/arrow/pull/45481#issuecomment-2647066452 :warning: GitHub issue #45436 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45436: [Docs][Packaging][Linux] Update how to build .deb/.rpm [arrow]

2025-02-09 Thread via GitHub
kou opened a new pull request, #45481: URL: https://github.com/apache/arrow/pull/45481 ### Rationale for this change If we can build .deb/.rpm, we can debug .deb/.rpm build easily. ### What changes are included in this PR? Update `dev/tasks/linux-packages/README.md`.

Re: [PR] GH-499: Require PR labels for changelog [arrow-java]

2025-02-09 Thread via GitHub
lidavidm commented on PR #594: URL: https://github.com/apache/arrow-java/pull/594#issuecomment-2647027617 Example run: https://github.com/lidavidm/arrow-java/actions/runs/13234776842/job/36937648586 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45475: URL: https://github.com/apache/arrow/pull/45475#issuecomment-2647008477 Revision: ef033221cede3dea4a0d07210543901d2c13e0d9 Submitted crossbow builds: [ursacomputing/crossbow @ actions-43580f0e80](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on PR #45268: URL: https://github.com/apache/arrow/pull/45268#issuecomment-2647007746 Good for review again. @pitrou @mapleFU , mind to take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] MINOR: Bump checker.framework.version from 3.48.4 to 3.49.0 [arrow-java]

2025-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #598: URL: https://github.com/apache/arrow-java/pull/598 Bumps `checker.framework.version` from 3.48.4 to 3.49.0. Updates `org.checkerframework:checker-qual` from 3.48.4 to 3.49.0 Release notes Sourced from https://github.com/typetools/c

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #45268: URL: https://github.com/apache/arrow/pull/45268#discussion_r1948445001 ## cpp/src/arrow/acero/task_util.cc: ## @@ -413,6 +421,8 @@ void TaskSchedulerImpl::Abort(AbortContinuationImpl impl) { all_finished = false;

Re: [PR] GH-45479: [CI][Release] Use Ubuntu 24.04 instead of 20.04 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/arrow/pull/45480#issuecomment-2647007141 Revision: 106110fb598e361d2985312b60216ff8fcc25935 Submitted crossbow builds: [ursacomputing/crossbow @ actions-8c57a7ae95](https://github.com/ursacomputing/crossbow/bra

[PR] MINOR: Bump org.bouncycastle:bcpkix-jdk18on from 1.79 to 1.80 [arrow-java]

2025-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #597: URL: https://github.com/apache/arrow-java/pull/597 Bumps [org.bouncycastle:bcpkix-jdk18on](https://github.com/bcgit/bc-java) from 1.79 to 1.80. Changelog Sourced from https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html"

[PR] MINOR: Bump com.github.luben:zstd-jni from 1.5.6-9 to 1.5.6-10 [arrow-java]

2025-02-09 Thread via GitHub
dependabot[bot] opened a new pull request, #596: URL: https://github.com/apache/arrow-java/pull/596 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.6-9 to 1.5.6-10. Commits See full diff in https://github.com/luben/zstd-jni/commits";>compare view

Re: [PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45475: URL: https://github.com/apache/arrow/pull/45475#issuecomment-2647005777 @github-actions crossbow submit test-r-versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] GH-45479: [CI][Release] Use Ubuntu 24.04 instead of 20.04 [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45480: URL: https://github.com/apache/arrow/pull/45480#issuecomment-2647004094 @github-actions crossbow submit verify-rc-source-*-linux-ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] GH-45479: [CI][Release] Use Ubuntu 24.04 instead of 20.04 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45480: URL: https://github.com/apache/arrow/pull/45480#issuecomment-2647003111 :warning: GitHub issue #45479 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45479: [CI][Release] Use Ubuntu 24.04 instead of 20.04 [arrow]

2025-02-09 Thread via GitHub
kou opened a new pull request, #45480: URL: https://github.com/apache/arrow/pull/45480 ### Rationale for this change Ubuntu 20.04 will reach EOL on 2025-05. ### What changes are included in this PR? * Remove Ubuntu 20.04 * Add Ubuntu 24.04 ### Are these changes

Re: [PR] CI: add benchmark workflow and script [arrow-go]

2025-02-09 Thread via GitHub
singh1203 commented on PR #250: URL: https://github.com/apache/arrow-go/pull/250#issuecomment-2646996776 Hi @kou can you trigger the runner here. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #45268: URL: https://github.com/apache/arrow/pull/45268#discussion_r1948436541 ## cpp/src/arrow/acero/task_util_test.cc: ## @@ -231,5 +231,96 @@ TEST(TaskScheduler, StressTwo) { } } +TEST(TaskScheduler, AbortContOnTaskErrorSerial) { + c

Re: [I] R: Benchmarking ADBC (Snowflake) vs ODBC shows issue with larger datasets [arrow-adbc]

2025-02-09 Thread via GitHub
lidavidm commented on issue #2508: URL: https://github.com/apache/arrow-adbc/issues/2508#issuecomment-2646990459 @zeroshade how expensive is `integerToDecimal128` in https://github.com/apache/arrow-adbc/blob/main/go/adbc/driver/snowflake/record_reader.go? I guess the thing for us is t

Re: [PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45477: URL: https://github.com/apache/arrow/pull/45477#issuecomment-2646978242 Revision: 5efcaf5182f07b1754c596b44d708ac7a70b907b Submitted crossbow builds: [ursacomputing/crossbow @ actions-bd78106d10](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45477: URL: https://github.com/apache/arrow/pull/45477#issuecomment-2646975707 @github-actions crossbow submit debian-* ubuntu-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45477: URL: https://github.com/apache/arrow/pull/45477#issuecomment-2646975964 :warning: GitHub issue #45476 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45476: [Packagin][Linux] Drop support for Ubuntu 20.04 [arrow]

2025-02-09 Thread via GitHub
kou opened a new pull request, #45477: URL: https://github.com/apache/arrow/pull/45477 ### Rationale for this change Ubuntu 20.04 will reach EOL on 2025-05. ### What changes are included in this PR? Remove Ubuntu 20.04 related codes. ### Are these changes tested?

Re: [PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45475: URL: https://github.com/apache/arrow/pull/45475#issuecomment-2646968737 Revision: a0f7dd54d90c07f81bb21674d6dfc29f752315bf Submitted crossbow builds: [ursacomputing/crossbow @ actions-29000abc82](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #45268: URL: https://github.com/apache/arrow/pull/45268#discussion_r1948422879 ## cpp/src/arrow/acero/task_util_test.cc: ## @@ -231,5 +231,96 @@ TEST(TaskScheduler, StressTwo) { } } +TEST(TaskScheduler, AbortContOnTaskErrorSerial) { + c

Re: [PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45475: URL: https://github.com/apache/arrow/pull/45475#issuecomment-2646966406 @github-actions crossbow submit test-r-versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
kou opened a new pull request, #45475: URL: https://github.com/apache/arrow/pull/45475 ### Rationale for this change Ubuntu 20.04 will reach EOL on 2025-05. ### What changes are included in this PR? Use Ubuntu 22.04 instead of 20.04. ### Are these changes tested?

Re: [PR] GH-45266: [C++][Acero] Fix the running tasks count of Scheduler when get error tasks in multi-threads [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on code in PR #45268: URL: https://github.com/apache/arrow/pull/45268#discussion_r1948422554 ## cpp/src/arrow/acero/task_util_test.cc: ## @@ -231,5 +231,96 @@ TEST(TaskScheduler, StressTwo) { } } +TEST(TaskScheduler, AbortContOnTaskErrorSerial) { + c

Re: [PR] GH-45389: [CI][R] Use Ubuntu 22.04 for test-r-versions [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45475: URL: https://github.com/apache/arrow/pull/45475#issuecomment-2646966635 :warning: GitHub issue #45389 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] R: Benchmarking ADBC (Snowflake) vs ODBC shows issue with larger datasets [arrow-adbc]

2025-02-09 Thread via GitHub
JavOrraca commented on issue #2508: URL: https://github.com/apache/arrow-adbc/issues/2508#issuecomment-2646963265 Good catch on the ADBC `SELECT TOP 100`... The base R `head(100)` SQL translation done by `dbplyr` actually translates it to `LIMIT 100`, but I re-ran the benchmarki

Re: [I] Supporting object store FFI [arrow-rs]

2025-02-09 Thread via GitHub
lisasgoh commented on issue #7075: URL: https://github.com/apache/arrow-rs/issues/7075#issuecomment-2646962621 A potential temporary solution could be to create a fork of Polars to integrate my new object store, though it creates some maintenance overhead which isn't ideal. There seems to b

Re: [PR] GH-44950: [C++] Bump minimum CMake version to 3.25 [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #44989: URL: https://github.com/apache/arrow/pull/44989#issuecomment-2646959311 I'll merge this in a few days if nobody objects it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] GH-45393: [C++][Compute] Fix wrong decoding for 32-bit column in row table [arrow]

2025-02-09 Thread via GitHub
ursabot commented on PR #45473: URL: https://github.com/apache/arrow/pull/45473#issuecomment-2646899651 Benchmark runs are scheduled for commit 0b81f6e9af2250d04d34fc87ca62c1e9b7b9154e. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be po

Re: [PR] GH-45393: [C++][Compute] Fix wrong decoding for 32-bit column in row table [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on PR #45473: URL: https://github.com/apache/arrow/pull/45473#issuecomment-2646899599 @ursabot please benchmark lang=R -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] GH-45159: [CI][Integration] Remove substrait consumer-testing integration job [arrow]

2025-02-09 Thread via GitHub
EpsilonPrime commented on PR #45463: URL: https://github.com/apache/arrow/pull/45463#issuecomment-2646899015 We discussed this in the Substrait community meeting and agreed that this can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] GH-45393: [C++][Compute] Fix wrong decoding for 32-bit column in row table [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45473: URL: https://github.com/apache/arrow/pull/45473#issuecomment-2646889916 :warning: GitHub issue #45393 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-45393: [C++][Compute] Fix wrong decoding for 32-bit column in row table [arrow]

2025-02-09 Thread via GitHub
zanmato1984 opened a new pull request, #45473: URL: https://github.com/apache/arrow/pull/45473 ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes?

Re: [I] cmake config for all drivers [arrow-adbc]

2025-02-09 Thread via GitHub
lidavidm commented on issue #2506: URL: https://github.com/apache/arrow-adbc/issues/2506#issuecomment-2646887049 Good catch, it appears all the Golang drivers are missing this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] R: Benchmarking ADBC (Snowflake) vs ODBC shows issue with larger datasets [arrow-adbc]

2025-02-09 Thread via GitHub
lidavidm commented on issue #2508: URL: https://github.com/apache/arrow-adbc/issues/2508#issuecomment-2646876374 Hey, thanks for filing this. Just to make sure, the SQL generated by d(b)plyr is the same as the hardcoded query you have? (And so presumably it became `SELECT TOP 100

Re: [PR] chore(format): add new lines to adbc.h for clarity [arrow-adbc]

2025-02-09 Thread via GitHub
lidavidm merged PR #2507: URL: https://github.com/apache/arrow-adbc/pull/2507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] Support converting large dates (i.e. +10999-12-31) from string to Date32 [arrow-rs]

2025-02-09 Thread via GitHub
phillipleblanc commented on PR #7074: URL: https://github.com/apache/arrow-rs/pull/7074#issuecomment-2646870682 Thanks @alamb for the review. I've pushed up fixes for your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] fixes :# 45322 [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45472: URL: https://github.com/apache/arrow/pull/45472#issuecomment-2646833003 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

[PR] fixes :# 45322 [arrow]

2025-02-09 Thread via GitHub
deekshatomer opened a new pull request, #45472: URL: https://github.com/apache/arrow/pull/45472 fixes issues :# 45322 Added hyperbolic trig functions to PyArrow API reference https://github.com/user-attachments/assets/6ba032ba-97bf-412d-b1d3-7ad74d09ff94"; /> -- This is an autom

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
kou commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646786407 Oh, sorry. It's the same type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
quinnj commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646776961 Is `string_view` different than the new Utf8View that we support (added here: https://github.com/apache/arrow-julia/pull/512/files#diff-bdc4e5cd6aa22fdc5e659e805b70c4763308be9f41128

Re: [PR] Parquet Modular decryption support [arrow-rs]

2025-02-09 Thread via GitHub
adamreeve commented on code in PR #6637: URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1948289774 ## parquet/Cargo.toml: ## @@ -98,7 +101,7 @@ zstd-sys = { version = ">=2.0.0, <2.0.14", default-features = false } all-features = true [features] -default = ["a

[PR] minor: fix deprecated_note [arrow-rs]

2025-02-09 Thread via GitHub
Chen-Yuan-Lai opened a new pull request, #7105: URL: https://github.com/apache/arrow-rs/pull/7105 # Which issue does this PR close? Closes #7067 . # Rationale for this change # What changes are included in this PR? # Are there any user-faci

Re: [PR] build(c): fix typo in static build causing error [arrow-adbc]

2025-02-09 Thread via GitHub
lidavidm merged PR #2505: URL: https://github.com/apache/arrow-adbc/pull/2505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[PR] bugfix: adjust allocated_size() in GenericByteViewBuilde [arrow-rs]

2025-02-09 Thread via GitHub
Chen-Yuan-Lai opened a new pull request, #7104: URL: https://github.com/apache/arrow-rs/pull/7104 # Which issue does this PR close? Closes #7099 . # Rationale for this change As #7099 says, `allocated_size()` in `GenericByteViewBuilder` needs to be adjus

Re: [I] [Documentation][Python] Add Hyperbolic Trig functions to API docs [arrow]

2025-02-09 Thread via GitHub
deekshatomer commented on issue #45322: URL: https://github.com/apache/arrow/issues/45322#issuecomment-2646735903 hello@AlenkaF assigm me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] GH-18036: [Packaging] Build python wheel for musl linux [arrow]

2025-02-09 Thread via GitHub
kou commented on code in PR #45470: URL: https://github.com/apache/arrow/pull/45470#discussion_r1948290478 ## dev/tasks/python-wheels/github.musllinux.yml: ## Review Comment: What is the difference between `github.manylinux.yml` and `github.musllinux.yml`? Can we use th

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
kou commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646725922 ```text text: string_view ``` It seems that arrow-julia doesn't support string view yet. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] GH-18036: [Packaging] Build python wheel for musl linux [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45470: URL: https://github.com/apache/arrow/pull/45470#issuecomment-2646708875 Revision: 732fc35238954a881e3dc87044d2386db95e92e6 Submitted crossbow builds: [ursacomputing/crossbow @ actions-d80189b582](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-18036: [Packaging] Build python wheel for musl linux [arrow]

2025-02-09 Thread via GitHub
kou commented on PR #45470: URL: https://github.com/apache/arrow/pull/45470#issuecomment-2646707007 @github-actions crossbow submit wheel-musllinux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
ForceBru commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646682912 Here's a `BoundsError: attempt to access 0-element Vector{Vector{UInt8}} at index [1]`: ``` > python >>> from random import randint; col=[randint(1,500) for _ in range

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
ForceBru commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646675505 More examples where Arrow.jl can't read the file: ``` > python Python 3.12.7 (main, Jan 17 2025, 16:55:27) [GCC 14.2.0] on linux Type "help", "copyright", "credits"

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
ForceBru commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646658394 Yes, pyarrow can read files written by `df.write_ipc` and `df.write_ipc_stream`: ```python #!/usr/bin/env -S uv run --script # /// script # requires-python = ">=3.1

Re: [PR] Draft: Deserialize MapScalar as Python dict's [arrow]

2025-02-09 Thread via GitHub
jonded94 closed pull request #45465: Draft: Deserialize MapScalar as Python dict's URL: https://github.com/apache/arrow/pull/45465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] GH-39010: [Python] Introduce `maps_as_pydicts` parameter for `to_pylist`, `to_pydict`, `as_py` [arrow]

2025-02-09 Thread via GitHub
jonded94 opened a new pull request, #45471: URL: https://github.com/apache/arrow/pull/45471 ### Rationale for this change Currently, unfortunately `MapScalar`/`Array` types are not deserialized into proper Python `dict`s, which is unfortunate since this breaks "roundtrips" from Pytho

Re: [PR] GH-39010: [Python] Introduce `maps_as_pydicts` parameter for `to_pylist`, `to_pydict`, `as_py` [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45471: URL: https://github.com/apache/arrow/pull/45471#issuecomment-2646637565 :warning: GitHub issue #39010 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

2025-02-09 Thread via GitHub
gstvg opened a new pull request, #7103: URL: https://github.com/apache/arrow-rs/pull/7103 # Which issue does this PR close? # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes? Docs only -- This is an autom

Re: [PR] Support setting key field in MapBuilder [arrow-rs]

2025-02-09 Thread via GitHub
rshkv commented on code in PR #7101: URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1948179727 ## arrow-array/src/builder/map_builder.rs: ## @@ -107,13 +108,32 @@ impl MapBuilder { field_names: field_names.unwrap_or_default(), key_builder

[PR] Add new lines to documentation [arrow-adbc]

2025-02-09 Thread via GitHub
xborder opened a new pull request, #2507: URL: https://github.com/apache/arrow-adbc/pull/2507 Closes https://github.com/apache/arrow-adbc/issues/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-44762: [GLib] Add garrow_table_validate_full() [arrow]

2025-02-09 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45468: URL: https://github.com/apache/arrow/pull/45468#issuecomment-2646412734 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e32f56b478171fc4b53dc2042c4cf5d37c97e351. There were 8

[PR] Fix static build [arrow-adbc]

2025-02-09 Thread via GitHub
m-kuhn opened a new pull request, #2505: URL: https://github.com/apache/arrow-adbc/pull/2505 ``` CMake Warning (dev) at cmake_modules/AdbcDefines.cmake:21 (enable_language): project() should be called prior to this enable_language() call. Call Stack (most recent call first): C

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
Moelf commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646373493 I guess another check is to see if `pyarrow` can read it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
ForceBru commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646331689 > is _ipc the correct thing to write out? Not sure, it's just what I've been using in Python. Should I be using a different `write_` method to write Arrow files from Polars?

Re: [I] File written by `polars.DataFrame.write_ipc` read incorrectly [arrow-julia]

2025-02-09 Thread via GitHub
Moelf commented on issue #540: URL: https://github.com/apache/arrow-julia/issues/540#issuecomment-2646326302 not at a computer but is _ipc the correct thing to write out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] GH-18036: [Packaging] Build python wheel for musl linux [arrow]

2025-02-09 Thread via GitHub
nveloso opened a new pull request, #45470: URL: https://github.com/apache/arrow/pull/45470 ### Rationale for this change Please check #18036. ### What changes are included in this PR? Almost everything needed for building and testing python wheels for musllinux. The servi

Re: [PR] GH-18036: [Packaging] Build python wheel for musl linux [arrow]

2025-02-09 Thread via GitHub
github-actions[bot] commented on PR #45470: URL: https://github.com/apache/arrow/pull/45470#issuecomment-2646312070 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

Re: [PR] Support setting key field in MapBuilder [arrow-rs]

2025-02-09 Thread via GitHub
rshkv commented on code in PR #7101: URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1948076890 ## arrow-array/src/builder/map_builder.rs: ## @@ -107,13 +108,32 @@ impl MapBuilder { field_names: field_names.unwrap_or_default(), key_builder

Re: [PR] GH-44762: [GLib] Add garrow_table_validate_full() [arrow]

2025-02-09 Thread via GitHub
kou merged PR #45468: URL: https://github.com/apache/arrow/pull/45468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [GLib] Add `garrow_table_validate_full()` [arrow]

2025-02-09 Thread via GitHub
kou commented on issue #44762: URL: https://github.com/apache/arrow/issues/44762#issuecomment-2646165069 Issue resolved by pull request 45468 https://github.com/apache/arrow/pull/45468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [Java] DenseUnionWriter#setPosition fails with NullPointerException [arrow-java]

2025-02-09 Thread via GitHub
kou commented on issue #399: URL: https://github.com/apache/arrow-java/issues/399#issuecomment-2646149703 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] GH-44762: [GLib] Add garrow_table_validate_full() [arrow]

2025-02-09 Thread via GitHub
kou commented on code in PR #45468: URL: https://github.com/apache/arrow/pull/45468#discussion_r1948050029 ## c_glib/arrow-glib/table.cpp: ## @@ -754,6 +754,24 @@ garrow_table_validate(GArrowTable *table, GError **error) return garrow::check(error, arrow_table->Validate(), "[

Re: [I] [Packaging] Add wheels for Alpine Linux [arrow]

2025-02-09 Thread via GitHub
kou commented on issue #18036: URL: https://github.com/apache/arrow/issues/18036#issuecomment-2646148770 Could you open a PR? Let's discuss details at there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] parquet: fix panic to instead return error for invalid file [arrow-rs]

2025-02-09 Thread via GitHub
Jefffrey commented on issue #7102: URL: https://github.com/apache/arrow-rs/issues/7102#issuecomment-2646135873 Look into making this test return an error instead of a panic, since input files are considered user input and thus should not panic for malformed input. See the discussion f

[I] parquet: fix panic to instead return error for invalid file [arrow-rs]

2025-02-09 Thread via GitHub
Jefffrey opened a new issue, #7102: URL: https://github.com/apache/arrow-rs/issues/7102 ### Discussed in https://github.com/apache/arrow-rs/discussions/7054 Originally posted by **jp0317** February 1, 2025 The rle decoder has an [assertion](https://github.com/apache/ar

Re: [I] [R][C++] "negative buffer resize" error with arrow and dplyr in R [arrow]

2025-02-09 Thread via GitHub
zanmato1984 commented on issue #39912: URL: https://github.com/apache/arrow/issues/39912#issuecomment-2646117951 Hi @amoeba , sorry for the late reply, I was on vacation last few days. I can take a look. But I may have trouble reproducing in R cause I have hardly developed anything in R. Do

Re: [I] [JS] Implement IPC RecordBatch body buffer compression from ARROW-300 [arrow]

2025-02-09 Thread via GitHub
fungiboletus commented on issue #24833: URL: https://github.com/apache/arrow/issues/24833#issuecomment-2646115946 > > > Any update on the timelines for JS implementation to support buffer compression > > > > > > If you are stuck and really need this feature, I can say that I impl

Re: [PR] Support setting key field in MapBuilder [arrow-rs]

2025-02-09 Thread via GitHub
Jefffrey commented on code in PR #7101: URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1948031364 ## arrow-array/src/builder/map_builder.rs: ## @@ -107,13 +108,32 @@ impl MapBuilder { field_names: field_names.unwrap_or_default(), key_buil