[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

2021-02-25 Thread GitBox
pitrou commented on a change in pull request #9474: URL: https://github.com/apache/arrow/pull/9474#discussion_r582862583 ## File path: cpp/src/arrow/csv/reader.cc ## @@ -935,18 +931,22 @@ class AsyncThreadedTableReader AsyncGenerator> buffer_generator_; }; +} // namespac

[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

2021-02-11 Thread GitBox
pitrou commented on a change in pull request #9474: URL: https://github.com/apache/arrow/pull/9474#discussion_r574720665 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -443,34 +449,37 @@ Result> SlowFileSystem::OpenAppendStream( } Status CopyFiles(const std::ve

[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

2021-02-11 Thread GitBox
pitrou commented on a change in pull request #9474: URL: https://github.com/apache/arrow/pull/9474#discussion_r574720241 ## File path: cpp/src/arrow/filesystem/filesystem.cc ## @@ -443,34 +449,37 @@ Result> SlowFileSystem::OpenAppendStream( } Status CopyFiles(const std::ve

[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

2021-02-11 Thread GitBox
pitrou commented on a change in pull request #9474: URL: https://github.com/apache/arrow/pull/9474#discussion_r574719928 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -160,6 +160,13 @@ Status FileWriter::Write(RecordBatchReader* batches) { return Status::OK(); }

[GitHub] [arrow] pitrou commented on a change in pull request #9474: ARROW-10420: [C++] Refactor io and filesystem APIs to take an IOContext

2021-02-11 Thread GitBox
pitrou commented on a change in pull request #9474: URL: https://github.com/apache/arrow/pull/9474#discussion_r574719660 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -160,6 +160,13 @@ Status FileWriter::Write(RecordBatchReader* batches) { return Status::OK(); }