[GitHub] [arrow] projjal commented on pull request #9852: ARROW-12154: [C++][Gandiva] Fix gandiva crash in certain OS/CPU combinations

projjal commented on pull request #9852: URL: https://github.com/apache/arrow/pull/9852#issuecomment-810825259 @pravindra @praveenbingo Can you review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] projjal commented on pull request #9833: ARROW-12133: [C++][Gandiva] Add option to disable targeting host cpu during llvm ir compilation

projjal commented on pull request #9833: URL: https://github.com/apache/arrow/pull/9833#issuecomment-810825577 @praveenbingo @pravindra can you review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #9856: ARROW-11858: [GLib][Gandiva] Add Gandiva::Filter and related functions

github-actions[bot] commented on pull request #9856: URL: https://github.com/apache/arrow/pull/9856#issuecomment-810883337 https://issues.apache.org/jira/browse/ARROW-11858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] ritchie46 opened a new pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 opened a new pull request #9860: URL: https://github.com/apache/arrow/pull/9860 The `append` functions in the `Builder` structs are often used in "hot" code. This PR tags them with `#[inline]`, making it possible to inline the function calls across crate boundaries. -- This is

[GitHub] [arrow] github-actions[bot] commented on pull request #9858: ARROW-12160: [Rust] Add `into_inner()` to StreamWriter

github-actions[bot] commented on pull request #9858: URL: https://github.com/apache/arrow/pull/9858#issuecomment-810947527 https://issues.apache.org/jira/browse/ARROW-12160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #9859: ARROW-11887: [C++] REVERT Add asynchronous read to streaming CSV reader

github-actions[bot] commented on pull request #9859: URL: https://github.com/apache/arrow/pull/9859#issuecomment-810959472 https://issues.apache.org/jira/browse/ARROW-11887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r604801337 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r604801995 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1246,44 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] Dandandan commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

Dandandan commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-810984745 @ritchie46 did you have some perf results on this? I think it definitely makes sense, especially as the functions are wrapped in (unnecessary) `Result` now which might make th

[GitHub] [arrow] Dandandan commented on a change in pull request #9860: ARROW-12165: [Rust] inline append functions of builders

Dandandan commented on a change in pull request #9860: URL: https://github.com/apache/arrow/pull/9860#discussion_r604810284 ## File path: rust/arrow/src/array/builder.rs ## @@ -2031,6 +2059,7 @@ where /// Append a primitive value to the array. Return an existing index

[GitHub] [arrow] anthonylouisbsb opened a new pull request #9861: ARROW-12166: [C++][Gandiva] Implements CONVERT_TO(value, type) function

anthonylouisbsb opened a new pull request #9861: URL: https://github.com/apache/arrow/pull/9861 Implements the CONVERT_TO function inside the Gandiva, which receives a value for a defined type and returns its bytes representation. The behavior is based on Apache Drill implementation:

[GitHub] [arrow] ritchie46 commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-810995348 > @ritchie46 did you have some perf results on this? > I think it definitely makes sense, especially as the functions are wrapped in (unnecessary) `Result` now which might mak

[GitHub] [arrow] alamb commented on pull request #9773: ARROW-12028 ARROW-11940: [Rust][DataFusion] Add TimestampMillisecond support to GROUP BY/hash aggregates

alamb commented on pull request #9773: URL: https://github.com/apache/arrow/pull/9773#issuecomment-810995675 > It seems the Docker build failed but I can't click on or expand on the details. Yeah, that has been happening recently. I don't think it is related to this PR. I plan t

[GitHub] [arrow] ritchie46 commented on a change in pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 commented on a change in pull request #9860: URL: https://github.com/apache/arrow/pull/9860#discussion_r604819808 ## File path: rust/arrow/src/array/builder.rs ## @@ -2031,6 +2059,7 @@ where /// Append a primitive value to the array. Return an existing index

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #9707: ARROW-11984: [C++][Gandiva] Implement SHA1 and SHA256 functions

anthonylouisbsb commented on a change in pull request #9707: URL: https://github.com/apache/arrow/pull/9707#discussion_r604820015 ## File path: cpp/cmake_modules/FindOpenSSLAlt.cmake ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

[GitHub] [arrow] frank400 closed pull request #9853: ARROW-12157: [C++][Gandiva] Implement like function for regex expressions

frank400 closed pull request #9853: URL: https://github.com/apache/arrow/pull/9853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [arrow] ritchie46 edited a comment on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 edited a comment on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-810995348 > @ritchie46 did you have some perf results on this? > I think it definitely makes sense, especially as the functions are wrapped in (unnecessary) `Result` now which mi

[GitHub] [arrow] lidavidm commented on a change in pull request #9838: ARROW-12134: [C++] Add match_substring_regex kernel

lidavidm commented on a change in pull request #9838: URL: https://github.com/apache/arrow/pull/9838#discussion_r604824849 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -411,40 +411,104 @@ void TransformMatchSubstring(const uint8_t* pattern, int64_t patter

[GitHub] [arrow] ritchie46 commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-811002506 > especially as the functions are wrapped in (unnecessary) Result now which might make things worse. Is there a reason not to remove this? Backwards incompatibility chan

[GitHub] [arrow] ritchie46 edited a comment on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

ritchie46 edited a comment on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-810995348 > @ritchie46 did you have some perf results on this? > I think it definitely makes sense, especially as the functions are wrapped in (unnecessary) `Result` now which mi

[GitHub] [arrow] pitrou closed pull request #9848: ARROW-12089: [Doc] Fix Sphinx warnings

pitrou closed pull request #9848: URL: https://github.com/apache/arrow/pull/9848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [arrow] projjal commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

projjal commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604831679 ## File path: cpp/src/gandiva/cache.cc ## @@ -38,6 +42,22 @@ int GetCapacity() { return capacity; } +int GetCacheTypeToUse() { + int cache_type; + c

[GitHub] [arrow] projjal commented on a change in pull request #9707: ARROW-11984: [C++][Gandiva] Implement SHA1 and SHA256 functions

projjal commented on a change in pull request #9707: URL: https://github.com/apache/arrow/pull/9707#discussion_r604838870 ## File path: dev/tasks/gandiva-jars/build-java.sh ## @@ -25,11 +25,11 @@ pushd java if [[ $OS_NAME == "linux" ]]; then SO_DEP=ldd GANDIVA_LIB=

[GitHub] [arrow] alamb commented on pull request #9847: ARROW-12108: [Rust] [DataFusion] Implement SHOW TABLES

alamb commented on pull request #9847: URL: https://github.com/apache/arrow/pull/9847#issuecomment-811022894 FYI @Dandandan @returnString @andygrove -- what do you think about adding support for `SHOW TABLES`? -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] alamb commented on pull request #9858: ARROW-12160: [Rust] Add `into_inner()` to StreamWriter

alamb commented on pull request #9858: URL: https://github.com/apache/arrow/pull/9858#issuecomment-811024151 Thank you @ericwburden -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] alamb commented on pull request #9826: ARROW-12123: [Rust][DataFusion] Use smallvec for indices for better join performance

alamb commented on pull request #9826: URL: https://github.com/apache/arrow/pull/9826#issuecomment-811024944 The integration test failure https://github.com/apache/arrow/pull/9826/checks?check_run_id=2229013566 seems to be related to out of disk space and not the changes in this PR

[GitHub] [arrow] alamb closed pull request #9826: ARROW-12123: [Rust][DataFusion] Use smallvec for indices for better join performance

alamb closed pull request #9826: URL: https://github.com/apache/arrow/pull/9826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] projjal commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

projjal commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604849417 ## File path: cpp/src/gandiva/decimal_scalar.h ## @@ -55,3 +55,19 @@ class DecimalScalar128 : public BasicDecimalScalar128 { }; } // namespace gandiva

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

jpedroantunes commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r604864206 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1246,39 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char*

[GitHub] [arrow] pitrou commented on a change in pull request #9838: ARROW-12134: [C++] Add match_substring_regex kernel

pitrou commented on a change in pull request #9838: URL: https://github.com/apache/arrow/pull/9838#discussion_r604870513 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -411,40 +411,106 @@ void TransformMatchSubstring(const uint8_t* pattern, int64_t pattern_

[GitHub] [arrow] frank400 commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

frank400 commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604879119 ## File path: cpp/src/gandiva/decimal_scalar.h ## @@ -55,3 +55,19 @@ class DecimalScalar128 : public BasicDecimalScalar128 { }; } // namespace gandiva

[GitHub] [arrow] lidavidm commented on a change in pull request #9810: ARROW-11677: [C++][Docs] Add basic C++ datasets documentation

lidavidm commented on a change in pull request #9810: URL: https://github.com/apache/arrow/pull/9810#discussion_r604880136 ## File path: cpp/examples/arrow/dataset-documentation-example.cc ## @@ -217,24 +229,29 @@ std::shared_ptr SelectAndProjectDataset( auto scan_builder =

[GitHub] [arrow] projjal commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

projjal commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604883353 ## File path: cpp/src/gandiva/decimal_scalar.h ## @@ -55,3 +55,19 @@ class DecimalScalar128 : public BasicDecimalScalar128 { }; } // namespace gandiva

[GitHub] [arrow] projjal commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

projjal commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604884393 ## File path: cpp/src/gandiva/tests/in_expr_test.cc ## @@ -34,6 +35,19 @@ class TestIn : public ::testing::Test { protected: arrow::MemoryPool* pool_;

[GitHub] [arrow] frank400 commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

frank400 commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604885913 ## File path: cpp/src/gandiva/decimal_scalar.h ## @@ -55,3 +55,19 @@ class DecimalScalar128 : public BasicDecimalScalar128 { }; } // namespace gandiva

[GitHub] [arrow] frank400 commented on a change in pull request #9785: ARROW-12069: [C++][Gandiva] Implement IN expressions for Decimal type

frank400 commented on a change in pull request #9785: URL: https://github.com/apache/arrow/pull/9785#discussion_r604887936 ## File path: cpp/src/gandiva/tests/in_expr_test.cc ## @@ -34,6 +35,19 @@ class TestIn : public ::testing::Test { protected: arrow::MemoryPool* pool_;

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604901684 ## File path: cpp/src/gandiva/lower_value_used_cache.h ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604901916 ## File path: cpp/src/gandiva/base_cache.h ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604902035 ## File path: cpp/src/gandiva/cache.h ## @@ -31,29 +32,40 @@ int GetCapacity(); GANDIVA_EXPORT void LogCacheSize(size_t capacity); +GANDIVA_EXPORT

[GitHub] [arrow] lidavidm commented on a change in pull request #9838: ARROW-12134: [C++] Add match_substring_regex kernel

lidavidm commented on a change in pull request #9838: URL: https://github.com/apache/arrow/pull/9838#discussion_r604902493 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -411,40 +411,106 @@ void TransformMatchSubstring(const uint8_t* pattern, int64_t patter

[GitHub] [arrow] pitrou commented on pull request #9849: ARROW-12068: [Python] Stop using distutils

pitrou commented on pull request #9849: URL: https://github.com/apache/arrow/pull/9849#issuecomment-811074353 I submitted some Crossbow jobs again: https://github.com/ursacomputing/crossbow/branches/all?query=build-122 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [arrow] andygrove commented on pull request #9723: ARROW-11982: [Rust] Donate Ballista Distributed Compute Platform [DO NOT MERGE]

andygrove commented on pull request #9723: URL: https://github.com/apache/arrow/pull/9723#issuecomment-811076387 Many people have submitted ICLAs at this point. I'm going to give this another couple of days and then start a vote for the IP clearance. -- This is an automated message from

[GitHub] [arrow] github-actions[bot] commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

github-actions[bot] commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-811101246 https://issues.apache.org/jira/browse/ARROW-12165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] returnString commented on pull request #9847: ARROW-12108: [Rust] [DataFusion] Implement SHOW TABLES

returnString commented on pull request #9847: URL: https://github.com/apache/arrow/pull/9847#issuecomment-811106134 Great stuff - I think it's super useful as an accessible way to view the catalog structure outside of GUI tooling :) -- This is an automated message from the Apache Git Ser

[GitHub] [arrow] lidavidm commented on a change in pull request #9808: ARROW-12097: [C++] Modify BackgroundGenerator so it creates fewer threads

lidavidm commented on a change in pull request #9808: URL: https://github.com/apache/arrow/pull/9808#discussion_r604951143 ## File path: cpp/src/arrow/util/async_generator_test.cc ## @@ -570,14 +659,134 @@ TEST(TestAsyncUtil, StackOverflow) { #endif -TEST(TestAsyncUtil, Ba

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604959826 ## File path: cpp/src/gandiva/cache.cc ## @@ -38,6 +42,22 @@ int GetCapacity() { return capacity; } +int GetCacheTypeToUse() { + int cache_type

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r604963234 ## File path: cpp/src/gandiva/lower_value_used_cache.h ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] github-actions[bot] commented on pull request #9861: ARROW-12166: [C++][Gandiva] Implements CONVERT_TO(value, type) function

github-actions[bot] commented on pull request #9861: URL: https://github.com/apache/arrow/pull/9861#issuecomment-811126868 https://issues.apache.org/jira/browse/ARROW-12166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jonkeane commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

jonkeane commented on pull request #9846: URL: https://github.com/apache/arrow/pull/9846#issuecomment-811149004 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pitrou opened a new pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

pitrou opened a new pull request #9863: URL: https://github.com/apache/arrow/pull/9863 ConvertedType::NA corresponds to an invalid converted type that was once added to the Parquet spec: https://github.com/apache/parquet-format/pull/45 but then quickly removed in favour of the Null lo

[GitHub] [arrow] zeroshade commented on a change in pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

zeroshade commented on a change in pull request #9817: URL: https://github.com/apache/arrow/pull/9817#discussion_r604994611 ## File path: go/parquet/compress/compress_test.go ## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

[GitHub] [arrow] emkornfield commented on a change in pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

emkornfield commented on a change in pull request #9817: URL: https://github.com/apache/arrow/pull/9817#discussion_r605003598 ## File path: go/parquet/compress/compress_test.go ## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [arrow] zeroshade opened a new pull request #9862: ARROW-12168: [Go][IPC] Implement Compression handling for Arrow IPC

zeroshade opened a new pull request #9862: URL: https://github.com/apache/arrow/pull/9862 @sbinet @emkornfield This is my follow up from #9836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] pitrou commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

pitrou commented on a change in pull request #9863: URL: https://github.com/apache/arrow/pull/9863#discussion_r605010147 ## File path: cpp/src/parquet/thrift_internal.h ## @@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) { static inline format::Co

[GitHub] [arrow] emkornfield commented on pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

emkornfield commented on pull request #9863: URL: https://github.com/apache/arrow/pull/9863#issuecomment-811166885 LGTM modulo one nit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] emkornfield commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

emkornfield commented on a change in pull request #9863: URL: https://github.com/apache/arrow/pull/9863#discussion_r605010964 ## File path: cpp/src/parquet/thrift_internal.h ## @@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) { static inline forma

[GitHub] [arrow] emkornfield commented on a change in pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

emkornfield commented on a change in pull request #9817: URL: https://github.com/apache/arrow/pull/9817#discussion_r605004149 ## File path: go/parquet/compress/compress_test.go ## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [arrow] emkornfield commented on pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

emkornfield commented on pull request #9817: URL: https://github.com/apache/arrow/pull/9817#issuecomment-811163730 I removed the "@" mentions in the description. It appears I get notified everytime someone clones the commit in master.Please tag people as a first comment instead. --

[GitHub] [arrow] emkornfield commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

emkornfield commented on a change in pull request #9863: URL: https://github.com/apache/arrow/pull/9863#discussion_r605008680 ## File path: cpp/src/parquet/thrift_internal.h ## @@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) { static inline forma

[GitHub] [arrow] emkornfield commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

emkornfield commented on a change in pull request #9863: URL: https://github.com/apache/arrow/pull/9863#discussion_r605010964 ## File path: cpp/src/parquet/thrift_internal.h ## @@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) { static inline forma

[GitHub] [arrow] zeroshade commented on pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

zeroshade commented on pull request #9817: URL: https://github.com/apache/arrow/pull/9817#issuecomment-811180729 @emkornfield Did not realize that, will keep that in mind for future PRs. Sorry! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] zeroshade commented on a change in pull request #9817: ARROW-12104: [Go][Parquet] Second chunk of Ported Go Parquet code

zeroshade commented on a change in pull request #9817: URL: https://github.com/apache/arrow/pull/9817#discussion_r605026154 ## File path: go/parquet/compress/compress_test.go ## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

[GitHub] [arrow] lidavidm commented on a change in pull request #9607: ARROW-7001: [C++] Develop threading APIs to accommodate nested parallelism

lidavidm commented on a change in pull request #9607: URL: https://github.com/apache/arrow/pull/9607#discussion_r604965806 ## File path: cpp/src/arrow/dataset/dataset.h ## @@ -133,8 +130,20 @@ class ARROW_DS_EXPORT Dataset : public std::enable_shared_from_this { Result> New

[GitHub] [arrow] ianmcook commented on pull request #9855: ARROW-11336: [C++][Doc] Improve Developing on Windows docs

ianmcook commented on pull request #9855: URL: https://github.com/apache/arrow/pull/9855#issuecomment-811185252 @bkietz please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] lidavidm commented on a change in pull request #9607: ARROW-7001: [C++] Develop threading APIs to accommodate nested parallelism

lidavidm commented on a change in pull request #9607: URL: https://github.com/apache/arrow/pull/9607#discussion_r605010331 ## File path: cpp/src/arrow/dataset/scanner.cc ## @@ -72,24 +104,251 @@ Result Scanner::GetFragments() { return GetFragmentsFromDatasets({dataset_}, sca

[GitHub] [arrow] lidavidm commented on a change in pull request #9607: ARROW-7001: [C++] Develop threading APIs to accommodate nested parallelism

lidavidm commented on a change in pull request #9607: URL: https://github.com/apache/arrow/pull/9607#discussion_r605008692 ## File path: cpp/src/arrow/dataset/scanner.h ## @@ -150,18 +199,43 @@ class ARROW_DS_EXPORT Scanner { Scanner(std::shared_ptr fragment, std::shared_ptr

[GitHub] [arrow] pitrou commented on a change in pull request #9863: PARQUET-1990: [C++] Refuse to write ConvertedType::NA

pitrou commented on a change in pull request #9863: URL: https://github.com/apache/arrow/pull/9863#discussion_r605031199 ## File path: cpp/src/parquet/thrift_internal.h ## @@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) { static inline format::Co

[GitHub] [arrow] Dandandan commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

Dandandan commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-811187222 @ritchie46 quite nice micro benchmark results :+1: > Is there a reason not to remove this? Backwards incompatibility changes are already happened, so maybe we can remove

[GitHub] [arrow] codecov-io commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

codecov-io commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-811194297 # [Codecov](https://codecov.io/gh/apache/arrow/pull/9860?src=pr&el=h1) Report > Merging [#9860](https://codecov.io/gh/apache/arrow/pull/9860?src=pr&el=desc) (1cb93ee) into

[GitHub] [arrow] pitrou commented on a change in pull request #9838: ARROW-12134: [C++] Add match_substring_regex kernel

pitrou commented on a change in pull request #9838: URL: https://github.com/apache/arrow/pull/9838#discussion_r605053704 ## File path: docs/source/cpp/compute.rst ## @@ -522,26 +522,31 @@ These functions trim off characters on both sides (trim), or the left (ltrim) or Contain

[GitHub] [arrow] nevi-me closed pull request #9850: ARROW-12153: [Rust] [Parquet] Return file stats after writing file

nevi-me closed pull request #9850: URL: https://github.com/apache/arrow/pull/9850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [arrow] alamb closed pull request #9847: ARROW-12108: [Rust] [DataFusion] Implement SHOW TABLES

alamb closed pull request #9847: URL: https://github.com/apache/arrow/pull/9847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] alamb commented on pull request #9847: ARROW-12108: [Rust] [DataFusion] Implement SHOW TABLES

alamb commented on pull request #9847: URL: https://github.com/apache/arrow/pull/9847#issuecomment-811278640 Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [arrow] alamb closed pull request #9773: ARROW-12028 ARROW-11940: [Rust][DataFusion] Add TimestampMillisecond support to GROUP BY/hash aggregates

alamb closed pull request #9773: URL: https://github.com/apache/arrow/pull/9773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #9707: ARROW-11984: [C++][Gandiva] Implement SHA1 and SHA256 functions

anthonylouisbsb commented on a change in pull request #9707: URL: https://github.com/apache/arrow/pull/9707#discussion_r605099025 ## File path: dev/tasks/gandiva-jars/build-java.sh ## @@ -25,11 +25,11 @@ pushd java if [[ $OS_NAME == "linux" ]]; then SO_DEP=ldd GAND

[GitHub] [arrow] alamb commented on pull request #9860: ARROW-12165: [Rust] inline append functions of builders

alamb commented on pull request #9860: URL: https://github.com/apache/arrow/pull/9860#issuecomment-811284294 > I don't think there is any reason. I tried to do it some time ago, but it requires a lot of work as it is used in quite some code as you can imagine. Yeah I agree it would m

[GitHub] [arrow] alamb closed pull request #9860: ARROW-12165: [Rust] inline append functions of builders

alamb closed pull request #9860: URL: https://github.com/apache/arrow/pull/9860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [arrow] nevi-me commented on pull request #9858: ARROW-12160: [Rust] Add `into_inner()` to StreamWriter

nevi-me commented on pull request #9858: URL: https://github.com/apache/arrow/pull/9858#issuecomment-811289622 @alamb we can merge after the clippy and Debian 10 CI tasks complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow] projjal commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

projjal commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r605106219 ## File path: cpp/src/gandiva/lower_value_used_cache.h ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [arrow] alamb commented on pull request #9840: ARROW-12107: [Rust][DataFusion] Support `SELECT * from information_schema.columns`

alamb commented on pull request #9840: URL: https://github.com/apache/arrow/pull/9840#issuecomment-811291912 FYI @returnString @Dandandan and @jorgecarleitao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow] projjal commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

projjal commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r605107516 ## File path: cpp/src/gandiva/filter.h ## @@ -45,6 +45,10 @@ class FilterCacheKey { bool operator!=(const FilterCacheKey& other) const { return !(*this

[GitHub] [arrow] pitrou opened a new pull request #9864: ARROW-12169: [C++] Fix decompressing file with empty stream at the end

pitrou opened a new pull request #9864: URL: https://github.com/apache/arrow/pull/9864 Compressed files such as `.gz` can contain multiple concatenated "streams". If the last stream in the file decompressed to empty data, we would erroneously raise an error. -- This is an automated me

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r60531 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1258,52 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605112605 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1258,52 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9840: ARROW-12107: [Rust][DataFusion] Support `SELECT * from information_schema.columns`

jorgecarleitao commented on a change in pull request #9840: URL: https://github.com/apache/arrow/pull/9840#discussion_r605110586 ## File path: rust/datafusion/src/catalog/information_schema.rs ## @@ -221,3 +262,226 @@ impl InformationSchemaTablesBuilder { MemTable::try

[GitHub] [arrow] alamb commented on a change in pull request #9840: ARROW-12107: [Rust][DataFusion] Support `SELECT * from information_schema.columns`

alamb commented on a change in pull request #9840: URL: https://github.com/apache/arrow/pull/9840#discussion_r605120867 ## File path: rust/datafusion/src/catalog/information_schema.rs ## @@ -221,3 +262,226 @@ impl InformationSchemaTablesBuilder { MemTable::try_new(sche

[GitHub] [arrow] alamb commented on a change in pull request #9840: ARROW-12107: [Rust][DataFusion] Support `SELECT * from information_schema.columns`

alamb commented on a change in pull request #9840: URL: https://github.com/apache/arrow/pull/9840#discussion_r605121436 ## File path: rust/datafusion/src/catalog/information_schema.rs ## @@ -221,3 +262,226 @@ impl InformationSchemaTablesBuilder { MemTable::try_new(sche

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605122459 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -156,6 +156,17 @@ void set_error_for_invalid_utf(int64_t execution_context, char val) { fr

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605123377 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -156,6 +156,17 @@ void set_error_for_invalid_utf(int64_t execution_context, char val) { fr

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9840: ARROW-12107: [Rust][DataFusion] Support `SELECT * from information_schema.columns`

jorgecarleitao commented on a change in pull request #9840: URL: https://github.com/apache/arrow/pull/9840#discussion_r605123656 ## File path: rust/datafusion/src/catalog/information_schema.rs ## @@ -221,3 +262,226 @@ impl InformationSchemaTablesBuilder { MemTable::try

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605123985 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1258,52 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605126448 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -156,6 +156,17 @@ void set_error_for_invalid_utf(int64_t execution_context, char val) { fr

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605126448 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -156,6 +156,17 @@ void set_error_for_invalid_utf(int64_t execution_context, char val) { fr

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605128374 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -1246,6 +1258,52 @@ const char* convert_fromUTF8_binary(gdv_int64 context, const char* bin_in

[GitHub] [arrow] projjal commented on a change in pull request #9844: ARROW-12146: [C++][Gandiva] Implement CONVERT_FROM(expression, replacement char) function

projjal commented on a change in pull request #9844: URL: https://github.com/apache/arrow/pull/9844#discussion_r605128545 ## File path: cpp/src/gandiva/precompiled/string_ops_test.cc ## @@ -115,6 +115,55 @@ TEST(TestStringOps, TestCharLength) { ctx.Reset(); } +TEST(TestSt

[GitHub] [arrow] jpedroantunes commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

jpedroantunes commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r605130406 ## File path: cpp/src/gandiva/filter.h ## @@ -45,6 +45,10 @@ class FilterCacheKey { bool operator!=(const FilterCacheKey& other) const { return !

[GitHub] [arrow] projjal commented on a change in pull request #9813: ARROW-12102: [C++][Gandiva] Implement new cache for Gandiva focused on a build time policy

projjal commented on a change in pull request #9813: URL: https://github.com/apache/arrow/pull/9813#discussion_r605132657 ## File path: cpp/src/gandiva/filter.h ## @@ -45,6 +45,10 @@ class FilterCacheKey { bool operator!=(const FilterCacheKey& other) const { return !(*this

[GitHub] [arrow] westonpace commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

westonpace commented on pull request #9846: URL: https://github.com/apache/arrow/pull/9846#issuecomment-811336478 Thanks for adding those builds I missed. Those changes look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] westonpace edited a comment on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

westonpace edited a comment on pull request #9846: URL: https://github.com/apache/arrow/pull/9846#issuecomment-811336478 Thanks for adding those builds I missed. Those changes look good to me. @jonkeane -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] projjal commented on a change in pull request #9707: ARROW-11984: [C++][Gandiva] Implement SHA1 and SHA256 functions

projjal commented on a change in pull request #9707: URL: https://github.com/apache/arrow/pull/9707#discussion_r605138316 ## File path: cpp/cmake_modules/FindOpenSSLAlt.cmake ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

  1   2   >