[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #1665: Skip some path in list_file_with_suffix.

2022-01-26 Thread GitBox
Ted-Jiang commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r792390508 ## File path: datafusion/src/datasource/object_store/mod.rs ## @@ -159,6 +159,16 @@ pub trait ObjectStore: Sync + Send + Debug { /// Get o

[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #1665: Skip some path in list_file_with_suffix.

2022-01-26 Thread GitBox
Ted-Jiang commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r792393480 ## File path: datafusion/src/physical_plan/file_format/parquet.rs ## @@ -217,6 +217,7 @@ impl ExecutionPlan for ParquetExec { let fi

[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #1665: Skip some path in list_file_with_suffix.

2022-01-26 Thread GitBox
Ted-Jiang commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r792393338 ## File path: datafusion/src/datasource/object_store/mod.rs ## @@ -141,7 +141,7 @@ pub trait ObjectStore: Sync + Send + Debug { let su

[GitHub] [arrow] vibhatha opened a new pull request #12266: ARROW-15258: [C++] Easy options to create a source node from a table

2022-01-26 Thread GitBox
vibhatha opened a new pull request #12266: URL: https://github.com/apache/arrow/pull/12266 This PR includes a source node creation using a Table. Here a `TableSourceNode` is created by Extending the `SourceNode`. -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow] vibhatha closed pull request #12266: ARROW-15258: [C++] Easy options to create a source node from a table

2022-01-26 Thread GitBox
vibhatha closed pull request #12266: URL: https://github.com/apache/arrow/pull/12266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] github-actions[bot] commented on pull request #12266: ARROW-15258: [C++] Easy options to create a source node from a table

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12266: URL: https://github.com/apache/arrow/pull/12266#issuecomment-1021967635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] sjperkins commented on pull request #10565: ARROW-638: [C++] Complex Number Support via ExtensionTypes

2022-01-26 Thread GitBox
sjperkins commented on pull request #10565: URL: https://github.com/apache/arrow/pull/10565#issuecomment-1021981985 > With some changes, I was able to get it your branch to work and output a complex array. It is still preliminary. Let me know if you want to see it. Hi @jmdeschenes, I

[GitHub] [arrow] iajoiner commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
iajoiner commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r792416212 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(table, where,

[GitHub] [arrow] iajoiner commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
iajoiner commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r792416212 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(table, where,

[GitHub] [arrow] iajoiner commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
iajoiner commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r792416212 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(table, where,

[GitHub] [arrow] iajoiner commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
iajoiner commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r792416212 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(table, where,

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
jorisvandenbossche commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r792418345 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(tab

[GitHub] [arrow] vibhatha opened a new pull request #12267: ARROW-15258: [C++] Easy options to create a source node from a table

2022-01-26 Thread GitBox
vibhatha opened a new pull request #12267: URL: https://github.com/apache/arrow/pull/12267 This PR includes the addition of `TableSourceNode` to create a `ExecNode` easily using a table as the data source. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow] github-actions[bot] commented on pull request #12267: ARROW-15258: [C++] Easy options to create a source node from a table

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12267: URL: https://github.com/apache/arrow/pull/12267#issuecomment-1021988742 https://issues.apache.org/jira/browse/ARROW-15258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] xhochy commented on pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-26 Thread GitBox
xhochy commented on pull request #11916: URL: https://github.com/apache/arrow/pull/11916#issuecomment-1021994933 Seems like all the errors left here have to be fixed on the conda-forge side after thorough investigation. I'll keep you all updated. -- This is an automated message from the

[GitHub] [arrow] ursabot edited a comment on pull request #12264: ARROW-15457: [Packaging][deb] Specify CUDAToolkit_ROOT explicitly

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12264: URL: https://github.com/apache/arrow/pull/12264#issuecomment-1021931648 Benchmark runs are scheduled for baseline = c5f400461f6d2be836d30df4626fed4d59107015 and contender = 0b95b625cc5f2423498bdafdcc5acad968909933. 0b95b625cc5f2423498bdafdc

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1681: refactor array_agg to not to have `update` and `merge`

2022-01-26 Thread GitBox
Jimexist opened a new pull request #1681: URL: https://github.com/apache/arrow-datafusion/pull/1681 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes

[GitHub] [arrow-cookbook] thisisnic closed issue #129: Read encrypted parquet file from R

2022-01-26 Thread GitBox
thisisnic closed issue #129: URL: https://github.com/apache/arrow-cookbook/issues/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] kszucs commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
kszucs commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022028717 @github-actions crossbow submit -g verify-rc-wheels-windows --param release=7.0.0 --param rc=8 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] zhixingheyi-tian commented on a change in pull request #11763: ARROW-14153: [C++][Dataset] Add support for batch_size in the ORC Scanner

2022-01-26 Thread GitBox
zhixingheyi-tian commented on a change in pull request #11763: URL: https://github.com/apache/arrow/pull/11763#discussion_r792463995 ## File path: cpp/src/arrow/adapters/orc/adapter.h ## @@ -231,6 +231,19 @@ class ARROW_EXPORT ORCFileReader { Status NextStripeReader(int64_t

[GitHub] [arrow] zhixingheyi-tian commented on a change in pull request #11763: ARROW-14153: [C++][Dataset] Add support for batch_size in the ORC Scanner

2022-01-26 Thread GitBox
zhixingheyi-tian commented on a change in pull request #11763: URL: https://github.com/apache/arrow/pull/11763#discussion_r792464846 ## File path: cpp/src/arrow/adapters/orc/adapter.h ## @@ -231,6 +231,19 @@ class ARROW_EXPORT ORCFileReader { Status NextStripeReader(int64_t

[GitHub] [arrow] kszucs commented on pull request #12265: MINOR: [Python][Packaging] Update crossbow cache key for vcpkg in the macos wheel builds

2022-01-26 Thread GitBox
kszucs commented on pull request #12265: URL: https://github.com/apache/arrow/pull/12265#issuecomment-1022032582 @github-actions crossbow submit wheel-macos-mavericks-cp37-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] github-actions[bot] commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022033687 ``` Invalid group(s) {'verify-rc-wheels-windows'}. Must be one of {'example', 'cpp', 'verify-rc-binaries', 'verify-rc-jars', 'packaging', 'conda', 'verify-rc-sou

[GitHub] [arrow] github-actions[bot] commented on pull request #12265: MINOR: [Python][Packaging] Update crossbow cache key for vcpkg in the macos wheel builds

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12265: URL: https://github.com/apache/arrow/pull/12265#issuecomment-1022035036 Revision: a37675cd79a3ada4b2480b4809a1a6df20d2f120 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1506](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-rs] HaoYang670 commented on a change in pull request #1238: dyn compare for binary array

2022-01-26 Thread GitBox
HaoYang670 commented on a change in pull request #1238: URL: https://github.com/apache/arrow-rs/pull/1238#discussion_r792467999 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -3843,6 +3960,114 @@ mod tests { assert_eq!(neq_dyn_scalar(&array, 8).unwrap(), e

[GitHub] [arrow] kszucs commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
kszucs commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022036422 @github-actions crossbow submit verify-rc-wheels-windows --param release=7.0.0 --param rc=8 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] github-actions[bot] commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022037401 Revision: 4011500d661cc15f39966103ae381c184c260d38 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1507](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-rs] HaoYang670 opened a new pull request #1241: Add Rust Docs examples for UnionArray

2022-01-26 Thread GitBox
HaoYang670 opened a new pull request #1241: URL: https://github.com/apache/arrow-rs/pull/1241 Signed-off-by: remzi <[email protected]> # Which issue does this PR close? Closes #751 # Rationale for this change Add 2 docs examples of building `U

[GitHub] [arrow] kszucs removed a comment on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
kszucs removed a comment on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1021842277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
github-actions[bot] removed a comment on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1021842924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] raulcd commented on a change in pull request #12265: MINOR: [Python][Packaging] Update crossbow cache key for vcpkg in the macos wheel builds

2022-01-26 Thread GitBox
raulcd commented on a change in pull request #12265: URL: https://github.com/apache/arrow/pull/12265#discussion_r792491601 ## File path: dev/tasks/python-wheels/github.osx.amd64.yml ## @@ -55,7 +55,7 @@ jobs: id: vcpkg-cache with: path: vcpkg -

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1241: Add Rust Docs examples for UnionArray

2022-01-26 Thread GitBox
codecov-commenter commented on pull request #1241: URL: https://github.com/apache/arrow-rs/pull/1241#issuecomment-1022060537 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1241?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-datafusion] yjshen opened a new pull request #1682: Add gauge

2022-01-26 Thread GitBox
yjshen opened a new pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow] ursabot edited a comment on pull request #12256: ARROW-15448: [C++] Use apache mirror system to download ORC's source

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12256: URL: https://github.com/apache/arrow/pull/12256#issuecomment-1021376940 Benchmark runs are scheduled for baseline = 85f67d71381c4dbfbf55377e646b785a643daa0b and contender = 3fc90532d4353146c64b2575a36a00069c747968. 3fc90532d4353146c64b2575a

[GitHub] [arrow-rs] tustvold commented on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold commented on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022089589 ``` cargo criterion --bench filter_kernels Compiling arrow v8.0.0 (/home/raphael/repos/external/arrow-rs/arrow) Finished bench [optimized] target(s) in 18.23s

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0

2022-01-26 Thread GitBox
xudong963 commented on a change in pull request #1632: URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r792528527 ## File path: datafusion-cli/Cargo.toml ## @@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"; rust-version = "1.58"

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-26 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r792530100 ## File path: r/R/array.R ## @@ -188,6 +188,11 @@ Array$create <- function(x, type = NULL) { return(out) } + if (inherits(x, "POSIXct") && att

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792532430 ## File path: datafusion/src/physical_plan/metrics/aggregated.rs ## @@ -35,25 +35,31 @@ pub struct AggregatedMetricsSet { final_: Arc>>, }

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792532430 ## File path: datafusion/src/physical_plan/metrics/aggregated.rs ## @@ -35,25 +35,31 @@ pub struct AggregatedMetricsSet { final_: Arc>>, }

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
liukun4515 commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792535023 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metric

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
liukun4515 commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792535023 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metric

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold edited a comment on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022089589 ``` cargo criterion --bench filter_kernels Compiling arrow v8.0.0 (/home/raphael/repos/external/arrow-rs/arrow) Finished bench [optimized] target(s) in 1

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold edited a comment on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022089589 ``` cargo criterion --bench filter_kernels Compiling arrow v8.0.0 (/home/raphael/repos/external/arrow-rs/arrow) Finished bench [optimized] target(s) in 1

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold edited a comment on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022089589 ``` cargo criterion --bench filter_kernels Compiling arrow v8.0.0 (/home/raphael/repos/external/arrow-rs/arrow) Finished bench [optimized] target(s) in 1

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
liukun4515 commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792538389 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metric

[GitHub] [arrow-datafusion] hntd187 opened a new issue #1505: Renaming Tests Discussion

2022-01-26 Thread GitBox
hntd187 opened a new issue #1505: URL: https://github.com/apache/arrow-datafusion/issues/1505 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I am starting the discussion on how we want to rename some of the tests post the re

[GitHub] [arrow-datafusion] alamb commented on issue #1505: Renaming Tests Discussion

2022-01-26 Thread GitBox
alamb commented on issue #1505: URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1022107436 FYI I plan to move some tests out of context.rs into the sql_integration test -- I'll try and get that done prior to the big rename 🏃 -- This is an automated message from

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold edited a comment on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022089589 ``` cargo criterion --bench filter_kernels Compiling arrow v8.0.0 (/home/raphael/repos/external/arrow-rs/arrow) Finished bench [optimized] target(s) in 1

[GitHub] [arrow-rs] tustvold commented on pull request #1225: Improve MutableArrayData Null Handling (#1224) (#1230)

2022-01-26 Thread GitBox
tustvold commented on pull request #1225: URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1022108312 Hmm I've changed my mind - will pause this until I've fixed #1229 as it will influence the benchmarks significantly -- This is an automated message from the Apache Git Serv

[GitHub] [arrow-datafusion] jonmmease opened a new pull request #1683: docs: Add link to VegaFusion as a project that uses DataFusion

2022-01-26 Thread GitBox
jonmmease opened a new pull request #1683: URL: https://github.com/apache/arrow-datafusion/pull/1683 Hi, I'd like to add my open source project, [VegaFusion](https://vegafusion.io/), to the list of projects that are known to use DataFusion. This project uses DataFusion to accelerate

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792543242 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metrics ty

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792544773 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metrics ty

[GitHub] [arrow] github-actions[bot] commented on pull request #12268: [Release][Java] Fix java jars upload script

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12268: URL: https://github.com/apache/arrow/pull/12268#issuecomment-1022112632 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792548957 ## File path: datafusion/src/physical_plan/mod.rs ## @@ -51,6 +51,11 @@ pub trait RecordBatchStream: Stream> { /// Implementation of this tra

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792548957 ## File path: datafusion/src/physical_plan/mod.rs ## @@ -51,6 +51,11 @@ pub trait RecordBatchStream: Stream> { /// Implementation of this tra

[GitHub] [arrow] kszucs commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
kszucs commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022118044 @github-actions crossbow submit -g verify-rc-jars --param release=7.0.0 --param rc=8 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] github-actions[bot] commented on pull request #12262: [Release] Verify 7.0.0 RC8 [WIP]

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12262: URL: https://github.com/apache/arrow/pull/12262#issuecomment-1022119482 Revision: 4011500d661cc15f39966103ae381c184c260d38 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1508](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] alamb opened a new pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-26 Thread GitBox
alamb opened a new pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684 # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/743 related, perhaps, to https://github.com/apache/arrow-datafusion/issues/1505 Built

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-26 Thread GitBox
alamb commented on a change in pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684#discussion_r792563062 ## File path: datafusion/src/execution/context.rs ## @@ -3551,476 +3550,6 @@ mod tests { Ok(()) } -#[tokio::test] Review comme

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-26 Thread GitBox
alamb commented on a change in pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684#discussion_r792564409 ## File path: datafusion/tests/sql/mod.rs ## @@ -693,6 +695,21 @@ fn make_timestamp_nano_table() -> Result> { make_timestamp_table::() } +/

[GitHub] [arrow-rs] alamb closed issue #1108: Add native comparison kernel support for BinaryArray

2022-01-26 Thread GitBox
alamb closed issue #1108: URL: https://github.com/apache/arrow-rs/issues/1108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb merged pull request #1238: dyn compare for binary array

2022-01-26 Thread GitBox
alamb merged pull request #1238: URL: https://github.com/apache/arrow-rs/pull/1238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] alamb commented on a change in pull request #1241: Add Rust Docs examples for UnionArray

2022-01-26 Thread GitBox
alamb commented on a change in pull request #1241: URL: https://github.com/apache/arrow-rs/pull/1241#discussion_r792584783 ## File path: arrow/src/array/array_union.rs ## @@ -35,6 +35,73 @@ use std::any::Any; /// [`UnionBuilder`]can be used to create `UnionArray`'s of primiti

[GitHub] [arrow-datafusion] alamb closed issue #1679: DiskManager keeps temporary files around until the manager itself is dropped

2022-01-26 Thread GitBox
alamb closed issue #1679: URL: https://github.com/apache/arrow-datafusion/issues/1679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1680: Use NamedTempFile rather than `String` in DiskManager

2022-01-26 Thread GitBox
alamb merged pull request #1680: URL: https://github.com/apache/arrow-datafusion/pull/1680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb merged pull request #1683: docs: Add link to VegaFusion as a project that uses DataFusion

2022-01-26 Thread GitBox
alamb merged pull request #1683: URL: https://github.com/apache/arrow-datafusion/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] thinkharderdev commented on issue #1675: Improvements to Ballista extensibility

2022-01-26 Thread GitBox
thinkharderdev commented on issue #1675: URL: https://github.com/apache/arrow-datafusion/issues/1675#issuecomment-1022172161 Agree on the substrait integration. It would definitely be nice to have a universal serializable representation and a way to configure extensions delcaritively.

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
liukun4515 commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792620579 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -77,6 +77,62 @@ impl Count { } } +/// A gauge is the simplest metric

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1552: enhance arithmetic operation for array with scalar

2022-01-26 Thread GitBox
liukun4515 commented on pull request #1552: URL: https://github.com/apache/arrow-datafusion/pull/1552#issuecomment-1022191668 PTAL @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] iajoiner commented on pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
iajoiner commented on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1022211244 @jorisvandenbossche Oops. I really didn’t catch that! Fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1682: Add a new metric type: `Gauge`

2022-01-26 Thread GitBox
yjshen commented on a change in pull request #1682: URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792652252 ## File path: datafusion/src/physical_plan/mod.rs ## @@ -51,6 +51,11 @@ pub trait RecordBatchStream: Stream> { /// Implementation of this tra

[GitHub] [arrow-datafusion] thinkharderdev commented on pull request #1677: Abstract over logical and physical plan representations in Ballista

2022-01-26 Thread GitBox
thinkharderdev commented on pull request #1677: URL: https://github.com/apache/arrow-datafusion/pull/1677#issuecomment-106754 Added some additional changes: 1. Abstract over `ExecutionPlan` representation as well. 2. Use a global `ExecutionContext` in `SchedulerServer` and `Execut

[GitHub] [arrow] jonkeane closed pull request #12152: ARROW-15123: [R] CSV dataset file header read in as data

2022-01-26 Thread GitBox
jonkeane closed pull request #12152: URL: https://github.com/apache/arrow/pull/12152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] pitrou commented on pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
pitrou commented on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1022234046 Thanks for the update @iajoiner ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] ursabot edited a comment on pull request #12247: ARROW-15439: [Release] Update .deb/.rpm changelogs after release

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12247: URL: https://github.com/apache/arrow/pull/12247#issuecomment-1021376965 Benchmark runs are scheduled for baseline = 3fc90532d4353146c64b2575a36a00069c747968 and contender = f6f494eae0719dd00da08aae02b2c39245f16ce3. f6f494eae0719dd00da08aae0

[GitHub] [arrow] okadakk opened a new pull request #12269: ARROW-15462: [GLib] Add GArrow{Month,DayTime,MonthDayNano}Scalar,Array,Arraybuilder

2022-01-26 Thread GitBox
okadakk opened a new pull request #12269: URL: https://github.com/apache/arrow/pull/12269 This PR adds month interval, day time interval, month day nano interval scalar, array, array builder! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] github-actions[bot] commented on pull request #12269: ARROW-15462: [GLib] Add GArrow{Month,DayTime,MonthDayNano}Scalar,Array,Arraybuilder

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12269: URL: https://github.com/apache/arrow/pull/12269#issuecomment-1022236314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] pitrou commented on a change in pull request #11763: ARROW-14153: [C++][Dataset] Add support for batch_size in the ORC Scanner

2022-01-26 Thread GitBox
pitrou commented on a change in pull request #11763: URL: https://github.com/apache/arrow/pull/11763#discussion_r792678341 ## File path: cpp/src/arrow/adapters/orc/adapter.h ## @@ -231,6 +231,19 @@ class ARROW_EXPORT ORCFileReader { Status NextStripeReader(int64_t batch_size

[GitHub] [arrow] ursabot commented on pull request #12152: ARROW-15123: [R] CSV dataset file header read in as data

2022-01-26 Thread GitBox
ursabot commented on pull request #12152: URL: https://github.com/apache/arrow/pull/12152#issuecomment-1022242315 Benchmark runs are scheduled for baseline = 0b95b625cc5f2423498bdafdcc5acad968909933 and contender = 458271315688fab239798ea146a12f06fa18e262. 458271315688fab239798ea146a12f06

[GitHub] [arrow] ursabot edited a comment on pull request #12152: ARROW-15123: [R] CSV dataset file header read in as data

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12152: URL: https://github.com/apache/arrow/pull/12152#issuecomment-1022242315 Benchmark runs are scheduled for baseline = 0b95b625cc5f2423498bdafdcc5acad968909933 and contender = 458271315688fab239798ea146a12f06fa18e262. 458271315688fab239798ea14

[GitHub] [arrow] c-jamie opened a new pull request #12270: ARROW-15218: [C++] add decimal support to the indices_nonzero compute function

2022-01-26 Thread GitBox
c-jamie opened a new pull request #12270: URL: https://github.com/apache/arrow/pull/12270 Adds decimal support to the `indices_nonzero` compute function. This vector function returns the indices of an array that contains values `!=0` or `!=false`. This can be used in conjunction wi

[GitHub] [arrow] github-actions[bot] commented on pull request #12270: ARROW-15218: [C++] add decimal support to the indices_nonzero compute function

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12270: URL: https://github.com/apache/arrow/pull/12270#issuecomment-1022273857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] okadakk opened a new pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-26 Thread GitBox
okadakk opened a new pull request #12271: URL: https://github.com/apache/arrow/pull/12271 This PR adds utf8 normalize options bindings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] dragosmg commented on pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-26 Thread GitBox
dragosmg commented on pull request #12240: URL: https://github.com/apache/arrow/pull/12240#issuecomment-1022275248 I think this is almost ready to go. 2 questions remain in my mind: 1. do we want to do anything special for the cases when, for some reason, `Sys.timezone()` returns `NA` or

[GitHub] [arrow] pitrou commented on pull request #12260: ARROW-15454: [Python] Try to make CSV cancellation test more robust

2022-01-26 Thread GitBox
pitrou commented on pull request #12260: URL: https://github.com/apache/arrow/pull/12260#issuecomment-1022277204 Looks like the changes here weren't enough to fix the test on macOS M1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] pitrou commented on pull request #12260: ARROW-15454: [Python] Try to make CSV cancellation test more robust

2022-01-26 Thread GitBox
pitrou commented on pull request #12260: URL: https://github.com/apache/arrow/pull/12260#issuecomment-1022279281 I've removed the Crossbow tasks changes and will merge if green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] github-actions[bot] commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-26 Thread GitBox
github-actions[bot] commented on pull request #12271: URL: https://github.com/apache/arrow/pull/12271#issuecomment-1022289470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-26 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r792729511 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -428,6 +428,290 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArra

[GitHub] [arrow-datafusion] Jimexist commented on pull request #1681: refactor array_agg to not to have `update` and `merge`

2022-01-26 Thread GitBox
Jimexist commented on pull request #1681: URL: https://github.com/apache/arrow-datafusion/pull/1681#issuecomment-1022293473 related #1598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-26 Thread GitBox
jorisvandenbossche commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r792744574 ## File path: r/R/array.R ## @@ -188,6 +188,11 @@ Array$create <- function(x, type = NULL) { return(out) } + if (inherits(x, "POSIXc

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-26 Thread GitBox
jorisvandenbossche commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r792744574 ## File path: r/R/array.R ## @@ -188,6 +188,11 @@ Array$create <- function(x, type = NULL) { return(out) } + if (inherits(x, "POSIXc

[GitHub] [arrow] pitrou commented on a change in pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-26 Thread GitBox
pitrou commented on a change in pull request #12270: URL: https://github.com/apache/arrow/pull/12270#discussion_r792731592 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2392,6 +2392,29 @@ struct NonZeroVisitor { return Status::OK(); } + + tem

[GitHub] [arrow] pitrou closed pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
pitrou closed pull request #12231: URL: https://github.com/apache/arrow/pull/12231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] hntd187 commented on a change in pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-26 Thread GitBox
hntd187 commented on a change in pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684#discussion_r792758009 ## File path: datafusion/tests/sql/mod.rs ## @@ -693,6 +695,21 @@ fn make_timestamp_nano_table() -> Result> { make_timestamp_table::() }

[GitHub] [arrow] ursabot commented on pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
ursabot commented on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1022313266 Benchmark runs are scheduled for baseline = 458271315688fab239798ea146a12f06fa18e262 and contender = f9f6fdbb7518c09b833cb6b78bc202008d28e865. f9f6fdbb7518c09b833cb6b78bc20200

[GitHub] [arrow-cookbook] davisusanibar opened a new pull request #135: [Java]: Java cookbook for create arrow data manipulation

2022-01-26 Thread GitBox
davisusanibar opened a new pull request #135: URL: https://github.com/apache/arrow-cookbook/pull/135 Java cookbook for create arrow data manipulation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] ursabot edited a comment on pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1022313266 Benchmark runs are scheduled for baseline = 458271315688fab239798ea146a12f06fa18e262 and contender = f9f6fdbb7518c09b833cb6b78bc202008d28e865. f9f6fdbb7518c09b833cb6b78

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1678: Fix bug while merging `RecordBatch`, Add `SortPreservingMerge` fuzz tester

2022-01-26 Thread GitBox
alamb commented on a change in pull request #1678: URL: https://github.com/apache/arrow-datafusion/pull/1678#discussion_r792787450 ## File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs ## @@ -410,40 +410,53 @@ impl SortPreservingMergeStream { //

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1678: Fix bug while merging `RecordBatch`, Add `SortPreservingMerge` fuzz tester

2022-01-26 Thread GitBox
alamb commented on a change in pull request #1678: URL: https://github.com/apache/arrow-datafusion/pull/1678#discussion_r792787885 ## File path: datafusion/tests/merge_fuzz.rs ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

[GitHub] [arrow] ursabot edited a comment on pull request #12152: ARROW-15123: [R] CSV dataset file header read in as data

2022-01-26 Thread GitBox
ursabot edited a comment on pull request #12152: URL: https://github.com/apache/arrow/pull/12152#issuecomment-1022242315 Benchmark runs are scheduled for baseline = 0b95b625cc5f2423498bdafdcc5acad968909933 and contender = 458271315688fab239798ea146a12f06fa18e262. 458271315688fab239798ea14

  1   2   3   >